Re: Review Request 116633: Change default font settings to Oxygen font

2014-05-20 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review58203 --- src/platformtheme/kfontsettingsdata.cpp

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 18, 2014, 11:52 p.m.) Status -- This change has been

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review53377 --- This review has been submitted with commit 34d3297293437f896a

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52579 --- Ship it! Before pushing it, contact with the sysadmins to mak

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Rex Dieter
Àlex Fiestas wrote: > Well supporting gtk app's is as simple as writing the configuration file > like or kcm-gtk-style does. Or just use: https://projects.kde.org/projects/playground/base/xsettings-kde and you get it for free. -- Rex ___ Plasma-devel

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Frank Reininghaus
> On March 7, 2014, 3:23 p.m., Frank Reininghaus wrote: > > We have had a complaint from a Dolphin user who uses the Oxygen font some > > time ago because it uses different widths for the digits 0-9, which makes > > the "Date" column in file managers/dialogs rather hard to read: > > > > https:

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Kai Uwe Broulik
> On March 7, 2014, 3:23 p.m., Frank Reininghaus wrote: > > We have had a complaint from a Dolphin user who uses the Oxygen font some > > time ago because it uses different widths for the digits 0-9, which makes > > the "Date" column in file managers/dialogs rather hard to read: > > > > https:

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Kai Uwe Broulik
> On March 7, 2014, 3:23 p.m., Frank Reininghaus wrote: > > We have had a complaint from a Dolphin user who uses the Oxygen font some > > time ago because it uses different widths for the digits 0-9, which makes > > the "Date" column in file managers/dialogs rather hard to read: > > > > https:

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52356 --- We have had a complaint from a Dolphin user who uses the Oxyge

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Aleix Pol Gonzalez
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Àlex Fiestas
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Àlex Fiestas
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
On Thursday, March 06, 2014 15:45:23 Mark Gaiser wrote: > @Aleix not a strong argument. GUI interfaces almost always use the default > font settings. My exact point is that those defaults _won't_ change for GTK > apps with this patch. It does for GTK Apps using the Oxygen style, and it also can be

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 6, 2014, 4:36 p.m.) Review request for Plasma and Àlex Fie

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
> On March 6, 2014, 4:22 p.m., Martin Gräßlin wrote: > > > will push that once this patch is through review > > > > shouldn't it be the other way around? How would anyone be able to compile > > test your review without those files in the oxygen fonts repo? Right. I've pushed it to oxygen-fonts

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52278 --- modulo the small issue below +1 from my side CMakeLists.txt

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52276 --- > will push that once this patch is through review shouldn't

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 6, 2014, 3:49 p.m.) Review request for Plasma and Àlex Fie

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Mark Gaiser
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- (Updated March 6, 2014, 3:40 p.m.) Review request for Plasma and Àlex Fie

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Aleix Pol Gonzalez
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Martin Gräßlin
> On March 6, 2014, 2:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52265 --- CMakeLists.txt

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Mark Gaiser
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
> On March 6, 2014, 1:55 p.m., Mark Gaiser wrote: > > How will this work with other non KDE apps (like Chrome), will they simply > > pickup the Oxygen font? > > > > I'm asking because fonts are working just fine now. If i open a GTK app in > > KDE it shows the fonts in the same manner as a KDE

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/#review52255 --- How will this work with other non KDE apps (like Chrome), will

Review Request 116633: Change default font settings to Oxygen font

2014-03-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116633/ --- Review request for Plasma and Àlex Fiestas. Repository: frameworkintegrat