---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review60666
---
Looks good to me, just one suggestion
On June 21, 2014, 1:59 p.m., Shantanu Tushar wrote:
mediaelements/mediacontroller/MediaController.qml, line 100
https://git.reviewboard.kde.org/r/116874/diff/9/?file=282642#file282642line100
runtimeData.playing || runtimeData.paused should work better, thats
usually the case in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated June 21, 2014, 3:55 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review60669
---
Ship it!
Ship It!
- Shantanu Tushar
On June 21, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review60670
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated June 21, 2014, 3:58 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review60674
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated June 19, 2014, 9:04 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated April 19, 2014, 12:44 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review56054
---
browsingbackends/onlineservices/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated April 19, 2014, 2:02 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated April 19, 2014, 3:37 p.m.)
Review request for Plasma, Shantanu
On April 14, 2014, 12:58 p.m., Sinny Kumari wrote:
checking only url of runtimeData will work only when PMC is launched and
nothing has been played. You need to handle many other cases like when
media get stopped, next/prev shouldn't be enabled until and unless current
media is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review55718
---
checking only url of runtimeData will work only when PMC is
On March 27, 2014, 1:05 p.m., Sebastian Kügler wrote:
If a button doesn't do anything, it should be indicated by disabling it,
not just making it a no-op.
Hey, Should I disable the other buttons like the play/pause, mediascroller,
currentmediatime etc ? I mean when there's no media
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 28, 2014, 12:39 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 28, 2014, 12:37 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review54431
---
See inline comment about line breaks. Also, the disabling of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 27, 2014, 11:22 a.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review54293
---
If a button doesn't do anything, it should be indicated by
On March 27, 2014, 1:05 p.m., Sebastian Kügler wrote:
mediaelements/playlist/Playlist.qml, line 159
https://git.reviewboard.kde.org/r/116874/diff/3/?file=257374#file257374line159
indenting is wrong now
I have added a new diff file after I pulled the latest source and built
On March 27, 2014, 1:05 p.m., Sebastian Kügler wrote:
mediaelements/playlist/Playlist.qml, line 159
https://git.reviewboard.kde.org/r/116874/diff/3/?file=257374#file257374line159
indenting is wrong now
R.Harish Navnit wrote:
I have added a new diff file after I pulled the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 26, 2014, 4 p.m.)
Review request for Plasma, Shantanu
On March 19, 2014, 6:05 p.m., Sinny Kumari wrote:
shells/newshell/package/contents/ui/mediacenter.qml, line 90
https://git.reviewboard.kde.org/r/116874/diff/2/?file=255217#file255217line90
Instead of checking runtimeData.url check if playlist current Index is
-1.
I've checked
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review53435
---
With current patch, suppose you play anything from media
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review53324
---
shells/newshell/package/contents/ui/mediacenter.qml
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated March 18, 2014, 6 p.m.)
Review request for Plasma, Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/#review53331
---
shells/newshell/package/contents/ui/mediacenter.qml
29 matches
Mail list logo
