---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/
---
(Updated April 25, 2014, 5:24 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review56553
---
This review has been submitted with commit
73316526ed84b25b8b
> On April 15, 2014, 10:17 a.m., Martin Gräßlin wrote:
> > David Faure changed the code with 1206a3eaaf31c5438011a53c4839e27249037ac0
> > to use QProcess. Should we still apply this patch or not?
Yes, go ahead. Your analysis is more complete than my mindless port ;)
- David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55804
---
David Faure changed the code with 1206a3eaaf31c5438011a53c4839
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55725
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 9, 2014, 5
> On April 14, 2014, 1:25 p.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
>
> Martin Gräßlin wrote:
> Yes, but why? What would be the use case for having it? It's rather
> useless, isn't it?
>
> Aleix Pol Gonzalez wrote:
> It's public API... either way, go
> On April 14, 2014, 11:25 a.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
>
> Martin Gräßlin wrote:
> Yes, but why? What would be the use case for having it? It's rather
> useless, isn't it?
>
> Aleix Pol Gonzalez wrote:
> It's public API... either way, go
> On April 14, 2014, 11:25 a.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
>
> Martin Gräßlin wrote:
> Yes, but why? What would be the use case for having it? It's rather
> useless, isn't it?
>
> Aleix Pol Gonzalez wrote:
> It's public API... either way, go
> On April 14, 2014, 1:25 p.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
>
> Martin Gräßlin wrote:
> Yes, but why? What would be the use case for having it? It's rather
> useless, isn't it?
>
> Aleix Pol Gonzalez wrote:
> It's public API... either way, go
> On April 14, 2014, 11:25 a.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
>
> Martin Gräßlin wrote:
> Yes, but why? What would be the use case for having it? It's rather
> useless, isn't it?
It's public API... either way, go for it if you deem necessary, won't
> On April 14, 2014, 1:25 p.m., Aleix Pol Gonzalez wrote:
> > You can port it to QProcess as well, no?
Yes, but why? What would be the use case for having it? It's rather useless,
isn't it?
- Martin
---
This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55699
---
You can port it to QProcess as well, no?
- Aleix Pol Gonzalez
> On April 9, 2014, 7:20 p.m., Martin Gräßlin wrote:
> > Oh I just found a usage in kglobaccel itself:
> >
> > KNotification *notification = new KNotification(
> > "newshortcutregistered",
> > KNotification::CloseOnTimeout,
> > q->parent())
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/#review55296
---
Oh I just found a usage in kglobaccel itself:
KNotifi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117455/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
15 matches
Mail list logo
