Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-07 Thread Aleix Pol
On Fri, Jun 6, 2014 at 10:20 PM, Luca Beltrame lbeltr...@kde.org wrote: In data venerdì 06 giugno 2014 17:22:52, Aleix Pol ha scritto: Can you give it another try? Now works perfectly. Thanks! -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-06 Thread Aleix Pol
On Thu, Jun 5, 2014 at 8:16 PM, Luca Beltrame lbeltr...@kde.org wrote: In data giovedì 05 giugno 2014 00:35:56, Aleix Pol Gonzalez ha scritto: This patch uses the screen geometry to figure out what's the screen and then passes around the screen rect so that we can filter out the screens

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-06 Thread Luca Beltrame
In data venerdì 6 giugno 2014 17:22:52, Aleix Pol ha scritto: Just realized that I forgot to submit a patch to plasma-desktop. Without it this had no chance to work. I'll update tonight and check it out. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-06 Thread Luca Beltrame
In data venerdì 06 giugno 2014 17:22:52, Aleix Pol ha scritto: Can you give it another try? Now works perfectly. Thanks! -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Description: This is a digitally signed message part.

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-05 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59350 --- Ship it! Looks good. - Eike Hein On June 5, 2014, 12:35

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/ --- (Updated June 5, 2014, 4:57 p.m.) Review request for Plasma, Martin

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59351 --- This review has been submitted with commit

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/ --- (Updated June 5, 2014, 5:12 p.m.) Status -- This change has been

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-05 Thread Luca Beltrame
In data giovedì 05 giugno 2014 00:35:56, Aleix Pol Gonzalez ha scritto: This patch uses the screen geometry to figure out what's the screen and then passes around the screen rect so that we can filter out the screens that I have tested it and unfortunately it doesn't really work: now tasks are

Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59370 --- It fudges window geometry by removing 5 pixels from each

Review Request 118548: Port libtaskmanager away from QDesktopWidget

2014-06-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/ --- Review request for Plasma, Eike Hein and Luca Beltrame. Repository: