Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/ --- (Updated July 14, 2014, 11:24 a.m.) Status -- This change has been

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-11 Thread Marco Martin
On July 10, 2014, 8:10 p.m., Marco Martin wrote: src/plasma/private/applet_p.cpp, line 316 https://git.reviewboard.kde.org/r/119220/diff/1/?file=289610#file289610line316 when the code hits this path, uiready gets anyways set to true in line 333 now, to be really

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/ --- (Updated July 11, 2014, 5:33 p.m.) Review request for Plasma. Changes

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/#review62147 --- hmm, i preferred the previous version :/ - Marco Martin On

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-11 Thread Marco Martin
On July 11, 2014, 5:42 p.m., Marco Martin wrote: hmm, i preferred the previous version :/ Anyways, would be fine for me.. i really need to write an unit test for this darn thing tough - Marco --- This is an automatically generated

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/#review62154 --- Ship it! So, it can go in for now, I decided to stop talking

Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/#review62094 --- Ship it! It seems correct, just a little note.

Re: Review Request 119220: Figure out why my plasma wasn't notifying the startup

2014-07-10 Thread Aleix Pol Gonzalez
On July 10, 2014, 8:10 p.m., Marco Martin wrote: src/plasma/private/applet_p.cpp, line 316 https://git.reviewboard.kde.org/r/119220/diff/1/?file=289610#file289610line316 when the code hits this path, uiready gets anyways set to true in line 333 now, to be really