---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---
(Updated Dec. 15, 2015, 11:09 a.m.)
Status
--
This change has been
Hi all,
since now 5.1 is branched, i would like to revert commit c8adae02c993a
Revert Support per-activity favourites in Kickoff
to have it again in master and start to iron out possible problems in master
in the meantime
--
Marco Martin
___
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---
(Updated Aug. 9, 2014, 8:48 a.m.)
Review request for Plasma, Eike Hein,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63406
---
applets/kickoff/core/krunnermodel.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---
Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63321
---
+1 from me, would like toknow from Eike if this provides all
On July 28, 2014, 12:03 p.m., Marco Martin wrote:
+1 from me, would like toknow from Eike if this provides all is needed for
use cases outside kickoff
Kicker doesn't use Kickoff's models, i.e. activity support has to be
implemented in Kicker's own favorites model.
- Eike
On July 28, 2014, 12:03 p.m., Marco Martin wrote:
+1 from me, would like toknow from Eike if this provides all is needed for
use cases outside kickoff
Eike Hein wrote:
Kicker doesn't use Kickoff's models, i.e. activity support has to be
implemented in Kicker's own favorites
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63347
---
Ship it!
for kickoff, for what i'm concerned is good to go
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/#review63349
---
applets/kickoff/package/contents/ui/ContextMenu.qml
On July 28, 2014, 5:31 p.m., Thomas Braxton wrote:
applets/kickoff/package/contents/ui/ContextMenu.qml, line 62
https://git.reviewboard.kde.org/r/119515/diff/1/?file=293832#file293832line62
addToGlobalFavorites sounds better
Agreed.
- Ivan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119515/
---
(Updated July 28, 2014, 5:50 p.m.)
Status
--
This change has been
12 matches
Mail list logo
