Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 7, 2014, 3:19 p.m.) Review request for KDE Frameworks and

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/#review63781 --- src/platformtheme/khintssettings.cpp

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 259 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line259 This means we'll end up with a KCM to change icons that does nothing. That sounds bad? I

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread David Edmundson
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 259 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line259 This means we'll end up with a KCM to change icons that does nothing. That sounds bad? I

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 53 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53 I don't think we want to call the default look and feel package something like maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 4, 2014, 3:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread David Edmundson
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 53 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53 I don't think we want to call the default look and feel package something like maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread David Edmundson
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 53 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53 I don't think we want to call the default look and feel package something like maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 53 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53 I don't think we want to call the default look and feel package something like maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: src/platformtheme/khintssettings.cpp, line 53 https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53 I don't think we want to call the default look and feel package something like maybe

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
On Aug. 4, 2014, 2:22 p.m., David Edmundson wrote: Another thing I would like an opinion on, is about the color scheme: right now it searches for a configured color scheme name, then searches in the package a file with the same name as the color scheme name. I was thinking it may be

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/#review63812 --- src/platformtheme/khintssettings.cpp

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 4, 2014, 6:09 p.m.) Review request for KDE Frameworks and

Review Request 119534: take defaults from a plasma look and feel package, if available

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated July 29, 2014, 1:25 p.m.) Review request for KDE Frameworks and