---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67339
---
Ship it!
Ship It!
- David Edmundson
On Sept. 23, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 24, 2014, 3:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 23, 2014, 1:07 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 23, 2014, 3:57 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 23, 2014, 3:58 p.m.)
Review request for Plasma.
Changes
On Sept. 20, 2014, 11:27 p.m., Pier Luigi Fiorini wrote:
Modules/base/info_wayland.cpp, line 210
https://git.reviewboard.kde.org/r/120279/diff/2/?file=313412#file313412line210
Why we need a new connection?
QPA already has one.
there is no QPA in this case. It's for reporting
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 22, 2014, 3:46 p.m.)
Review request for Plasma.
Changes
On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 289
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line289
Why make this a function and use it once? It seems rather pointless.
Martin Gräßlin wrote:
simple: I
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67091
---
Modules/base/info_wayland.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review67092
---
Modules/base/info_wayland.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
Review request for Plasma.
Repository: kinfocenter
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66922
---
Modules/base/info_wayland.cpp
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 9:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/#review66928
---
Modules/base/info_wayland.cpp
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 11:37 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 236
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line236
This will add a row when the keyboard is added, but won't delete it
when you remove it.
When
On Sept. 19, 2014, 11:53 a.m., David Edmundson wrote:
Modules/base/info_wayland.cpp, line 194
https://git.reviewboard.kde.org/r/120279/diff/1/?file=313396#file313396line194
aren't we doing this in the ctor too?
good spot, I moved the code later-on to the class and oversaw that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120279/
---
(Updated Sept. 19, 2014, 12:49 p.m.)
Review request for Plasma.
22 matches
Mail list logo