Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/ --- (Updated Oct. 15, 2014, 1:54 p.m.) Review request for Plasma. Changes

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68453 --- Ship it! Inviala! - Marco Martin On Ott. 15, 2014, 1:54

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68455 --- I consider it as highly unlikely that KWin positioned the

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-15 Thread Aleix Pol Gonzalez
On Oct. 15, 2014, 2:06 p.m., Martin Gräßlin wrote: I consider it as highly unlikely that KWin positioned the panel unless it (or Qt) was doing something wrong. The panel should request a position and KWin honors that and as it's a panel there is nothing which should make KWin in

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/ --- (Updated Oct. 15, 2014, 3:15 p.m.) Status -- This change has been

Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68400 --- looks like a useful change to me (and I hope it fixes the

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68401 --- That seems to fix the panel showing on the wrong screen I was

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68402 --- Ship it! Ship It! - Jeremy Whiting On Oct. 14, 2014,

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120584/#review68403 --- Ship it! Sounds sensible. however, can someone try plasma

Re: Review Request 120584: Don't position the panel until it's about to be displayed

2014-10-14 Thread Marco Martin
On Ott. 14, 2014, 4:36 p.m., Marco Martin wrote: Sounds sensible. however, can someone try plasma without this patch and with the Qt patch: https://codereview.qt-project.org/#/c/97050/ this one may be a workaround for the qt xcb problem adressed in the above, but i'm not 100%