Re: Review Request 123040: Make selection in krunner wrapping

2015-03-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77833 --- Ship it! Go ahead then :) - Vishesh Handa On March 18,

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-20 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77840 --- Git commit 05570618369027c8636db9abbe3726ece6fe8e72 by Pinak

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-20 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/ --- (Updated March 20, 2015, 4:14 p.m.) Status -- This change has been

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-19 Thread Marco Martin
On March 18, 2015, 10:36 p.m., Aleix Pol Gonzalez wrote: But do we really want this? Vishesh Handa wrote: Doesn't seem like a bad idea. Specially since someone has asked for it. Any particular reason you're against this? Pinak Ahuja wrote: In my opinion it would be better

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-19 Thread Marco Martin
On March 18, 2015, 10:36 p.m., Aleix Pol Gonzalez wrote: But do we really want this? Vishesh Handa wrote: Doesn't seem like a bad idea. Specially since someone has asked for it. Any particular reason you're against this? Pinak Ahuja wrote: In my opinion it would be better

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-19 Thread Vishesh Handa
On March 18, 2015, 10:36 p.m., Aleix Pol Gonzalez wrote: But do we really want this? Vishesh Handa wrote: Doesn't seem like a bad idea. Specially since someone has asked for it. Any particular reason you're against this? Pinak Ahuja wrote: In my opinion it would be better

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-19 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77735 --- I like the idea (I'm the bug reporter, surprise) As Marco

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/#review77712 --- But do we really want this? - Aleix Pol Gonzalez On March

Review Request 123040: Make selection in krunner wrapping

2015-03-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/ --- Review request for Plasma and Vishesh Handa. Bugs: 345301

Re: Review Request 123040: Make selection in krunner wrapping

2015-03-18 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123040/ --- (Updated March 18, 2015, 7:06 p.m.) Review request for Plasma and