---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated May 2, 2015, 4:46 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated May 2, 2015, 7:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79767
---
Don't remove the case that improves things for users :)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 30, 2015, 9:05 a.m.)
Review request for KDE Frameworks,
On April 28, 2015, 2:35 p.m., David Faure wrote:
src/core/global.cpp, line 407
https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407
startsWith('.') (using the QChar overload)
Do we even need this special case, with the way the code is now? It
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 28, 2015, 2:38 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79631
---
src/core/global.cpp (line 396)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79629
---
src/core/global.cpp (line 396)
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote:
autotests/globaltest.cpp, line 96
https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96
This should be (1).txt?
Ashish Bansal wrote:
imho if my any file starts with ., that's my dot file and I would
On April 25, 2015, 7:42 p.m., David Faure wrote:
src/core/global.cpp, line 397
https://git.reviewboard.kde.org/r/123224/diff/2/?file=359785#file359785line397
Why do you assemble a list, and then only look at the last element? You
just need an int and a QMimeType, if only the last
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 26, 2015, 12:19 p.m.)
Review request for KDE Frameworks,
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote:
autotests/globaltest.cpp, line 96
https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96
This should be (1).txt?
Ashish Bansal wrote:
imho if my any file starts with ., that's my dot file and I would
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79509
---
src/core/global.cpp (line 396)
On April 6, 2015, 3:12 p.m., Martin Klapetek wrote:
autotests/globaltest.cpp, line 96
https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96
This should be (1).txt?
Ashish Bansal wrote:
imho if my any file starts with ., that's my dot file and I would
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review78559
---
Just a question - why is the current suggested name wrong?
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote:
Just a question - why is the current suggested name wrong?
In name filename-1.6.tar.gz, 1.6 denotes package version and new suggested
name changes it to filename-1 2.6.tar.gz. It should add 1 after the package
version and should not
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 4, 2015, 1:15 p.m.)
Review request for KDE Frameworks,
17 matches
Mail list logo
