Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-21 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 21, 2015, 7:37 p.m.) Status -- This change has been

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-20 Thread Bernhard Friedreich
On April 20, 2015, 7:59 a.m., Marco Martin wrote: hmm, the timer is actually quite small and not bigger than the digital clock, It would be probably better if it stays always extended the whole resizing mechanism of the plasmoid will need to be rewritten I fear.. while doing this I also

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/#review79243 --- hmm, the timer is actually quite small and not bigger than

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-20 Thread Bernhard Friedreich
On April 20, 2015, 7:59 vorm., Marco Martin wrote: hmm, the timer is actually quite small and not bigger than the digital clock, It would be probably better if it stays always extended Bernhard Friedreich wrote: the whole resizing mechanism of the plasmoid will need to be rewritten

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-20 Thread Marco Martin
On April 20, 2015, 7:59 a.m., Marco Martin wrote: hmm, the timer is actually quite small and not bigger than the digital clock, It would be probably better if it stays always extended Bernhard Friedreich wrote: the whole resizing mechanism of the plasmoid will need to be rewritten

Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-18 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-18 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 5:26 nachm.) Review request for Plasma.

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-18 Thread Bernhard Friedreich
On April 18, 2015, 5:33 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/timer.qml, lines 221-225 https://git.reviewboard.kde.org/r/123420/diff/1/?file=362055#file362055line221 Can be simplified to operation.summary = notificationText || i18n(Timer finished)

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/#review79175 --- applets/timer/package/contents/ui/timer.qml (line 56)

Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

2015-04-18 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 6:14 nachm.) Review request for Plasma.