Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Ashish Madeti
On April 23, 2015, 7:42 p.m., Bhushan Shah wrote: Ship It! What about the .cache discussion? debate on some other day? :P - Ashish --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79386 --- Looks good from my POV, I'll let the maintainer chech ship

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 2:20 p.m.) Status -- This change has been

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Bhushan Shah
On April 23, 2015, 7:42 p.m., Bhushan Shah wrote: Ship It! Ashish Madeti wrote: What about the .cache discussion? debate on some other day? :P More I think about it we don't want to use .cache. Reasons 1) This is for only playing media files and not all files in medialibrary 2) We

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79387 --- Ship it! Ship It! - Bhushan Shah On April 23, 2015, 7:25

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 7:25 p.m.) Review request for Plasma, Bhushan

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Sebastian Kügler
On April 22, 2015, 10:35 p.m., Sebastian Kügler wrote: libs/mediacenter/mpris2/mpris2.cpp, line 33 https://git.reviewboard.kde.org/r/123467/diff/3/?file=362527#file362527line33 Actually, this is wrong now. Using the native separator may produce \ (on Windows, for example), which

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 9:47 p.m.) Review request for Plasma, Bhushan

Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 22, 2015, 7:14 p.m.) Review request for Plasma, Bhushan

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79349 --- The idea sounds, some nitpicks though.

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79364 --- libs/mediacenter/mpris2/mpris2.cpp (line 33)

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-22 Thread Ashish Madeti
On April 23, 2015, 4:05 a.m., Sebastian Kügler wrote: libs/mediacenter/mpris2/mpris2.cpp, line 33 https://git.reviewboard.kde.org/r/123467/diff/3/?file=362527#file362527line33 Actually, this is wrong now. Using the native separator may produce \ (on Windows, for example), which