Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-08 Thread Martin Gräßlin
On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: Looks good to me too, as long as it works. OTOH, it looks like a bad reason to offer an homogeneous experience, albeit being a not really interesting bit of Plasma. Hrvoje Senjan wrote: I submited this patch to upstream due to

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Hrvoje Senjan
On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: Looks good to me too, as long as it works. OTOH, it looks like a bad reason to offer an homogeneous experience, albeit being a not really interesting bit of Plasma. I submited this patch to upstream due to two reasons: 1) number of

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Aleix Pol Gonzalez
On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: Looks good to me too, as long as it works. OTOH, it looks like a bad reason to offer an homogeneous experience, albeit being a not really interesting bit of Plasma. Hrvoje Senjan wrote: I submited this patch to upstream due to

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Martin Gräßlin
On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: Looks good to me too, as long as it works. OTOH, it looks like a bad reason to offer an homogeneous experience, albeit being a not really interesting bit of Plasma. Hrvoje Senjan wrote: I submited this patch to upstream due to

Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82147 --- Looks good to me - Martin Gräßlin On July 6, 2015, 8:41

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82157 --- Looks good to me too, as long as it works. OTOH, it looks