Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- (Updated July 21, 2015, 3:05 p.m.) Status -- This change has been ma

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Sebastian Kügler
On Tuesday, July 21, 2015 12:30:34 David Edmundson wrote: > > On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: > > > ...with my maintainer hat on. I would say let's gather feedback from > > > beta and during akademy and if it's bad, we can revert for the release. > +1 to that idea. +another1 --

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread David Edmundson
> On July 21, 2015, 8:07 a.m., Martin Klapetek wrote: > > ...with my maintainer hat on. I would say let's gather feedback from beta > > and during akademy and if it's bad, we can revert for the release. +1 to that idea. - David --- Thi

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Kai Uwe Broulik
> On Juli 21, 2015, 8:46 vorm., Mark Gaiser wrote: > > lookandfeel/contents/osd/Osd.qml, line 44 > > > > > > http://doc.qt.io/qt-5/qml-qtquick-opacityanimator.html perhaps? Animators only work within the SceneGra

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
> On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might res

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Gräßlin
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
> On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might res

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82755 --- lookandfeel/contents/osd/Osd.qml (line 44)

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
> On Juli 21, 2015, 7:03 vorm., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might res

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82751 --- Ship it! ...with my maintainer hat on. I would say let's gath

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 8:28 a.m., Martin Gräßlin wrote: > > This needs quite a bit of testing in real world: how does it behave with > > changing content underneath (e.g. a video, scrolling web browser), heavy > > load on the system, heavy load on the compositor, etc. Looks like the upcoming beta

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Klapetek
> On July 21, 2015, 1:36 a.m., Aleix Pol Gonzalez wrote: > > lookandfeel/contents/osd/Osd.qml, line 48 > > > > > > This looks like a random wait time... Looking at the video, it seems > > like a slow animation. >

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Martin Gräßlin
> On July 21, 2015, 9:03 a.m., Heiko Tietze wrote: > > Nice presentation, as always. But I'm not so sure that the realization of > > fading out quickly meets the needs from 'OSD is disturbing'. The second > > when the OSD is shown is still annoying (interaction during the fading > > might rest

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-21 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82745 --- Nice presentation, as always. But I'm not so sure that the rea

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82743 --- This needs quite a bit of testing in real world: how does it b

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82738 --- lookandfeel/contents/osd/Osd.qml (line 48)

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Jens Reuterberg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82734 --- Ship it! Ship It! - Jens Reuterberg On juli 20, 2015, 8:19

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82732 --- Nice! +1 from me. - Andrew Lake On July 20, 2015, 8:19 p.m.

Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- Review request for Plasma and KDE Usability. Repository: plasma-workspace