Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-08-12 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/ --- (Updated Aug. 12, 2015, 8:34 a.m.) Status -- This change has been

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-08-11 Thread Eric Koegel
On Aug. 10, 2015, 2:12 p.m., David Edmundson wrote: Ship It! Thanks for the review. I don't have push rights, would you mind doing that for me? Thanks! - Eric --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-08-10 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/ --- (Updated Aug. 10, 2015, 1:59 p.m.) Review request for Plasma. Changes

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-08-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/#review83659 --- Ship it! Ship It! - David Edmundson On Aug. 10, 2015,

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-07-29 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/ --- (Updated July 29, 2015, 4:10 p.m.) Review request for Plasma. Changes

Review Request 124469: ConsoleKit2 support for screenlocker

2015-07-26 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-07-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124469/#review82970 --- ksmserver/screenlocker/logind.h (line 67)

Re: Review Request 124469: ConsoleKit2 support for screenlocker

2015-07-26 Thread Kai Uwe Broulik
On Juli 26, 2015, 7:43 vorm., David Edmundson wrote: ksmserver/screenlocker/logind.h, line 70 https://git.reviewboard.kde.org/r/124469/diff/1/?file=387737#file387737line70 our normal naming is m_lowerCamelCase also, can you set these to 0. const