Re: Review Request 124697: Make Wayland a hard build time dependency

2015-08-12 Thread Martin Gräßlin
On Aug. 11, 2015, 6:45 p.m., Thomas Lübking wrote: abstract_client.cpp, line 519 https://git.reviewboard.kde.org/r/124697/diff/1/?file=393340#file393340line519 Why are these functions in AbstractClient itfp.? Looks like shell-client-only feature. No, we also need to expose the

Re: Review Request 124697: Make Wayland a hard build time dependency

2015-08-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124697/#review83729 --- Ship it! Ship It! - Thomas Lübking On Aug. 11, 2015,

Re: Review Request 124697: Make Wayland a hard build time dependency

2015-08-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124697/ --- (Updated Aug. 12, 2015, 9:39 a.m.) Status -- This change has been

Review Request 124697: Make Wayland a hard build time dependency

2015-08-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124697/ --- Review request for kwin and Plasma. Repository: kwin Description

Re: Review Request 124697: Make Wayland a hard build time dependency

2015-08-11 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124697/#review83711 --- Generally fine with the change, but some present oddities