Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-26 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-26 Thread David Kahles
On Aug. 24, 2015, 2:06 a.m., Marco Martin wrote: the middle thing was done in order to not cross the handles, but the other check you afded should prevent this anyways That was done by `offsetHandle.position + units.gridUnit * 3` in minimumPosition: Math.max(offsetHandle.position +

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/#review84238 --- Ship it! the middle thing was done in order to not cross the

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/#review84196 --- Ship it! - David Edmundson On Aug. 17, 2015, 10:50 a.m.,

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-17 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ --- (Updated Aug. 17, 2015, 12:50 p.m.) Review request for Plasma.

Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-17 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ --- Review request for Plasma. Repository: plasma-desktop Description