Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-09 Thread Martin Gräßlin
> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-09 Thread Thomas Lübking
> On Sept. 7, 2015, 2:59 nachm., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-09 Thread Martin Gräßlin
> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-09 Thread Martin Gräßlin
> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/ --- (Updated Sept. 9, 2015, 8:42 a.m.) Status -- This change has been

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-08 Thread Martin Gräßlin
> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-08 Thread Thomas Lübking
> On Sept. 7, 2015, 2:59 nachm., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-08 Thread Martin Gräßlin
> On Sept. 7, 2015, 4:59 nachm., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-07 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/#review84959 --- Hold it. Implementationwise, this looks wonky - if it's

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/#review84957 --- Ship it! Ship It! - Sebastian Kügler On Aug. 27, 2015,

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-06 Thread Thomas Pfeiffer
> On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-04 Thread Hans Chen
> On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-31 Thread Martin Gräßlin
> On Aug. 27, 2015, 9:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-31 Thread Martin Gräßlin
> On Aug. 27, 2015, 9:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-31 Thread Hans Chen
> On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-30 Thread Hans Chen
On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte to

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-28 Thread Thomas Lübking
On Aug. 27, 2015, 7:04 nachm., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-28 Thread Thomas Lübking
On Aug. 27, 2015, 7:04 nachm., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-28 Thread Martin Gräßlin
On Aug. 27, 2015, 9:04 p.m., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte to

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-28 Thread Martin Gräßlin
On Aug. 27, 2015, 9:04 p.m., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte to

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-28 Thread Thomas Lübking
On Aug. 27, 2015, 7:04 nachm., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. Thomas Lübking wrote: or restricte

Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/ --- Review request for kwin, Plasma and Hans Chen. Repository: kwin

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-27 Thread Thomas Lübking
On Aug. 27, 2015, 7:04 nachm., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. or restricte to wayland? same process

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-27 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/#review84486 --- Since this is indeed a very often required feature, why do we