Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-15 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/ --- (Updated Dec. 15, 2015, 3:44 p.m.) Status -- This change has been ma

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/#review89509 --- Ship it! Ship It! - Vishesh Handa On Dec. 6, 2015, 2:18 p.

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-06 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/ --- (Updated Dec. 6, 2015, 2:18 p.m.) Review request for Plasma and Vishesh H

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-06 Thread Pinak Ahuja
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-12-06 Thread Vishesh Handa
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-10-10 Thread Pinak Ahuja
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-10-03 Thread Vishesh Handa
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-09-18 Thread Vishesh Handa
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. > > Pinak Ahuja

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-09-18 Thread Pinak Ahuja
> On Sept. 15, 2015, 9:33 p.m., Vishesh Handa wrote: > > Maybe we could just add this to our `IndexerConfig` class so that users of > > our API don't need to know about dbus interfaces? Specially since I'm not > > too keen on maintaining API comatibility in the dbus interface. You mean adding

Re: Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-09-15 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/#review85462 --- Maybe we could just add this to our `IndexerConfig` class so t

Review Request 125129: Update baloo's D-Bus interface name in KCM

2015-09-09 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125129/ --- Review request for Plasma and Vishesh Handa. Repository: plasma-desktop