Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated May 30, 2016, 1:29 p.m.) Status -- This change has been

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On April 29, 2016, 4:06 nachm., David Edmundson wrote: > > lets get this merged ASAP so we have some time to fix any fallout from it. > > Sebastian Kügler wrote: > But we don't depend on Qt 5.6 yet in workspace. I think the blocker there > is that we need Qt 5.6 on the CI system, then we

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On May 21, 2016, 9:26 a.m., Matthias Blaicher wrote: > > Hello Aleix, > > I've just applied this patch and it fixed all my > > multi-screen/laptop/docking issues! You literally saved my relationship! > > (Gf switch her laptop to plasma 5 and was constantly cursing) <3 imagine the couples we

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review95666 --- Ship it! Hello Aleix, I've just applied this patch and it

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On April 29, 2016, 2:06 p.m., David Edmundson wrote: > > lets get this merged ASAP so we have some time to fix any fallout from it. > > Sebastian Kügler wrote: > But we don't depend on Qt 5.6 yet in workspace. I think the blocker there > is that we need Qt 5.6 on the CI system, then we

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On April 29, 2016, 2:06 p.m., David Edmundson wrote: > > lets get this merged ASAP so we have some time to fix any fallout from it. > > Sebastian Kügler wrote: > But we don't depend on Qt 5.6 yet in workspace. I think the blocker there > is that we need Qt 5.6 on the CI system, then we

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On April 29, 2016, 2:06 p.m., David Edmundson wrote: > > lets get this merged ASAP so we have some time to fix any fallout from it. But we don't depend on Qt 5.6 yet in workspace. I think the blocker there is that we need Qt 5.6 on the CI system, then we can switch. Incidentally, Qt 5.6 on

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review95021 --- lets get this merged ASAP so we have some time to fix any

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review95020 --- Ship it! Ship It! - David Edmundson On March 17, 2016,

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated March 17, 2016, 2:02 a.m.) Review request for Plasma.

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On March 13, 2016, 1:54 a.m., David Edmundson wrote: > > shell/panelview.cpp, line 687 > > > > > > This is wrong as you connect to the same signal multiple times. > > > > this connect should be in the

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review93459 --- shell/panelview.cpp (line 682)

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated March 12, 2016, 6:40 p.m.) Review request for Plasma.

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

> On March 10, 2016, 3 p.m., Marco Martin wrote: > > Ship It! Heh, hold your horses (my horses?). Still uses Qt 5.6 and doesn't have the changes we discussed. - Aleix --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review93388 --- Ship it! Ship It! - Marco Martin On March 10, 2016,

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated March 10, 2016, 11:48 a.m.) Review request for Plasma.

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated Oct. 26, 2015, 6:39 p.m.) Review request for Plasma. Changes

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review87448 --- shell/panelview.cpp (line 718)

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review86169 --- +1 as well. KScreen should only be used to configure the

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review86170 --- shell/panelview.cpp (line 727)

Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review86123 --- very happy about this \o/ I'll test on this system once i'll