Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Nov. 3, 2015, 1:09 p.m.) Status -- This change has been mar

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review87902 --- Ship it! Ship It! - Martin Gräßlin On Oct. 30, 2015, 4:54

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 30, 2015, 3:54 p.m.) Review request for Plasma. Repositor

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review87652 --- xembed-sni-proxy/COPYING.LIB (line 1)

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 23, 2015, 6:57 a.m., Martin Gräßlin wrote: > > xembedsniproxy/fdoselectionmanager.cpp, line 49 > > > > > > my search for selectionAtom only find's this usage. Given that I > > recommend to skip using th

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 28, 2015, 5:36 p.m.) Review request for Plasma. Changes -

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review87297 --- sorry for the const auto nitpicks. xembedsniproxy/debug.h (l

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 10:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. > > David Edmundson wrote: > I have.

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 21, 2015, 9:01 p.m.) Review request for Plasma. Repositor

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- (Updated Oct. 21, 2015, 9 p.m.) Review request for Plasma. Changes

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.cpp, lines 180-183 > > > > > > maybe you could use the sync protocol? xsync would make sense, except there doesn't seem to be one

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 8:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. > > David Edmundson wrote: > I have. F

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 10:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. > > David Edmundson wrote: > I have.

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 8:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. > > David Edmundson wrote: > I have. F

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 10:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. > > David Edmundson wrote: > I have.

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 8:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. I have. For me it works (for most clients

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86935 --- did you try whether the proxy works without compositing? I jus

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? ah yes, forgot to finish that Does anyone have a mouse with a horizontal scroll? If so can you open

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86919 --- finally :D xembedsniproxy/sniproxy.cpp (line 223)

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.h, lines 42-50 > > > > > > hmm? > > David Edmundson wrote: > ah right, I need some advice on here. > > There are pro

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 2:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/CMakeLists.txt, line 50 > > > > > > are you sure you want -Wall. The last project I tried to build with > > that flag was unbuildable. > >

Re: Review Request 125655: Xembed SNI Proxy

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.h, lines 42-50 > > > > > > hmm? ah right, I need some advice on here. There are properties that exist in the SNI spec that I can

Re: Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86912 --- Overall looks good! General comments: * please use KSelectionO

Review Request 125655: Xembed SNI Proxy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- Review request for Plasma. Repository: plasma-workspace Description ---