Re: Review Request 125743: Keep aspect ratio in default KSplash background

2016-09-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/ --- (Updated Sept. 15, 2016, 11:33 a.m.) Status -- This change has been

Re: Review Request 125743: Keep aspect ratio in default KSplash background

2015-10-28 Thread David Edmundson
> On Oct. 21, 2015, 9:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match > > Martin Klapetek wrote: > Match what? Do we have similar code elsewhere? Btw Hrvoje reported that > this is less than ideal as it "letterboxes" the background, which I was a bit >

Re: Review Request 125743: Keep aspect ratio in default KSplash background

2015-10-28 Thread Martin Klapetek
> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match Match what? Do we have similar code elsewhere? Btw Hrvoje reported that this is less than ideal as it "letterboxes" the background, which I was a bit worried about. So, I'm thinking

Re: Review Request 125743: Keep aspect ratio in default KSplash background

2015-10-28 Thread Martin Klapetek
> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote: > > Makes sense for the default behaviours to match > > Martin Klapetek wrote: > Match what? Do we have similar code elsewhere? Btw Hrvoje reported that > this is less than ideal as it "letterboxes" the background, which I was a bit >

Review Request 125743: Keep aspect ratio in default KSplash background

2015-10-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125743: Keep aspect ratio in default KSplash background

2015-10-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/ --- (Updated Oct. 21, 2015, 8:51 p.m.) Review request for Plasma.

Re: Review Request 125743: Keep aspect ratio in default KSplash background

2015-10-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125743/#review87228 --- Ship it! Makes sense for the default behaviours to match -