Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- (Updated Feb. 8, 2017, 4:02 p.m.) Status -- This change has been dis

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/#review102488 --- please post this again on phabricator if is still relevant

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > > weird

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Nov. 2, 2015, 1:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > > weird

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > > weird

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > > weird

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > > weird

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > > weird

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/#review87864 --- I don't like this change, as it introduces a magic constant fo

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- (Updated Oct. 29, 2015, 6:16 p.m.) Review request for Plasma. Changes -

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Oct. 24, 2015, 3:07 p.m., David Edmundson wrote: > > src/plasma/theme.cpp, lines 469-473 > > > > > > that looks wrong. size is already width and height and users (should) > > be already using the right one

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- (Updated Oct. 24, 2015, 3:22 p.m.) Review request for Plasma. Changes -

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

> On Oct. 24, 2015, 3:07 p.m., David Edmundson wrote: > > src/plasma/theme.cpp, lines 469-473 > > > > > > that looks wrong. size is already width and height and users (should) > > be already using the right one

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/#review87339 --- src/plasma/theme.cpp (lines 469 - 473)

Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/ --- Review request for Plasma. Bugs: 343349 http://bugs.kde.org/show_bug.