Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/ --- (Updated Oct. 27, 2015, 10:02 a.m.) Status -- This change has been

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/ --- (Updated Oct. 27, 2015, 9:43 a.m.) Review request for Plasma.

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Marco Martin
> On Oct. 26, 2015, 9:12 p.m., Sebastian Kügler wrote: > > applets/notifications/package/metadata.desktop, line 170 > > > > > > We have a special notifications applet for handsets in plasma-mobile, > > so this

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/#review87498 --- Ship it! Ship It! - Sebastian Kügler On Oct. 27, 2015,

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/#review87465 --- Some remarks, but otherwise, thanks for taking care of this.

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Sebastian Kügler
> On Oct. 26, 2015, 5:26 p.m., Kai Uwe Broulik wrote: > > applets/analog-clock/metadata.desktop, line 170 > > > > > > Why not "not specified = everywhere"? > > Marco Martin wrote: > yeah, in some of those

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/#review87443 --- applets/analog-clock/metadata.desktop (line 170)

Re: Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Marco Martin
> On Oct. 26, 2015, 5:26 p.m., Kai Uwe Broulik wrote: > > applets/analog-clock/metadata.desktop, line 170 > > > > > > Why not "not specified = everywhere"? yeah, in some of those are probably redundant -

Review Request 125810: Add some formfactor info to plasma-workspace applets

2015-10-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125810/ --- Review request for Plasma. Repository: plasma-workspace Description