Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/ --- (Updated Jan. 26, 2016, 5:44 p.m.) Status -- This change has been

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 4:04 nachm., Lamarque Souza wrote: > > kded/notification.cpp, line 56 > > > > > > It would be safer to add an inhibit to guarantee onPrepareForSleep() > > has finished before letting

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91598 --- Ship it! Ship It! - Lamarque Souza On Jan. 15, 2016,

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 4:04 p.m., Lamarque Souza wrote: > > kded/notification.cpp, line 56 > > > > > > It would be safer to add an inhibit to guarantee onPrepareForSleep() > > has finished before letting

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91150 --- Ship it! Looks good to me, maybe just change what I

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 3:20 nachm., Jan Grulich wrote: > > Looks good to me, maybe just change what I pointed out (storing just UUIDs > > as strings instead active connections). I don't have time right now to test > > it, but I trust you that it works. > > > > Looking only for active connections

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/ --- (Updated Jan. 15, 2016, 3:03 nachm.) Review request for Plasma, Jan

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91149 --- kded/notification.h (line 60)

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91153 --- kded/notification.cpp (line 56)

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Led. 14, 2016, 6:22 odp., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails

Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/ --- Review request for Plasma and Jan Grulich. Repository: plasma-nm

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 7:22 p.m., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it fails

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? Doesn't it tell you that anyway? At least when I try to connect to something and it fails I get like 3 notifications about

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 14, 2016, 6:22 nachm., Martin Klapetek wrote: > > It should probably still show when you get disconnected and *not* > > reconnected (to any network) on resume? > > Kai Uwe Broulik wrote: > Doesn't it tell you that anyway? At least when I try to connect to > something and it

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91107 --- It should probably still show when you get disconnected and