Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-03-02 Thread Pino Toscano
> On Mar. 1, 2016, 1:31 p.m., Martin Klapetek wrote: > > Turns out pkg_get_variable is available only in cmake 3.4, while minimum > > requirement is "2.8.12". > > > > Can you perhaps change the cmake module to not use pkg_get_variable for now? Yessir, will change it soon. Thanks for the

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-03-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review92995 --- Turns out pkg_get_variable is available only in cmake 3.4,

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-02-14 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/ --- (Updated Feb. 14, 2016, 1:09 p.m.) Status -- This change has been

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review91586 --- Ship it! Looks good, thanks! - Martin Klapetek On Jan.

Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/ --- Review request for Localization and Translation (l10n), Plasma and John

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review91552 --- +1 applets/digital-clock/plugin/timezonesi18n.cpp (line

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread Pino Toscano
> On Gen. 24, 2016, 10:39 p.m., David Edmundson wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 517 > > > > > > may as well keep the comment from the i18n? Not sure what you mean. The point here

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-01-24 Thread David Edmundson
> On Jan. 24, 2016, 10:39 p.m., David Edmundson wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 517 > > > > > > may as well keep the comment from the i18n? > > Pino Toscano wrote: > Not sure