Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 15, 2017, 6:54 p.m.) Status -- This change has been

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 15, 2017, 7:54 p.m.) Status -- This change has been

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review102051 --- Ship it! Ship It! - Ivan Čukić On Jan. 15, 2017, 1:12

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review102040 --- Ship it! Ship It! - Martin Koller On Jan. 15, 2017,

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-15 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 15, 2017, 1:08 p.m.) Review request for Plasma. Changes

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-07 Thread Andreas Sturmlechner
> On Jan. 7, 2017, 4:48 a.m., Anthony Fieroni wrote: > > CMakeLists.txt, line 168 > > > > > > You still need find_package(KF5KHtml QUIET) In the line above, but QUIET is indeed prettier, thanks. - Andreas

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-07 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- (Updated Jan. 7, 2017, 12:38 p.m.) Review request for Plasma. Changes

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-06 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review101846 --- CMakeLists.txt (line 166)

Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

2017-01-06 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- Review request for Plasma. Repository: kio-extras Description ---