Review Request: Keyboard control for PMC welcome screen

2010-10-03 Thread Luca Tringali
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5522/ --- Review request for Plasma. Summary --- Added the keyboard control for

Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5525/ --- Review request for Plasma. Summary --- For some projects it's

Review Request: kdebase: add support for ScriptEngine::evaluate() in the JavaScript Engine (depends on 5525)

2010-10-03 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5526/ --- Review request for Plasma. Summary --- This adds support for

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5525/#review7951 --- I like the approach, as you said, supporting the extra types is

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Martin Blumenstingl
On 2010-10-03 19:01:08, Marco Martin wrote: I like the approach, as you said, supporting the extra types is needed, so a similar binding like the js engine itself for the color ctor is needed as well here. are stringlist supported atm? StringLists are supported (in a very ugly way) by

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5525/#review7953 --- two problems i didn't see before, this add a virtual and complex

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Marco Martin
On 2010-10-03 20:31:11, Marco Martin wrote: two problems i didn't see before, this add a virtual and complex types that require a constructor won't work, since are not registered yet a solution could be assuming that code would be javascript, and use a new engine just for that with all

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5525/#review7956 --- beyond Marco's observation that we can't add a new virtual to

Re: Review Request: kdelibs: default-values in config files should be able to handle code-generated default values

2010-10-03 Thread Aaron Seigo
On 2010-10-04 04:41:13, Aaron Seigo wrote: beyond Marco's observation that we can't add a new virtual to that class (breaks binary compat), i'd honestly rather not support code entries unless we have some good use cases for it, since is likely to be non-trivial to get right. i