Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread makis marimpis
> On April 4, 2012, 5:13 p.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 41 > > > > > > Maybe the slowness has nothing to do with your patch. Last weekend I > > was d

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12288 --- service/plugins/globalshortcuts/globalshortcuts.cpp

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread Lamarque Vieira Souza
> On April 4, 2012, 5:13 p.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 41 > > > > > > Maybe the slowness has nothing to do with your patch. Last weekend I > > was d

Re: NotifierItem Glowing on mouseOver

2012-04-11 Thread Aaron J. Seigo
On Tuesday, April 10, 2012 16:21:24 Alex Fiestas wrote: > A few releases ago iirc (or at some point in the development) all > NotifierItems glow in systemtray when mouseOver, now only Network Management > does (at least here). it seems they are all indeed glowing (confirmed both by instrumenting t

Re: NotifierItem Glowing on mouseOver

2012-04-11 Thread Marco Martin
On Wednesday 11 April 2012, Aaron J. Seigo wrote: > then i changed it to colorize the icons .. and again it was more visible > but interestingly enough, due to the small amount of colour used in the > default system tray icons, only small bits of the icons were affected. > > one way to confirm tha

Re: NotifierItem Glowing on mouseOver

2012-04-11 Thread Mark
On Wed, Apr 11, 2012 at 11:07 AM, Marco Martin wrote: > On Wednesday 11 April 2012, Aaron J. Seigo wrote: > > then i changed it to colorize the icons .. and again it was more visible > > but interestingly enough, due to the small amount of colour used in the > > default system tray icons, only sm

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated April 11, 2012, 5:41 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread makis marimpis
> On April 10, 2012, 9:48 a.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 41 > > > > > > This plugin is loaded in EventProcessor's constructor, which is called > > fr

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated April 11, 2012, 8:06 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12335 --- service/plugins/globalshortcuts/globalshortcuts.cpp

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12342 --- service/plugins/globalshortcuts/globalshortcuts.cpp

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread makis marimpis
> On April 11, 2012, 6:18 p.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 26 > > > > > > Maybe setting this and all other variables related to dbus in > > ::realInit(

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-11 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12347 --- service/plugins/globalshortcuts/globalshortcuts.cpp