Re: IRC meeting
On Friday 07 September 2012, Mark wrote: Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel Ehh, plasma3? We don't even have a plasma 2 yet (it's in development).. Or am i missing something obvious now? eheh, i see this made quite some confusion: yes it is a typo ;) here i mean plasma2 indeed. so, meeting about among other thing plasma active 3 *and* plasma 2 :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. - Aaron J. Seigo On Sept. 7, 2012, 9:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 9:20 a.m.) Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 9:20 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 9:20 a.m.) Review request for Plasma. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Changes --- add mgrasselin Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Greg T wrote: Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... idea: 1) create a dataengine called org.kde.appshortcuts or something like that every source would represent a shortcut (even if just the desktop file name) 2) it has a service to add or remove shortcuts 3) the taskbar is connected to that engine and uses it for its own shortcuts would mean that: * would add shortcuts in the taskbar (and any other plasmoid connected to that) rather than directly the panel, so would need at least one connected to work * add to desktop is not supported anymore and i think is good, too many assumption on what desktop it is and where it is ;) - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 10:58 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Ordering items in QML Column
Hi there, Is there a way to re-order items in QML Column element? I can, of course, remove all items and add them in a new order, but that seems a very inelegant solution. In the docs there is no info on any ordering methods nor properties (or at least I do not see those): http://doc.qt.nokia.com/4.7/qml-column.html -- Pozdrawiam Michał rysiek Woźniak Fundacja Wolnego i Otwartego Oprogramowania signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: RFC: on notifications applet
On Thursday, September 06, 2012 13:05:48 Shaun Reich wrote: curious, are the inner layout shifting bugs magically fixed with this qml version? *crosses fingers toes* Most likely, yes. That seems to be genuine QGraphicsLayout borkage. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: declarative plasmoid object, containment access
On Sept. 7, 2012, 9:43 a.m., Aaron J. Seigo wrote: exposing the containment to all plasmoids is not a good idea. one of the main benefits of these QML/JS plasmoids is that they are far more sandboxed from the rest of the system. this also invites plasmoids to think they know how the shell works, which they can't - it could just as easily be plasma-netbook ad plasma-desktop. let's back up and look at the problem from the starting point: the goal is to put an entry in a context menu that people can select which adds an icon for that application to the panel or the desktop (whatever that means given multiple screens, per virtual desktop views, etc.) first question: do we really need this exact feature? is drag and drop good enough? are there other ways we could offer? (e.g. in the Add widgets UI could there be a way to add applications as well?) second question: if this is really, really required can it be done without opening access to Containment? e.g. could it be done using a Plasma::Service which does the right thing for the given shell? also, i don't think missing this feature should stand in the way of the QML version replacing the C++ version in master. we need to get this merged as soon as possible so people can start using it and we can start improving problems that crop up. Greg T wrote: Hi Aaron, 1. I really think as long as we support a context menu, we must also provide those 2 'add to xxx' entrys. Probably our users would be rather pissed off and call it a regression, if we drop them in kickoff-qml/KDE 4.10. 2. agreed, some kind of abstraction would be a great, no idea how to implement that though. You can really do a lot of creepy things with a containment... 3. I'm ok with that, but I never merged a feature branch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... Marco Martin wrote: idea: 1) create a dataengine called org.kde.appshortcuts or something like that every source would represent a shortcut (even if just the desktop file name) 2) it has a service to add or remove shortcuts 3) the taskbar is connected to that engine and uses it for its own shortcuts would mean that: * would add shortcuts in the taskbar (and any other plasmoid connected to that) rather than directly the panel, so would need at least one connected to work * add to desktop is not supported anymore and i think is good, too many assumption on what desktop it is and where it is ;) interesting, but for clarification: the idea is to add those app shortcuts as launchers to the task manager? But lets get kickoff into master before working on this topic :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/#review18645 --- On Sept. 7, 2012, 10:58 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106365/ --- (Updated Sept. 7, 2012, 10:58 a.m.) Review request for Plasma and Martin Gräßlin. Description --- Heya, I need access to the containment in a qml plasmoid with c++ extensions. Actually I'm using that to add launcher items from the new kickoff-qml to the desktop/panel. Thats one of the last missing features of declarative kickoff, basically it would be ready now to replace the c++ version... Well, certainly you know what I want to achieve, so feel free to suggest better alternatives :) Diffs - plasma/scriptengines/javascript/plasmoid/appletinterface.h 4f1201b plasma/scriptengines/javascript/plasmoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Weather Forecast QML port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18663 --- Any updates here? - Luis Gabriel Lima On Aug. 30, 2012, 1:53 a.m., Luis Gabriel Lima wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/ --- (Updated Aug. 30, 2012, 1:53 a.m.) Review request for Plasma and Marco Martin. Description --- This patch is part of the work done in my GSoC 2012 project. Diffs - applets/weather/CMakeLists.txt 4ae9c6f applets/weather/package/contents/ui/DetailsView.qml PRE-CREATION applets/weather/package/contents/ui/FiveDaysView.qml PRE-CREATION applets/weather/package/contents/ui/Notice.qml PRE-CREATION applets/weather/package/contents/ui/NoticesView.qml PRE-CREATION applets/weather/package/contents/ui/TopPanel.qml PRE-CREATION applets/weather/package/contents/ui/Utils.js PRE-CREATION applets/weather/package/contents/ui/WeatherListView.qml PRE-CREATION applets/weather/package/contents/ui/main.qml PRE-CREATION applets/weather/package/metadata.desktop PRE-CREATION applets/weather/weatherapplet.h a7e7f8d applets/weather/weatherapplet.cpp 9fd3e5f applets/weather/weatherdelegate.h 8a27f0d applets/weather/weatherdelegate.cpp 1cd987b applets/weather/weatherview.h f177501 applets/weather/weatherview.cpp 5234cd3 Diff: http://git.reviewboard.kde.org/r/106225/diff/ Testing --- - Tested inside panels and floating on desktop - Tested with various providers and locations Screenshots --- http://git.reviewboard.kde.org/r/106225/s/696/ http://git.reviewboard.kde.org/r/106225/s/698/ http://git.reviewboard.kde.org/r/106225/s/699/ http://git.reviewboard.kde.org/r/106225/s/700/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Ordering items in QML Column
On Fri, Sep 7, 2012 at 4:36 PM, Michał 'rysiek' Woźniak rys...@fwioo.pl wrote: Hi there, Is there a way to re-order items in QML Column element? I can, of course, remove all items and add them in a new order, but that seems a very inelegant solution. In the docs there is no info on any ordering methods nor properties (or at least I do not see those): http://doc.qt.nokia.com/4.7/qml-column.html From Qt mailing list: http://lists.qt.nokia.com/pipermail/qt-qml/2010-October/001423.html -- Pozdrawiam Michał rysiek Woźniak Fundacja Wolnego i Otwartego Oprogramowania ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Weather Forecast QML port
On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: applets/weather/package/contents/ui/Notice.qml, line 27 http://git.reviewboard.kde.org/r/106225/diff/1/?file=81341#file81341line27 Unless there's a good reason, use PlasmaComponents.Label rather than Text. Otherwise font size won't be consistent. Saves you setting the theme colour yourself too :) Same for all instances of Text Luis Gabriel Lima wrote: The C++ version uses the QApplication::font() instead of the plasma theme font. So after notice the difference when I was trying the PlasmaComponents.Label, I decided to keep the same way as the C++ version. David Edmundson wrote: That's sort of a good reason. Though I would argue that if the C++ one is wrong, there's no need to copy it. Luis Gabriel Lima wrote: I don't know if the C++ version is wrong, actually all the three plasmoid that I've ported was using QApplication::font(). It's still (IMHO) rather wrong. For example if a user had bad eyesight and increases their plasma font size in the Workspace Appearance KCM, you'd expect it to actually work. However, as it's not a regression so I'm not calling it a showstopper to merging. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18054 --- On Aug. 30, 2012, 1:53 a.m., Luis Gabriel Lima wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/ --- (Updated Aug. 30, 2012, 1:53 a.m.) Review request for Plasma and Marco Martin. Description --- This patch is part of the work done in my GSoC 2012 project. Diffs - applets/weather/CMakeLists.txt 4ae9c6f applets/weather/package/contents/ui/DetailsView.qml PRE-CREATION applets/weather/package/contents/ui/FiveDaysView.qml PRE-CREATION applets/weather/package/contents/ui/Notice.qml PRE-CREATION applets/weather/package/contents/ui/NoticesView.qml PRE-CREATION applets/weather/package/contents/ui/TopPanel.qml PRE-CREATION applets/weather/package/contents/ui/Utils.js PRE-CREATION applets/weather/package/contents/ui/WeatherListView.qml PRE-CREATION applets/weather/package/contents/ui/main.qml PRE-CREATION applets/weather/package/metadata.desktop PRE-CREATION applets/weather/weatherapplet.h a7e7f8d applets/weather/weatherapplet.cpp 9fd3e5f applets/weather/weatherdelegate.h 8a27f0d applets/weather/weatherdelegate.cpp 1cd987b applets/weather/weatherview.h f177501 applets/weather/weatherview.cpp 5234cd3 Diff: http://git.reviewboard.kde.org/r/106225/diff/ Testing --- - Tested inside panels and floating on desktop - Tested with various providers and locations Screenshots --- http://git.reviewboard.kde.org/r/106225/s/696/ http://git.reviewboard.kde.org/r/106225/s/698/ http://git.reviewboard.kde.org/r/106225/s/699/ http://git.reviewboard.kde.org/r/106225/s/700/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Weather Forecast QML port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18666 --- Ship it! Fine with me. - David Edmundson On Aug. 30, 2012, 1:53 a.m., Luis Gabriel Lima wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/ --- (Updated Aug. 30, 2012, 1:53 a.m.) Review request for Plasma and Marco Martin. Description --- This patch is part of the work done in my GSoC 2012 project. Diffs - applets/weather/CMakeLists.txt 4ae9c6f applets/weather/package/contents/ui/DetailsView.qml PRE-CREATION applets/weather/package/contents/ui/FiveDaysView.qml PRE-CREATION applets/weather/package/contents/ui/Notice.qml PRE-CREATION applets/weather/package/contents/ui/NoticesView.qml PRE-CREATION applets/weather/package/contents/ui/TopPanel.qml PRE-CREATION applets/weather/package/contents/ui/Utils.js PRE-CREATION applets/weather/package/contents/ui/WeatherListView.qml PRE-CREATION applets/weather/package/contents/ui/main.qml PRE-CREATION applets/weather/package/metadata.desktop PRE-CREATION applets/weather/weatherapplet.h a7e7f8d applets/weather/weatherapplet.cpp 9fd3e5f applets/weather/weatherdelegate.h 8a27f0d applets/weather/weatherdelegate.cpp 1cd987b applets/weather/weatherview.h f177501 applets/weather/weatherview.cpp 5234cd3 Diff: http://git.reviewboard.kde.org/r/106225/diff/ Testing --- - Tested inside panels and floating on desktop - Tested with various providers and locations Screenshots --- http://git.reviewboard.kde.org/r/106225/s/696/ http://git.reviewboard.kde.org/r/106225/s/698/ http://git.reviewboard.kde.org/r/106225/s/699/ http://git.reviewboard.kde.org/r/106225/s/700/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: IRC meeting
On Thursday 06 September 2012, Marco Martin wrote: September 11, 7PM UTC (21:00 for most europe) unfortunately doesn't seem to work for Thomas and Luis, the completely perfect spot doesn't seem to exist this time, damn timezones ;) Anyways IRC log will be saved. for Thomas and Luis: if you have arguments you would like to be discussed (or tasks you already know you want to take on), please say so here in this thread ;) just FYI, confermed September 11, 17 UTC as the time with more green ;) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
