Re: Review Request: Make KDM compilation optional

2012-09-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106444/#review19261 --- This review has been submitted with commit

Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/ --- Review request for Plasma. Description --- This patch is my attempt

Re: Notifications-future, a recap

2012-09-21 Thread Aaron J. Seigo
On Friday, September 21, 2012 01:40:51 Alex Fiestas wrote: On Thursday 20 September 2012 19:42:32 Sune Vuorela wrote: On 2012-09-17, Dario Freddi drf54...@gmail.com wrote: It really depends on what you want to achieve. If your goal is just cleaning up the API and implementing the existing

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/#review19264 --- plasma/desktop/shell/panelview.cpp

Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106523/ --- Review request for Plasma. Description --- Smooth scroll by

Re: Notifications-future, a recap

2012-09-21 Thread Dario Freddi
2012/9/21 Aaron J. Seigo ase...@kde.org: if the new can be achieved by extending or building on galago, that would seem to me to be a much better thing. and no, galago is not perfect. it's not even great, but it is passable and widely used and that gives it a lot of value. if it turns out

Re: Review Request: smooth scroll by mousewheel in SystemSettings

2012-09-21 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106523/#review19265 --- See my comments, otherwise this looks fine to me.

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/ --- (Updated Sept. 21, 2012, 12:36 p.m.) Review request for Plasma. Changes

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/ --- (Updated Sept. 21, 2012, 1:18 p.m.) Review request for Plasma. Changes

Re: Notifications-future, a recap

2012-09-21 Thread Mark
On Tue, Sep 18, 2012 at 12:17 AM, Dario Freddi drf54...@gmail.com wrote: (putting back plasma-devel on CC, since the discussion is quite relevant) 2012/9/17 Sune Vuorela nos...@vuorela.dk: I know Sune already had some plans for the notification stack and I think that's one of the best times

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/#review19269 --- plasma/desktop/shell/desktopcorona.cpp

Re: Notifications-future, a recap

2012-09-21 Thread Mark
On Fri, Sep 21, 2012 at 4:42 PM, Mark mark...@gmail.com wrote: On Tue, Sep 18, 2012 at 12:17 AM, Dario Freddi drf54...@gmail.com wrote: (putting back plasma-devel on CC, since the discussion is quite relevant) 2012/9/17 Sune Vuorela nos...@vuorela.dk: I know Sune already had some plans for

Re: Notifications-future, a recap

2012-09-21 Thread Dario Freddi
2012/9/21 Mark mark...@gmail.com: On Tue, Sep 18, 2012 at 12:17 AM, Dario Freddi drf54...@gmail.com wrote: (putting back plasma-devel on CC, since the discussion is quite relevant) 2012/9/17 Sune Vuorela nos...@vuorela.dk: I know Sune already had some plans for the notification stack and I

Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/ --- Review request for kdelibs, Plasma, Marco Martin, and David Faure.

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/#review19270 --- Ship it! +1 from me - Marco Martin On Sept. 21, 2012, 3:29

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/ --- (Updated Sept. 21, 2012, 3:57 p.m.) Review request for Plasma. Changes

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106519/#review19273 --- Ship it! Obviously not a beauty queen, but so is X. I don't

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-09-21 Thread Simeon Bird
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106244/ --- (Updated Sept. 21, 2012, 1:51 p.m.) Review request for Plasma, Sebastian