Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115326/#review48453 --- - Harald Sitter On Jan. 28, 2014, 9:18 a.m., Harald Sitter

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Harald Sitter
On Jan. 29, 2014, 1:50 p.m., Aaron J. Seigo wrote: plasma/theme.cpp, lines 273-276 https://git.reviewboard.kde.org/r/115326/diff/3/?file=240803#file240803line273 it's nice to clean up the svg elements files; however without an active cache file it doesn't matter and they are a

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/#review48588 --- I don't think it's the right way.. thinking about it, that's

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Aaron J. Seigo
On Jan. 29, 2014, 1:50 p.m., Aaron J. Seigo wrote: plasma/theme.cpp, lines 273-276 https://git.reviewboard.kde.org/r/115326/diff/3/?file=240803#file240803line273 it's nice to clean up the svg elements files; however without an active cache file it doesn't matter and they are a

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115326/ --- (Updated Jan. 30, 2014, 10:53 a.m.) Review request for Plasma, Aaron J.

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115326/ --- (Updated Jan. 30, 2014, 10:56 a.m.) Review request for Plasma, Aaron J.

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Harald Sitter
On Jan. 29, 2014, 1:50 p.m., Aaron J. Seigo wrote: plasma/theme.cpp, lines 273-276 https://git.reviewboard.kde.org/r/115326/diff/3/?file=240803#file240803line273 it's nice to clean up the svg elements files; however without an active cache file it doesn't matter and they are a

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread David Edmundson
On Jan. 30, 2014, 9:38 a.m., Marco Martin wrote: I don't think it's the right way.. thinking about it, that's true for panels as well, (even tough is already forced by extended structs, but is not a given since the other panel modes still have to come back) what it suggests me is

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread Marco Martin
On Jan. 30, 2014, 9:38 a.m., Marco Martin wrote: I don't think it's the right way.. thinking about it, that's true for panels as well, (even tough is already forced by extended structs, but is not a given since the other panel modes still have to come back) what it suggests me is

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread David Edmundson
On Jan. 30, 2014, 9:38 a.m., Marco Martin wrote: I don't think it's the right way.. thinking about it, that's true for panels as well, (even tough is already forced by extended structs, but is not a given since the other panel modes still have to come back) what it suggests me is

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread Sebastian Kügler
On Wednesday, January 29, 2014 22:51:27 David Edmundson wrote: For the WidgetExplorer we want to show the tooltips to the right of the scrollbar in the view, not to the right of the delegate the tooltip is for. Actually, and this is a different discussion, I would like to get rid of the

Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/ --- Review request for Plasma, Martin Klapetek and Harald Sitter.

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/ --- (Updated Jan. 30, 2014, 12:18 p.m.) Review request for Plasma, Martin

Re: Review Request 115326: fix theme cache cleanup and discarding

2014-01-30 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115326/ --- (Updated Jan. 30, 2014, 12:19 p.m.) Status -- This change has been

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/ --- (Updated Jan. 30, 2014, 12:24 p.m.) Review request for Plasma, Martin

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread David Edmundson
This bug https://bugs.kde.org/show_bug.cgi?id=329199 has been open since the 12th of December last year. You were even on the bug CC list when I assigned it to me before I started working on it. /grumble As for the widget explorer popups. I agree for a different reason. License, Author and Email

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/ --- (Updated Jan. 30, 2014, 1:32 p.m.) Review request for Plasma.

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread Marco Martin
On Thursday 30 January 2014, David Edmundson wrote: Which means we have a popup just for uninstall. Which is wrong. With regards to this patch, is it still useful? I think it makes sense as it puts all panel tooltips in the right place. It would be needed once we have again panels in modes

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/ --- (Updated Jan. 30, 2014, 2:03 p.m.) Status -- This change has been

Re: Review Request 115393: Add property to allow Dialog Popups to align to visualParent item's window

2014-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115393/#review48611 --- This review has been submitted with commit

Re: Review Request 115224: Remove unused property drawWallpaper

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115224/ --- (Updated Jan. 30, 2014, 2:35 p.m.) Status -- This change has been

Re: Review Request 115192: Fix building 32bit target on 64bit machine

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115192/#review48616 --- Ship it! Ship It! - David Edmundson On Jan. 21, 2014,

Re: Review Request 115224: Remove unused property drawWallpaper

2014-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115224/#review48615 --- This review has been submitted with commit

Re: Review Request 112959: Add color picker in plasmaextracomponents

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112959/#review48618 ---

Re: Review Request 112959: Add color picker in plasmaextracomponents

2014-01-30 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112959/ --- (Updated Jan. 30, 2014, 8:20 p.m.) Status -- This change has been

Re: Review Request 112959: Add color picker in plasmaextracomponents

2014-01-30 Thread Bhushan Shah
On Jan. 30, 2014, 8:14 p.m., David Edmundson wrote: src/declarativeimports/plasmaextracomponents/qml/ColorPicker.qml, line 2 https://git.reviewboard.kde.org/r/112959/diff/2/?file=192841#file192841line2 That's not your name. but code was! ;) - Bhushan

Re: Review Request 114566: Plasmate: Port remoteinstaller to Qt5/KF5

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114566/#review48627 --- Ship it! Ship It! - David Edmundson On Jan. 5, 2014, 5:36

Re: Review Request 114681: Removed all X-Plasma-DefaultSize declarations

2014-01-30 Thread Benjamin Kaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114681/ --- (Updated Jan. 30, 2014, 2:53 p.m.) Status -- This change has been

Re: Review Request 112360: Enable mouse DataEngine on KF5

2014-01-30 Thread Bhushan Shah
On Jan. 30, 2014, 8:26 p.m., David Edmundson wrote: What's the status of this? There is somewhere review request by Andrea Scarpino which ports it and fixes compilation error in this patch. So discard this. - Bhushan --- This is an

Re: Review Request 112360: Enable mouse DataEngine on KF5

2014-01-30 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112360/ --- (Updated Jan. 30, 2014, 8:30 p.m.) Status -- This change has been

Re: Review Request 112360: Enable mouse DataEngine on KF5

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112360/#review48628 --- What's the status of this? - David Edmundson On Aug. 29,

Re: Review Request 113236: make the warnings accessible from QML

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113236/#review48630 --- This patch doesn't match the review description at all. It

Re: Plasmate dragdrop breaks

2014-01-30 Thread Giorgos Tsiapaliokas
Hello, On Tuesday, January 28, 2014 03:36:14 PM Aleix Pol wrote: Hi, I've been encountering lately that when I drag and drop something to plasmate it crashes badly (it enters an endless loop where the only output I guess that you mean plasmoidviewer. Plasmate isn't ported yet. Is the

Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113697/#review48631 ---

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/#review48634 --- Ship it! Looks sensible to me, thanks. - David Edmundson

Re: Review Request 113236: make the warnings accessible from QML

2014-01-30 Thread Giorgos Tsiapaliokas
On Jan. 30, 2014, 2:59 p.m., David Edmundson wrote: This patch doesn't match the review description at all. It just prints the error messages. the idea of the patch was to pass the errors with m_qmlObject-rootObject()-setProperty(warnings, warn); because we needed it for plasmoidviewer.

Review Request 113236: make the warnings accessible from QML

2014-01-30 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113236/ --- Status -- This change has been discarded. Review request for

Re: Release schedule for Plasma Next

2014-01-30 Thread Àlex Fiestas
On Wednesday 29 January 2014 16:52:51 Martin Graesslin wrote: I suggest to significantly increase the number of intermediate releases. One month between RC and final is too long. +1 I would prefer to have a series of release candidates and a release candidate should be exactly that: a

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/#review48645 --- This review has been submitted with commit

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/ --- (Updated Jan. 30, 2014, 5:05 p.m.) Status -- This change has been

Re: Release schedule for Plasma Next

2014-01-30 Thread Martin Graesslin
On Thursday 30 January 2014 17:48:34 Àlex Fiestas wrote: On Wednesday 29 January 2014 16:52:51 Martin Graesslin wrote: I suggest to significantly increase the number of intermediate releases. One month between RC and final is too long. +1 I would prefer to have a series of release

Re: Review Request 115397: fix theme cache cleanup and discarding (v2)

2014-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115397/#review48648 --- This review has been submitted with commit

Review Request 115409: Workaround battery detection at runtime

2014-01-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115409/ --- Review request for Plasma and Solid. Bugs: 324847

Using kqmlgraphplugin in Plasma Next

2014-01-30 Thread Bhushan Shah
To people from kde-core-devel: please keep me and plasma-devel in CC, I am not subscribed to list Hello, Currently I am working on a QML Canvas based SignalPlotter, to replace the old Plasma1SignalPlotter which is KSignalPlotter and QGraphicWidget based. My SignalPlotter is in bshah/plotter-qml