Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- This causes a regression: normal images can no longer be

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aaron J. Seigo
On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop this has been fixed. - Aaron J.

Jenkins build became unstable: plasma-workspace_master_qt5 #879

2014-09-20 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/879/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120298: Enable lastfmimagefetchertest again,

2014-09-20 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- Review request for Plasma and Shantanu Tushar. Repository:

Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images

2014-09-20 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-20 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review67074 --- dataengines/comic/CMakeLists.txt

Re: Review Request 120298: Enable lastfmimagefetchertest again,

2014-09-20 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- (Updated Sept. 20, 2014, 8:34 p.m.) Review request for Plasma, Shantanu

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-20 Thread Martin Klapetek
On Sept. 20, 2014, 4 p.m., Bhushan Shah wrote: dataengines/comic/CMakeLists.txt, line 82 https://git.reviewboard.kde.org/r/120276/diff/2/?file=313487#file313487line82 Why this is commented out? The file does not exist anymore; It had only the EXPORT macro in it anyway and i

Re: Announcing KWayland library

2014-09-20 Thread šumski
On Friday 19 of September 2014 11:06:56 Martin Gräßlin wrote: Hi plasma-devs, as discussed on Monday's hangout I split out KWin's Wayland handling code into a dedicated repository and library: git clone kde:kwayland The repository provides two libraries: * Client * Server At the

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aleix Pol Gonzalez
On set. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop Aaron J. Seigo wrote: this has been

Re: Review Request 120279: Port to KWayland client library

2014-09-20 Thread Pier Luigi Fiorini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review67091 --- Modules/base/info_wayland.cpp

Re: Review Request 120279: Port to KWayland client library

2014-09-20 Thread Pier Luigi Fiorini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review67092 --- Modules/base/info_wayland.cpp

Re: Review Request 120050: Wallpaper package structure fixes

2014-09-20 Thread Aaron J. Seigo
On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop Aaron J. Seigo wrote: this has been