Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-24 Thread Martin Klapetek
On March 24, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: File Attachment: New Screenshot - notifications_config.png https://git.reviewboard.kde.org/r/122842/#fcomment375 We usually have a title over here. Ah yeah, I thought there's something missing. That should be a different patch

Jenkins build is back to normal : plasma-workspace_master_qt5 #1420

2015-03-24 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1420/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/ --- (Updated March 24, 2015, 1:19 p.m.) Review request for Plasma. Changes

Build failed in Jenkins: plasma-workspace_master_qt5 #1419

2015-03-24 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1419/ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-24 Thread Martin Klapetek
On March 24, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: File Attachment: New Screenshot - notifications_config.png https://git.reviewboard.kde.org/r/122842/#fcomment376 We usually have a title over here. Martin Klapetek wrote: Ah yeah, I thought there's something missing.

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-24 Thread Ivan Čukić
On March 20, 2015, 9:23 p.m., Marco Martin wrote: +1 from here (will read it more) Eike Hein wrote: +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade Ivan Čukić wrote: Waiting for +2 since +1 +1 = 1.98 on

Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review77996 --- File Attachment: New Screenshot - notifications_config.png

5.4 release schedule

2015-03-24 Thread Jonathan Riddell
Here's the dates for 5.4 keeping to our current practice of 3 month schedule. 5.3 beta in two week's time, 5.3 end of next month, 5.3.1 a month later, 5.3.2 a month later, 5.4 beta two weeks after that and 5.4 final end of july. https://techbase.kde.org/Schedules/Plasma_5

Re: Build failed in Jenkins: plasma-workspace_master_qt5 #1418

2015-03-24 Thread David Edmundson
​Just an anongit timeout, not our fault. Will probably fix itself. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5.2.2 candidate tars

2015-03-24 Thread Jonathan Riddell
Last minute update to Muon to fix a crash tr valign=top tda href= http://download.kde.org/stable/plasma/5.2.2/muon-5.2.2.tar.xz;muon-5.2.2/a/td - td align=right1.0MB/td - tdtted2f327c700299be56f8b2124fea7d43b5cb730bc94a53daf7cfdf3736e5db46/tt/td + td align=right1001kB/td +

Build failed in Jenkins: plasma-workspace_master_qt5 #1418

2015-03-24 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1418/ -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 122332: KQuickControls IconDialog

2015-03-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122332/#review77990 --- Ship it! +1 from me. Remember I asked you to shove in a

Re: Plasma 5.2.2 candidate tars

2015-03-24 Thread Jonathan Riddell
Looks like this muon update included a bad merge and it has the wrong version number amongst other problems. Please hold of on updating muon for now while we work it out. Jonathan On 24 March 2015 at 12:38, Jonathan Riddell j...@jriddell.org wrote: Last minute update to Muon to fix a crash

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-24 Thread Martin Klapetek
On March 20, 2015, 10:23 p.m., Marco Martin wrote: +1 from here (will read it more) Eike Hein wrote: +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade Ivan Čukić wrote: Waiting for +2 since +1 +1 = 1.98 on

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-24 Thread Eike Hein
On March 20, 2015, 9:23 p.m., Marco Martin wrote: +1 from here (will read it more) Eike Hein wrote: +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade Ivan Čukić wrote: Waiting for +2 since +1 +1 = 1.98 on

Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform

2015-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/#review78034 --- Is it all in now? Maybe an updated screenshot would help?

Review Request 123124: Display an instance of the grey login strip in the sddm theme on every screen

2015-03-24 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123124/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-24 Thread Ivan Čukić
On March 20, 2015, 9:23 p.m., Marco Martin wrote: +1 from here (will read it more) Eike Hein wrote: +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade Ivan Čukić wrote: Waiting for +2 since +1 +1 = 1.98 on

Re: 5.4 release schedule

2015-03-24 Thread David Edmundson
On Tue, Mar 24, 2015 at 3:15 PM, Jonathan Riddell j...@jriddell.org wrote: Here's the dates for 5.4 keeping to our current practice of 3 month schedule. 5.3 beta in two week's time, 5.3 end of next month, 5.3.1 a month later, 5.3.2 a month later, 5.4 beta two weeks after that and 5.4 final

Re: Review Request 123124: Display an instance of the grey login strip in the sddm theme on every screen

2015-03-24 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123124/ --- (Updated March 25, 2015, 12:29 a.m.) Review request for Plasma.

Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123119/ --- Review request for Plasma. Repository: kdeclarative Description

Re: 5.4 release schedule

2015-03-24 Thread Vishesh Handa
On Tue, Mar 24, 2015 at 3:15 PM, Jonathan Riddell j...@jriddell.org wrote: Are there any issues with the release cycle in general? Plasma 5.4 release is on - 2015-07-23 Applications 15.08 will probably be on - 2015-08-04 Baloo will break compatibility between Qt4 and Qt5 releases at that

Re: 5.4 release schedule

2015-03-24 Thread Jonathan Riddell
On Wed, Mar 25, 2015 at 01:55:38AM +0100, Vishesh Handa wrote: On Tue, Mar 24, 2015 at 3:15 PM, Jonathan Riddell j...@jriddell.org wrote: Are there any issues with the release cycle in general? Plasma 5.4 release is on - 2015-07-23 Applications 15.08 will probably be on -

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread Marco Martin
On March 24, 2015, 5:59 p.m., Marco Martin wrote: I wonder if we want instead push for the heading api in apps too (i guess would be another header component in this import here) both api and look i mean - Marco --- This is an

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123119/#review78014 --- I wonder if we want instead push for the heading api in apps

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread David Edmundson
On March 24, 2015, 5:59 p.m., Marco Martin wrote: I wonder if we want instead push for the heading api in apps too (i guess would be another header component in this import here) Marco Martin wrote: both api and look i mean Would be fine with me. So copy the plasmaextras ones and

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread Marco Martin
On March 24, 2015, 5:59 p.m., Marco Martin wrote: I wonder if we want instead push for the heading api in apps too (i guess would be another header component in this import here) Marco Martin wrote: both api and look i mean David Edmundson wrote: Would be fine with me.

Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-24 Thread Martin Klapetek
On March 24, 2015, 5:22 p.m., Kai Uwe Broulik wrote: Nice! I'm not sure whether a global setting should be in the applet configuration but fair enough. The Default keeps the previous behavior where it sort-of follows your panel? Yes. On March 24, 2015, 5:22 p.m., Kai Uwe

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123119/#review78004 --- KTitleWidget also has a subtitle, no? Also pity that we

Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review78005 --- Nice! I'm not sure whether a global setting should be in the

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread David Edmundson
On March 24, 2015, 4:17 p.m., Kai Uwe Broulik wrote: KTitleWidget also has a subtitle, no? Also pity that we cannot have that stuff styled since KTitleWidget has a border usually but just in our styles does not. hmm, I could try and push for a frame in QQC I'll add the comment.

Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform

2015-03-24 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated March 24, 2015, 9:38 p.m.) Review request for Plasma. Changes

Re: Review Request 122332: KQuickControls IconDialog

2015-03-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122332/ --- (Updated März 24, 2015, 6:53 nachm.) Review request for Plasma and

Plasma 5.2.2 is out

2015-03-24 Thread Jonathan Riddell
Happy release all https://www.kde.org/announcements/plasma-5.2.2.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-24 Thread Eike Hein
On March 20, 2015, 9:23 p.m., Marco Martin wrote: +1 from here (will read it more) Eike Hein wrote: +1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade Ivan Čukić wrote: Waiting for +2 since +1 +1 = 1.98 on

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123119/#review78013 --- src/qmlcontrols/kquickcontrols/Title.qml (line 32)

Re: Review Request 123119: Add a component file that mimicks KTitleWidget

2015-03-24 Thread Marco Martin
On March 24, 2015, 5:59 p.m., Marco Martin wrote: I wonder if we want instead push for the heading api in apps too (i guess would be another header component in this import here) Marco Martin wrote: both api and look i mean David Edmundson wrote: Would be fine with me.