Re: Review Request 123164: Add new Bluetooth applet

2015-04-04 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/ --- (Updated April 4, 2015, 7:19 a.m.) Status -- This change has been

Re: Review Request 123131: Port kio_man away from kdelibs4support

2015-04-04 Thread David Faure
On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: man/kio_man.cpp, line 242 https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. Nick

Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123251/ --- Review request for Plasma, Eike Hein and Marco Martin. Repository:

Re: Review Request 122679: Show Desktop feature: refurbished

2015-04-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122679/ --- (Updated April 4, 2015, 3:28 nachm.) Review request for kwin, Plasma,

Re: Review Request 117681: showdesktop plasma addon: Add option to restrict size on large panels

2015-04-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117681/ --- (Updated April 4, 2015, 4:13 p.m.) Status -- This change has been

Re: Review Request 117802: Merge ShowDesktop and ShowDashboard plasma applets into one

2015-04-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117802/ --- (Updated April 4, 2015, 4:15 p.m.) Status -- This change has been

Re: Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123251/ --- (Updated April 4, 2015, 4:05 p.m.) Review request for Plasma, Eike Hein

Re: Review Request 123131: Port kio_man away from kdelibs4support

2015-04-04 Thread Alex Richardson
On March 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: man/kio_man.cpp, line 242 https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. Nick

Re: Review Request 122679: Show Desktop feature: refurbished

2015-04-04 Thread Vishesh Handa
On March 22, 2015, 8:28 p.m., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like OSX

Re: Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Eike Hein
On April 4, 2015, 3:44 p.m., Eike Hein wrote: This won't catch launches from the favorites sidebar or the Recent Applications model. You either have to add more hooks there, or you could actually hook into RecentApplications::addApp for now, which is what all the other models'

Re: Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123251/#review78492 --- Ship it! Ship It! - Eike Hein On April 4, 2015, 4:05

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-04 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 1:15 p.m.) Review request for KDE Frameworks,

Re: Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123251/#review78487 --- This won't catch launches from the favorites sidebar or the

Re: Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Ivan Čukić
On April 4, 2015, 3:44 p.m., Eike Hein wrote: This won't catch launches from the favorites sidebar or the Recent Applications model. You either have to add more hooks there, or you could actually hook into RecentApplications::addApp for now, which is what all the other models'

Re: Review Request 122679: Show Desktop feature: refurbished

2015-04-04 Thread Thomas Lübking
On März 22, 2015, 8:28 nachm., Kai Uwe Broulik wrote: Sorry for being late to the party: UX issues I have with that implementation: - No transition, the windows just disappear (would be cool to have them slide out of the screen or have them stay at the edges of the screen like

Re: Review Request 117041: kdeplasma-addons/applets/pastebin: add two new options

2015-04-04 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117041/ --- (Updated April 4, 2015, 4:11 p.m.) Status -- This change has been

Jenkins build is back to normal : plasma-desktop_master_qt5 #1166

2015-04-04 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/1166/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123255: Use Animator for splash animation

2015-04-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123255/#review78496 --- Ship it! Ship It! - Marco Martin On April 4, 2015, 6:35

Re: Review Request 123251: Kicker is notifying KAMD of the recently started applications

2015-04-04 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123251/ --- (Updated April 4, 2015, 4:45 p.m.) Status -- This change has been

Review Request 123255: Use Animator for splash animation

2015-04-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123255/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 123255: Use Animator for splash animation

2015-04-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123255/ --- (Updated April 4, 2015, 6:48 p.m.) Status -- This change has been

Re: Review Request 123131: Port kio_man away from kdelibs4support

2015-04-04 Thread Albert Astals Cid
On mar. 25, 2015, 9:54 p.m., Lukáš Tinkl wrote: man/kio_man.cpp, line 242 https://git.reviewboard.kde.org/r/123131/diff/1/?file=356605#file356605line242 Not correct, this returns only user configured list of languages, whereas it previously returned the full list. Nick

Build failed in Jenkins: plasma-desktop_master_qt5 #1164

2015-04-04 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/1164/changes Changes: [hein] Experimental port of RecentDocsModel to KActivitiesStats. [ivan.cukic] Adapting to cmake changes [ivan.cukic] Adding the url filter for showing only files [hein] Refactor to bring back the funnel model and get