Review Request 123859: prepare for single QQmlengine mode

2015-05-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123859/ --- Review request for Plasma. Repository: bluedevil Description ---

Re: Review Request 123859: prepare for single QQmlengine mode

2015-05-20 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123859/#review80653 --- Ship it! Ship It! - David Rosca On May 20, 2015, 7:43

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-20 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80655 --- Ship it! Ship It! - Eike Hein On May 18, 2015, 7:40 p.m.,

Review Request 123860: Handle backend being deleted during GetConfigOperation

2015-05-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123860/ --- Review request for Plasma and Solid. Repository: libkscreen

Re: Review Request 123859: prepare for single QQmlengine mode

2015-05-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123859/ --- (Updated May 20, 2015, 11:16 a.m.) Status -- This change has been

Re: Review Request 123860: Handle backend being deleted during GetConfigOperation

2015-05-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123860/ --- (Updated May 20, 2015, 1:09 p.m.) Status -- This change has been

Re: Review Request 123860: Handle backend being deleted during GetConfigOperation

2015-05-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123860/ --- (Updated May 20, 2015, 2:36 p.m.) Review request for Plasma and Solid.

Re: Review Request 123860: Handle backend being deleted during GetConfigOperation

2015-05-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123860/#review80657 --- +1 - Aleix Pol Gonzalez On May 20, 2015, 2:36 p.m., David

Re: Review Request 123807: Fix popup menu items getting stray highlighted

2015-05-20 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/ --- (Updated May 20, 2015, 1:04 p.m.) Status -- This change has been

Re: Review Request 123860: Handle backend being deleted during GetConfigOperation

2015-05-20 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123860/#review80661 --- Ship it! Ship It! - Daniel Vrátil On May 20, 2015, 2:36

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-20 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80669 --- src/quickaddons/quickviewsharedengine.h (line 41)

Review Request 123864: Extract messages from Modules/base into the catalog kcminfo

2015-05-20 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123864/ --- Review request for Localization and Translation (l10n) and Plasma. Bugs:

Re: Review Request 123864: Extract messages from Modules/base into the catalog kcminfo

2015-05-20 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123864/#review80667 --- Ship it! Ship It! - Lukáš Tinkl On Kvě. 20, 2015, 5:54

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-20 Thread Marco Martin
On May 20, 2015, 5:24 p.m., Vishesh Handa wrote: src/quickaddons/quickviewsharedengine.h, line 41 https://git.reviewboard.kde.org/r/123735/diff/8/?file=370104#file370104line41 It would be awesome if we could have some tests for this class. Maybe we can just try and