date:20151125


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126168/
---

Review request for Plasma.


Bugs: 355577
http://bugs.kde.org/show_bug.cgi?id=355577


Repository: plasma-framework


Description
---

According to the docs theme() in KIconLoader can return null. Guard for this.


Diffs
-

  src/declarativeimports/core/iconitem.cpp f32b3d1 

Diff: https://git.reviewboard.kde.org/r/126168/diff/


Testing
---

Compiles. Wasn't able to reproduce the crash before but could be given during 
SDDM we might not use the proper kdeglobals or so.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts



> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote:
> > I don't like this change, as it introduces a magic constant for a value 
> > that we completely control our own. (Well, to the degree that we say "a 
> > gridUnit is roughly the height of a line of text". The 1.6 constant looks 
> > weird here, and I'm against adding font specific hacks in, especially since 
> > at that point in the code, we don't even know what the font is.
> > 
> > This is not a structural solution, so -1.
> 
> David Rosca wrote:
> I understand, but what is a structural solution?
> The font metric is clearly wrong for Noto, Oxygen (and certainly some 
> other fonts) and this change is backwards compatible with current code.
> 
> And this is not a font specific hack, this just scales the actual height 
> of M to the expected gridUnit value because gridUnit never was a height of M 
> character (it is like 1.6 * height of M = thus the magic number).
> 
> Sebastian Kügler wrote:
> Well, problems arise as soon as you change the font -- the computation is 
> not based on the default font, but on the currently selected font. The funny 
> thing here is that the Oxygen font is actually the wrong one, as that 
> includes more height than the rendered character, but also some spacing above.
> 
> What is the exact issue you see? I'm still not quite clear on that.
> 
> The bug you're referring to should be fixed by not computing the font 
> manually, but use units.iconSizes.* instead. (I haven't tried, but that's the 
> semantically correct solution.)
> 
> David Rosca wrote:
> > Well, problems arise as soon as you change the font
> 
> In the current implementation, yes. Because 
> QFontMetrics::boundingRect(QString = "M").height() returns more than just 
> height of M character, and this extra size is different for various fonts - 
> it will return different value for 2 fonts even when the font size (eg. 
> actual height of M character) is the same in both.
> 
> > The funny thing here is that the Oxygen font is actually the wrong one, 
> as that includes more height than the rendered character, but also some 
> spacing above.
> 
> Yes, but that spacing is there for every font, but different and that's 
> exactly the whole problem. For DejaVu Sans font it returns value that plays 
> well with what we use as gridUnit (roughly M height * 1.6), but for Noto and 
> Oxygen it returns just too much (~ * 2). Only 
> QFontMetrics::boundingRect(QChar = 'M').height() returns the actual M height 
> without any spacing.
> 
> > What is the exact issue you see? I'm still not quite clear on that.
> 
> My issue is that units.gridUnit and theme.mSize is too big and that leads 
> to too big spacing relative to font size. You can see it on screenshots, it 
> shows the minimum size of system tray popup (it is calculated as x multiple 
> of units.gridUnit). You can see on the first screenshot that it is just too 
> big, and the same story is for every other plasma widget.
> 
> Maybe I should have posted the whole screen, not just a snip. It looks 
> much worse when you see the whole screen and can compare the size to the rest 
> of screen (1920x1080).
> 
> > The bug you're referring to should be fixed by not computing the font 
> manually, but use units.iconSizes.* instead.
> 
> Yes, that would fix the linked bug - size of systemtray icons. But it 
> won't fix the general issue mentioned above.
> 
> Marco Martin wrote:
> also -1.
> the sizing of systray icons should depend in a range between iconsizes, 
> so from iconSizes.small to smallMedium (or medium, or whetever).
> for the grid unit, adding that ratio to the m height, i get that you are 
> trying to have pretty much the height of a line of text? could 
> QFontMetrics::lineSpacing() work?
> 
> Martin Klapetek wrote:
> From me it's a +1, the patch is technically correct. The icons sizes are 
> just a byproduct of this patch, this is about the difference that
> 
> boundingRect("M") and
> boundingRect('M') make.
> 
> Using the QString overload is wrong because it is not just the M height, 
> but also the spacing above and that spacing is random, making things scale 
> randomly with different fonts. Using the ::lineSpacing wouldn't really make 
> much difference I think because it would still need some kind of multiplier 
> to get back to the original value that boundingRect("M") returns up till now, 
> otherwise Plasma will get really tiny for users with Oxygen font. Using 
> boundingRect('M'), the QL1Char overload, it counds *only* the M size, no 
> other spacing included. This would result in much much more consistent 
> scaling with different fonts. Curretnly the difference can be quite big.
> 
> So, +1, this patch is correct from my point of view.

Perhaps could you give this a second thought?

If I wasn't myself clear then please read Martin's comment, he

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

Mathieu Roy  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #5 from Mathieu Roy  ---
I expect:

1. a bug not to be marked as resolved when it is open.
2. a bug that is due to UPSTREAM (upower) to be marked as such and not
mistakingly marked DOWNSTREAM (because of likely animosity - I never seen any
report of Ubuntu users discarded in such fashion)

So please mark this bug appropriately, if you do not intend to fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126168: [IconItem] Don't crash on no icon theme

2015-11-25 Thread David Edmundson


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126168/#review88833
---

Ship it!



src/declarativeimports/core/iconitem.cpp (line 137)


const auto


- David Edmundson


On Nov. 25, 2015, 3:59 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126168/
> ---
> 
> (Updated Nov. 25, 2015, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 355577
> http://bugs.kde.org/show_bug.cgi?id=355577
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> According to the docs theme() in KIconLoader can return null. Guard for this.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
> 
> Diff: https://git.reviewboard.kde.org/r/126168/diff/
> 
> 
> Testing
> ---
> 
> Compiles. Wasn't able to reproduce the crash before but could be given during 
> SDDM we might not use the proper kdeglobals or so.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

On Wed, Nov 25, 2015 at 12:34 PM, David Edmundson <
da...@davidedmundson.co.uk> wrote:

> it's in QWindow which you  inherit from
>

Oh, my qt-assistant tricked me; I thought it's a top-level class.

http://paste.opensuse.org/view/raw/33270855

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable



> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
> Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
> So it needs fix in plasma-framework first.
> 
> Marco Martin wrote:
> hmm, can you explain what the problem in tooltip management is?

I tested the patch before I gave the Ship It!, and it worked just fine for me 
with latest plasma-framework. The Tooltip dialog docked at the screen edges 
left and right and the contents scrolled.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-25 Thread Aditya Dev Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 25, 2015, 4:31 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs
-

  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
Am working on fixing those thumbnails and ~/.cache 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Michael Palimaka via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355892

--- Comment #8 from Michael Palimaka  ---
(In reply to Mathieu Roy from comment #7)
> "Which turns it into a distro problem. Your distribution configured the
> system in a way that suspend/hibernate is broken"
> 
> This statement is wrong. As said earlier, pm-suspend and pm-hibernate works
> fine, as they do since years. 

The statement is correct. It is libupower-glib that has changed. See the commit
for yourself:
http://cgit.freedesktop.org/upower/commit/?id=030e2c9d3633e35e8beeecc1f41f6e0ff77b57dc

> 
> "It doesn't come with any of the supported solutions Plasma provides. Which
> makes it a distro problem"
> 
> It is a regression for KDE to drop support for perfectly working solution in
> favor of... broken ones. And when you say "any of the supported solutions",
> you mean only one, actually. Is there any alternative?

As already mentioned it is upower that has dropped support - KDE has dropped
nothing. Current working solutions are:

* Using systemd
* Using ConsoleKit2
* Using upower <=0.9.23

> "It failed here by ripping out systemd and replace it with well nothing."
> 
> Well, if the plan with KDE is now to alter every feature that users are used
> to, so they only support some systemd feature (is that what you refers as
> "any of the supported solutions"), with no user perceptible benefit, I think
> that should be advertised clearly. 

No feature has been altered and there is no systemd dependency. I've even seen
KDE developers take the time to resolve ConsoleKit bugs even though they are
not using it.

> If you are curious, you will see many bugs reports of Ubuntu users - with a
> common workaround being using an outdated upower version.  

This is becauase of upower changes, see above.

> 
> Anyway, so now you give a pointer to consolekit2 support. Didn't powerdevil
> supported pm-utils in the past?

powerdevil continues to support upower just fine. Feel free to contact me if I
can assist with packaging improvements - we ship powerdevil that works just
fine both with and without systemd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/
---

(Updated Nov. 25, 2015, 5:03 p.m.)


Review request for Plasma and Martin Klapetek.


Changes
---

setMinimumSize(sizeHint())


Bugs: 355798
https://bugs.kde.org/show_bug.cgi?id=355798


Repository: bluedevil


Description
---

Set the minimum window size to be twice the width of PIN label.


Diffs (updated)
-

  src/wizard/pages/pairing.cpp 6d1eac0 

Diff: https://git.reviewboard.kde.org/r/126160/diff/


Testing
---

The window gets resized now if there is not enough free space for PIN.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Martin Gräßlin via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355892

Martin Gräßlin  changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED

--- Comment #6 from Martin Gräßlin  ---
> Unless KDE is prepared to make a statement that it depends on systemd 

of course not. Powerdevil recently also gained support for ConsoleKit2, see:
http://commits.kde.org/powerdevil/10f2be4f0a2b482008937b1e378e914a637d83be

Which turns it into a distro problem. Your distribution configured the system
in a way that suspend/hibernate is broken. It doesn't come with any of the
supported solutions Plasma provides. Which makes it a distro problem. The
distro integrates various parts of the software stack. This includes it's the
distro's task to ensure that components work together. It failed here by
ripping out systemd and replace it with well nothing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click



> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote:
> > I would expect middle clicking to paste.
> 
> Marco Martin wrote:
> same here
> 
> David Rosca wrote:
> I would expect it to paste the content of X selection, not clipboard.

That's at least what happens in the desktop containment -- middle click to 
paste (which creates a notes applet). So +1 for that.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88810
---


On Nov. 25, 2015, 2:18 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 2:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible



> On Nov. 25, 2015, 2:08 p.m., Sebastian Kügler wrote:
> > src/wizard/pages/pairing.cpp, line 111
> > 
> >
> > The *2 seems fairly random. Can't we set the right minimum width 
> > derived from the pinNumber? Given the pin numbers display is huge, wouldn't 
> > this lead to a very large widget? Also, distinction between minimumSize and 
> > preferredSize would be more useful here.

The issue is that the size constraints are not updated when the pin number is 
set (not sure why). So I've changed it to explicitly set wizard's minimumSize 
to the wizard's sizeHint.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88800
---


On Nov. 25, 2015, 5:03 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> ---
> 
> (Updated Nov. 25, 2015, 5:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
> https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> ---
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible



> On Nov. 25, 2015, 5:35 p.m., Martin Klapetek wrote:
> > As you don't implement your own sizeHint() in the wizard - can you be sure 
> > that QWizard::sizeHint() will always return sensible value?
> > 
> > As an alternative, you could just scale the font to always fit the wizard. 
> > That would also help with resizing the window (for whatever reason).

It does, it just ignores it if the sizeHint() was changed after 
initializePage(). Setting wizard sizepolicy to minimum has also no effect 
either.

That's why wizard->setMinimumSize(wizard->sizeHint()) in second diff works.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88839
---


On Nov. 25, 2015, 5:03 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> ---
> 
> (Updated Nov. 25, 2015, 5:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
> https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> ---
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88841
---

Ship it!


Ok, I'll trust you.

- Martin Klapetek


On Nov. 25, 2015, 6:03 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> ---
> 
> (Updated Nov. 25, 2015, 6:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
> https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> ---
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

--- Comment #9 from Mathieu Roy  ---
> This statement is wrong. As said earlier, pm-suspend and pm-hibernate works
> fine, as they do since years. The statement is correct. It is libupower-glib 
> that has changed. See the commit for yourself: 
> http://cgit.freedesktop.org/upower/commit/?id=030e2c9d3633e35e8beeecc1f41f6e0ff77b57dc

Clearly, I think we're getting lost in translation.  Writting "Your
distribution configured the
>> system in a way that suspend/hibernate is broken" is obviously wrong when 
>> you speak of a system with a working suspend hibernate mechanism. It is more 
>> "Your distribution configured the system in a way that Powerdevil 
>> suspend/hibernate is broken". It may not looks like such, but actually it 
>> really means something else. suspend/hibernate does work.


> As already mentioned it is upower that has dropped support - KDE has dropped 
> nothing. 
> Current working solutions are:
> * Using systemd 
> * Using ConsoleKit2 
> * Using upower <=0.9.23

So we agree that this bug is UPSTREAM, if anything. Thanks!

I'd gladly try ConsoleKit2 but I dont think it has been packaged yet.  Which
version of upower is known to include ConsoleKit2 support?

>powerdevil continues to support upower just fine. Feel free to contact me if I 
>can assist with
> packaging improvements - we ship powerdevil that works just fine both with 
> and without systemd.

That is very nice of you Michael (and, BTW, I thank you for your meaningful
comments) but it looks like I'll end up using an outdated upower
(http://snapshot.debian.org/package/upower/0.9.23-2/ Seen in debian on
2013-10-23!) waiting for PolicyKit2 to be actually packaged.

Still, days after days, I cannot help but feeling pressured to use systemd,
which actually makes more more suspicious about it. I understand that
powerdevil depends on upower that in turned somehow dropped support for
pm-utils, endgame being that for the desktop user, it is just a regression,
even though you are not responsible for it. I sincerily wonder if I'll be able
to keep using KDE next year without systemd or whether more and more parts will
stop to work similarly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-11-25 Thread andreas kainz



> On Nov. 25, 2015, 2:13 nachm., Sebastian Kügler wrote:
> > This has been shipped, no?

no cause there was some rework needed.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126092/#review88804
---


On Nov. 16, 2015, 10:38 nachm., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126092/
> ---
> 
> (Updated Nov. 16, 2015, 10:38 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> The emoticon pack was done by Andrea Del Sarto
> 
> 
> Diffs
> -
> 
>   themes/CMakeLists.txt 657c7fc 
> 
> Diff: https://git.reviewboard.kde.org/r/126092/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> eKspression emoticon pack
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/1054a71a-4c1f-46e4-8d52-cf8bb33653bd__eKspression.zip
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

Couple questions:

 - I have a QQuickWindow which, by the docs, is rendered by OpenGL.
   Does the same assumptions hold as for animating X11 window?

 - The suggested KWindowEffects::slideWindow() takes WinId as arg
   but QQuickWindow has no WinId returning method. Can it still be
   animated using KWindowEffects?

 - The KWindowEffects::slideWindow() docs say "Desktop and Floating
   won't have effect". What is that referring to? The location argument
   does not offer such values. So I assume it's about a window type?
   How about the Notification window type? Is that Floating?

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-25 Thread Aditya Dev Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 25, 2015, 4:30 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  datasources/CMakeLists.txt a7171b7 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

Mathieu Roy  changed:

   What|Removed |Added

 Resolution|DOWNSTREAM  |UPSTREAM

--- Comment #3 from Mathieu Roy  ---
Martin Gräßlin, "This works fine on Debian testing. Please get in contact with
your distribution to figure out why this broke in your Debian fork. You might
consider of course to install systemd."

Basically, your answer is: to avoid a bug linked to systemd dependancy, I
should use systemd?
Is this Debian bug tracker or KDE bug tracker?
I'm using KDE on GNU/Linux since more than 10 years, as KDE user, I'd like KDE
to still be working, no matter what systemd or flavor of GNU/Linux I decided to
use.

Unless KDE is prepared to make a statement that it depends on systemd (which is
exactly the kind of notion that makes people suspicious about systemd), please
consider fixing this regression.

Please, do not mark this bug as RESOLVED: it is not.
Please, do not mark this bug as DOWNSTREAM: if it is that you force support of
systemd, then it is definitely not a packaging issue. Rather mark is as
WONTFIX, if you dont care.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

Mathieu Roy  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|UPSTREAM|---

--- Comment #7 from Mathieu Roy  ---
"Which turns it into a distro problem. Your distribution configured the system
in a way that suspend/hibernate is broken"

This statement is wrong. As said earlier, pm-suspend and pm-hibernate works
fine, as they do since years. 

"It doesn't come with any of the supported solutions Plasma provides. Which
makes it a distro problem"

It is a regression for KDE to drop support for perfectly working solution in
favor of... broken ones. And when you say "any of the supported solutions", you
mean only one, actually. Is there any alternative?

"It failed here by ripping out systemd and replace it with well nothing."

Well, if the plan with KDE is now to alter every feature that users are used
to, so they only support some systemd feature (is that what you refers as "any
of the supported solutions"), with no user perceptible benefit, I think that
should be advertised clearly. 
If you are curious, you will see many bugs reports of Ubuntu users - with a
common workaround being using an outdated upower version.  


Anyway, so now you give a pointer to consolekit2 support. Didn't powerdevil
supported pm-utils in the past?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/
---

(Updated Nov. 25, 2015, 4:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ceb827322c3402ae08e88f60fbed7a09ed0a222b by David Rosca 
to branch master.


Repository: plasma-desktop


Description
---

Make the windows in tooltip scrollable when it doesn't fit on the screen.


Diffs
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/125908/diff/


Testing
---

Works fine. One thing that would be great is to allow vertical wheel scrolling, 
but for that KQuickControlsAddons.EventGenerator needs to support wheel events 
(custom wheel handling would be too complex for Flickable)


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126168: [IconItem] Don't crash on no icon theme


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126168/
---

(Updated Nov. 25, 2015, 5:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 9ccc6293f792bb5a5cae624568c0073a73064b88 by Kai Uwe 
Broulik to branch master.


Bugs: 355577
http://bugs.kde.org/show_bug.cgi?id=355577


Repository: plasma-framework


Description
---

According to the docs theme() in KIconLoader can return null. Guard for this.


Diffs
-

  src/declarativeimports/core/iconitem.cpp f32b3d1 

Diff: https://git.reviewboard.kde.org/r/126168/diff/


Testing
---

Compiles. Wasn't able to reproduce the crash before but could be given during 
SDDM we might not use the proper kdeglobals or so.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88839
---


As you don't implement your own sizeHint() in the wizard - can you be sure that 
QWizard::sizeHint() will always return sensible value?

As an alternative, you could just scale the font to always fit the wizard. That 
would also help with resizing the window (for whatever reason).

- Martin Klapetek


On Nov. 25, 2015, 6:03 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> ---
> 
> (Updated Nov. 25, 2015, 6:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
> https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> ---
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126174: [Task Manager] Add support for Jump Lists

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126174/
---

Review request for Plasma, KDE Usability and Eike Hein.

Bugs: 339750
https://bugs.kde.org/show_bug.cgi?id=339750

Repository: plasma-desktop

Description
---

This adds support for "Additional applications actions" (aka Jumplists).

Jumplists are supplemental actions an application can offer, such as "Open New
Tab" or "Open New Incognito Tab" or "Pause Music", jump directly into a certain
part of an application "Downloads", or in case of LibreOffice go directly to a
specific document editor (Text, Impress, etc)

More information can be found in the linked bug report.

Diffs
-

applets/taskmanager/plugin/backend.h 3885a93
applets/taskmanager/plugin/backend.cpp ef7bb2a

Diff: https://git.reviewboard.kde.org/r/126174/diff/

Testing
---

LibreOffice now offers jump lists to me, unfortunately hardly any application I
have installed uses them. Konsole, for some reason, has a "New Window" option.
LibreOffice launcher allows to jump directly into a specific editor. My really
old Chromium install has some actions (none of my recent Chrome installs have
it, they only have X-Ayatana-Desktop-Shortcuts).

The actions are only offered for pinned launchers. I would love to have them
also on regular task manager entries. Once we start using them in more
applications, they could provide some handy shortcuts, even if the app is
already running. (Usability?)

File Attachments

Libreoffice

https://git.reviewboard.kde.org/media/uploaded/files/2015/11/25/7792fd6b-ba97-4eab-af71-fd236d95c660__launcheractions.png
Chromium

https://git.reviewboard.kde.org/media/uploaded/files/2015/11/25/260905b3-2692-4c7d-a899-a3bc1d2e4f29__launcheractions1.png

Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126174: [Task Manager] Add support for Jump Lists

2015-11-25 Thread Thomas Pfeiffer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126174/#review88858
---


I don't see any usability problems here.
If we add this to running tasks as well, there should be a separator between 
the jumplist and the other options, though.

- Thomas Pfeiffer


On Nov. 25, 2015, 11:43 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126174/
> ---
> 
> (Updated Nov. 25, 2015, 11:43 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 339750
> https://bugs.kde.org/show_bug.cgi?id=339750
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This adds support for "Additional applications actions" (aka Jumplists).
> 
> Jumplists are supplemental actions an application can offer, such as "Open 
> New Tab" or "Open New Incognito Tab" or "Pause Music", jump directly into a 
> certain part of an application "Downloads", or in case of LibreOffice go 
> directly to a specific document editor (Text, Impress, etc)
> 
> More information can be found in the linked bug report.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/plugin/backend.h 3885a93 
>   applets/taskmanager/plugin/backend.cpp ef7bb2a 
> 
> Diff: https://git.reviewboard.kde.org/r/126174/diff/
> 
> 
> Testing
> ---
> 
> LibreOffice now offers jump lists to me, unfortunately hardly any application 
> I have installed uses them. Konsole, for some reason, has a "New Window" 
> option. LibreOffice launcher allows to jump directly into a specific editor. 
> My really old Chromium install has some actions (none of my recent Chrome 
> installs have it, they only have X-Ayatana-Desktop-Shortcuts).
> 
> The actions are only offered for pinned launchers. I would love to have them 
> also on regular task manager entries. Once we start using them in more 
> applications, they could provide some handy shortcuts, even if the app is 
> already running. (Usability?)
> 
> 
> File Attachments
> 
> 
> Libreoffice
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/25/7792fd6b-ba97-4eab-af71-fd236d95c660__launcheractions.png
> Chromium
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/25/260905b3-2692-4c7d-a899-a3bc1d2e4f29__launcheractions1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

--- Comment #10 from Mathieu Roy  ---
I posted this
https://yeupou.wordpress.com/2015/11/25/getting-back-suspendresume-with-kde-5s-powerdevil-and-no-systemd-by-installing-an-obsolete-version-of-upower/
that describe step by step how to put back an old version of upower.
This is really a terrible band aid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

On Wednesday 25 November 2015, Martin Klapetek wrote:
> Yes, my question is however about the "Desktop and Floating won't have
> effect"
> note in the docs. What is it about? Will the notification popup be
> affected?

hmm, is probably a leftover from when it was using the plasma's location enum

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

On Wednesday 25 November 2015, Martin Klapetek wrote:
>  - The KWindowEffects::slideWindow() docs say "Desktop and Floating
>won't have effect". What is that referring to? The location argument
>does not offer such values. So I assume it's about a window type?
>How about the Notification window type? Is that Floating?

the location is basically from where you want to animate and would be pretty 
much the location of you panel (bottom, the slide will happen from bottom to 
top, left->from left to right and so on)


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread David Edmundson

On Wed, Nov 25, 2015 at 5:23 PM, Martin Klapetek 
wrote:

> Couple questions:
>
>  - I have a QQuickWindow which, by the docs, is rendered by OpenGL.
>Does the same assumptions hold as for animating X11 window?
>
>  - The suggested KWindowEffects::slideWindow() takes WinId as arg
>but QQuickWindow has no WinId returning method. Can it still be
>animated using KWindowEffects?
>
> it's in QWindow which you  inherit from


>  - The KWindowEffects::slideWindow() docs say "Desktop and Floating
>won't have effect". What is that referring to? The location argument
>does not offer such values. So I assume it's about a window type?
>How about the Notification window type? Is that Floating?
>
>



> Cheers
> --
> Martin Klapetek | KDE Developer
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355906] New: Please consider unification for themes' data paths.

2015-11-25 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355906

Bug ID: 355906
   Summary: Please consider unification for themes' data paths.
   Product: Breeze
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: vladimir-...@yandex.ru

Hello everyone!
There is an ongoing discussion in LXQt bugtracker about various themes and how
to handle them. 
https://github.com/lxde/lxqt/issues/572
One of the issues is: theme data paths and naming.

Some convention had formed, mostly in GTK world, but not limited to it, to
place theme data into [$XDG_DATA_DIRS|$XDG_DATA_HOME]/$THEME_NAME/$COMPONENT,
where $COMPONENT is the name of an engine, toolkit or application that is being
themed by $THEME_NAME.

"not limited to GTK" can be illustrated by the output of this command on my
machine:
$ ls /usr/share/themes/ | while read THEME ; do ls /usr/share/themes/"$THEME" ;
done  | sort | uniq
cinnamon
gnome-shell
gtk-2.0
gtk-2.0-key
gtk-3.0
metacity-1
openbox-3
Panel
unity
xfce-notify-4.0
xfwm4
(some non-related lines of output were excluded)

This discussion has convinced tsujan (https://github.com/tsujan), developer of
Kvantum Qt engine to add support of these paths in Kvantum
(https://github.com/tsujan/Kvantum/commit/17a41413263dc546fac816ae1eb43aceb6366eb4).
So, the list presented above may soon be supplemented with 'Kvantum' entry.

I hope that this is a start of something very promising and would like to ask
if you would agree to support this move in Qt theme engines of KDE.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

On Wed, Nov 25, 2015 at 1:10 PM, Marco Martin  wrote:

> On Wednesday 25 November 2015, Martin Klapetek wrote:
> >  - The KWindowEffects::slideWindow() docs say "Desktop and Floating
> >won't have effect". What is that referring to? The location argument
> >does not offer such values. So I assume it's about a window type?
> >How about the Notification window type? Is that Floating?
>
> the location is basically from where you want to animate and would be
> pretty
> much the location of you panel (bottom, the slide will happen from bottom
> to
> top, left->from left to right and so on)
>

Yes, my question is however about the "Desktop and Floating won't have
effect"
note in the docs. What is it about? Will the notification popup be affected?

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

2015-11-25 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/
---

Review request for Plasma.


Bugs: 354651
https://bugs.kde.org/show_bug.cgi?id=354651


Repository: plasma-workspace


Description
---

You can see videos in bug repot


Diffs
-

  shell/desktopview.cpp bc40083 

Diff: https://git.reviewboard.kde.org/r/126175/diff/


Testing
---

I test patch and all works as expected.
http://doc.qt.io/qt-5/qevent.html
QEvent::Leave   11  Mouse leaves widget's boundaries.


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable



> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!

Hmm, it no longer works because the tooltip size is not bound by the available 
screen size.
So it needs fix in plasma-framework first.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable



> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
> Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
> So it needs fix in plasma-framework first.

hmm, can you explain what the problem in tooltip management is?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog



> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.
> 
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add 
> another context menu option for the icon settings, like we do with a couple 
> of applets that can spawn a KCM.

yeah, a second context menu item would be good in this case i think


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Martin Gräßlin via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355892

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|--- |DOWNSTREAM
 Status|UNCONFIRMED |RESOLVED
 CC||mgraess...@kde.org

--- Comment #1 from Martin Gräßlin  ---
This works fine on Debian testing. Please get in contact with your distribution
to figure out why this broke in your Debian fork. You might consider of course
to install systemd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Michael Palimaka via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355892

Michael Palimaka  changed:

   What|Removed |Added

 CC||kensing...@gentoo.org

--- Comment #2 from Michael Palimaka  ---
Newer versions of upower drop the support in favour of systemd. I think 0.9.23
was the last version that still supported the old behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126064: [DragArea] Add dragActive property


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126064/#review88818
---

Ship it!


I would be in favor of this

- Marco Martin


On Nov. 14, 2015, 3:59 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126064/
> ---
> 
> (Updated Nov. 14, 2015, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> It allows to query whether a drag is currently ongoing. This eases avoiding 
> dropping something onto itself when it has both DragArea and DropArea
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d 
>   src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 
> 
> Diff: https://git.reviewboard.kde.org/r/126064/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126126: kicker: always show arrows for items with children



> On Nov. 23, 2015, 9:41 a.m., Marco Martin wrote:
> > I think currently without arrows does look a bit strange with potential 
> > usability issues, but with arrows always in will probably indeed look a bit 
> > cluttered..
> > can you please include a screenshot in such reviews that cause a look 
> > change?
> 
> Sebastian Kügler wrote:
> Perhaps reducing the opacity of the arrows when not hovered is a good 
> compromise?

yeah, a screenshot of translucent arrows except the selected group would be 
helpful


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126126/#review88711
---


On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126126/
> ---
> 
> (Updated Nov. 21, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Always show the arrow in menu items which represent a submenu, instead
> of only when hovering on them. This eases the discovery of which items
> are actually submenus as opposed to actual entries.
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/ItemListDelegate.qml 
> becf13d278862b20f46eacae628364708abadfdc 
> 
> Diff: https://git.reviewboard.kde.org/r/126126/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable



> On Nov. 25, 2015, 1:04 p.m., Eike Hein wrote:
> > Ship It!
> 
> David Rosca wrote:
> Hmm, it no longer works because the tooltip size is not bound by the 
> available screen size.
> So it needs fix in plasma-framework first.
> 
> Marco Martin wrote:
> hmm, can you explain what the problem in tooltip management is?
> 
> Eike Hein wrote:
> I tested the patch before I gave the Ship It!, and it worked just fine 
> for me with latest plasma-framework. The Tooltip dialog docked at the screen 
> edges left and right and the contents scrolled.

For some reason, it doesn't work for me (full kdesrc-build today) without

width: Math.min(Screen.availableDesktopWidth, Math.max(windowRow.width, 
appLabelRow.width)  + _s) 

eg. the contentItem.width == viewport.width even after the tooltip doesn't fit 
on screen.

Ok, so I'll commit it and then try to debug my local issue.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog



> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.
> 
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add 
> another context menu option for the icon settings, like we do with a couple 
> of applets that can spawn a KCM.
> 
> Marco Martin wrote:
> yeah, a second context menu item would be good in this case i think

Okay.

One thing I noticed is that when I edit eg. Kate and apply in the dialog, it 
adds this Kate to the "open with" actions but never removes them again and now 
I have 20 Kate entries there :( Any idea how to prevent this?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog



> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.
> 
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add 
> another context menu option for the icon settings, like we do with a couple 
> of applets that can spawn a KCM.
> 
> Marco Martin wrote:
> yeah, a second context menu item would be good in this case i think
> 
> Kai Uwe Broulik wrote:
> Okay.
> 
> One thing I noticed is that when I edit eg. Kate and apply in the dialog, 
> it adds this Kate to the "open with" actions but never removes them again and 
> now I have 20 Kate entries there :( Any idea how to prevent this?

perhaps when editing an icon that is installed globally, it then creates a copy 
in the home, and then disaster ensues?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-25 Thread Hugo Pereira Da Costa via KDE Bugzilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88822
---

Ship it!


Ship It!

- Marco Martin


On Nov. 23, 2015, 10:19 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> ---
> 
> (Updated Nov. 23, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> also contains fix for clazy warning regarding iterating over temporary 
> roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used 
> QLatin1String because QStringLiteral is known to produce crashes-on-exit if 
> the code is inside a library
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 89c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Graesslin

On Wednesday, November 25, 2015 12:23:28 PM CET Martin Klapetek wrote:
> Couple questions:
> 
>  - I have a QQuickWindow which, by the docs, is rendered by OpenGL.
>Does the same assumptions hold as for animating X11 window?

Yes, it's a window. It doesn't matter how you render to the window, but that 
it's a window. In general in Qt everything which in the end uses the QWindow 
class (which QQuickWindow does) is an X11 window.  This includes things like 
Plasma::Dialog, Tooltips, thumbnails. Everything plasma uses to render to is a 
window. The only application we have which can render without windows is KWin.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

2015-11-25 Thread Martin Gräßlin via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355892

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|--- |DOWNSTREAM
 Status|UNCONFIRMED |RESOLVED

--- Comment #11 from Martin Gräßlin  ---
Setting back to resolved downstream. From our side there is just nothing to do
and to me it's an integration issue (bundling of non-compatible versions) which
means downstream.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355879] Some hover tool tips in "Breeze" theme have no contrast (barely readable)

https://bugs.kde.org/show_bug.cgi?id=355879

Hugo Pereira Da Costa  changed:

   What|Removed |Added

  Component|QStyle  |general
   Assignee|hugo.pere...@free.fr|plasma-devel@kde.org

--- Comment #7 from Hugo Pereira Da Costa  ---
@Marco
Yes. And in the meanwhile reassigning to "general". 
This is not QStyle, and I should not be assigned to the bug (because I do not
know how to fix)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355879] Some hover tool tips in "Breeze" theme have no contrast (barely readable)

2015-11-25 Thread Frederic Mohr via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355879

--- Comment #8 from Frederic Mohr  ---
Anything I can do to help with this problem? Any information I can provide?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Heads-up: Session management issues

On Tuesday, November 24, 2015 11:11:05 PM Andreas Hartmetz wrote:
> I've started a thread "Causes of session management problems in Plasma 
> 5" on kde-core-devel about the session management problems affecting 
> Plasma 5. ksmserver is part of plasma-workspace but the other involved 
> parts aren't part of Plasma.

I can't say much about the issues at hand, but thanks for what looks like a 
thorough and useful analysis!
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker



> On Nov. 24, 2015, 11:50 p.m., andreas kainz wrote:
> > Should we convert the icons from svg to png?

nah, I would like to stylesheet the svgs (patch coming about that actually) 
since i want to eventually have the default theme following the system colors


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126163/#review88781
---


On Nov. 24, 2015, 11:46 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126163/
> ---
> 
> (Updated Nov. 24, 2015, 11:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Widget Explorer takes quite a while to open. Especially now that we load 
> basically double the number of items (two columns) and significantly more 
> complex SVGs. This patch uses a couple of tricks to make it feel a lot faster:
> - Create context menu items on demand
> - Set the model for the list after a slight delay
> - Some minor cleanups
> 
> By setting the model later we let the dialog slide in first (KWin does the 
> animation anyway so it won't block) and then nicely fade in the view once we 
> have loaded it.
> 
> I have noticed that the applet item model which gets the decoration role from 
> the applet package can take quite a while blocking the explorer. It might 
> also be worth investigating whether we should keep the WidgetExplorer around 
> when it has been opened once (I mean the model, not the QML view) so we save 
> creating the model everytime we open it again.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 
> 
> Diff: https://git.reviewboard.kde.org/r/126163/diff/
> 
> 
> Testing
> ---
> 
> Feels a lot quicker now.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker

2015-11-25 Thread andreas kainz



> On Nov. 24, 2015, 11:50 nachm., andreas kainz wrote:
> > Should we convert the icons from svg to png?
> 
> Marco Martin wrote:
> nah, I would like to stylesheet the svgs (patch coming about that 
> actually) since i want to eventually have the default theme following the 
> system colors

you are my hero yeah. Thanks marco


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126163/#review88781
---


On Nov. 24, 2015, 11:46 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126163/
> ---
> 
> (Updated Nov. 24, 2015, 11:46 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Widget Explorer takes quite a while to open. Especially now that we load 
> basically double the number of items (two columns) and significantly more 
> complex SVGs. This patch uses a couple of tricks to make it feel a lot faster:
> - Create context menu items on demand
> - Set the model for the list after a slight delay
> - Some minor cleanups
> 
> By setting the model later we let the dialog slide in first (KWin does the 
> animation anyway so it won't block) and then nicely fade in the view once we 
> have loaded it.
> 
> I have noticed that the applet item model which gets the decoration role from 
> the applet package can take quite a while blocking the explorer. It might 
> also be worth investigating whether we should keep the WidgetExplorer around 
> when it has been opened once (I mean the model, not the QML view) so we save 
> creating the model everytime we open it again.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 
> 
> Diff: https://git.reviewboard.kde.org/r/126163/diff/
> 
> 
> Testing
> ---
> 
> Feels a lot quicker now.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip



> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote:
> > Ship It!

Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to Fabian.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126162/#review88793
---


On Nov. 24, 2015, 10:15 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126162/
> ---
> 
> (Updated Nov. 24, 2015, 10:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346348
> https://bugs.kde.org/show_bug.cgi?id=346348
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is basically patch by Fabian Vogt from the bugreport. 
> But it is still not fixed, so I opened the RR myself.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/126162/diff/
> 
> 
> Testing
> ---
> 
> Bug is now fixed, I cannot see any side-effects.
> 
> Reliable way to reproduce bug:
> 
> 1. Set some launcher to always show
> 2. Make sure the app from step 1. is not running (so you have the launcher in 
> taskmanager without running app)
> 3. Mouse over the launcher from step 1., let the tooltip show and then move 
> mouse out to hide it.
> 4. Mouse over some other taskmanager entry that is for running application
> 5. Tooltip is shown without labels
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126165: quickshare: Trigger paste from clipboard action on click


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/
---

Review request for Plasma.


Repository: kdeplasma-addons


Description
---

It is now possible to paste with mouse click even when ContentTracker's uri is 
empty.


Diffs
-

  applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 

Diff: https://git.reviewboard.kde.org/r/126165/diff/


Testing
---

Works fine, I no longer need to open context menu and select Paste.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126013: fix: kacess should not be built if xkb is not present

2015-11-25 Thread Johan Ouwerkerk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126013/
---

(Updated Nov. 25, 2015, 2:04 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 5667cb503e513bc5197b2ad008d1a921d450ffb3 by Sebastian 
Kügler to branch Plasma/5.5.


Repository: plasma-desktop


Description
---

The XCB-XKB dependency of plasma-desktop is optional, however kacess depends 
directly and unconditionally on the xcb/xkb.h header file.
This causes the build of plasma-desktop to fail at compile stage if the xkb 
header is not present.

As per the convention in the kcm modules shipped by plasma-desktop, inclusion 
of the kacess subdirectory is made conditional on XKB being present and 
properly detected during the cmake configure stage.


Diffs
-

  CMakeLists.txt 193238a8dcbb2c6e2bda01c390c57ff2ecfebeb0 

Diff: https://git.reviewboard.kde.org/r/126013/diff/


Testing
---

Built without xkb header, using kdesrc-build


Thanks,

Johan Ouwerkerk

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126163/#review88797
---

Ship it!



desktoppackage/contents/explorer/WidgetExplorer.qml (line 355)


reason for this?


- Marco Martin


On Nov. 24, 2015, 11:46 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126163/
> ---
> 
> (Updated Nov. 24, 2015, 11:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Widget Explorer takes quite a while to open. Especially now that we load 
> basically double the number of items (two columns) and significantly more 
> complex SVGs. This patch uses a couple of tricks to make it feel a lot faster:
> - Create context menu items on demand
> - Set the model for the list after a slight delay
> - Some minor cleanups
> 
> By setting the model later we let the dialog slide in first (KWin does the 
> animation anyway so it won't block) and then nicely fade in the view once we 
> have loaded it.
> 
> I have noticed that the applet item model which gets the decoration role from 
> the applet package can take quite a while blocking the explorer. It might 
> also be worth investigating whether we should keep the WidgetExplorer around 
> when it has been opened once (I mean the model, not the QML view) so we save 
> creating the model everytime we open it again.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 
> 
> Diff: https://git.reviewboard.kde.org/r/126163/diff/
> 
> 
> Testing
> ---
> 
> Feels a lot quicker now.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip



> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote:
> > Ship It!
> 
> Eike Hein wrote:
> Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to 
> Fabian.

Is this enough, or do you mean anything else?

git commmit --author="Fabian Vogt "


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126162/#review88793
---


On Nov. 24, 2015, 10:15 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126162/
> ---
> 
> (Updated Nov. 24, 2015, 10:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346348
> https://bugs.kde.org/show_bug.cgi?id=346348
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is basically patch by Fabian Vogt from the bugreport. 
> But it is still not fixed, so I opened the RR myself.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/126162/diff/
> 
> 
> Testing
> ---
> 
> Bug is now fixed, I cannot see any side-effects.
> 
> Reliable way to reproduce bug:
> 
> 1. Set some launcher to always show
> 2. Make sure the app from step 1. is not running (so you have the launcher in 
> taskmanager without running app)
> 3. Mouse over the launcher from step 1., let the tooltip show and then move 
> mouse out to hide it.
> 4. Mouse over some other taskmanager entry that is for running application
> 5. Tooltip is shown without labels
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip



> On Nov. 25, 2015, 1:01 p.m., Eike Hein wrote:
> > Ship It!
> 
> Eike Hein wrote:
> Please commit the patch with GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set to 
> Fabian.
> 
> David Rosca wrote:
> Is this enough, or do you mean anything else?
> 
> git commmit --author="Fabian Vogt "

^ That's fine (the env variables are an alternative).


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126162/#review88793
---


On Nov. 24, 2015, 10:15 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126162/
> ---
> 
> (Updated Nov. 24, 2015, 10:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346348
> https://bugs.kde.org/show_bug.cgi?id=346348
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is basically patch by Fabian Vogt from the bugreport. 
> But it is still not fixed, so I opened the RR myself.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/126162/diff/
> 
> 
> Testing
> ---
> 
> Bug is now fixed, I cannot see any side-effects.
> 
> Reliable way to reproduce bug:
> 
> 1. Set some launcher to always show
> 2. Make sure the app from step 1. is not running (so you have the launcher in 
> taskmanager without running app)
> 3. Mouse over the launcher from step 1., let the tooltip show and then move 
> mouse out to hide it.
> 4. Mouse over some other taskmanager entry that is for running application
> 5. Tooltip is shown without labels
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126166: use stylesheets in breeze icons


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126166/
---

Review request for Plasma, andreas kainz and Uri Herrera.


Repository: breeze-icons


Description
---

unfortunately the diff was about 35 megabytes, so was too big for reviewboard 
little mind ;)
a tarball of the modified icons can be found at 
http://notmart.org/misc/breeze-icons.tar.bz2
this changes the monochrome breeze icons (other icons are untouched) to use 
stylesheets instead of hardcoded colors, at least with text color for the black 
bits, background for the light bits.
This is kinda needed for icons loaded in plasma (even tough some basic icons in 
the plasma theme systray and actions are still needed, less duplication would 
be needed)
Will be needed a bit more stringently in plasma mobile, where the plasma theme 
is used as theme for applications (and probably some effects will be needed 
like changing icons from black to white on the fly)

This change is not supposed to change the look of any icon anywhere: for 
desktop applications all of them should look *exactly* the same as they did 
(please doublecheck this ;))


Diffs
-

  CMakeLists.txt 886ab74 

Diff: https://git.reviewboard.kde.org/r/126166/diff/


Testing
---


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126162/#review88793
---

Ship it!


Ship It!

- Eike Hein


On Nov. 24, 2015, 10:15 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126162/
> ---
> 
> (Updated Nov. 24, 2015, 10:15 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 346348
> https://bugs.kde.org/show_bug.cgi?id=346348
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is basically patch by Fabian Vogt from the bugreport. 
> But it is still not fixed, so I opened the RR myself.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/126162/diff/
> 
> 
> Testing
> ---
> 
> Bug is now fixed, I cannot see any side-effects.
> 
> Reliable way to reproduce bug:
> 
> 1. Set some launcher to always show
> 2. Make sure the app from step 1. is not running (so you have the launcher in 
> taskmanager without running app)
> 3. Mouse over the launcher from step 1., let the tooltip show and then move 
> mouse out to hide it.
> 4. Mouse over some other taskmanager entry that is for running application
> 5. Tooltip is shown without labels
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125908/#review88795
---

Ship it!


Ship It!

- Eike Hein


On Nov. 5, 2015, 9:05 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125908/
> ---
> 
> (Updated Nov. 5, 2015, 9:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Make the windows in tooltip scrollable when it doesn't fit on the screen.
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125908/diff/
> 
> 
> Testing
> ---
> 
> Works fine. One thing that would be great is to allow vertical wheel 
> scrolling, but for that KQuickControlsAddons.EventGenerator needs to support 
> wheel events (custom wheel handling would be too complex for Flickable)
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126163: [Widget Explorer] Make it feel a lot quicker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126163/
---

(Updated Nov. 25, 2015, 1:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 7eb5de9feaf43d1b76c3f2d4e0b8ad9643135cf0 by Kai Uwe 
Broulik to branch Plasma/5.5.


Repository: plasma-desktop


Description
---

Widget Explorer takes quite a while to open. Especially now that we load 
basically double the number of items (two columns) and significantly more 
complex SVGs. This patch uses a couple of tricks to make it feel a lot faster:
- Create context menu items on demand
- Set the model for the list after a slight delay
- Some minor cleanups

By setting the model later we let the dialog slide in first (KWin does the 
animation anyway so it won't block) and then nicely fade in the view once we 
have loaded it.

I have noticed that the applet item model which gets the decoration role from 
the applet package can take quite a while blocking the explorer. It might also 
be worth investigating whether we should keep the WidgetExplorer around when it 
has been opened once (I mean the model, not the QML view) so we save creating 
the model everytime we open it again.


Diffs
-

  desktoppackage/contents/explorer/WidgetExplorer.qml 911d9c9 

Diff: https://git.reviewboard.kde.org/r/126163/diff/


Testing
---

Feels a lot quicker now.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126166: use stylesheets in breeze icons


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126166/#review88799
---

Ship it!


Ship It!

- Sebastian Kügler


On Nov. 25, 2015, 1:54 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126166/
> ---
> 
> (Updated Nov. 25, 2015, 1:54 p.m.)
> 
> 
> Review request for Plasma, andreas kainz and Uri Herrera.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> unfortunately the diff was about 35 megabytes, so was too big for reviewboard 
> little mind ;)
> a tarball of the modified icons can be found at 
> http://notmart.org/misc/breeze-icons.tar.bz2
> this changes the monochrome breeze icons (other icons are untouched) to use 
> stylesheets instead of hardcoded colors, at least with text color for the 
> black bits, background for the light bits.
> This is kinda needed for icons loaded in plasma (even tough some basic icons 
> in the plasma theme systray and actions are still needed, less duplication 
> would be needed)
> Will be needed a bit more stringently in plasma mobile, where the plasma 
> theme is used as theme for applications (and probably some effects will be 
> needed like changing icons from black to white on the fly)
> 
> This change is not supposed to change the look of any icon anywhere: for 
> desktop applications all of them should look *exactly* the same as they did 
> (please doublecheck this ;))
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 886ab74 
> 
> Diff: https://git.reviewboard.kde.org/r/126166/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88801
---

Not so sure about this: Just clicking on it will publish information on an 
online service, that's hardly what a naive user would expect. On middle-click I 
think it would be fine, but a normal click is usually used to open some kind of 
popup, if we ship the clipboard to the internet in that case, we may be 
producing privacy leaks inadvertently.

If you make it paste only on pressing the middle button, I'd be OK with this.

- Sebastian Kügler

On Nov. 25, 2015, 1:32 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 1:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click



> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote:
> > Not so sure about this: Just clicking on it will publish information on an 
> > online service, that's hardly what a naive user would expect. On 
> > middle-click I think it would be fine, but a normal click is usually used 
> > to open some kind of popup, if we ship the clipboard to the internet in 
> > that case, we may be producing privacy leaks inadvertently.
> > 
> > If you make it paste only on pressing the middle button, I'd be OK with 
> > this.
> 
> Aleix Pol Gonzalez wrote:
> Just clicking will show the dialog with alternatives.

It asks you first what to do and where to publish (in a popup), so no random 
uploads.

Originally, I made it on middle click, but then I changed it to just left click 
because it already pastes on left click when it gets uri from activity manager.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88801
---


On Nov. 25, 2015, 1:32 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 1:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126014: fix: kcms/input and kcms/touchpad should not be built if XInput is not present.

2015-11-25 Thread Johan Ouwerkerk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126014/
---

(Updated Nov. 25, 2015, 2:17 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 0bd4f5d4777d1aa5978a67ee90bd8a963a245687 by Sebastian 
Kügler to branch Plasma/5.5.


Repository: plasma-desktop


Description
---

Previously the presence of evdev headers would enable the kcms/input KCM 
module, and the presence of synaptics driver headers would enable the touchpad 
module.
However, both KCMs unconditionally depend on XInput in some way in a (sub) 
CMakelists.txt file and deliberately break the build if it is not present or 
not properly detected.

As per the convention in the KCM modules shipped by plasma-desktop, inclusion 
of the kcms/input and kcms/touchpad subdirectory is made conditional on XInput 
being present and properly detected during the cmake configure stage.

This patch can be pulled from the fix-cmake-xinput-dep branch at: 
g...@github.com:cmacq2/plasma-desktop.git


Diffs
-

  kcms/CMakeLists.txt 321fbebba49dad32d237f3941dea9fedaf1a8e5a 

Diff: https://git.reviewboard.kde.org/r/126014/diff/


Testing
---

Built without XInput development files, using kdesrc-build.


Thanks,

Johan Ouwerkerk

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/
---

(Updated Nov. 25, 2015, 2:18 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ca9b6310ceba285a67098b705b7015ae6202f21c by David Rosca 
to branch master.


Repository: kdeplasma-addons


Description
---

It is now possible to paste with mouse click even when ContentTracker's uri is 
empty.


Diffs
-

  applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 

Diff: https://git.reviewboard.kde.org/r/126165/diff/


Testing
---

Works fine, I no longer need to open context menu and select Paste.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126064: [DragArea] Add dragActive property


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126064/#review88807
---


ping, what's the status of this?

- Sebastian Kügler


On Nov. 14, 2015, 3:59 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126064/
> ---
> 
> (Updated Nov. 14, 2015, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> It allows to query whether a drag is currently ongoing. This eases avoiding 
> dropping something onto itself when it has both DragArea and DropArea
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d 
>   src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 
> 
> Diff: https://git.reviewboard.kde.org/r/126064/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Reminder: your window animations belong to KWin

On Wednesday, November 25, 2015 03:13:28 PM Martin Graesslin wrote:
> So if you want to animate any aspect of the window: talk to me. If you have 
> code which animates: get rid of it.

Trigger for this reminder? (I thought we had gotten rid of that kind of 
nonsense long time ago.)
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

Mathieu Roy  changed:

   What|Removed |Added

Version|unspecified |5.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88800
---



src/wizard/pages/pairing.cpp (line 111)


The *2 seems fairly random. Can't we set the right minimum width derived 
from the pinNumber? Given the pin numbers display is huge, wouldn't this lead 
to a very large widget? Also, distinction between minimumSize and preferredSize 
would be more useful here.



src/wizard/pages/pairing.cpp (line 143)


same as above concern.


- Sebastian Kügler


On Nov. 24, 2015, 9:36 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> ---
> 
> (Updated Nov. 24, 2015, 9:36 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
> https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> ---
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> ---
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126162: taskmanager: Fix sometimes not showing labels in tooltip


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126162/
---

(Updated Nov. 25, 2015, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 0ed62041f1715d4e732576bde3e98b7c6d1f3190 by David Rosca 
on behalf of Fabian Vogt to branch Plasma/5.5.


Bugs: 346348
https://bugs.kde.org/show_bug.cgi?id=346348


Repository: plasma-desktop


Description
---

This is basically patch by Fabian Vogt from the bugreport. 
But it is still not fixed, so I opened the RR myself.


Diffs
-

  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 

Diff: https://git.reviewboard.kde.org/r/126162/diff/


Testing
---

Bug is now fixed, I cannot see any side-effects.

Reliable way to reproduce bug:

1. Set some launcher to always show
2. Make sure the app from step 1. is not running (so you have the launcher in 
taskmanager without running app)
3. Mouse over the launcher from step 1., let the tooltip show and then move 
mouse out to hide it.
4. Mouse over some other taskmanager entry that is for running application
5. Tooltip is shown without labels


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126126: kicker: always show arrows for items with children



> On Nov. 23, 2015, 9:41 a.m., Marco Martin wrote:
> > I think currently without arrows does look a bit strange with potential 
> > usability issues, but with arrows always in will probably indeed look a bit 
> > cluttered..
> > can you please include a screenshot in such reviews that cause a look 
> > change?

Perhaps reducing the opacity of the arrows when not hovered is a good 
compromise?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126126/#review88711
---


On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126126/
> ---
> 
> (Updated Nov. 21, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Always show the arrow in menu items which represent a submenu, instead
> of only when hovering on them. This eases the discovery of which items
> are actually submenus as opposed to actual entries.
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/ItemListDelegate.qml 
> becf13d278862b20f46eacae628364708abadfdc 
> 
> Diff: https://git.reviewboard.kde.org/r/126126/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reminder: your window animations belong to KWin

2015-11-25 Thread Martin Graesslin

Hi Plasma devs,

a small reminder: if you want to animate windows use KWin. You should not 
animate your windows yourself. Why you might ask?

X11 sucks. If you animate using X11 you are moving the window. With each 
animation step you perform a configure event on the X server. This is then 
sent to all listening applications (e.g. KWin, Plasma, many more) which are 
woken up, process, etc.

You cannot in no reasonable way know when the frame gets rendered. So if you 
animate yourself you pick a "frame rate" which might be anywhere from 
stuttering to too fast. You just cannot know, because you have no 
introspection into X. If you send too many events, you just block everything 
due to too many wakeups and you get stuttering and in worst case even tearing. 
Oh and you increase the CPU usage significantly. Which again slows down your 
animation.

How does this change when you use KWin? Well KWin for starters doesn't need to 
move the window. All it needs to do is move a window texture around. For that 
it uses OpenGL and there is one thing OpenGL is really good at: that's texture  
mapping.

So with KWin you don't have to send configure requests, you don't wake up 
completely uninterested applications. The animation is controlled (KWin knows 
its framerate and how long it took to render the last frame), it never renders 
more frames than the screen could show. It cannot stall due to too many frames 
rendered.

If you have a problem where you want to animate windows and do so by moving 
the window position: talk to me. But please, pretty please never animate 
windows yourself. X sucks for that and Wayland makes it impossible. So please 
don't do it. Talk to me.

The same goes for opacity btw. Don't change the window opacity with Qt's 
mechanism, but use KWin. It's pretty much the same: QWindow's opacity goes 
through an X property, you have no control when it goes on the screen. KWin 
can animate opacity without going through X. That's how our fade effect works.

So if you want to animate any aspect of the window: talk to me. If you have 
code which animates: get rid of it.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126092: Konqui based Emotion pack named eKspression


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126092/#review88804
---


This has been shipped, no?

- Sebastian Kügler


On Nov. 16, 2015, 10:38 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126092/
> ---
> 
> (Updated Nov. 16, 2015, 10:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> The emoticon pack was done by Andrea Del Sarto
> 
> 
> Diffs
> -
> 
>   themes/CMakeLists.txt 657c7fc 
> 
> Diff: https://git.reviewboard.kde.org/r/126092/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> eKspression emoticon pack
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/1054a71a-4c1f-46e4-8d52-cf8bb33653bd__eKspression.zip
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Aleix Pol Gonzalez



> On Nov. 25, 2015, 3:12 p.m., Sebastian Kügler wrote:
> > Not so sure about this: Just clicking on it will publish information on an 
> > online service, that's hardly what a naive user would expect. On 
> > middle-click I think it would be fine, but a normal click is usually used 
> > to open some kind of popup, if we ship the clipboard to the internet in 
> > that case, we may be producing privacy leaks inadvertently.
> > 
> > If you make it paste only on pressing the middle button, I'd be OK with 
> > this.

Just clicking will show the dialog with alternatives.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88801
---


On Nov. 25, 2015, 2:32 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 2:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click

2015-11-25 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88802
---

Ship it!


Looks good!

- Aleix Pol Gonzalez


On Nov. 25, 2015, 2:32 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 2:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review88808
---


pingeling, status of this? :)

- Sebastian Kügler


On Nov. 14, 2015, 12:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> ---
> 
> (Updated Nov. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QMenu is smart enough not to position itself outside the screen, however this 
> can mean that the button the Menu originated from, could be covered. This can 
> be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> ---
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. 
> Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of 
> popup(0, height) to have the menu pop up below the button. Now it pops up 
> above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click



> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote:
> > Not so sure about this: Just clicking on it will publish information on an 
> > online service, that's hardly what a naive user would expect. On 
> > middle-click I think it would be fine, but a normal click is usually used 
> > to open some kind of popup, if we ship the clipboard to the internet in 
> > that case, we may be producing privacy leaks inadvertently.
> > 
> > If you make it paste only on pressing the middle button, I'd be OK with 
> > this.
> 
> Aleix Pol Gonzalez wrote:
> Just clicking will show the dialog with alternatives.
> 
> David Rosca wrote:
> It asks you first what to do and where to publish (in a popup), so no 
> random uploads.
> 
> Originally, I made it on middle click, but then I changed it to just left 
> click because it already pastes on left click when it gets uri from activity 
> manager.

Okay, thanks for the clarification!


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88801
---


On Nov. 25, 2015, 2:18 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 2:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355892] New: missing suspend/hibernate with upower 0.99.3 and Devuan

https://bugs.kde.org/show_bug.cgi?id=355892

Bug ID: 355892
   Summary: missing suspend/hibernate with upower 0.99.3 and
Devuan
   Product: Powerdevil
   Version: unspecified
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: yeu...@gnu.org

I lack the suspend/hibernate on my KDE5 session. pm-suspend and pm-hibernate
work as expected, so it is a software issue.

upower 0.99.3 in installed. This version does no longer, when called with -d,
advertise can-suspend and can-hibernate.

powerdevil is up and running according to systemsettings5.

As it is a Devuan system, without systemd, there is no libpam-systemd
installed.

Reproducible: Always

Steps to Reproduce:
1. Have Devuan system, without systemd/libpam-systemd
2.
3.


Expected Results:  
Same as pm-suspend and pm-resume.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88810
---


I would expect middle clicking to paste.

- Kai Uwe Broulik


On Nov. 25, 2015, 2:18 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 2:18 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click



> On Nov. 25, 2015, 2:35 p.m., Kai Uwe Broulik wrote:
> > I would expect middle clicking to paste.

same here


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88810
---


On Nov. 25, 2015, 2:18 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> ---
> 
> (Updated Nov. 25, 2015, 2:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> It is now possible to paste with mouse click even when ContentTracker's uri 
> is empty.
> 
> 
> Diffs
> -
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> ---
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126165: quickshare: Trigger paste from clipboard action on click