Re: Custom shell and corona

[Marco Martin]

On Sun, Nov 29, 2015 at 9:08 PM, Olivier Churlaud  wrote:

>  - Put some connections between the main app and the plasmoid. I don't know
> how to do that because I've never really used QML, but I think it should not
> be to complicated.
>  -> Question: do we do this by QDbus, or by DataEngine (I think it's the
> name of the thing)?

You have several ways, that all are quite simple:
you can do a DataEngine (how did Amarok1 do? if it was based on
dataengines they can all be just ported as the api there didn't
change)
Or you can have amarok applets using a subclass of Plasma::Applet ,
which shares a singleton with the Amarok app. Being in the same
process, everybody can just communicate by reading and writing that
single object instance (I can tell you the more detailed steps)

> Feedback about plasma-framework
> ===
>  - To add a container, one must use PlasmaQuick::ContainmentView, which is a
> QQuickWindow and should therefore be toplevel. It's not so good, if I want
> to put it as a widget in a QDialog or something else. Another class would be
> good for applications.

The problem there is that QML stuff can't be directly used in QWidget
based applications because they are two different kinds of windows,
you can embed them with
http://doc.qt.io/qt-5/qwidget.html#createWindowContainer
(not a problem of plasma, it's an issue in the use of QML in general)

>  - The Shortcuts defined for the desktop are also defined for the custom
> shell, even with a minimal Shell that contains only
>
>  Item { id: root; property Item containment; }
>
> In my case, if I scroll on the QML object it changes my virtual desktop !!

for both those things it will need a custom shell package that
disables the shortcut setting dialog and the action plugins (mouse
wheel, context menus)
I was thinking to add one ready for this in plasma-framework, so you
can ignore that for now

--
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Custom shell and corona

[David Edmundson]

On Sun, Nov 29, 2015 at 8:08 PM, Olivier Churlaud 
wrote:

>  Hi,
>
> I'm now done with this first custom shell we spoke about with Marco.
>
> You can see it at
> https://quickgit.kde.org/?p=scratch%2Fochurlaud%2Fplasma-skratch.git
>
> What is currently missing
> 
>  - Put some connections between the main app and the plasmoid. I don't
> know how to do that because I've never really used QML, but I think it
> should not be to complicated.
>  -> Question: do we do this by QDbus, or by DataEngine (I think it's the
> name of the thing)?
>

This is the easiest approach:
http://doc.qt.io/qt-5/qtqml-modules-cppplugins.html
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355540] Tooltips color wrong in gtk applications

[Frederic Mohr via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355540

--- Comment #3 from Frederic Mohr  ---
Same problem for me, see also my screenshots in
https://bugs.kde.org/show_bug.cgi?id=355879 (closed as duplicate)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125702: switch to noto sans

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125702/#review88930
---


There's a huge chunk of startkde which is about the oxygen font.
Should this be updated/removed?

- David Edmundson


On Oct. 21, 2015, 4:01 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125702/
> ---
> 
> (Updated Oct. 21, 2015, 4:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> switch to noto sans
> goes with https://git.reviewboard.kde.org/r/125699/
> 
> 
> Diffs
> -
> 
>   kcms/fonts/fonts.cpp 74da799 
> 
> Diff: https://git.reviewboard.kde.org/r/125702/diff/
> 
> 
> Testing
> ---
> 
> none
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355540] Tooltips color wrong in gtk applications

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355540

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 CC||frederic.m...@gmail.com

--- Comment #2 from Hugo Pereira Da Costa  ---
*** Bug 355879 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355879] Some hover tool tips in "Breeze" theme have no contrast (barely readable)

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355879

Hugo Pereira Da Costa  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Hugo Pereira Da Costa  ---


*** This bug has been marked as a duplicate of bug 355540 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Custom shell and corona

[Olivier Churlaud]

 Hi,

I'm now done with this first custom shell we spoke about with Marco.

You can see it at 
https://quickgit.kde.org/?p=scratch%2Fochurlaud%2Fplasma-skratch.git


What is currently missing

 - Put some connections between the main app and the plasmoid. I don't 
know how to do that because I've never really used QML, but I think it 
should not be to complicated.
 -> Question: do we do this by QDbus, or by DataEngine (I think it's 
the name of the thing)?


Feedback about plasma-framework
===
 - To add a container, one must use PlasmaQuick::ContainmentView, which 
is a QQuickWindow and should therefore be toplevel. It's not so good, if 
I want to put it as a widget in a QDialog or something else. Another 
class would be good for applications.
 - The Shortcuts defined for the desktop are also defined for the 
custom shell, even with a minimal Shell that contains only


 Item { id: root; property Item containment; }

In my case, if I scroll on the QML object it changes my virtual desktop !!

I'll be slowly trying to implement this on amarok, if any help on your 
side is very welcomed (about this missing classes, mainly)


Cheers!
Olivier
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 356037] Confusing indication of active tab (Konsole)

[Hugo Pereira Da Costa via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356037

Hugo Pereira Da Costa  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|hugo.pere...@free.fr
 CC||hugo.pere...@free.fr
  Component|general |QStyle

--- Comment #2 from Hugo Pereira Da Costa  ---
Not sure if there is any way to fix this: as long as you only have two tabs,
and since they will always differ, you will not be able to know (out of
nowhere) which one is the active one and which on is not. Meaning: since there
is no link between the tab and the window content, "active" is only a relative
concept. Or maybe you have a suggestion that would allow to unambiguously
decide which one is active ? 

In any case, this of course changes when you have more than 2 tabs.
Also, the actual color convention is the same as in all other tabbars of the
widget style, and for which there is a better indication about which tab is
active, because it usually is effectively attached to the tabbar content. (see,
e.g. Dolphin).
So that I would hope that people would get "used" to which convention is used
for active and which for inactive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126080: [xembed-sni-proxy] Fix quit if we fail to claim

[Boris Pek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126080/
---

(Updated Nov. 29, 2015, 11:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 968b14962a454f19fc99d7728e14fc9e6e448525 by David 
Edmundson to branch Plasma/5.5.


Repository: plasma-workspace


Description
---

Sync with git repo at github (part 1)

Based on: https://github.com/davidedmundson/xembed-sni-proxy/commit/11e8648


Diffs
-

  xembed-sni-proxy/fdoselectionmanager.h 084152e 
  xembed-sni-proxy/fdoselectionmanager.cpp 02d2660 

Diff: https://git.reviewboard.kde.org/r/126080/diff/


Testing
---


Thanks,

Boris Pek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88931
---


>MoseMove is too expensive event to be redirect, it can cause problems on slow 
>CPU's.

I don't see how. 
It's no different to when the mouse is actually over the containment.

The case for when you're in the 4px margin at the edge of the panel seems like 
it must be tiny.

- David Edmundson


On Nov. 28, 2015, 3:30 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> ---
> 
> (Updated Nov. 28, 2015, 3:30 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> ---
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11  Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

[Anthony Fieroni]

> On Ноев. 30, 2015, 1:26 преди обяд, David Edmundson wrote:
> > shell/panelview.cpp, line 832
> > 
> >
> > why this instead of proxying the event like the others?
> 
> Anthony Fieroni wrote:
> I don't understaind what you mean?

I use this patch since i made it, no problems at all.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88932
---


On Ноев. 28, 2015, 5:30 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> ---
> 
> (Updated Ноев. 28, 2015, 5:30 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> ---
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11  Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

[Anthony Fieroni]

> On Ноев. 30, 2015, 1:25 преди обяд, David Edmundson wrote:
> > >MoseMove is too expensive event to be redirect, it can cause problems on 
> > >slow CPU's.
> > 
> > I don't see how. 
> > It's no different to when the mouse is actually over the containment.
> > 
> > The case for when you're in the 4px margin at the edge of the panel seems 
> > like it must be tiny.

First of all, you don't understaind the problem at all. Every postEvent is 
expensive, not for allocating memory, case event is append to queque. Here 
problem is simple - QEvent::Leave is append to queque *before* MouseMove, this 
behavior can be easy preproduce at slower CPU's like mine. To make redirect on 
evey mousemove is not only stupid, it's more expencive than any other event.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88931
---


On Ноев. 28, 2015, 5:30 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> ---
> 
> (Updated Ноев. 28, 2015, 5:30 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> ---
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11  Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

[Anthony Fieroni]

> On Ноев. 30, 2015, 1:26 преди обяд, David Edmundson wrote:
> > shell/panelview.cpp, line 832
> > 
> >
> > why this instead of proxying the event like the others?

I don't understaind what you mean?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88932
---


On Ноев. 28, 2015, 5:30 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> ---
> 
> (Updated Ноев. 28, 2015, 5:30 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> ---
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11  Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

[Anthony Fieroni]

> On Ноев. 30, 2015, 1:25 преди обяд, David Edmundson wrote:
> > >MoseMove is too expensive event to be redirect, it can cause problems on 
> > >slow CPU's.
> > 
> > I don't see how. 
> > It's no different to when the mouse is actually over the containment.
> > 
> > The case for when you're in the 4px margin at the edge of the panel seems 
> > like it must be tiny.
> 
> Anthony Fieroni wrote:
> First of all, you don't understaind the problem at all. Every postEvent 
> is expensive, not for allocating memory, case event is append to queque. Here 
> problem is simple - QEvent::Leave is append to queque *before* MouseMove, 
> this behavior can be easy preproduce at slower CPU's like mine. To make 
> redirect on evey mousemove is not only stupid, it's more expencive than any 
> other event.

Even more, on lower CPU event queque may increase it size case busy processor, 
this can cause slowdowns, flickers, example: widgets in system tray when has 
expand view by click on item, task window *must not* seen in taskmanager, but 
some time on lower CPU, when it be busy, postEvent is appended *after* event 
that window must be ignore for taskmanager, this cause visual flicker in 
taskmanager. http://tinypic.com/player.php?v=6ft8gn%3E=9 You can see blue 
flicker in taskmanager, cause postEvent is expensive when CPU is busy, this 
cannot see on better CPU.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88931
---


On Ноев. 28, 2015, 5:30 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> ---
> 
> (Updated Ноев. 28, 2015, 5:30 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> ---
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11  Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88932
---



shell/panelview.cpp (line 832)


why this instead of proxying the event like the others?


- David Edmundson


On Nov. 28, 2015, 3:30 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> ---
> 
> (Updated Nov. 28, 2015, 3:30 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
> https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> ---
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave 11  Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 350682] Double-click on GTK widgets initiates window movement, breaks control of the widget

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=350682

David Edmundson  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #9 from David Edmundson  ---
We now have a new Breeze GTK theme in 5.5

Can someone retest and reopen if appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 343555] Breeze support for gtk2 and gtk3

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=343555

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
 CC||k...@davidedmundson.co.uk

--- Comment #18 from David Edmundson  ---
In 5.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355540] Tooltips color wrong in gtk applications

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355540

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk
  Component|general |gtk theme
   Assignee|plasma-devel@kde.org|scionicspec...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 356006] Breeze GTK does not respect the color scheme

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356006

David Edmundson  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|scionicspec...@gmail.com
  Component|general |gtk theme
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=351875

David Edmundson  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||k...@davidedmundson.co.uk
 Resolution|--- |DUPLICATE

--- Comment #8 from David Edmundson  ---


*** This bug has been marked as a duplicate of bug 343369 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel