Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/
---

(Updated Dec. 30, 2015, 5:05 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, KDE Usability and Martin Klapetek.


Changes
---

Submitted with commit be4b0f5aacb9f6550d4e4d0f7226c9e78acd63b5 by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

It's nice that we offer to configure notifications from a notification. 
Usually, however, you're lost in a dialog notifications and you have no idea 
which event you actually just saw.


Diffs
-

  applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
  applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
  applets/notifications/package/contents/ui/Notifications.qml f479a65 
  dataengines/notifications/notificationaction.cpp da5ba14 
  dataengines/notifications/notifications.operations d2a120a 
  dataengines/notifications/notificationsengine.h b275830 
  dataengines/notifications/notificationsengine.cpp 829ef4e 

Diff: https://git.reviewboard.kde.org/r/126570/diff/


Testing
---

I now get the actual notification highlighted when I press the configure button 
of one. Neat.


File Attachments


Highlighted notification
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread David Edmundson 


On Dec. 30, 2015, 12:52 p.m., David Edmundson wrote:
> > The rest LGTM. Thanks.

You're right it's unrelated. 

Removed for now.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/#review90338
---


On Dec. 30, 2015, noon, David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126576/
> ---
> 
> (Updated Dec. 30, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting objects in another object is generally bad practice.
> 
> ShellCorona::availableScreenRect knows what properties of panelview we
> use, so tracking of property changes should be in ShellCorona.
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
>   shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/126576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread Martin Klapetek 


> On Dec. 30, 2015, 12:49 p.m., David Edmundson wrote:
> > Ship It!

This requires frameworks 5.18 (because of the KNotifyConfig changes),
so it should bump the required frameworks version, otherwise build
failures will happen.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/#review90333
---


On Dec. 29, 2015, 11:55 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126570/
> ---
> 
> (Updated Dec. 29, 2015, 11:55 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> It's nice that we offer to configure notifications from a notification. 
> Usually, however, you're lost in a dialog notifications and you have no idea 
> which event you actually just saw.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
>   applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
>   applets/notifications/package/contents/ui/Notifications.qml f479a65 
>   dataengines/notifications/notificationaction.cpp da5ba14 
>   dataengines/notifications/notifications.operations d2a120a 
>   dataengines/notifications/notificationsengine.h b275830 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126570/diff/
> 
> 
> Testing
> ---
> 
> I now get the actual notification highlighted when I press the configure 
> button of one. Neat.
> 
> 
> File Attachments
> 
> 
> Highlighted notification
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126573: Don't duplicate checking content length is within user set bounds

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126573/
---

(Updated Dec. 30, 2015, 4:11 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ba733d16fb2849b2b2cc390ed89b5200dffb5c3f by David 
Edmundson to branch master.


Repository: plasma-desktop


Description
---

This is done by PanelView, we should not be doing the same thing twice.

Longer term means we can use length to refer to the content implicitWidth and 
not the current panel width and resize whilst we are dragging the min sliders.


Diffs
-

  desktoppackage/contents/views/Panel.qml 
a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 

Diff: https://git.reviewboard.kde.org/r/126573/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

2015-12-30 Thread Xuetian Weng 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126513/#review90350
---


ping :)

- Xuetian Weng


On Dec. 25, 2015, 7:02 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126513/
> ---
> 
> (Updated Dec. 25, 2015, 7:02 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Bugs: 349545 and 356923
> https://bugs.kde.org/show_bug.cgi?id=349545
> https://bugs.kde.org/show_bug.cgi?id=356923
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Currently, there are some mixed issue in kcm touchpad related to libinput 
> backend and hot plug.
> There are several issues:
> 1. only one backend maybe used at runtime, either synaptics or libinput. But 
> libinput backend will only be used if there is a libinput backend present. 
> Which means if libinput touchpad is not present at login, kded will not be 
> able to properly support them.
> 2. hotplug touchpad will always set touchpad to disabled.
> 3. hotplug touchpad will not get configuration applied.
> 4. The libinput devices detection may pick some non-touchpad device.  
> 
> To solve these problems, following changes are made:
> 1. Remove SynapticsBackend and LibinputBackend and add three new classes 
> called XlibTouchpad/SynapticsTouchpad/LibinputTouchpad. So findTouchpad may 
> pick up both synaptics or libinput device, and no need to depend on a fixed 
> backend. This change also make it easier to support multiple touchpad device 
> easier if needed.
> 
> 2. hotplug touchpad config not being applied (bug 356923) is mainly because 
> one can't apply settings to a disabled device. Change the statement order in 
> handleReset, apply settings first then set enable status.
> 
> 3. findTouchpad() is changed to use XListInputDevices, because it provides 
> necessary information of device type in order to filter out non-touchpad 
> device. xf86-input-libinput doesn't have a unique atom for touchpad, so 
> current identityAtom cannot guarantee that findTouchpad always returns a 
> touchpad device for libinput.
> 
> 4. On my surface pro 4 system, if touchpad is unpluged, the device will be 
> set to disabled automatically first, then touchpadDetached is called, which 
> makes m_enabled in TouchpadDisabled always to be false after unplug the 
> touchapd. This patch makes TouchpadDisabler have two different enabled 
> property. m_userRequestedState only stores the user requested status, so when 
> handleReset is called, it can properly set enabled state to the last user 
> requested state.
> 
> 
> Diffs
> -
> 
>   kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml 8dec7c2 
>   kcms/touchpad/src/applet/touchpadengine.h 16b98c2 
>   kcms/touchpad/src/applet/touchpadengine.cpp eae429e 
>   kcms/touchpad/src/backends/x11.cmake c9fcea8 
>   kcms/touchpad/src/backends/x11/libinputproperties.c 9dbf9ea 
>   kcms/touchpad/src/backends/x11/libinputtouchpad.h PRE-CREATION 
>   kcms/touchpad/src/backends/x11/libinputtouchpad.cpp PRE-CREATION 
>   kcms/touchpad/src/backends/x11/propertyinfo.h PRE-CREATION 
>   kcms/touchpad/src/backends/x11/propertyinfo.cpp PRE-CREATION 
>   kcms/touchpad/src/backends/x11/synapticstouchpad.h PRE-CREATION 
>   kcms/touchpad/src/backends/x11/synapticstouchpad.cpp PRE-CREATION 
>   kcms/touchpad/src/backends/x11/synclientproperties.h 43d18d2 
>   kcms/touchpad/src/backends/x11/synclientproperties.c 5fd1ed6 
>   kcms/touchpad/src/backends/x11/xlibbackend.h 7cecb4a 
>   kcms/touchpad/src/backends/x11/xlibbackend.cpp b55a45f 
>   kcms/touchpad/src/backends/x11/xlibtouchpad.h PRE-CREATION 
>   kcms/touchpad/src/backends/x11/xlibtouchpad.cpp PRE-CREATION 
>   kcms/touchpad/src/kded/kded.h 9b8fe6e 
>   kcms/touchpad/src/kded/kded.cpp 409126b 
>   kcms/touchpad/src/touchpadbackend.h b225ed9 
> 
> Diff: https://git.reviewboard.kde.org/r/126513/diff/
> 
> 
> Testing
> ---
> 
> Without touchpad -> login -> plug touchpad -> settings applied to device 
> using libinput driver.
> unplug -> replug -> settings applied to device using libinput driver.
> 
> 
> Disable touchpad -> applet shows up -> unplug touchpad -> applet hides -> 
> replug touchpad -> touchpad is still disabled, and applet shows up -> enable 
> touhcpad -> applet hides.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 354 - Still Unstable!

2015-12-30 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/354/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 30 Dec 2015 16:10:38 +
Build duration: 5 min 1 sec

CHANGE SET
Revision ce58e59e471b6a0d5a29d1653fde6b8cd0499300 by David Edmundson: 
(Dont adjust thickness twice)
  change: edit shell/panelview.cpp
Revision e23a1814b0a11624c4970a890578ddfaf3beea51 by David Edmundson: (Add 
missing emit)
  change: edit shell/panelview.cpp
Revision c62452c467e96756a4e5bcaddcee98caa7d27d49 by David Edmundson: 
(Dont emit signals in another object from panel)
  change: edit shell/shellcorona.cpp
  change: edit shell/panelview.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1673/2105 
(79%)CONDITIONAL 1208/1810 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 104/152 (68%)CONDITIONAL 
37/62 (60%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/#review90359
---


+1

- David Edmundson


On Dec. 30, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126579/
> ---
> 
> (Updated Dec. 30, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This enables drag and drop for favorites
> 
> 
> Diffs
> -
> 
>   applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
> 
> Diff: https://git.reviewboard.kde.org/r/126579/diff/
> 
> 
> Testing
> ---
> 
> Dragged application to my desktop: got an icon widget
> Dragged recent document to my desktop: got an icon widget
> Dragged a random text document to my desktop: got an icon widget
> 
> Probably not optimal querying KService all the time?
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2015-12-30 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/
---

Review request for Plasma and Eike Hein.


Repository: plasma-desktop


Description
---

This enables drag and drop for favorites


Diffs
-

  applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 

Diff: https://git.reviewboard.kde.org/r/126579/diff/


Testing
---

Dragged application to my desktop: got an icon widget
Dragged recent document to my desktop: got an icon widget
Dragged a random text document to my desktop: got an icon widget

Probably not optimal querying KService all the time?


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

2015-12-30 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126578/
---

Review request for Plasma, KDE Usability and Eike Hein.


Repository: plasma-desktop


Description
---

This adds the context menu actions you also get in the favorites and 
applications view to search results.

Usability: This enables this for Kickoff, Kicker and Application Dashboard.

I did not add the "Edit application" context menu as search results are 
somewhat conceptually detached from the application menu structure.


Diffs
-

  applets/kicker/package/contents/ui/main.qml 5defa75 
  applets/kicker/plugin/actionlist.h 58dd6dd 
  applets/kicker/plugin/actionlist.cpp 6d73434 
  applets/kicker/plugin/appentry.cpp 61fd8a9 
  applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
  applets/kicker/plugin/runnermodel.h 4c3f212 
  applets/kicker/plugin/runnermodel.cpp 6496816 
  applets/kickoff/package/contents/ui/Kickoff.qml 8a8c9c5 

Diff: https://git.reviewboard.kde.org/r/126578/diff/


Testing
---

Steam favorite: Add to desktop, panel, task manager work, "Screenshots" jump 
list action works

Searched for "steam": Add to desktop, panel, task manager work, "Screenshots" 
jump list action works


File Attachments


Search result menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/2e00c239-3dcc-4253-9c0c-0563a11de9b2__steaminsearch.jpg


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126373: change the taskbar color from blue to gray

2015-12-30 Thread andreas kainz 


> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote:
> > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo 
> > that cleans up all the random margins and inconsistent corner styles in it 
> > that currently mess up alignments inside and outside of task buttons as 
> > well as corner appearance. Whatever the outcome of this, it needs to be 
> > rebased against those fixes first.
> 
> Uri Herrera wrote:
> The margins are not random. I literally had to use kruler and kmag to 
> properly align that. I even used a layered file with a red rectangle in it 
> because that area consists of a deadzone. I pointed that out when I made the 
> reveiw request originally.
> 
> Eike Hein wrote:
> The inside margins are currently inconsistent at the top and bottom 
> causing the icon to be vertically misaligned. The outside margins are 
> inconsistent as well - I think it's trying to position the button well inside 
> the panel, but this is an incorrect approach to the problem (the optical 
> imbalance with consistent margins is caused by how the panel inside margins 
> function, which is something we need to address in the theming system - my 
> approach to fix it was rejected, I'll be trying again though). The outside 
> margins and the corners (top ones rounded, bottom ones not) subtly break 
> things when the panel is anywhere but the bottom.
> 
> I'm working on a series of changes to make the panel and Task Manager 
> finally pixel-perfect - fix the theme, fix the panel controller when 
> resizing, fix the panel default size, and fix something in FrameSVG/the panel 
> containment.
> 
> Johan Ouwerkerk wrote:
> In any case, the top version (new draft?) has markedly better alignment 
> of the text with icons... The other two versions seem vertically imbalanced 
> (more margin on the bottom than at the top).
> Ideally, the icon is vertically aligned with the baseline of the text 
> such that ascenders and descenders extend equally far beyond the 
> corresponding border of the icon, hough this may be rather tricky when 
> considering languages with different baseline conventions (hanging or 
> variable or none).
> 
> Eike Hein wrote:
> The top version on the screenshot still shows all of the problems I'm 
> currently fixing FWIW.
> 
> Eike Hein wrote:
> I've now pushed the cleaned up tasks.svgz to git master. This fixes:
> 
> * Fix inconsistent inside margins causing vertical misalignment inside 
> Task Buttons.
> * Fix inconsistent outside margins causing incorrect alignment inside 
> panel.
> * Fix outside margins and button corner appearance in locations other 
> than South.
> * Align button frames with things like the pager edges.
> * Fix a few instances of incorrect color scheme application.
> * Remove many unused elements.
> 
> This is what this gets us: http://i.imgur.com/7KaeJH5.png
> 
> This took *hours* to fix. If anyone breaks these margins I will *eat* 
> them. Please base future changes on this version of the file!
> 
> Johan Ouwerkerk wrote:
> Much better! Appreciated.
> 
> Perhaps a test application that sets window name in a variety of scripts 
> might be useful to check how it performs on various scripts...?
> 
> Eike Hein wrote:
> I test CJK and Arabic fairly regularly.
> 
> andreas kainz wrote:
> as I'm to jung to die can you change the behavior from your new 
> tasks.svgz file to 
> 
> 3. add blue boarder as all other tasks have (see first line in 
> taskbar3.png)
> 
> as suggested above.
> 
> Kai Uwe Broulik wrote:
> Looking good, Eike, I'm just not sure about the gray background for 
> minimized tasks. It makes them more prominent than the non-minimized ones - I 
> liked the frameless variant for those better.

Eike can I have a blue boarder for the selected task as fare as I see it's the 
only selection mode without border.


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126373/#review89779
---


On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126373/
> ---
> 
> (Updated Dec. 16, 2015, 7:23 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Uri Herrera.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Problem
> ===
> with the new taskbar we look that the look and feel is consistent between 
> plasma and the applications therefore Uri change the selected application 
> taskbar button to a blue background. The problem is that the blue background 
> couldn't be the same blue than e.g. in the dolphin sidebar cause when you 
> select an element

Re: Review Request 126356: change minimum size of clipboard

2015-12-30 Thread andreas kainz 


> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote:
> > applets/clipboard/contents/ui/clipboard.qml, line 69
> > 
> >
> > this is not the actual size of the systray, but a hardcoded value which 
> > might match (or not) the size of systray.
> > 
> > As the motivation sounds correct to me I suggest to find a way to 
> > actually use the size of systray. Experts around?
> 
> andreas kainz wrote:
> it doesn't have to have the same size than in the system tray popup. I 
> only want to reduce the minimum height so that the minimum height would be at 
> least the height of the popup. it's only a preset value. you don't have to 
> investigate to much time. use a number would be ok. and it doesn't matter 
> what would be the minimum size the user have to change the plasmoid size by 
> themself at the desktop so it is not a predefinition.

would be also ok to use the system tray size but where is the system tray size 
defined?


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/#review89547
---


On Dec. 15, 2015, 12:37 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126356/
> ---
> 
> (Updated Dec. 15, 2015, 12:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> if you use clipboard on the desktop the minimum window height is heigher than 
> you use clipboard from the panel (drop down window). As the user can define 
> the width and height for the desktop plasmoid the minimum allowed height 
> should be at least the same than the drop down window in the panel. so I 
> change the minimumHeig to 16.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/clipboard.qml 97230c1 
> 
> Diff: https://git.reviewboard.kde.org/r/126356/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> old before with 26 min height
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
> new after with 16 min height
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126092: Konqui based Emotion pack named eKspression

2015-12-30 Thread andreas kainz 


> On Dec. 29, 2015, 7:56 p.m., Martin Klapetek wrote:
> > Are you sure this is the updated pack? I see the exact same icons as in the 
> > first round.

Andrea del sarto please upload the updated emoticons or send them to me. thanks


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126092/#review90304
---


On Dec. 23, 2015, 8:05 p.m., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126092/
> ---
> 
> (Updated Dec. 23, 2015, 8:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> The emoticon pack was done by Andrea Del Sarto
> 
> 
> Diffs
> -
> 
>   themes/CMakeLists.txt 657c7fc 
> 
> Diff: https://git.reviewboard.kde.org/r/126092/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> eKspression emoticon pack
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/16/1054a71a-4c1f-46e4-8d52-cf8bb33653bd__eKspression.zip
> konqui
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/7fc6ede6-9965-43ed-ac5f-937bf380103d__konqui.tar.gz
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126574: Don't adjust thickness twice

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126574/
---

(Updated Dec. 30, 2015, 4:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit ce58e59e471b6a0d5a29d1653fde6b8cd0499300 by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

No point doing a setMinimumWidth/Height directly in positionPanel (which
we always call) does a setMinimumSize anyway


Diffs
-

  shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 

Diff: https://git.reviewboard.kde.org/r/126574/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/
---

(Updated Dec. 30, 2015, 4:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c62452c467e96756a4e5bcaddcee98caa7d27d49 by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

Emitting objects in another object is generally bad practice.

ShellCorona::availableScreenRect knows what properties of panelview we
use, so tracking of property changes should be in ShellCorona.


Diffs
-

  shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
  shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 

Diff: https://git.reviewboard.kde.org/r/126576/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126575: Add missing emit

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126575/
---

(Updated Dec. 30, 2015, 4:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit e23a1814b0a11624c4970a890578ddfaf3beea51 by David 
Edmundson to branch master.


Repository: plasma-workspace


Description
---

Add missing emit


Diffs
-

  shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 

Diff: https://git.reviewboard.kde.org/r/126575/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

2015-12-30 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/356/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 30 Dec 2015 17:05:34 +
Build duration: 5 min 44 sec

CHANGE SET
Revision be4b0f5aacb9f6550d4e4d0f7226c9e78acd63b5 by kde: ([Notifications] 
Highlight the actual event when configuring)
  change: edit dataengines/notifications/notificationsengine.h
  change: edit dataengines/notifications/notificationaction.cpp
  change: edit applets/notifications/package/contents/ui/NotificationPopup.qml
  change: edit 
applets/notifications/package/contents/ui/NotificationDelegate.qml
  change: edit applets/notifications/package/contents/ui/Notifications.qml
  change: edit dataengines/notifications/notificationsengine.cpp
  change: edit dataengines/notifications/notifications.operations
Revision 25160bac00a28feeac19efd33000223d49c93094 by kde: (Bump KDE Frameworks 
requirement)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1653/2105 
(79%)CONDITIONAL 1197/1788 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 84/152 (55%)CONDITIONAL 
26/40 (65%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

2015-12-30 Thread Thomas Pfeiffer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126578/#review90361
---


Looks great, no objections!

- Thomas Pfeiffer


On Dec. 30, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126578/
> ---
> 
> (Updated Dec. 30, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This adds the context menu actions you also get in the favorites and 
> applications view to search results.
> 
> Usability: This enables this for Kickoff, Kicker and Application Dashboard.
> 
> I did not add the "Edit application" context menu as search results are 
> somewhat conceptually detached from the application menu structure.
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/main.qml 5defa75 
>   applets/kicker/plugin/actionlist.h 58dd6dd 
>   applets/kicker/plugin/actionlist.cpp 6d73434 
>   applets/kicker/plugin/appentry.cpp 61fd8a9 
>   applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
>   applets/kicker/plugin/runnermodel.h 4c3f212 
>   applets/kicker/plugin/runnermodel.cpp 6496816 
>   applets/kickoff/package/contents/ui/Kickoff.qml 8a8c9c5 
> 
> Diff: https://git.reviewboard.kde.org/r/126578/diff/
> 
> 
> Testing
> ---
> 
> Steam favorite: Add to desktop, panel, task manager work, "Screenshots" jump 
> list action works
> 
> Searched for "steam": Add to desktop, panel, task manager work, "Screenshots" 
> jump list action works
> 
> 
> File Attachments
> 
> 
> Search result menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/2e00c239-3dcc-4253-9c0c-0563a11de9b2__steaminsearch.jpg
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126573: Don't duplicate checking content length is within user set bounds

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126573/
---

Review request for Plasma.


Repository: plasma-desktop


Description
---

This is done by PanelView, we should not be doing the same thing twice.

Longer term means we can use length to refer to the content implicitWidth and 
not the current panel width and resize whilst we are dragging the min sliders.


Diffs
-

  desktoppackage/contents/views/Panel.qml 
a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 

Diff: https://git.reviewboard.kde.org/r/126573/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126575: Add missing emit

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126575/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Add missing emit


Diffs
-

  shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 

Diff: https://git.reviewboard.kde.org/r/126575/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126574: Don't adjust thickness twice

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126574/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

No point doing a setMinimumWidth/Height directly in positionPanel (which
we always call) does a setMinimumSize anyway


Diffs
-

  shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 

Diff: https://git.reviewboard.kde.org/r/126574/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126570: [Notifications] Highlight the actual event when configuring a notification

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126570/#review90333
---

Ship it!


Ship It!

- David Edmundson


On Dec. 29, 2015, 10:55 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126570/
> ---
> 
> (Updated Dec. 29, 2015, 10:55 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Klapetek.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> It's nice that we offer to configure notifications from a notification. 
> Usually, however, you're lost in a dialog notifications and you have no idea 
> which event you actually just saw.
> 
> 
> Diffs
> -
> 
>   applets/notifications/package/contents/ui/NotificationDelegate.qml fde115c 
>   applets/notifications/package/contents/ui/NotificationPopup.qml d398027 
>   applets/notifications/package/contents/ui/Notifications.qml f479a65 
>   dataengines/notifications/notificationaction.cpp da5ba14 
>   dataengines/notifications/notifications.operations d2a120a 
>   dataengines/notifications/notificationsengine.h b275830 
>   dataengines/notifications/notificationsengine.cpp 829ef4e 
> 
> Diff: https://git.reviewboard.kde.org/r/126570/diff/
> 
> 
> Testing
> ---
> 
> I now get the actual notification highlighted when I press the configure 
> button of one. Neat.
> 
> 
> File Attachments
> 
> 
> Highlighted notification
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/4533273e-f4f8-43e4-b291-8ac2907e0138__Screenshot_20151229_234815a.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 353 - Still Unstable!

2015-12-30 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 30 Dec 2015 09:43:00 +
Build duration: 5 min 4 sec

CHANGE SET
Revision c1da8f1f866fc050a1d47861f38a2d4fe2ef600c by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit runners/baloo/plasma-runner-baloosearch.desktop
  change: edit dataengines/share/data/plasma_shareprovider.desktop
  change: edit 
containmentactions/switchdesktop/plasma-containmentactions-switchdesktop.desktop
  change: edit runners/activities/plasma-runner-activityrunner.desktop
  change: edit shell/plasmashell.desktop
  change: edit runners/sessions/plasma-runner-sessions.desktop
  change: edit appmenu/appmenu.desktop
  change: edit runners/windows/plasma-runner-windows.desktop
  change: edit 
shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 
test(s)Failed: TestSuite.testdesktop

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1673/2105 
(79%)CONDITIONAL 1208/1810 (67%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 104/152 (68%)CONDITIONAL 
37/62 (60%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 64/66 (97%)CONDITIONAL 
25/46 (54%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126577: Update battery.svgz

2015-12-30 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126577/
---

Review request for Plasma and Uri Herrera.


Bugs: 356380
http://bugs.kde.org/show_bug.cgi?id=356380


Repository: plasma-framework


Description
---

Battery.svgz is not valid compressed file. gunzip report
"gzip: battery.svg.gz: unexpected end of file"
when process it with /src/tools/currentColorFillFix.sh


Diffs
-

  src/desktoptheme/breeze/icons/battery.svgz f02b1d6 

Diff: https://git.reviewboard.kde.org/r/126577/diff/


Testing
---

Now it is OK.


File Attachments


battery.svgz
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/d8e7fb05-8458-491b-a303-3212b74b1d73__battery.svgz


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Failing!

2015-12-30 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 30 Dec 2015 12:20:23 +
Build duration: 49 sec

CHANGE SET
Revision e3d6860928628dd3d9a040fd8c3ffb4fb73dc986 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit dataengines/share/data/plasma_shareprovider.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Emitting objects in another object is generally bad practice.

ShellCorona::availableScreenRect knows what properties of panelview we
use, so tracking of property changes should be in ShellCorona.


Diffs
-

  shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
  shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 

Diff: https://git.reviewboard.kde.org/r/126576/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126573: Don't duplicate checking content length is within user set bounds

2015-12-30 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126573/#review90336
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 30, 2015, 12:46 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126573/
> ---
> 
> (Updated Dec. 30, 2015, 12:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This is done by PanelView, we should not be doing the same thing twice.
> 
> Longer term means we can use length to refer to the content implicitWidth and 
> not the current panel width and resize whilst we are dragging the min sliders.
> 
> 
> Diffs
> -
> 
>   desktoppackage/contents/views/Panel.qml 
> a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 
> 
> Diff: https://git.reviewboard.kde.org/r/126573/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

kde/workspace repos on phabricator

2015-12-30 Thread Bhushan Shah 
Hello people,

Just quick-ish update that kde/workspace repos are imported into
phabricator, so I think its time we should start using phabricator for
reviews.

Thanks!

-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126575: Add missing emit

2015-12-30 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126575/#review90337
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 30, 2015, 12:53 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126575/
> ---
> 
> (Updated Dec. 30, 2015, 12:53 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Add missing emit
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
> 
> Diff: https://git.reviewboard.kde.org/r/126575/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kde/workspace repos on phabricator

2015-12-30 Thread Ivan Čukić 
Oh, happy day :)

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/#review90338
---



shell/panelview.cpp 


Unrelated? Why? Otherwise we have weird screen jumps...



shell/panelview.cpp (line 166)


remove?


The rest LGTM. Thanks.

- Aleix Pol Gonzalez


On Dec. 30, 2015, 1 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126576/
> ---
> 
> (Updated Dec. 30, 2015, 1 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting objects in another object is generally bad practice.
> 
> ShellCorona::availableScreenRect knows what properties of panelview we
> use, so tracking of property changes should be in ShellCorona.
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
>   shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/126576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126577: Update battery.svgz

2015-12-30 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126577/#review90340
---

Ship it!


Ship It!

- David Edmundson


On Dec. 30, 2015, 1:39 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126577/
> ---
> 
> (Updated Dec. 30, 2015, 1:39 p.m.)
> 
> 
> Review request for Plasma and Uri Herrera.
> 
> 
> Bugs: 356380
> http://bugs.kde.org/show_bug.cgi?id=356380
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Battery.svgz is not valid compressed file. gunzip report
> "gzip: battery.svg.gz: unexpected end of file"
> when process it with /src/tools/currentColorFillFix.sh
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/battery.svgz f02b1d6 
> 
> Diff: https://git.reviewboard.kde.org/r/126577/diff/
> 
> 
> Testing
> ---
> 
> Now it is OK.
> 
> 
> File Attachments
> 
> 
> battery.svgz
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/d8e7fb05-8458-491b-a303-3212b74b1d73__battery.svgz
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126577: Update battery.svgz

2015-12-30 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126577/#review90342
---

Ship it!


Ship It!

- Marco Martin


On Dec. 30, 2015, 1:39 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126577/
> ---
> 
> (Updated Dec. 30, 2015, 1:39 p.m.)
> 
> 
> Review request for Plasma and Uri Herrera.
> 
> 
> Bugs: 356380
> http://bugs.kde.org/show_bug.cgi?id=356380
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Battery.svgz is not valid compressed file. gunzip report
> "gzip: battery.svg.gz: unexpected end of file"
> when process it with /src/tools/currentColorFillFix.sh
> 
> 
> Diffs
> -
> 
>   src/desktoptheme/breeze/icons/battery.svgz f02b1d6 
> 
> Diff: https://git.reviewboard.kde.org/r/126577/diff/
> 
> 
> Testing
> ---
> 
> Now it is OK.
> 
> 
> File Attachments
> 
> 
> battery.svgz
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/30/d8e7fb05-8458-491b-a303-3212b74b1d73__battery.svgz
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126576: Don't emit signals in another object from panel.

2015-12-30 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126576/#review90343
---

Ship it!


looks good, i'm also not 100% convinced by the removal of that line even tough 
i agree with it, do a test  show no regressions?


shell/panelview.cpp 


was probably a workaround to setscreen not working? looks unrelated indeed, 
but if now works fine without this line it should be committed as well


- Marco Martin


On Dec. 30, 2015, noon, David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126576/
> ---
> 
> (Updated Dec. 30, 2015, noon)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Emitting objects in another object is generally bad practice.
> 
> ShellCorona::availableScreenRect knows what properties of panelview we
> use, so tracking of property changes should be in ShellCorona.
> 
> 
> Diffs
> -
> 
>   shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 
>   shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd 
> 
> Diff: https://git.reviewboard.kde.org/r/126576/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kde/workspace repos on phabricator

2015-12-30 Thread Marco Martin 
On Wednesday 30 December 2015 17:53:36 Bhushan Shah wrote:
> Hello people,
> 
> Just quick-ish update that kde/workspace repos are imported into
> phabricator, so I think its time we should start using phabricator for
> reviews.

should them be forcefully removed from reviewboard now? (otherwise, we well 
know where the path of least resistence leads ;)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel