Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 352 - Fixed!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 10:05:06 +
Build duration: 6 min 28 sec

CHANGE SET
Revision edfb10ba83e717a9e90a778d5f0def38fb9e97cb by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit dataengines/kimpanel/plasma-dataengine-kimpanel.desktop
  change: edit applets/kimpanel/package/metadata.desktop
  change: edit solid-device-automounter/kded/device_automounter.desktop
  change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2392/3441 
(70%)CONDITIONAL 1769/3063 (58%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 820/1555 
(53%)CONDITIONAL 774/1288 (60%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
493/958 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 271/352 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 372 - Fixed!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/372/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 10:05:26 +
Build duration: 15 min

CHANGE SET
Revision 3b05d0cad98e58d19ab42d6ee16215066c02325c by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/systemmonitor/diskactivity/metadata.desktop
  change: edit applets/systemmonitor/diskusage/metadata.desktop
  change: edit xembed-sni-proxy/xembedsniproxy.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1682/2105 
(80%)CONDITIONAL 1219/1834 (66%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/152 (73%)CONDITIONAL 
47/82 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 372 - Fixed!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/372/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 10:05:26 +
Build duration: 15 min

CHANGE SET
Revision 3b05d0cad98e58d19ab42d6ee16215066c02325c by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit applets/systemmonitor/diskactivity/metadata.desktop
  change: edit applets/systemmonitor/diskusage/metadata.desktop
  change: edit xembed-sni-proxy/xembedsniproxy.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1682/2105 
(80%)CONDITIONAL 1219/1834 (66%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 304/425 (72%)CONDITIONAL 
478/541 (88%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 77/77 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 111/152 (73%)CONDITIONAL 
47/82 (57%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 258/379 
(68%)CONDITIONAL 109/146 (75%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 614/677 (91%)CONDITIONAL 
377/742 (51%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 88/161 (55%)CONDITIONAL 
34/56 (61%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 98/102 (96%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 66/66 (100%)CONDITIONAL 
31/60 (52%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126356: change minimum size of clipboard

2016-01-09 Thread andreas kainz


> On Dez. 15, 2015, 2:29 nachm., Martin Gräßlin wrote:
> > applets/clipboard/contents/ui/clipboard.qml, line 69
> > 
> >
> > this is not the actual size of the systray, but a hardcoded value which 
> > might match (or not) the size of systray.
> > 
> > As the motivation sounds correct to me I suggest to find a way to 
> > actually use the size of systray. Experts around?
> 
> andreas kainz wrote:
> it doesn't have to have the same size than in the system tray popup. I 
> only want to reduce the minimum height so that the minimum height would be at 
> least the height of the popup. it's only a preset value. you don't have to 
> investigate to much time. use a number would be ok. and it doesn't matter 
> what would be the minimum size the user have to change the plasmoid size by 
> themself at the desktop so it is not a predefinition.
> 
> andreas kainz wrote:
> would be also ok to use the system tray size but where is the system tray 
> size defined?
> 
> David Edmundson wrote:
> FWIW, the size of the system tray is defined in main.qml as
> height: units.gridUnit * 14
> width: units.gridUnit * 24.5 (yes, really)
> 
> However, no other applets match the system tray, and there's no 
> conceptual reason this has to.
> 
> The minimum size is effectively an arbitrary amount that changes per 
> plasmoid, and it should be the smallest size one can reasnobly show all the 
> contents.
> I'd say this patch is good as-is.

thanks David I will push this request asap


- andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/#review89547
---


On Dez. 15, 2015, 12:37 nachm., andreas kainz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126356/
> ---
> 
> (Updated Dez. 15, 2015, 12:37 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> if you use clipboard on the desktop the minimum window height is heigher than 
> you use clipboard from the panel (drop down window). As the user can define 
> the width and height for the desktop plasmoid the minimum allowed height 
> should be at least the same than the drop down window in the panel. so I 
> change the minimumHeig to 16.
> 
> 
> Diffs
> -
> 
>   applets/clipboard/contents/ui/clipboard.qml 97230c1 
> 
> Diff: https://git.reviewboard.kde.org/r/126356/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> old before with 26 min height
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
> new after with 16 min height
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
> 
> 
> Thanks,
> 
> andreas kainz
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 352 - Fixed!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 10:05:06 +
Build duration: 6 min 28 sec

CHANGE SET
Revision edfb10ba83e717a9e90a778d5f0def38fb9e97cb by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit dataengines/kimpanel/plasma-dataengine-kimpanel.desktop
  change: edit applets/kimpanel/package/metadata.desktop
  change: edit solid-device-automounter/kded/device_automounter.desktop
  change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2392/3441 
(70%)CONDITIONAL 1769/3063 (58%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 820/1555 
(53%)CONDITIONAL 774/1288 (60%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
493/958 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 271/352 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126658: Notifications again not works correctly [revert parch 126408]

2016-01-09 Thread Anthony Fieroni

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126658/
---

(Updated Ян. 9, 2016, 2:52 след обяд)


Review request for Plasma, David Edmundson, Marco Martin, and Martin Klapetek.


Repository: plasma-workspace


Description
---

Review 126408 completely same flying and configurations issues


Diffs
-

  applets/notifications/plugin/notificationshelper.cpp 15b4479 
  applets/notifications/package/contents/ui/configNotifications.qml 95a8e59 
  applets/notifications/package/contents/ui/Notifications.qml f479a65 
  applets/notifications/lib/notificationsapplet.h 5b262f1 
  applets/notifications/lib/notificationsapplet.cpp 891cdb0 
  applets/notifications/plugin/notificationshelper.h 860a2da 
  applets/notifications/package/contents/ui/ScreenPositionSelector.qml efff648 

Diff: https://git.reviewboard.kde.org/r/126658/diff/


Testing
---

My code works *correctly*, revert patch from 126408 - configurations issues.
Qt 5.5.1, libxcb 1.11.1 Arch Linux


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-09 Thread Kai Uwe Broulik


> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote:
> > Very nice!
> > 
> > Gut feeling feedback:
> > 
> > - the error message's icon could take the place of the eject icon
> > - the "safely remove" icon could go away, text made italic (not sure if 
> > there's prior art in the HIG, I'm just imagining it would look less 
> > invasive)

Please no italic text. Another idea would be having an emblem on the device 
icon, we indicate mounted vs not mounted, so we could show error / success 
there as well/instead.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review90819
---


On Jan. 9, 2016, 8:15 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 9, 2016, 8:15 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126356: change minimum size of clipboard

2016-01-09 Thread andreas kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/
---

(Updated Jan. 9, 2016, 9:53 p.m.)


Review request for Plasma.


Changes
---

and the screenshot with the updated minimum size


Repository: plasma-workspace


Description
---

if you use clipboard on the desktop the minimum window height is heigher than 
you use clipboard from the panel (drop down window). As the user can define the 
width and height for the desktop plasmoid the minimum allowed height should be 
at least the same than the drop down window in the panel. so I change the 
minimumHeig to 16.


Diffs
-

  applets/clipboard/contents/ui/clipboard.qml 97230c1 

Diff: https://git.reviewboard.kde.org/r/126356/diff/


Testing
---


File Attachments (updated)


old before with 26 min height
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
new after with 16 min height
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png
screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/566b420b-df44-44d4-86b3-b9f2d441aed8__clipboardMinimumSize.png


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 13:12:14 +
Build duration: 16 min

CHANGE SET
Revision 241d1d7c15d388aae5c3a49cd7e4769d5ac16d2c by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit solid-device-automounter/kded/device_automounter.desktop
  change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2392/3441 
(70%)CONDITIONAL 1850/3225 (57%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 820/1555 
(53%)CONDITIONAL 825/1390 (59%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
523/1018 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 271/352 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 51 - Fixed!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 13:12:14 +
Build duration: 16 min

CHANGE SET
Revision 241d1d7c15d388aae5c3a49cd7e4769d5ac16d2c by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit solid-device-automounter/kded/device_automounter.desktop
  change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2392/3441 
(70%)CONDITIONAL 1850/3225 (57%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 90/187 (48%)CONDITIONAL 
18/34 (53%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 820/1555 
(53%)CONDITIONAL 825/1390 (59%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 503/584 (86%)CONDITIONAL 
523/1018 (51%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 251/253 (99%)CONDITIONAL 
242/364 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 357/410 (87%)CONDITIONAL 
108/178 (61%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 271/352 (77%)CONDITIONAL 
82/137 (60%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: KDE Discover binary & library names

2016-01-09 Thread Jonathan Riddell
On Fri, Jan 08, 2016 at 07:08:40PM +0100, Ivan Čukić wrote:
> While I'm not against the name plasma-discover, I think that we are
> starting to use the term plasma in far too many places - wherever we
> used to use KDE.

My definition of what I'd be happy to include in a release is stuff that you'd 
install in a KDE Plasma distro variant but wouldn't if you were running a Gnome 
or other desktop variant of your distro.  In that regard Discover fits in 
because increasingly other desktops come with their own package managers such 
as Gnome Software.  So a name of plasma-discover would do nicely.

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-09 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/
---

Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
---

Instead of showing a detached status bar with the device name, show the message 
below the device.

When removing a device, device notifier will pop up and a "You can now safely 
remove this device" message will show up; after 5 seconds the message and the 
device will disappear. When trying to unmount a device and it fails, device 
notifier will show up with an error message that will stay there until device 
notifier is closed or another message appears.

This review consists of two patches: one for fixing the device notifications 
engine's wording (I'm open to better verbalizations) and one for the device 
notifier


Diffs
-

  applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
  applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
  dataengines/devicenotifications/ksolidnotify.h fac8cc1 
  dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 

Diff: https://git.reviewboard.kde.org/r/126688/diff/


Testing
---

There a still a couple of glitches:
- the layout doesn't properly reset at times (eg. the delegate height doesn't 
update) or fails to show certain items (also looks like a Qt bug)
- sometimes the delegates suddenly overlap each other beacuse the section thing 
gets confused when the one item is already gone in the model (looks like a Qt 
bug)
- the "no devices" heading doesn't know that there's still a pseudo-device there
- it cannot actually highlight the device that was safely removed (it's no 
longer part of the model and thus has no index), we could do a hack for this 
though
- the message doesn't disappear reliably or spontaneously re-appears
- depending on your screen dpi you sometimes get a black and white Info icon 
but the error thing is always red, there's a smaller variant for the former but 
not the latter apparently, also it seems we lack a proper "task done" icon, 
Oxygen had one


File Attachments


Failed to mount
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
Safely remove
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-09 Thread Thomas Pfeiffer

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review90823
---


Nice idea!
I'd set the dely until the popup closes again shorter, though. This is just a 
feedback message that things happened as expected, so throwing the popup in the 
user's face for five seconds is too much distraction in that case (especially 
as nothing bad happens if the user misses the feedback). I'd just use the 
standard notification delay (or is that five seconds?). When unmounting failed, 
however, it should stay for five seconds because it's important that the user 
knows that the should not unplug the device.

- Thomas Pfeiffer


On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 9, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: KDE Discover binary & library names

2016-01-09 Thread Ivan Čukić
We are heading towards the Plasma Software Compilation :)

One benefit of using Plasma 'everywhere' is that people will start
seeing the name Plasma more often and maybe speed up the
KDE-as-in-desktop -> Plasma transition.

> if you were running a Gnome or other desktop variant of your distro

Yes, this is one of the definitions that I'm considering valid (with
the second one being 'plasma is only plasma shell and plasma
library').

The problem is that it is not easy to decide whether it fits - there
will always be at least one non-plasma user who uses an application
from our community (something like this was posted as an argument for
spectacle not being called something generic like plasma-screenshot or
similar). Objectively, how many non-plasma users use dolphin,
spectacle, ktp, etc.?

BTW, did anyone make an inquiry about whether the discover might be
useful to lxqt people?

Cheers,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-09 Thread Sebastian Kügler

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review90819
---


Very nice!

Gut feeling feedback:

- the error message's icon could take the place of the eject icon
- the "safely remove" icon could go away, text made italic (not sure if there's 
prior art in the HIG, I'm just imagining it would look less invasive)

- Sebastian Kügler


On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 9, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-09 Thread Thomas Pfeiffer


> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote:
> > Very nice!
> > 
> > Gut feeling feedback:
> > 
> > - the error message's icon could take the place of the eject icon
> > - the "safely remove" icon could go away, text made italic (not sure if 
> > there's prior art in the HIG, I'm just imagining it would look less 
> > invasive)
> 
> Kai Uwe Broulik wrote:
> Please no italic text. Another idea would be having an emblem on the 
> device icon, we indicate mounted vs not mounted, so we could show error / 
> success there as well/instead.

Using an emblem sounds reasonable, though we would have to test whether it's 
recognizeable at a glance.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review90819
---


On Jan. 9, 2016, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 9, 2016, 8:15 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-09 Thread Kai Uwe Broulik


> On Jan. 9, 2016, 9:24 nachm., Thomas Pfeiffer wrote:
> > Nice idea!
> > I'd set the dely until the popup closes again shorter, though. This is just 
> > a feedback message that things happened as expected, so throwing the popup 
> > in the user's face for five seconds is too much distraction in that case 
> > (especially as nothing bad happens if the user misses the feedback). I'd 
> > just use the standard notification delay (or is that five seconds?). When 
> > unmounting failed, however, it should stay for five seconds because it's 
> > important that the user knows that the should not unplug the device.

The 5 seconds are for when the dialog is already opened. It does not change the 
time until it auto-closes again, after which the message disappears anyway. I 
don't know that duration from the top of me head, though.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126688/#review90823
---


On Jan. 9, 2016, 8:15 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126688/
> ---
> 
> (Updated Jan. 9, 2016, 8:15 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Instead of showing a detached status bar with the device name, show the 
> message below the device.
> 
> When removing a device, device notifier will pop up and a "You can now safely 
> remove this device" message will show up; after 5 seconds the message and the 
> device will disappear. When trying to unmount a device and it fails, device 
> notifier will show up with an error message that will stay there until device 
> notifier is closed or another message appears.
> 
> This review consists of two patches: one for fixing the device notifications 
> engine's wording (I'm open to better verbalizations) and one for the device 
> notifier
> 
> 
> Diffs
> -
> 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1b3bb1b 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 9e9aa25 
>   applets/devicenotifier/package/contents/ui/StatusBar.qml ba827c3 
>   dataengines/devicenotifications/ksolidnotify.h fac8cc1 
>   dataengines/devicenotifications/ksolidnotify.cpp 3935ba3 
> 
> Diff: https://git.reviewboard.kde.org/r/126688/diff/
> 
> 
> Testing
> ---
> 
> There a still a couple of glitches:
> - the layout doesn't properly reset at times (eg. the delegate height doesn't 
> update) or fails to show certain items (also looks like a Qt bug)
> - sometimes the delegates suddenly overlap each other beacuse the section 
> thing gets confused when the one item is already gone in the model (looks 
> like a Qt bug)
> - the "no devices" heading doesn't know that there's still a pseudo-device 
> there
> - it cannot actually highlight the device that was safely removed (it's no 
> longer part of the model and thus has no index), we could do a hack for this 
> though
> - the message doesn't disappear reliably or spontaneously re-appears
> - depending on your screen dpi you sometimes get a black and white Info icon 
> but the error thing is always red, there's a smaller variant for the former 
> but not the latter apparently, also it seems we lack a proper "task done" 
> icon, Oxygen had one
> 
> 
> File Attachments
> 
> 
> Failed to mount
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/8e7142b2-38a9-4867-a067-0e6cdbcaa076__devicenotifierinlinefeedback1.png
> Safely remove
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/09/a43199cf-36a3-4337-9843-cb7375462c57__devicenotifierinlinefeedback2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126356: change minimum size of clipboard

2016-01-09 Thread andreas kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126356/
---

(Updated Jan. 9, 2016, 9:49 p.m.)


Review request for Plasma.


Changes
---

ok as david say the minimum usefull size I change the minimum size to the 
minimum useful now it clould be used also in the sidebar


Repository: plasma-workspace


Description
---

if you use clipboard on the desktop the minimum window height is heigher than 
you use clipboard from the panel (drop down window). As the user can define the 
width and height for the desktop plasmoid the minimum allowed height should be 
at least the same than the drop down window in the panel. so I change the 
minimumHeig to 16.


Diffs (updated)
-

  applets/clipboard/contents/ui/clipboard.qml 97230c1 

Diff: https://git.reviewboard.kde.org/r/126356/diff/


Testing
---


File Attachments


old before with 26 min height
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/cdc4e222-a954-4f92-816f-521f35aab7c7__clipboard-alt_.png
new after with 16 min height
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/50773744-a980-4091-8ef2-7eec516cb597__clipboard-new_.png


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 40 - Still Failing!

2016-01-09 Thread no-reply

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 09 Jan 2016 13:12:34 +
Build duration: 4 min 1 sec

CHANGE SET
Revision 69d7f7480a7af52960b5cab638c5a564a01fc7e4 by scripty: (SVN_SILENT made 
messages (.desktop file))
  change: edit xembed-sni-proxy/xembedsniproxy.desktop
  change: edit applets/systemmonitor/diskusage/metadata.desktop
  change: edit applets/systemmonitor/diskactivity/metadata.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126673: [Device Notifer] Rewrite delegates to use Layouts

2016-01-09 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126673/
---

(Updated Jan. 9, 2016, 4:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 9cc524e554b5fc449748e1e36fb33323757c37c3 by Kai Uwe 
Broulik to branch master.


Repository: plasma-workspace


Description
---

The code is from 2011/2012 before we had smart layouts and thus is pretty 
complicated with a lot of anchoring, this cleans up the code massively.

The layout layout is a bit tighter now, the eject/mount button is now a proper 
ToolButton. The "n actions for this device" text disappears when the actions 
are expanded, as you can now see the actions. Appearance/disappearance of the 
disk usage bar is now nicely animated, the lagging behind hover effect has been 
removed, however.

Also VDG: I need an action icon for "mount" (and possible for "unmount" as well)


Diffs
-

  applets/devicenotifier/package/contents/ui/ActionItem.qml e5ec90d 
  applets/devicenotifier/package/contents/ui/DeviceItem.qml 1a07c3f 
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml 48546f1 

Diff: https://git.reviewboard.kde.org/r/126673/diff/


Testing
---

I have the feeling the busy indicator doesn't show anymore and that the "expand 
newly inserted device automatically" also no longer works.

Also, IconItem doesn't like when its opacity isn't 1 (Bug 355894) and I get 
strange glowing when the actions list expands.

Next step will be improving the status bar by providing in-line feedback (ie. 
you click unmount on your USB stick and your USB stick gets a warning icon with 
a message, instead of this detached status bar at the bottom)


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/7e128987-b7c5-4f89-a418-b9c520e9ed47__devicenotifierreviewold.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/2df5974a-bc4d-4819-9860-4fe82eb8d0c8__devicenotifierreviewnew1.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 126687: [DataModel] Don't reset model when source is removed

2016-01-09 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126687/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

This allows me to track removing items from a list


Diffs
-

  src/declarativeimports/core/datamodel.cpp 4449f30 

Diff: https://git.reviewboard.kde.org/r/126687/diff/


Testing
---

I now get ListView.onRemove in device notifier. Tests still pass. I have no 
idea if this approach is correct, however.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[Powerdevil] [Bug 337674] kded5 is eating CPU

2016-01-09 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674

--- Comment #84 from mif...@gmail.com ---
Created attachment 96551
  --> https://bugs.kde.org/attachment.cgi?id=96551=edit
screenshot

Well, now it eats ~40% with same bt. And here still only one kded5 process.
I no have any ideas what's going on...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 126689: Change minimum Size of Calendar

2016-01-09 Thread andreas kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126689/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

it's the minimum usefull size for the calendar applet on the desktop

https://git.reviewboard.kde.org/r/126356/


Diffs
-

  applets/calendar/contents/ui/main.qml 863a6f3 

Diff: https://git.reviewboard.kde.org/r/126689/diff/


Testing
---


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126689: Change minimum Size of Calendar

2016-01-09 Thread andreas kainz

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126689/
---

(Updated Jan. 10, 2016, 12:14 a.m.)


Review request for Plasma.


Changes
---

it's the same min size as clipboard and could be used in a sidebar too.


Repository: plasma-workspace


Description
---

it's the minimum usefull size for the calendar applet on the desktop

https://git.reviewboard.kde.org/r/126356/


Diffs
-

  applets/calendar/contents/ui/main.qml 863a6f3 

Diff: https://git.reviewboard.kde.org/r/126689/diff/


Testing
---


File Attachments (updated)


calendar min
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/94ccc241-fc5d-4987-afd4-9139ab0d45d7__calendarMinimumSize.png


Thanks,

andreas kainz

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-01-09 Thread Dāvis Mosāns

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126691/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Add DBusMenuShortcut type overload for QDBusArgument.
I don't know if there's a better way to fix this than this kinda code 
duplication.


This is needed because otherwise it wouldn't compile with latest Qt dev branch. 
It's probably because QList overload was removed in 
http://code.qt.io/cgit/qt/qtbase.git/commit/src/dbus/qdbusargument.h?h=dev=5f542f3cca13f2da58b82aee2efbaffefeee00a7

and Container doesn't work...

/usr/include/QtDBus/qdbusargument.h:244:29: note: candidate: 
template