Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126980/ --- (Updated Feb. 4, 2016, 12:46 p.m.) Review request for kwin and Plasma.

Re: KActivities split, 2nd phase

2016-02-04 Thread Ivan Čukić
I have a cunning plan. It is as cunning as a fox what used to be a Professor of Cunning at Oxford University but has moved on and is now working for the U.N. at the High Commission of International Cunning Planning. As previously mentioned, the problem is that someone who upgrades the framework

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin
> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote: > > effects/backgroundcontrast/contrast.cpp, line 383 > > > > > > This looks fishy - and QTransform a tiny bit clumsy. > > > > Does this work: > >

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/#review92054 ---

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-02-04 Thread Sebastian Kügler via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 Sebastian Kügler changed: What|Removed |Added Summary|laptop won't hybrid-suspend |laptop won't hybrid-suspend

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Marco Martin
> On Feb. 4, 2016, 12:37 p.m., Anthony Fieroni wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22 > > > > > > Make duration depend on animation speed config, pls. > > Below

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 54 - Still Failing!

2016-02-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 Feb 2016 10:57:05 + Build duration: 1 min 43 sec CHANGE SET Revision

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Marco Martin
> On Feb. 4, 2016, 6:52 a.m., Luca Beltrame wrote: > > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see > > get in once all the issues have been addressed. Family members are > > depending upon it. ;) > > Lars Pontoppidan wrote: > Hi Luca, I'm working through

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin
> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote: > > effects/backgroundcontrast/contrast.cpp, line 383 > > > > > > This looks fishy - and QTransform a tiny bit clumsy. > > > > Does this work: > >

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Marco Martin
> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote: > > effects/backgroundcontrast/contrast.cpp, line 383 > > > > > > This looks fishy - and QTransform a tiny bit clumsy. > > > > Does this work: > >

Re: Review Request 126980: Scale blurbehind and backgroundcontrast besides translating

2016-02-04 Thread Thomas Lübking
> On Feb. 3, 2016, 9:43 p.m., Thomas Lübking wrote: > > effects/backgroundcontrast/contrast.cpp, line 383 > > > > > > This looks fishy - and QTransform a tiny bit clumsy. > > > > Does this work: > >

[Differential] [Request, 13 lines] D908: [Baloo Runner] Add mime data to matches

2016-02-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, vhanda. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Allows to drag and drop around found files.

Re: Review Request 124397: Add today button to calendar

2016-02-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review92067 --- And sorry for keeping you hanging there for so long :) -

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik
> On Feb. 2, 2016, 12:37 vorm., Andrew Lake wrote: > > Nice improvement. If the week numbers look ok then +1 from me. I need some inspiration for how to align the week names, though. The more I look at it now the better I like it. I tried vertically centering them but that looks awful. On the

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik
> On Feb. 4, 2016, 11:24 nachm., Heiko Tietze wrote: > > File Attachment: How about this? #2 - How about this? #2 > > > > > > Bug 299174 - Remove "week number" from system tray calendar for > > improved readability > > > >

Re: Review Request 126952: Set layout in kickoff config properly

2016-02-04 Thread David Edmundson
> On Feb. 2, 2016, 9:29 a.m., Marco Martin wrote: > > applets/kickoff/package/contents/ui/ConfigGeneral.qml, line 39 > > > > > > maybe look and feel package? right, but all I'm changing here is the indentation

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/ --- (Updated Feb. 4, 2016, 11:19 nachm.) Review request for Plasma and KDE

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review92070 --- Ship it! Ship It! - Andreas Kainz On Feb. 4, 2016,

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review92071 --- File Attachment: How about this? #2 - How about this? #2

Re: QWeakPointer error in DrKonqi

2016-02-04 Thread Aleix Pol
On Thu, Feb 4, 2016 at 7:19 PM, René J.V. wrote: > Hi, > > Is DrKonqi under active maintenance? I'm in the process of getting it (and a > few select other things from plasma-workspace) to build on OS X and I'm > seeing errors that should have nothing to do with "Plasma

Re: Review Request 126960: [Calendar] Add proper back/forward buttons and a "Today" button

2016-02-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126960/#review92073 --- This diff doesn't seem to have the week days row changes? -

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Marco Martin
> On Feb. 4, 2016, 12:37 p.m., Anthony Fieroni wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22 > > > > > > Make duration depend on animation speed config, pls. > > Below

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek
> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. I was

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-04 Thread Martin Gräßlin
> On Feb. 4, 2016, 1:37 p.m., Anthony Fieroni wrote: > > effects/morphingpopups/package/contents/code/morphingpopups.js, line 22 > > > > > > Make duration depend on animation speed config, pls. > > Below

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124576/#review92059 --- FYI, This may not entirely work as

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson
> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. > >

[Differential] [Request, 2 lines] D902: [DesktopView] Allow Shift modifier for triggering KRunner

2016-02-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY We were rejecting all key presses that had modifier in

[Differential] [Accepted] D901: [KRunner] Use time-based sorting rather than length for auto-completion

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. Well that was easy :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D901 EMAIL PREFERENCES

[Differential] [Accepted] D902: [DesktopView] Allow Shift modifier for triggering KRunner

2016-02-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 128 lines] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 updated this revision to Diff 2192. mck182 added a comment. Keep the MouseArea visible always as it pushes the action buttons to the side REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D899?vs=2190=2192 BRANCH

[Differential] [Closed] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4819282d329f: [notifications] Make the text selectable in the popup too (authored by mck182). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mklapetek/selectableTextInNotifications REVISION DETAIL https://phabricator.kde.org/D899 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 55 - Still Failing!

2016-02-04 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 04 Feb 2016 17:12:17 + Build duration: 1 min 45 sec CHANGE SET Revision

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson
> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows ack, there's a new message that we're not catching. I don't know what the string is though. - David

Re: libkscreen bugs on Plasma 4

2016-02-04 Thread Sebastian Kügler
On Tuesday, February 02, 2016 03:01:40 PM Sebastian Kügler wrote: > When going over the list of libkscreen bugs, there are some reported against > Plasma 4. I'm planning to close them as Plasma 4 is unmaintained, and it > would be dishonest to let people think that we're actually working on it.

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread Martin Gräßlin
> On Feb. 4, 2016, 3:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. > >

Re: Review Request 124576: Show a dialog if Plasma failed to create an OpenGL Context

2016-02-04 Thread David Edmundson
> On Feb. 4, 2016, 2:26 p.m., Martin Klapetek wrote: > > FYI, This may not entirely work as > > https://bugs.kde.org/show_bug.cgi?id=358869 shows > > David Edmundson wrote: > ack, there's a new message that we're not catching. > > I don't know what the string is though. > >

[Differential] [Request, 128 lines] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This simplifies the component by removing the Loader-property combo and leaves just a read-only TextEdit BUG: 358981 REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Updated] D899: [notifications] Make the text selectable in the popup too

2016-02-04 Thread mck182 (Martin Klapetek)
mck182 added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D899 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mck182, Plasma Cc: plasma-devel

[Differential] [Request, 24 lines] D901: [KRunner] Use time-based sorting rather than length for auto-completion

2016-02-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This makes more recently typed queries take

QWeakPointer error in DrKonqi

2016-02-04 Thread René J . V . Bertin
Hi, Is DrKonqi under active maintenance? I'm in the process of getting it (and a few select other things from plasma-workspace) to build on OS X and I'm seeing errors that should have nothing to do with "Plasma isn't supposed to work here" : 1) an error initialising a QWeakPointer from a

[Differential] [Request, 23 lines] D904: [Baloo Runner] Allow opening parent folder

2016-02-04 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, vhanda. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This allows opening the folder a file is

[Differential] [Updated] D904: [Baloo Runner] Allow opening parent folder

2016-02-04 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D904 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, vhanda Cc: plasma-devel

Re: Review Request 124397: Add today button to calendar

2016-02-04 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Feb. 4, 2016, 8:30 nachm.) Status -- This change has been

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Luca Beltrame
> On Feb. 4, 2016, 7:52 a.m., Luca Beltrame wrote: > > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see > > get in once all the issues have been addressed. Family members are > > depending upon it. ;) > > Lars Pontoppidan wrote: > Hi Luca, I'm working through

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-02-04 Thread Lars Pontoppidan
> On Feb. 4, 2016, 6:52 a.m., Luca Beltrame wrote: > > Ping? Feature freeze is in ~1 month or so (March 3rd) and I'd like to see > > get in once all the issues have been addressed. Family members are > > depending upon it. ;) Hi Luca, I'm working through Kai's list - and have a good few fixes