[Differential] [Updated] D947: Fix path of kcheckpass when pass to chown

[Martin Gräßlin]

graesslin added a comment.


  are you installing to $HOME with root? Because I think it fails as you are 
not allowed to chown to root.
  
  Anyway another option could be to just scratch that command as it's no longer 
needed on modern distros.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D947

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

[Dominik Haumann]

> On Feb. 15, 2016, 9:15 p.m., David Edmundson wrote:
> > Ship It!

David: Can you cherry-pick 71eb4801d1f2771915ae49b0423eef1f6aecf6e1 to older 
branches as required? Would be awesome!


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127083/#review92416
---


On Feb. 15, 2016, 9:07 p.m., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127083/
> ---
> 
> (Updated Feb. 15, 2016, 9:07 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Bugs: 357699
> http://bugs.kde.org/show_bug.cgi?id=357699
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Instead of showing an empty popup when clicking on the DiskQuota applet, this 
> patch changes shows a label saying "No quota restrictions found." This is in 
> line with with the tool tip, so even no new i18n string is added.
> 
> This also fixes part of bug #357699 (the icon is still missing, for whatever 
> reason, I can reproduce that on openSUSE Leap 42.1).
> 
> 
> Diffs
> -
> 
>   applets/diskquota/package/contents/ui/main.qml c749c8b 
> 
> Diff: https://git.reviewboard.kde.org/r/127083/diff/
> 
> 
> Testing
> ---
> 
> Compiles and works as expected, tested with plasma development version.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

[Dominik Haumann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127083/
---

(Updated Feb. 15, 2016, 9:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Kai Uwe Broulik.


Bugs: 357699
http://bugs.kde.org/show_bug.cgi?id=357699


Repository: kdeplasma-addons


Description
---

Instead of showing an empty popup when clicking on the DiskQuota applet, this 
patch changes shows a label saying "No quota restrictions found." This is in 
line with with the tool tip, so even no new i18n string is added.

This also fixes part of bug #357699 (the icon is still missing, for whatever 
reason, I can reproduce that on openSUSE Leap 42.1).


Diffs
-

  applets/diskquota/package/contents/ui/main.qml c749c8b 

Diff: https://git.reviewboard.kde.org/r/127083/diff/


Testing
---

Compiles and works as expected, tested with plasma development version.


Thanks,

Dominik Haumann

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127083/#review92416
---


Ship it!




Ship It!

- David Edmundson


On Feb. 15, 2016, 9:07 p.m., Dominik Haumann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127083/
> ---
> 
> (Updated Feb. 15, 2016, 9:07 p.m.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Bugs: 357699
> http://bugs.kde.org/show_bug.cgi?id=357699
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> ---
> 
> Instead of showing an empty popup when clicking on the DiskQuota applet, this 
> patch changes shows a label saying "No quota restrictions found." This is in 
> line with with the tool tip, so even no new i18n string is added.
> 
> This also fixes part of bug #357699 (the icon is still missing, for whatever 
> reason, I can reproduce that on openSUSE Leap 42.1).
> 
> 
> Diffs
> -
> 
>   applets/diskquota/package/contents/ui/main.qml c749c8b 
> 
> Diff: https://git.reviewboard.kde.org/r/127083/diff/
> 
> 
> Testing
> ---
> 
> Compiles and works as expected, tested with plasma development version.
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127083: Disk Quota: "No quota restrictions found." instead of empty space

[Dominik Haumann]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127083/
---

Review request for Plasma and Kai Uwe Broulik.


Bugs: 357699
http://bugs.kde.org/show_bug.cgi?id=357699


Repository: kdeplasma-addons


Description
---

Instead of showing an empty popup when clicking on the DiskQuota applet, this 
patch changes shows a label saying "No quota restrictions found." This is in 
line with with the tool tip, so even no new i18n string is added.

This also fixes part of bug #357699 (the icon is still missing, for whatever 
reason, I can reproduce that on openSUSE Leap 42.1).


Diffs
-

  applets/diskquota/package/contents/ui/main.qml c749c8b 

Diff: https://git.reviewboard.kde.org/r/127083/diff/


Testing
---

Compiles and works as expected, tested with plasma development version.


Thanks,

Dominik Haumann

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 3 lines] D951: PanelShadow: Don't remove shadows from destroyed windows

[drosca (David Rosca)]

drosca created this revision.
drosca added reviewers: Plasma, graesslin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  If the window's platform surface was destroyed, there is also
  no shadow to be removed.
  Both X and Wayland code will try to create the platform surface
  again, and it will lead to crash in other code that doesn't expect
  platform surface to be created when the containment is being deleted.
  
  This fixes crash in PanelConfigView::event when removing panels.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  panel-crash

REVISION DETAIL
  https://phabricator.kde.org/D951

AFFECTED FILES
  shell/panelshadows.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Disk Quota Applet: Icon sizes

[Dominik Haumann]

Hi all,

the disk quota applet's icons are still too big, see
http://i.imgur.com/cBVPXuu.png

At Akademy 2015, I was asking some developers what do do about it,
but noone could give me hint.

Since these icons are *really* too big, I think we should do something about
it at least now.

Obviously the margin of these icons is wrong. Do I need to adapt the SVGs
somehow? All icons live in one svg file with different IDs.

Any hint would be very much appreciated!

Cheers,
Dominik
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 1 line] D950: Fix size of drop placeholder after moving larger applet

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  placeHolder.syncWithItem() sets minimumWidth/minimumHeight when
  moving applets, so we must clear it when using placeholder for
  drop indicator.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  placeholder-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D950

AFFECTED FILES
  containments/desktop/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 51 lines] D948: Don't show applet handle outside of desktop

[drosca (David Rosca)]

drosca updated this revision to Diff 2311.
drosca added a comment.


  x, y coords should be bound by available rect size

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D948?vs=2309=2311

BRANCH
  handle-position (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D948

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127075/
---

(Updated Feb. 15, 2016, 6:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 4d012a8cc51ef32f5b85070747a51706ba82606e by David Rosca 
to branch master.


Repository: plasma-framework


Description
---

Desktop containment will match every valid pos, so we should return it only if 
nothing else matches.


Diffs
-

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 2acf680 

Diff: https://git.reviewboard.kde.org/r/127075/diff/


Testing
---

Added few panels, can now move applets from desktop to every panel (not just 
the first).


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127072/
---

(Updated Feb. 15, 2016, 6:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit 1e196fdfb2a6eaf1664e1155c086616d55c6712b by David Rosca 
to branch master.


Bugs: 357895
http://bugs.kde.org/show_bug.cgi?id=357895


Repository: plasma-framework


Description
---

BUG: 357895


Diffs
-

  src/declarativeimports/core/windowthumbnail.cpp 21e655e 

Diff: https://git.reviewboard.kde.org/r/127072/diff/


Testing
---

No more crash


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

[David Rosca]

> On Feb. 15, 2016, 5:58 p.m., Kai Uwe Broulik wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 273
> > 
> >
> > Q_NULLPTR in Frameworks

Fixed in push


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127075/#review92412
---


On Feb. 15, 2016, 6:10 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127075/
> ---
> 
> (Updated Feb. 15, 2016, 6:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Desktop containment will match every valid pos, so we should return it only 
> if nothing else matches.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 2acf680 
> 
> Diff: https://git.reviewboard.kde.org/r/127075/diff/
> 
> 
> Testing
> ---
> 
> Added few panels, can now move applets from desktop to every panel (not just 
> the first).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D948: Don't show applet handle outside of desktop

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  handle-position (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D948

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127075/#review92412
---




src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 273)


Q_NULLPTR in Frameworks


- Kai Uwe Broulik


On Feb. 14, 2016, 6:06 nachm., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127075/
> ---
> 
> (Updated Feb. 14, 2016, 6:06 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Desktop containment will match every valid pos, so we should return it only 
> if nothing else matches.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 2acf680 
> 
> Diff: https://git.reviewboard.kde.org/r/127075/diff/
> 
> 
> Testing
> ---
> 
> Added few panels, can now move applets from desktop to every panel (not just 
> the first).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127079: fix uninitialised var

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/#review92411
---




src/declarativeimports/platformcomponents/application_p.h (line 35)


We can't do this in Frameworks


- Kai Uwe Broulik


On Feb. 15, 2016, 5:23 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127079/
> ---
> 
> (Updated Feb. 15, 2016, 5:23 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Valgrind pointed this out whilst debugging something else.
> 
> (though I'm not sure what on the desktop creates an Application object)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/platformcomponents/application_p.h 
> 8e690928c2a4a0d3da983cb385e50e0e9e9d66e9 
> 
> Diff: https://git.reviewboard.kde.org/r/127079/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 51 lines] D948: Don't show applet handle outside of desktop

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  This makes sure the applet handle won't be displayed outside
  of available desktop area (under panels or outside of screen).
  
  BUG: 353992

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  handle-position (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D948

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml
  containments/desktop/package/contents/ui/AppletHandle.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127079: fix uninitialised var

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Valgrind pointed this out whilst debugging something else.

(though I'm not sure what on the desktop creates an Application object)


Diffs
-

  src/declarativeimports/platformcomponents/application_p.h 
8e690928c2a4a0d3da983cb385e50e0e9e9d66e9 

Diff: https://git.reviewboard.kde.org/r/127079/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

[David Rosca]

> On Feb. 15, 2016, 4:29 p.m., David Edmundson wrote:
> > src/plasmaquick/appletquickitem.cpp, line 736
> > 
> >
> > if that's the case, filter on event->child()->metaObject.className()
> > 
> > rather than creating a new event for every single child

Unfortunately that doesn't work, it just shows as QObject.

>From doc:
>QEvent::ChildAdded and QEvent::ChildRemoved events are sent to objects when 
>children are added or removed. In both cases you can only rely on the child 
>being a QObject, or if isWidgetType() returns true, a QWidget. (This is 
>because, in the ChildAdded case, the child is not yet fully constructed, and 
>in the ChildRemoved case it might have been destructed already).


If the applet has attached Layout, it is generally the first and only child 
that will get through the conditionals and actually creates the timer.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92406
---


On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> ---
> 
> (Updated Feb. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
> http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> ---
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, 
> though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 2 lines] D947: Fix path of kcheckpass when pass to chown

[kfunk (Kevin Funk)]

kfunk updated this revision to Diff 2307.
kfunk added a comment.


  Fix message

REPOSITORY
  rKSCREENLOCKER KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D947?vs=2306=2307

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D947

AFFECTED FILES
  kcheckpass/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127075/#review92410
---


Ship it!




Ship It!

- Marco Martin


On Feb. 14, 2016, 6:06 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127075/
> ---
> 
> (Updated Feb. 14, 2016, 6:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Desktop containment will match every valid pos, so we should return it only 
> if nothing else matches.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 2acf680 
> 
> Diff: https://git.reviewboard.kde.org/r/127075/diff/
> 
> 
> Testing
> ---
> 
> Added few panels, can now move applets from desktop to every panel (not just 
> the first).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D947: Fix path of kcheckpass when pass to chown

[kfunk (Kevin Funk)]

kfunk added a reviewer: graesslin.

REPOSITORY
  rKSCREENLOCKER KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D947

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, graesslin
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 2 lines] D947: Fix path of kcheckpass when pass to chown

[kfunk (Kevin Funk)]

kfunk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  Now this still fails for me when installing kscreenlocker to $HOME:
  
chown: changing ownership of
  
  ‘/home/kfunk/devel/install/kf5/lib/x86_64-linux-gnu/libexec/kcheckpass’:
  Operation not permitted

REPOSITORY
  rKSCREENLOCKER KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D947

AFFECTED FILES
  kcheckpass/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127075: Prefer other containments than desktop in containmentAt()

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127075/#review92407
---


Ship it!




Ship It!

- David Edmundson


On Feb. 14, 2016, 6:06 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127075/
> ---
> 
> (Updated Feb. 14, 2016, 6:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Desktop containment will match every valid pos, so we should return it only 
> if nothing else matches.
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 2acf680 
> 
> Diff: https://git.reviewboard.kde.org/r/127075/diff/
> 
> 
> Testing
> ---
> 
> Added few panels, can now move applets from desktop to every panel (not just 
> the first).
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92406
---




src/plasmaquick/appletquickitem.cpp (line 736)


if that's the case, filter on event->child()->metaObject.className()

rather than creating a new event for every single child


- David Edmundson


On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> ---
> 
> (Updated Feb. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
> http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> ---
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, 
> though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] [RFC] make handles obscure less of the screen behind them

[Marco Martin]

On Sunday 14 February 2016, Dirk Hohndel wrote:
> I don't think this is the right way to do this. The patch below is the
> hack that I used for the last few Subsurface-mobile alpha builds to give
> people the idea that the handles really shouldn't be so visually dominant.
> 
> So the background is even more transparent and instead of filling the path
> we just stroke it.

i pushed it, but I altered the graphics a bit.

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] make context drawer smaller

[Marco Martin]

On Monday 15 February 2016, Sebastian Kügler wrote:
> > I would keep this very big, but on the other hand since it's only an
> > "hint",  make sire the final overlay is never ~70/80% of the screen width
> 
> I think limiting it to, say, 70% of the root item would make sense. I've
> fixed this thing in both ways already (and it's still not making us really
> happy).

in the end i went for the 70% route

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repo freeze on Thursday

[Ivan Čukić]

> We'd best release it then, the final will be after 5.20 is out and distros 
> will
> expect it to work with 5.20.

We will also need to make a -1 release for it - if somebody updates
frameworks to 20 before 5.6 is released.

Before I send the group list, what do you think is the best way (with
your packager hat on) to handle moving of the kio, kcm, fileitem
plugin from the kactivities repo into plasma-workspace, kio-extras...

I was thinking to make a single transition release (these three are
currently in a scratch repository - was agreed with Ben that there is
no need to create a proper repository that would exist only until 5.6)
for the period between when the user upgrades to kf 5.20 and before
the upgrade to plasma 5.6.

Cheers,
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127072/#review92400
---


Ship it!




Ship It!

- Martin Gräßlin


On Feb. 14, 2016, 12:23 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127072/
> ---
> 
> (Updated Feb. 14, 2016, 12:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357895
> http://bugs.kde.org/show_bug.cgi?id=357895
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> BUG: 357895
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
> 
> Diff: https://git.reviewboard.kde.org/r/127072/diff/
> 
> 
> Testing
> ---
> 
> No more crash
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

[Martin Gräßlin]

> On Feb. 15, 2016, 8:11 a.m., Martin Gräßlin wrote:
> > do you know what exactly crashes if discard is not called? I just tried to 
> > read the code and also compare it to KWin's code to try to understand why 
> > it's needed. From all I can see I don't find a reason why it should crash. 
> > The pixmap should still be valid, etc. etc.
> > 
> > Comparing to KWin was tricky as it doesn't composite each window 
> > individually, but uses composite of root window. The only relatively 
> > related code is the fullscreen unredirection. And there interestingly on 
> > unredirection it doesn't call into discardPixmap().
> > 
> > If you don't know that fine and I'll give you shipit. I just wanted to 
> > understand ;-)
> 
> David Rosca wrote:
> Sorry, no idea at all. It crashes only with swrast_dri, so probably bug 
> there?

oh I never noticed in the bug reports that it's only swrast. Explains why I 
never hit it.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127072/#review92376
---


On Feb. 14, 2016, 12:23 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127072/
> ---
> 
> (Updated Feb. 14, 2016, 12:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357895
> http://bugs.kde.org/show_bug.cgi?id=357895
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> BUG: 357895
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
> 
> Diff: https://git.reviewboard.kde.org/r/127072/diff/
> 
> 
> Testing
> ---
> 
> No more crash
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repo freeze on Thursday

[Jonathan Riddell]

On Mon, Feb 15, 2016 at 01:05:23PM +0100, Ivan Čukić wrote:
> For 5.19, ti is not needed (it was split out of the kde:kactivities
> repository after 5.19 was tagged).
> 
> I'll send a mail to packagers, plasma and frameworks in a few hours
> explaining everything regarding the transition period.

We'd best release it then, the final will be after 5.20 is out and distros will 
expect it to work with 5.20.

> p.s. I've added to to be the KDE project manager

I feel the power!

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repo freeze on Thursday

[Ivan Čukić]

For 5.19, ti is not needed (it was split out of the kde:kactivities
repository after 5.19 was tagged).

I'll send a mail to packagers, plasma and frameworks in a few hours
explaining everything regarding the transition period.

Cheerio,
Ivan

p.s. I've added to to be the KDE project manager

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

ffmpegthumbs + ffmpeg 2.9

[Harald Sitter]

heya,

ffmpeg 2.9 sees the removal of previously deprecated API. since
ffmpegthumbs hasn't had a proper maintenance pass in a while this
needs quite a bit of porting for which there is a review request
already, but someone needs to do the review [1].
given ffmpeg's aggressive deprecation policies it probably would be
handy to have a maintainer for ffmpegthumbs who checks for
deprecations every once in a while to stay ahead of breakage and make
sure the thumbnailer is of adequate quality.

[1] https://git.reviewboard.kde.org/r/126992

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repo freeze on Thursday

[Jonathan Riddell]

On Mon, Feb 15, 2016 at 12:54:42PM +0100, Ivan Čukić wrote:
> Hi,
> 
> Against which version of frameworks will plasma 5.6 be released? If it
> will be released against 5.20, then we will need kde:kactivitymanagerd
> repository as well.

5.19 preferably, does that affect it?

Can you make me KDE project admin on that repository for release management 
foo? (setting l10n branches mostly.)

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repo freeze on Thursday

[Ivan Čukić]

Hi,

Against which version of frameworks will plasma 5.6 be released? If it
will be released against 5.20, then we will need kde:kactivitymanagerd
repository as well.

Cheerio,
Ivan

--
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key id: 850B6F76
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127071: ButtonStyle: Fix text alignment with minimumWidth

[David Rosca]

> On Feb. 14, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> > src/declarativeimports/plasmastyle/ButtonStyle.qml, line 83
> > 
> >
> > Looks bound to implode, I'd rather specify the minimumWith as a 
> > property, for every case.

That doesn't work as it creates binding loop, which makes the text alignment 
completely broken.

But maybe it would be better to add new property to Button, something like 
`resizeToContents` instead of using `implicitWidth: minimumWidth`.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127071/#review92366
---


On Feb. 13, 2016, 11:23 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127071/
> ---
> 
> (Updated Feb. 13, 2016, 11:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix text alignment with buttons that sets implicitWidth
> to minimumWidth.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
>   tests/components/button.qml a645537 
> 
> Diff: https://git.reviewboard.kde.org/r/127071/diff/
> 
> 
> Testing
> ---
> 
> Direct binding causes binding loop. I'm not really sure on the fix though as 
> it's quite ugly.
> 
> To reproduce the bug, press "-" in button test.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: repo freeze on Thursday

[Martin Graesslin]

On Monday, February 15, 2016 11:46:11 AM CET Jonathan Riddell wrote:
> The Plasma 5.6 repo freeze is on Thursday.  We can't add new git
> repositories to make tars after Thursday.  Does anyone have any git
> repositories that need added to this release which were not in 5.5?

new repo: https://phabricator.kde.org/diffusion/PLASMAINTEGRATION/

git clone git://anongit.kde.org/plasma-integration

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] make context drawer smaller

[Sebastian Kügler]

On Monday, February 15, 2016 12:00:00 PM Marco Martin wrote:
> On Sunday 14 February 2016, Dirk Hohndel wrote:
> > This is an odd one. Not sure what the logic was behind that, but with the
> > existing code on most phones the context drawer takes up the complete
> > screen which makes it look really weird.
> >
> > 
> 
> not sure about this, we had text in context drawer not fittin in the column
> in  the past.
> It should actually be based upon the length of the entries text, but it's
> not  really possible to know the actual size hints of a listview (almost
> leaning making it a repeater)
> 
> I would keep this very big, but on the other hand since it's only an
> "hint",  make sire the final overlay is never ~70/80% of the screen width

I think limiting it to, say, 70% of the root item would make sense. I've fixed 
this thing in both ways already (and it's still not making us really happy).
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

repo freeze on Thursday

[Jonathan Riddell]

The Plasma 5.6 repo freeze is on Thursday.  We can't add new git
repositories to make tars after Thursday.  Does anyone have any git
repositories that need added to this release which were not in 5.5?

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

[David Rosca]

> On Feb. 15, 2016, 7:11 a.m., Martin Gräßlin wrote:
> > do you know what exactly crashes if discard is not called? I just tried to 
> > read the code and also compare it to KWin's code to try to understand why 
> > it's needed. From all I can see I don't find a reason why it should crash. 
> > The pixmap should still be valid, etc. etc.
> > 
> > Comparing to KWin was tricky as it doesn't composite each window 
> > individually, but uses composite of root window. The only relatively 
> > related code is the fullscreen unredirection. And there interestingly on 
> > unredirection it doesn't call into discardPixmap().
> > 
> > If you don't know that fine and I'll give you shipit. I just wanted to 
> > understand ;-)

Sorry, no idea at all. It crashes only with swrast_dri, so probably bug there?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127072/#review92376
---


On Feb. 13, 2016, 11:23 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127072/
> ---
> 
> (Updated Feb. 13, 2016, 11:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357895
> http://bugs.kde.org/show_bug.cgi?id=357895
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> BUG: 357895
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 21e655e 
> 
> Diff: https://git.reviewboard.kde.org/r/127072/diff/
> 
> 
> Testing
> ---
> 
> No more crash
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Meeting

[Sebastian Kügler]

Minutes Plasma 'hangout', 15-2-2016, 12:00 CET

Present: sebas, mgraesslin, bshah, jensreuterberg, notmart, sitter, Riddell
Excused: kbroulik

PSA: Repo freeze for Plasma 5.6 is on Thursday!


kbroulik:
* KDevelop now shows compile progress in the task bar using Unity launcher API
* https://git.reviewboard.kde.org/r/127023/ ← "Support Origin Email subject/
sender/id", useful for KMail

mgraesslin:
* worked on input redirection
* fixing lots of quality issues and adding some new ones
* splitting into pointer, touch and keyboard related code

bshah:
* changed mobile image to xenial, with some issues:
  * sometimes /home gets mounted read-only

jensreuterberg:
* bit of communication drama around neon
* SDDM theme work

notmart:
* worked on plasma mobile components, compromise for big action button
* new systemtray: implemented more missing features:
* filtering by category,
* showing/hiding applets,
* keyboard shortcut assignment
* some stuff needs fixing still, then good to be tested
* did some bughunting
* tried to help with mobile image / multirom
* tooltip morphing animation ( https://git.reviewboard.kde.org/r/126968/ ) 
nearing completion with https://git.reviewboard.kde.org/r/126981/ in

Riddell:
* working on communication issues around neon
* not much else related to report

sebas:
* working on the kwin_wayland DRM backend for
* started on kscreen-doctor (cli tool to change screen settings, mainly for 
testing right now)



-- 
sebas

http://www.kde.org | http://vizZzion.org

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127024: Don't filter names if we have mimetypes

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/
---

(Updated Feb. 15, 2016, 12:37 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 415ad2ed48356c3065c937813888fa1bd2742789 by Aleix Pol to 
branch master.


Repository: frameworkintegration


Description
---

setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
entries, on the other hand setMimeFilter will do some nice things using the 
extra knowledge.


Diffs
-

  src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 

Diff: https://git.reviewboard.kde.org/r/127024/diff/


Testing
---

Tested it while porting okular.


Thanks,

Aleix Pol Gonzalez

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

[Anthony Fieroni]

> On Фев. 15, 2016, 12:06 след обяд, Marco Martin wrote:
> > src/plasmaquick/appletquickitem.cpp, line 55
> > 
> >
> > why splitting it in a separate method if you don't call it from 
> > anywhere else?
> 
> David Rosca wrote:
> Because d-pointer is accessed from `childEvent` which is called from 
> AppletQuickItemPrivate constructor (`qmlObject` parented to `q`), and at that 
> point `d` is dangling pointer.

David Rosca +1, this is why, when you see *this* in contructor initialization 
list aways can be dangerous :)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92387
---


On Фев. 14, 2016, 1:48 преди обяд, David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> ---
> 
> (Updated Фев. 14, 2016, 1:48 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
> http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> ---
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, 
> though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] make context drawer smaller

[Marco Martin]

On Sunday 14 February 2016, Dirk Hohndel wrote:
> This is an odd one. Not sure what the logic was behind that, but with the
> existing code on most phones the context drawer takes up the complete
> screen which makes it look really weird.
> 

not sure about this, we had text in context drawer not fittin in the column in 
the past.
It should actually be based upon the length of the entries text, but it's not 
really possible to know the actual size hints of a listview (almost leaning 
making it a repeater)

I would keep this very big, but on the other hand since it's only an "hint", 
make sire the final overlay is never ~70/80% of the screen width


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] Allow the app to filter the back key even at the top level

[Marco Martin]

On Sunday 14 February 2016, Dirk Hohndel wrote:
> The onBackRequested trick didn't work on the top level page. Which seems
> odd to me - why shouldn't an application be allowed to prevent the back
> key from exiting?

thanks, added. REgardless of the reasons should lways be possible to filter.

> Now imagine we want to allow the user to change credentials. Simple,
> right? Just go back to the other incarnation of that top page. But how do
> you change your mind and go back? Easy again. Hit the back button.

yeah, looks weird, could probably be worth to separe the credential page as a 
separate thing, that can then be accessed by the general menu

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92387
---


Fix it, then Ship it!




fine with an issue


src/plasmaquick/appletquickitem.cpp (line 55)


why splitting it in a separate method if you don't call it from anywhere 
else?


- Marco Martin


On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> ---
> 
> (Updated Feb. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
> http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> ---
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, 
> though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

[Marco Martin]

> On Feb. 13, 2016, 11:33 p.m., Kai Uwe Broulik wrote:
> > src/plasmaquick/appletquickitem.h, line 149
> > 
> >
> > This looks binary incompatible.
> > 
> > Also, add Q_DECL_OVERRIDE
> 
> David Rosca wrote:
> Looks fine to me (according to policies on techbase), besides this is not 
> public header.

I'm not installing those headers (probably going to change) but we have to keep 
them BC anyways.
what is doing is reimplmenting an already existing virtual.
from the techbase page:

"As already explained, you can safely reimplement a virtual function defined in 
one of the base classes only if it is safe that the programs linked with the 
prior version call the implementation in the base class rather than the derived 
one."

so "should" be fine?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127073/#review92328
---


On Feb. 13, 2016, 11:48 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127073/
> ---
> 
> (Updated Feb. 13, 2016, 11:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 358849
> http://bugs.kde.org/show_bug.cgi?id=358849
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Regression from 344dbeb938
> 
> BUG: 358849
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/appletquickitem.h 1e0174a 
>   src/plasmaquick/appletquickitem.cpp 28f1eb5 
>   src/plasmaquick/private/appletquickitem_p.h 1f99d2f 
> 
> Diff: https://git.reviewboard.kde.org/r/127073/diff/
> 
> 
> Testing
> ---
> 
> Fixed for example plasmoid from bug.
> Would be better if there was a way to fix it without adding another timer, 
> though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126775: Use KDE_INSTALL_DATADIR to install lookandfeel directory

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126775/
---

(Updated Feb. 15, 2016, 10:07 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit c5ec6a8d72e4332b1cdf24d44cf33fb0e09dbc0f by Heiko Becker 
to branch Plasma/5.5.


Repository: oxygen


Description
---

It was previously hard-coded to prefix/share which is not helpful on a
multiarch layout, where the prefix might be something like /usr/${arch}
but arch independent files should still go into /usr/share.


Diffs
-

  CMakeLists.txt 94c18de497b9f670f88be4d908b0d64e13a2a876 

Diff: https://git.reviewboard.kde.org/r/126775/diff/


Testing
---

Files are installed to the desired location.


Thanks,

Heiko Becker

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127024: Don't filter names if we have mimetypes

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127024/#review92384
---


Ship it!




Ship It!

- David Faure


On Feb. 14, 2016, 11:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127024/
> ---
> 
> (Updated Feb. 14, 2016, 11:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> setMimeTypeFilters will call setNameFilter anyway, so we're not missing any 
> entries, on the other hand setMimeFilter will do some nice things using the 
> extra knowledge.
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 11e7efb 
> 
> Diff: https://git.reviewboard.kde.org/r/127024/diff/
> 
> 
> Testing
> ---
> 
> Tested it while porting okular.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel