Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

> On May 6, 2016, 2:09 p.m., Hugo Pereira Da Costa wrote: > > Thanks ! > > I tested it here. Looks fine. > > Although the diff is hard to read, new code looks good. > > > > Hugo PS: since oxygen does a lot of caching, there actually are many other places also affected by the coverty report.

Re: Review Request 127848: Revert "Don't import an nonexistent layout"

> On May 6, 2016, 5:39 p.m., Aleix Pol Gonzalez wrote: > > I understand it's a bit complex, but it's also not really acceptable that > > the signal is emitted twice. Let me try to come up with an alternative. > > David Rosca wrote: > Sure, no problem. When running plasmashell from terminal

Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/ --- Review request for KDE Frameworks, Plasma and David Rosca. Bugs: 60777

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

> On May 6, 2016, 6:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 No, it's already called by `ShellCorona::loadDefaultLayout()`. - Aleix

Re: Proposal: kde-libs.org, a repository of contributed libraries

On Tue May 3 01:04:03 UTC 2016, David Edmundson wrote: > The code is a thin wrapper round TextMetrics but has a fallback that makes > it usable on <= Qt 5.4 using the hidden Text item hack that we used to use > in the DigitalClock plasmoid I didn't know the digital clock used the same idea. I'm

Re: Proposal: kde-libs.org, a repository of contributed libraries

On Mon May 2 23:20:00 UTC 2016, Aleix Pol wrote: > > I didn't know https://inqlude.org/ . Some things I see: > > > > - It seems to be for big libraries, not for little, user-contributed > > libraries. > How is something good for big libraries but not for small? Well, of course it could be used

Re: Proposal: kde-libs.org, a repository of contributed libraries

On Tue May 3 00:59:23 UTC 2016, Martin Klapetek wrote: > What does it actually do? There is a similar thing in QML > called TextMetrics and FontMetrics btw, maybe they could > be of use to you. In fact "TextSize.qml" uses TextMetrics, if available, to get the real width and real height of a

Re: Review Request 127848: Revert "Don't import an nonexistent layout"

> On May 6, 2016, 5:39 p.m., Aleix Pol Gonzalez wrote: > > I understand it's a bit complex, but it's also not really acceptable that > > the signal is emitted twice. Let me try to come up with an alternative. > > David Rosca wrote: > Sure, no problem. When running plasmashell from terminal

[Differential] [Updated] D1549: allow distro version number to be overridden in config file

sitter added a comment. very lovely REPOSITORY rKINFOCENTER KInfoCenter REVISION DETAIL https://phabricator.kde.org/D1549 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, sitter Cc: plasma-devel, sebas

[Differential] [Request, 3 lines] D1549: allow distro version number to be overridden in config file

jriddell created this revision. jriddell added a reviewer: sitter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY allow distro version number to be overridden in config file TEST PLAN edit /etc/xdg/kcm-about-distrorc

Re: Review Request 127848: Revert "Don't import an nonexistent layout"

> On May 6, 2016, 3:39 p.m., Aleix Pol Gonzalez wrote: > > I understand it's a bit complex, but it's also not really acceptable that > > the signal is emitted twice. Let me try to come up with an alternative. Sure, no problem. When running plasmashell from terminal without any arguments, the

Re: Review Request 127848: Revert "Don't import an nonexistent layout"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127848/ --- (Updated May 6, 2016, 3:57 p.m.) Status -- This change has been

[Differential] [Closed] D1549: allow distro version number to be overridden in config file

This revision was automatically updated to reflect the committed changes. Closed by commit rKINFOCENTER650d00f5f4a1: allow distro version number to be overridden in config file (authored by jriddell). REPOSITORY rKINFOCENTER KInfoCenter CHANGES SINCE LAST UPDATE

[Differential] [Request, 237 lines] D1550: Move everything KCrash related from Application to ApplicationX11

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change ensures that kwin_wayland does not pull in KCrash. We don't want and need KCrash in the

Re: Review Request 127848: Revert "Don't import an nonexistent layout"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127848/#review95235 --- I understand it's a bit complex, but it's also not really

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95239 --- src/plasma/corona.cpp (line 181)

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95240 --- src/plasma/corona.cpp (line 181)

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127837/#review95233 --- Ship it! Thanks ! I tested it here. Looks fine. Although

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95241 --- It will also need

[Differential] [Request, 2 lines] D1552: Fix typo in TooltipDelegate

bshah created this revision. bshah added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As pointed by Yuking on IRC REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #3 from Markus --- I can confirm this problem on a Lenovo Thinkpad Yoga12 with Slackware64-Linux 14.2/-current and KDE Framework 5.21/Plasma 5.6.3 and Application 16.04.0. UPower is at version 0.9.23. Kernel is 4.6rc6.

Re: Review Request 127837: oxygen_windeco: Fix potential use-after-free from improper use of QCache

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127837/ --- (Updated May 7, 2016, 4:24 a.m.) Status -- This change has been

Review Request 127818: [calendar] Add "No events for today" in the agenda when no events are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127818/ --- Review request for Plasma. Repository: plasma-workspace Description

[Differential] [Commented On] D1533: guard access to unsafe config pointer

sebas added a comment. Yes, it's to deep. It would pretty much require running the daemon. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, Plasma Cc: graesslin,

[Differential] [Closed] D1367: PulseObjectFilterModel: Allow to set more filters

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA569fa9abb32d: PulseObjectFilterModel: Allow to set more filters (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1367?vs=3235=3662#toc REPOSITORY rPLASMAPA Plasma

[Differential] [Closed] D1443: Applet: Move Application streams with drag and drop

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA94df728fb1aa: Applet: Move Application streams with drag and drop (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1443?vs=3435=3663#toc REPOSITORY rPLASMAPA Plasma

[Differential] [Closed] D1292: Add mute microphone global shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA9833c2c05507: Add mute microphone global shortcut (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1292?vs=3079=3664#toc REPOSITORY rPLASMAPA Plasma Audio Volume

[Differential] [Request, 2 lines] D1546: Fix the building of tests in parallel

bshah created this revision. bshah added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY tests depend on kded module, for this check was added in 34acf3 but 6cc50d ported plugin to json

[Differential] [Accepted] D1546: Fix the building of tests in parallel

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH fix-build-parallel REVISION DETAIL https://phabricator.kde.org/D1546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, sebas,

[Differential] [Closed] D1546: Fix the building of tests in parallel

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENc5fec5f1b1d5: Fix the building of tests in parallel (authored by bshah). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1546?vs=3665=3666 REVISION DETAIL

[Differential] [Updated, 109 lines] D1545: [libinput] Support toggleTouchpad

graesslin updated this revision to Diff 3667. graesslin added a comment. Now with global shortcut stealing and support also for on/off in addition to just toggle REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1545?vs=3661=3667 BRANCH toggle-touchpad

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

> On Май 6, 2016, 8:50 преди обяд, Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 245 > > > > > > showing you the icon look up code from KWin, which is close to > > perfection

[Differential] [Updated, 135 lines] D1126: Remove Desktop.SystemSettings import

drosca updated this revision to Diff 3655. drosca added a comment. > REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1126?vs=2723=3655 BRANCH stylehints (branched from master) REVISION DETAIL https://phabricator.kde.org/D1126

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

> On Май 6, 2016, 8:50 преди обяд, Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 245 > > > > > > showing you the icon look up code from KWin, which is close to > > perfection

[Differential] [Updated] D1291: Add microphone volume OSD

drosca added a subscriber: andreaska. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mic-osd REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, sebas, Plasma, Plasma: Design Cc: andreaska,

[Differential] [Request, 94 lines] D1542: [kcms/input] Make mouse KCM work on non-X11

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY With this change the KCM is shown again on platforms != X11 and the X11 usage is guarded so that the

[Differential] [Updated] D1543: [libinput] Support for left-handed pointer

graesslin added a dependency: D1542: [kcms/input] Make mouse KCM work on non-X11. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Request, 71 lines] D1543: [libinput] Support for left-handed pointer

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The configuration file kcminput, group Mouse is parsed to decide whether pointer devices should be in

[Differential] [Updated] D1542: [kcms/input] Make mouse KCM work on non-X11

graesslin added a dependent revision: D1543: [libinput] Support for left-handed pointer. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1542 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc:

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

> On May 6, 2016, 7:50 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 245 > > > > > > showing you the icon look up code from KWin, which is close to > > perfection

[Differential] [Commented On] D1291: Add microphone volume OSD

drosca added a comment. I've now realized that Gnome uses different icon names for microphone volume: https://github.com/GNOME/adwaita-icon-theme/blob/master/src/fullcolor/microphones.svg microphone-sensitivity-muted microphone-sensitivity-low microphone-sensitivity-medium

[Differential] [Closed] D1538: [libinput] Add a wrapper class Device for a libinput_device

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4d7134f6c74a: [libinput] Add a wrapper class Device for a libinput_device (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1538?vs=3641=3654

[Differential] [Accepted] D1532: validate the config before checking if it can be applied

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. INLINE COMMENTS src/config.cpp:104 you don't need to add "canBeApplied" - the method name can be set through QT_MESSAGE_PATTERN REPOSITORY rLIBKSCREEN KScreen Library

[Differential] [Commented On] D1533: guard access to unsafe config pointer

graesslin added a comment. what about a test case for this? If it's too deep inside KScreen just push without. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas,

Review Request 127848: Revert "Don't import an nonexistent layout"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127848/ --- Review request for Plasma and Aleix Pol Gonzalez. Bugs: 360777

[Differential] [Updated] D1543: [libinput] Support for left-handed pointer

graesslin added a dependent revision: D1544: [lbinput] Support setting pointer acceleration. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: broulik,

[Differential] [Updated] D1544: [lbinput] Support setting pointer acceleration

graesslin added a dependency: D1543: [libinput] Support for left-handed pointer. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated, 73 lines] D1543: [libinput] Support for left-handed pointer

graesslin updated this revision to Diff 3658. graesslin added a comment. Set default value for left handed if there is no config key REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1543?vs=3657=3658 BRANCH linput-left-handed REVISION DETAIL

Re: Review Request 127848: Revert "Don't import an nonexistent layout"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127848/#review95228 --- +1 Even the progressbar steps backward - Anthony Fieroni

[Differential] [Request, 64 lines] D1547: Don't reset InputDevicesModel when devices change

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of reset a proper beginInsertRows, beginRemoveRows is used. In addition changes in the device

[Differential] [Closed] D1532: validate the config before checking if it can be applied

This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREENd80fedea86d6: validate the config before checking if it can be applied (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1534: make the serializer a bit more robust

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN7497eb49a142: make the serializer a bit more robust (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1534?vs=3647=3670 REVISION DETAIL

Re: Review Request 126732: a plymouth theme for breeze

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126732/ --- (Updated May 6, 2016, 12:15 p.m.) Status -- This change has been

Re: Review Request 127828: Remove .desktop file, it is unused and unhelpful as the app is called by ssh-add not run directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127828/ --- (Updated May 6, 2016, 12:16 p.m.) Status -- This change has been

[Differential] [Closed] D1539: Don't show knetattach in the menu, it's only useful from within a file manager/dialog

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP0e405ee75af7: Don't show knetattach in the menu, it's only useful from within a file… (authored by jriddell). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 74 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/74/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 May 2016 12:23:04 + Build duration: 10 min CHANGE SET Revision

[Differential] [Accepted] D1533: guard access to unsafe config pointer

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/362586 REVISION DETAIL https://phabricator.kde.org/D1533 EMAIL PREFERENCES

[Differential] [Closed] D1533: guard access to unsafe config pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN3cd5c74d5523: guard access to unsafe config pointer (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1533?vs=3648=3669 REVISION DETAIL

[Differential] [Closed] D1537: show klipper in non-kde desktops

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfc439f63e122: show klipper in non-kde desktops (authored by jriddell). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 79 lines] D1545: [libinput] Support toggleTouchpad

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The LibInput::Device provides a way to enable/disable the device. This is used by the Connection to

[Differential] [Updated] D1545: [libinput] Support toggleTouchpad

graesslin added a dependency: D1544: [lbinput] Support setting pointer acceleration. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1544: [lbinput] Support setting pointer acceleration

graesslin added a dependent revision: D1545: [libinput] Support toggleTouchpad. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

Re: Review Request 127818: [calendar] Add "No events for today" in the agenda when no events are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127818/#review95252 --- Ship it! Ship It! - David Edmundson On May 6, 2016,

Re: Proposal: kde-libs.org, a repository of contributed libraries

Hi, http://qt-apps.org/ also has a "Qt Components" section, in addition to "Qt Widgets". ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel