[Differential] [Updated, 9,257 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4118.
hein added a comment.


  Refresh activity count prop on activity state changes; more explicit prop 
name.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4117=4118

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,218 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4117.
hein marked an inline comment as done.
hein added a comment.


  Fix window info cache leak.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4110=4117

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> TODO.txt:1
> +Larger outstanding tasks:
> +- Implement missing kwayland bits (e.g. transient handling, virtual desktop 
> logic).

do you really want to add a TODO.txt? My suggestion would be to add tasks to 
maniphest here

> abstracttasksmodel.cpp:33-35
> +AbstractTasksModel::~AbstractTasksModel()
> +{
> +}

AbstractTaskModel::~AbstractTaskModel() = default;

> abstracttasksmodel.h:92
> +
> +virtual QModelIndex  index(int row, int column = 0, const 
> QModelIndex  = QModelIndex()) const;
> +

This looks weird. There is  a virtual method QAbstractItemModel::index which 
has column not optional. So you are maybe hiding a virtual method. I suggest to 
use override here and make column not optional.

> abstracttasksmodel.h:94-102
> +/**
> + * Request activation of the task at the given index. Derived classes are
> + * free to interpret the meaning of "activate" themselves depending on
> + * the nature and state of the task, e.g. launch or raise a window task.
> + *
> + * This base implementation does nothing.
> + *

why copy all the documentation? It's already documented in 
AbstractTasksModelIface. That yells like "will diverge" to me ;-)

> abstracttasksmodel.h:103
> + **/
> +virtual void requestActivate(const QModelIndex );
> +

please use override for these methods as well. They are defined in 
AbstractTasksModelIface after all.

> abstracttasksmodeliface.h:2
> +/
> +Copyright 2016  Eike Hein 
> +

your email address in the copy right headers is not a valid email address 
(seems to be consistent over all header files)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1714: [server] Don't destroy SlideInterface when parent SurfaceInterface is destroyed

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND7250773cf15d: [server] Don't destroy SlideInterface 
when parent SurfaceInterface is destroyed (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1714?vs=4064=4116

REVISION DETAIL
  https://phabricator.kde.org/D1714

AFFECTED FILES
  autotests/client/test_wayland_slide.cpp
  src/server/slide_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1711: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND4971be582ce7: [server] Don't destroy ShadowInterface 
when SurfaceInterface gets destroyed (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1711?vs=4059=4114

REVISION DETAIL
  https://phabricator.kde.org/D1711

AFFECTED FILES
  autotests/client/test_shadow.cpp
  src/server/shadow_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1713: [server] Properly handle destructor in SlideInterface

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDc7bf5dd0: [server] Properly handle destructor in 
SlideInterface (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1713?vs=4062=4115

REVISION DETAIL
  https://phabricator.kde.org/D1713

AFFECTED FILES
  autotests/client/test_wayland_slide.cpp
  src/server/slide_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDd2f6665ce355: [server] Don't destroy BlurInterface 
when parent SurfaceInterface is destroyed (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1708?vs=4055=4111

REVISION DETAIL
  https://phabricator.kde.org/D1708

AFFECTED FILES
  autotests/client/test_wayland_blur.cpp
  src/server/blur_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND73e89530e69e: [server] Don't destroy 
ServerSideDecorationInterface when parent… (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1710?vs=4057=4113

REVISION DETAIL
  https://phabricator.kde.org/D1710

AFFECTED FILES
  autotests/client/test_server_side_decoration.cpp
  src/server/server_decoration_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1709: [server] Don't destroy ContrastInterface when parent SurfaceInterface is destroyed

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND6354bff902a4: [server] Don't destroy 
ContrastInterface when parent SurfaceInterface is… (authored by graesslin).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1709?vs=4056=4112

REVISION DETAIL
  https://phabricator.kde.org/D1709

AFFECTED FILES
  autotests/client/test_wayland_contrast.cpp
  src/server/contrast_interface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> hein wrote in tasksmodel.cpp:1220
> Quite possibly, I'll give it a try. I originally had everything in 
> filterAcceptsRow() and the code then evolved more, and this was kind of left 
> on the table along the way I think.

Done now.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,210 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4110.
hein added a comment.


  - Move refilter-launcher-on-window insertion out of filterAcceptsRow() to 
make it lighter.
  - Move launcher refilter triggers to after grouping to ignore irrelevant 
sub-level window insertions/removals.
  - Remove a redundant SkipTaskbar check.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4108=4110

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 5,135 lines] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein updated this revision to Diff 4109.
hein marked an inline comment as done.
hein added a comment.


  Adapt to *FullScreen* API change in update to 
https://phabricator.kde.org/D1722.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1724?vs=4106=4109

BRANCH
  importtmng

REVISION DETAIL
  https://phabricator.kde.org/D1724

AFFECTED FILES
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/Messages.sh
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/taskmanager/plugin/blur.cpp
  applets/taskmanager/plugin/draghelper.cpp
  applets/taskmanager/plugin/draghelper.h
  applets/taskmanager/plugin/qmldir
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp
  applets/taskmanager/plugin/taskmanagerplugin.h
  applets/taskmanager/plugin/textlabel.cpp
  applets/taskmanager/plugin/textlabel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,197 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4108.
hein added a comment.


  Fullscreen -> FullScreen for consistency with Qt.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4107=4108

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128070: Update mouse kcm docbook to 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

bump date + releaseinfo
single / double click setting was removed from dolphin / konqueror
remove Change Pointer + Automatically select icons settings, no longer in the 
code
change kde -> plasma


Diffs
-

  doc/kcontrol/mouse/index.docbook b09f8e7 

Diff: https://git.reviewboard.kde.org/r/128070/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,197 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4107.
hein marked 2 inline comments as done.
hein added a comment.


  Addressed most of David's and Martin's minor requests.
  
  Outstanding bigger request:
  
  - The ActivityInfo fix
  - The TasksModel::filterAcceptsRow comment

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4092=4107

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein marked 2 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in taskfilterproxymodel.cpp:34
> Not that it will make a real difference, but shouldn't this technically 
> default to 0?
> 
> virtual desktops start at 1 with 0 being invalid.

Makes sense -- I've changed the type to uint, the default to 0 and expanded the 
API docs a bit.

> davidedmundson wrote in taskfilterproxymodel.cpp:298
> There was a bug that Kai found recently where some other bit of code randomly 
> set the virtual desktop to 0 if you only had 1 virtual desktop.
> 
> (I don't know if that was in a bit of code we've replaced or not).

I've dropped the 0 check.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein marked 6 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> hein wrote in xwindowtasksmodel.cpp:756
> Done.

Actually not done -- I'll ask you later about this.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein marked 7 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> graesslin wrote in CMakeLists.txt:18-23
> do we want to have X11 conditional? Other areas of Plasma use X11 
> unconditionally.

Personally as maintainer I do :). From my POV X11 is a legacy windowing system 
for libtaskmanager and I want to support building without it. If nothing else 
being disciplined about that helps a bit to prevent X11 stuff from creeping 
over the codebase again ...

> graesslin wrote in CMakeLists.txt:51
> Qt5::X11Extras

Done.

> davidedmundson wrote in tasksmodel.cpp:134
> you need a 
>  --d->activityInfoUsers
> 
> otherwise:
> 
> - set sort mode activities
> - delete task bar
> - add a task bar
> - set sort mode activities
> - set sort mode something else
> 
> you leak an activityInfo object.

Done.

> davidedmundson wrote in tasksmodel.cpp:478
> invalidateFilter()?

invalidateFilter() doesn't do a full resort - it only sorts in rows that may 
now get past the filter, leaving already-sorted rows alone. Unfortunately this 
was the best way I found to get QSortFilterProxyModel to guaranteed sort all 
rows.

> davidedmundson wrote in tasksmodel.cpp:1220
> would this be clearer and faster if it connected to groupsModel::rowsInserted 
> ?

Quite possibly, I'll give it a try. I originally had everything in 
filterAcceptsRow() and the code then evolved more, and this was kind of left on 
the table along the way I think.

> davidedmundson wrote in tasksmodel.cpp:84
> const

Done.

> davidedmundson wrote in xwindowtasksmodel.cpp:307
> We're missing some changed roles
> 
> IsKeepAbove
> IsKeepBelow
> SkipTaskbar

Done.

> davidedmundson wrote in xwindowtasksmodel.cpp:313
> IsVirtualDesktopChangeable

Done.

> davidedmundson wrote in xwindowtasksmodel.cpp:434
> we don't want to open and parse a config file on every new window.
> It'll be worth keeping the kconfig object.

I've added a FIXME to optimize this at a later time. It's not worse than the 
old lib (it did this too).

> davidedmundson wrote in xwindowtasksmodel.cpp:756
> you can do all this in the QByteArray ctor

Done.

> davidedmundson wrote in xwindowtasksmodel.cpp:861
> what's with the Q_INVOKABLE?

Copy and paste mistake probably, fixed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 5,135 lines] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein updated this revision to Diff 4106.
hein marked 12 inline comments as done.
hein added a comment.


  Make grouping toggle action actually a toggle action; requested code cleanup.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1724?vs=4105=4106

BRANCH
  importtmng

REVISION DETAIL
  https://phabricator.kde.org/D1724

AFFECTED FILES
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/Messages.sh
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/taskmanager/plugin/blur.cpp
  applets/taskmanager/plugin/draghelper.cpp
  applets/taskmanager/plugin/draghelper.h
  applets/taskmanager/plugin/qmldir
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp
  applets/taskmanager/plugin/taskmanagerplugin.h
  applets/taskmanager/plugin/textlabel.cpp
  applets/taskmanager/plugin/textlabel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein marked 2 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in ContextMenu.qml:123
> can be simplified to
> return menu.visualParent && menu.visualParent.virtualDesktop != 
> virtualDesktopInfo.currentDesktop
> same in tons of places below

Ok.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1724

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein marked 13 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in CMakeLists.txt:7
> Why is icon tasks now in plasma-desktop instead of kdeplasma-addons?

It's not a case of "now": Icontasks has been in plasma-desktop for a long time 
now. Please keep in mind code reviews are not plasma-devel ...

> broulik wrote in CMakeLists.txt:1
> This stays "ng"?

No, that's a bug from my rename orgy :) Thanks!

> broulik wrote in tools.js:44
> var taskIndexList = [];

Really? :P Ok ...

> broulik wrote in ContextMenu.qml:216
> I suppose this is also emitted when I press return on the keyboard?

Yup!

> broulik wrote in ContextMenu.qml:313
> I think this should be a checkable item "[X] Allow this program to be grouped"

This is the way it was before -- I don't mind changing it I guess ...

> broulik wrote in ContextMenu.qml:324
> I think you should also follow visible, so when kiosk restrictions disallow 
> configuring applets the entry is hidden altogether (like in the rest of the 
> shell)

"follow visible"?

> broulik wrote in GroupDialog.qml:108
> Where does that 6 come from?

Not sure - this is code that goes back to 4.11. It's not new in this review.

> broulik wrote in MouseHandler.qml:85
> That's the default

Being explicit is nice and aids readability.

> broulik wrote in Task.qml:233
> Can't you just bind prefix: TaskTools.taskPrefix(basePrefix)?

IIRC Marco wrote this code, it's unrelated to the backend change anyway.

> broulik wrote in TaskList.qml:28
> Doesn't that assumption break when you have launchers, ie. the first one 
> being a tiny square instead of a wide task?

Yes it does, that's why I asked Marco - who wrote that code - to mark up the 
related stuff in main.qml with big bad FIXMEs. Also unrelated to what this 
review is about.

> broulik wrote in ToolTipDelegate.qml:352
> TextMetrics {
> 
>   font: tooltipMaintextPlaceholder.font
>   text: mainText
> 
> } ?

Unrelated to this review. Please file a patch later.

> broulik wrote in backend.cpp:114
> check KDesktopFile::isDesktopFile(...) like in the recentDocumentsActions

Aye.

> broulik wrote in backend.cpp:118
> Other than being incremented, this variable is not used

You realize you are reviewing your own code now, right ...? I'll remove it, 
it's the same in the old code though (since it's unchanged).

> broulik wrote in backend.cpp:162
> QLatin1String

Ok.

> broulik wrote in backend.cpp:179-180
> init in one line?

Ok ...

> broulik wrote in backend.cpp:298
> mapToScene? (QQuickItem 5.7 will have a mapToGlobal btw)

Am I supposed to guess what you mean here? Please elaborate.

> broulik wrote in backend.cpp:362
> Do we need an isDesktopFile check here too?

I don't think so -- hasApplicationType() should return false.

> broulik wrote in backend.h:52
> Q_ENUM here instead of Q_ENUMS above

Ok.

> broulik wrote in backend.h:57
> coding style: QQuickItem *foo, also below

Ok.

> broulik wrote in backend.h:77
> coding style: const QUrl 

Ok.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1724

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 5,133 lines] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein updated this revision to Diff 4105.
hein added a comment.


  Addressed the comments relevant to the purpose of the review,
  in particular the incorrect install names.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1724?vs=4091=4105

BRANCH
  importtmng

REVISION DETAIL
  https://phabricator.kde.org/D1724

AFFECTED FILES
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/Messages.sh
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/taskmanager/plugin/blur.cpp
  applets/taskmanager/plugin/draghelper.cpp
  applets/taskmanager/plugin/draghelper.h
  applets/taskmanager/plugin/qmldir
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp
  applets/taskmanager/plugin/taskmanagerplugin.h
  applets/taskmanager/plugin/textlabel.cpp
  applets/taskmanager/plugin/textlabel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D1726: Introduce a test server

[bshah (Bhushan Shah)]

bshah requested changes to this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision now requires changes to proceed.


  While looking at cmake, I realized one issue.. and to verify this I tried to 
build it and it didn't even build.. :\

INLINE COMMENTS

> KF5WaylandConfig.cmake.in:10
> +add_test(NAME ${testBinaryName}-kwayland-test COMMAND
> +${CMAKE_INSTALL_FULL_LIBEXECDIR}/org-kde-kf5-kwayland-testserver 
> ${CMAKE_CURRENT_BINARY_DIR}/${testBinaryName}
> +)

I've gut feeling this will not work on CI, I am 80% sure about this but can't 
verify because I can't build this at all.

It works for you and me because in your local setup all repos are installed in 
same prefix, so CMAKE_INSTALL_FULL_LIBEXECDIR is same for all repos, while on 
CI each repo gets its own prefix, So on CI, when you will be using this 
CMAKE_INSTALL_FULL_LIBEXEC_DIR will resolve to repo using (e.g. 
kwayland-integration) this function and not to install prefix of kwayland.

Change this line to,

  @CMAKE_INSTALL_FULL_LIBEXECDIR@/org-kde-kf5-kwayland-testserver 
${CMAKE_CURRENT_BINARY_DIR}/${testBinaryName}

instead.

> testserver.cpp:140
> +m_seat->touchUp(it.value());
> +m_touchIdMapper.erase(it);
> +}

Actually this doesn't build for me.

  
/home/bshah/kdesrc/source/kwayland/src/tools/testserver/testserver.cpp:140:47: 
error: no viable conversion from 'const QHash::const_iterator' to 
'QHash::iterator'
  m_touchIdMapper.erase(it);
^~
  /usr/include/qt/QtCore/qhash.h:296:11: note: candidate constructor (the 
implicit copy constructor) not viable: no known conversion from 'const 
QHash::const_iterator' to 'const QHash::iterator &' for 1st 
argument
  class iterator
^
  /usr/include/qt/QtCore/qhash.h:296:11: note: candidate constructor (the 
implicit move constructor) not viable: no known conversion from 'const 
QHash::const_iterator' to 'QHash::iterator &&' for 1st 
argument
  class iterator
^
  /usr/include/qt/QtCore/qhash.h:453:29: note: passing argument to parameter 
'it' here
  iterator erase(iterator it);
  ^
  1 error generated.

(Using Qt 5.6)

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, sebas, Plasma, bshah
Cc: sebas, bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1726: Introduce a test server

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.


  Aside from @bshah 's request, it looks good to me.

INLINE COMMENTS

> graesslin wrote in main.cpp:30-33
> right, but then more needs to be changed. All positional arguments need to be 
> passed to the application.

That sounds useful when we want to allow more fancy stuff (different configs?) 
in the future.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  test-server

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, bshah, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kscreen daemon race

[Sebastian Kügler]

On Tuesday 31 May 2016 14:29:06 Sebastian Kügler wrote:
> Discussed with mgraesslin on IRC, preliminary conclusion below...
> 
> On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> > reboot
> > 
> > This bugreport seems to be a common problem, and it's a good example for
> > what's wrong with the screen configuration on startup.
> > 
> > TL;DR: We have a race condition when the kscreen daemon starts. It looks
> > up
> > a  known config, then applies it and subsequently resaves the config. The
> > same happens on config changes, it writes, then re-reads and then
> > re-writes
> > the config change.
> > I've managed to prevent this from happening by adding a timer that avoids
> > saving the config as a direct reaction to our own config changes.
> 
> So what we want to try is the same mechanism that KWin uses. Kwin watches
> for configuration changes for 100ms, if any change takes longer than 100ms,
> it's considered unrelated. Basically, what we want to do in kscreen daemon
> is:
> 
> - start a timer in kscreen daemon for 100ms after
> SetConfigOperation::finished and
> - restart it for every configChanged that arrives while the timer is still
>   running,
> - if the timer has timed out in the meantime, react to configChanged as
> usual
> 
> That should achieve the same effect as the "current" timer approach (which
> was just a proof of concept to prove my point, anyway.
> 
> Let's see how this goes.

Patch: https://phabricator.kde.org/D1730
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kscreen daemon race

[Sebastian Kügler]

On Wednesday 01 June 2016 00:05:10 Mark Gaiser wrote:
> Perhaps blockSignals can help you out [1]?
> 
> object->blockSignals(true);
> // ...
> Write your changes
> // ...
> object->blockSignals(false);
> 
> Object should be the object that currently receives the notification that
> the config file has been changed i think.
> 
> [1] http://doc.qt.io/qt-5/qobject.html#blockSignals 

That is essentially already what's happening, the problem is that signals come 
in after unblocking them.
-- 
sebas

Sebastian Kügler•http://vizZzion.org•http://www.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128069: Added keyboard shortcuts to Sticky Notes

[Viorel-Cătălin Răpițeanu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128069/
---

Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebastian 
Kügler.


Repository: kdeplasma-addons


Description
---

The commits adds the following keyboard shortcuts:
CTRL+b: Bold
CTRL+i: Italic
CTRL+u: Underline
CTRL+s: Strike out


Diffs
-

  applets/notes/package/contents/ui/main.qml 62a5ffa 

Diff: https://git.reviewboard.kde.org/r/128069/diff/


Testing
---

The testing was done locally by installing the modified version.


Thanks,

Viorel-Cătălin Răpițeanu

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 13 lines] D1730: address race condition around setoperation

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: graesslin.
sebas added a subscriber: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Use a timer to avoid catching configChanged signals after we set
  changes.
  
  The long version:
  
  TL;DR: We have a race condition when the kscreen daemon starts. It looks
  up a known config, then applies it and subsequently resaves the config.
  The same happens on config changes, it writes, then re-reads and then
  re-writes the config change.
  I've managed to prevent this from happening by adding a timer that does
  avoids saving the config as a direct reaction to our own config changes.
  
  So what happens on kded5 startup after loading the kscreen2 module:
  
  - the kscreen config is requested and received
  - the kscreen daemon (KD) looks into its config directory for a suitable 
config file (a config file is identified by a combined hash of all screen
  
  attached, so unique per connected set of outputs)
  
  - KD usually finds a config
  - KD ignores configChanged events before it starts ...
  - a KScreen::SetConfigOperation to apply the "known config"
  - SetConfigOperation returns after a while (say 100ms later)
  - we re-enable the change monitor
  - we receive a configChanged signal
  - we save the new config (usually to the existing config file)
  
  I don't think this behavior is desirable. I don't see a reason why the
  daemon should save its config right after applying it. I think this
  causes more problems than we want, since the startup may overwrite the
  user's config. This behavior seems to be desired by the code in KD, it's
  already blocking configChanged signals during the SetOperation (which,
  to be honest may result in nightmarish behavior in any way, so it might
  be a kludge which aims too short).
  
  From libkscreen perspective, SetConfigOperation::finished cannot
  guarantee that all configChanged signals are already fired and that it's
  safe to watch for new, independent changes now. At least on X11, we
  simply don't know, and what we can do is wait a bit and cross fingers
  that we're not catching our own noise. The changed signal *may* come
  from a re-request of the edid information, but this is a bit hard to
  track down, and not too useful, anyway, since changed Edid may affect a
  large number of a screen's properties.
  In the Wayland backend, that's a different story and we can prevent this
  behavior at an earlier stage, so this timer is "probably not needed" (I
  haven't tested that).
  
  This effectively prevents KD from catching reactions to its own changes
  and does not trigger saving the config file on every login. It still
  reacts to changes from libkscreen, but will avoid re-saving the config a
  few times. The timer may not be the neatest of solutions for this, but
  it does help narrowing down the problem and may be a last resort action.
  Most importantly, it avoids the re-writing of the config on startup and
  plugging/unplugging a monitor effectively.
  
  The timer value of 100ms is also used in kwin, which should make the
  behavior (which is no problem in kwin) more solid.
  
  CCBUG:346961
  CCBUG:358011

REPOSITORY
  rKSCREEN KScreen

BRANCH
  sebas/setop-race

REVISION DETAIL
  https://phabricator.kde.org/D1730

AFFECTED FILES
  kded/daemon.cpp
  kded/daemon.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, graesslin
Cc: plasma-devel, Plasma, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Thomas Pfeiffer]

On 31.05.2016 22:38, Ivan Čukić wrote:

Hi all,

There are two main reasons why I'm against this (regardless of what
ends up being plasma logo, and regardless of whether it will be pretty
or not - the KDE logo would not win any beauty pageants :) ):

  - (as previously mentioned) the gear-logo is a recognizable brand
(easy to spot on on TV or elsewhere)
  - the menu is entrance to the KDE world (even if there are a lot of
non-kde apps in it) - most Plasma users use other KDE applications as
well. Changing this logo might feel like we want to separate ourselves
from those applications and their developers. I would rather like to
see something that joins the community together than splitting it
apart.
Seeing Plasma's launcher (and with that, Plasma) as "the entrance to the KDE 
world" is one of the reasons why people still see them as closely related.
People are not supposed to see Plasma's launcher more as an entrance to "the KDE 
world" than as the entrance to the world of any other software available for 
their system, nor should they think that Plasma is a better entrance to "the KDE 
world" than any other desktop (or operating system).

I honestly do not see this as a part of KDE-is-not-the-desktop
rebranding effort.
Your argument above exactly shows to me why this _is_ related to the rebranding: 
You seeing Plasma's launcher specifically as an "entrance to the KDE world" 
shows me that even you still think of Plasma as more closely related to KDE 
applications than to other applications and vice versa.
That's what the rebranding wanted to change, and we're holding ourselves back if 
we insist on that visual connection.

Microsoft is not Windows (they share the logo) and
Apple is not OSX shell (they also show the logo as the 'menu' button),
MATE project is not only the desktop (and they use the project logo as
the 'menu' button).

MATE is insteresting in the way that they include the file manager,
archiver, image viewer, document viewer etc (what is traditionally
considered a DE). If we had a unified logo for Plasma and Dolphin,
Okular, etc. this would be much more fitting.
This is an excellent point: We have made several attempts to define what, apart 
from plasmashell, makes up "the Plasma workspace". The consensus seemed to 
always have been that some applications are considered to be a core part of the 
workspace, but individual opinions differ regarding specifically which 
applications these are.


The VDG is convinced that it would be hugely beneficial if we (along with the 
maintainers of the respective applications) would finally define which apps 
belong to the workspace, and then to put them all under one brand.


Cheers,
Thomas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kscreen daemon race

[Mark Gaiser]

On Tue, May 31, 2016 at 2:29 PM, Sebastian Kügler  wrote:

> Discussed with mgraesslin on IRC, preliminary conclusion below...
>
> On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> > reboot
> >
> > This bugreport seems to be a common problem, and it's a good example for
> > what's wrong with the screen configuration on startup.
> >
> > TL;DR: We have a race condition when the kscreen daemon starts. It looks
> up
> > a  known config, then applies it and subsequently resaves the config. The
> > same happens on config changes, it writes, then re-reads and then
> re-writes
> > the config change.
> > I've managed to prevent this from happening by adding a timer that avoids
> > saving the config as a direct reaction to our own config changes.
>
> So what we want to try is the same mechanism that KWin uses. Kwin watches
> for
> configuration changes for 100ms, if any change takes longer than 100ms,
> it's
> considered unrelated. Basically, what we want to do in kscreen daemon is:
>
> - start a timer in kscreen daemon for 100ms after
> SetConfigOperation::finished
>   and
> - restart it for every configChanged that arrives while the timer is still
>   running,
> - if the timer has timed out in the meantime, react to configChanged as
> usual
>
> That should achieve the same effect as the "current" timer approach (which
> was
> just a proof of concept to prove my point, anyway.
>
> Let's see how this goes.
>
>
Perhaps blockSignals can help you out [1]?

object->blockSignals(true);
// ...
Write your changes
// ...
object->blockSignals(false);

Object should be the object that currently receives the notification that
the config file has been changed i think.

[1] http://doc.qt.io/qt-5/qobject.html#blockSignals
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 968 lines] D1231: Add Krfb interface to KWayland

[Kanedias (Oleg Chernovskiy)]

Kanedias updated this revision to Diff 4100.
Kanedias added a comment.


  Updated against last M.Graesslin review.
  Sorry, couldn't find  a way to get rid of GbmBuffer struct (removed some 
redundant fields though).
  
  Re-checked with latest KWin and KRfb.

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=3620=4100

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/tools/mapping.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Kanedias, graesslin
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Harald Sitter]

On Tue, May 31, 2016 at 10:38 PM, Ivan Čukić  wrote:
> Microsoft is not Windows (they share the logo)

Not that I feel we need to discuss this further, but they do not share
the logo. The actual windows logo changes between iterations and has
since forever been the four tiles representing a window. The microsoft
logo has been first and foremost a wordmark logo up until recently
when it adopted the four tiles as part of the logo. And that being
said the current windows logo and the current microsoft icon-only
logo, are both 4 tiles, they are not the same 4 tiles though (i.e.
windows 10 has perspective tiles, microsoft does not).
HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1711: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  shadow-destroy-surface

REVISION DETAIL
  https://phabricator.kde.org/D1711

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1713: [server] Properly handle destructor in SlideInterface

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  slide-destroy-callback

REVISION DETAIL
  https://phabricator.kde.org/D1713

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  ssd-destroy-surface

REVISION DETAIL
  https://phabricator.kde.org/D1710

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

[Sebastian Kügler]

sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  blur-destroy-surface

REVISION DETAIL
  https://phabricator.kde.org/D1708

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Ivan Čukić]

Hi all,

There are two main reasons why I'm against this (regardless of what
ends up being plasma logo, and regardless of whether it will be pretty
or not - the KDE logo would not win any beauty pageants :) ):

 - (as previously mentioned) the gear-logo is a recognizable brand
(easy to spot on on TV or elsewhere)
 - the menu is entrance to the KDE world (even if there are a lot of
non-kde apps in it) - most Plasma users use other KDE applications as
well. Changing this logo might feel like we want to separate ourselves
from those applications and their developers. I would rather like to
see something that joins the community together than splitting it
apart.

I honestly do not see this as a part of KDE-is-not-the-desktop
rebranding effort. Microsoft is not Windows (they share the logo) and
Apple is not OSX shell (they also show the logo as the 'menu' button),
MATE project is not only the desktop (and they use the project logo as
the 'menu' button).

MATE is insteresting in the way that they include the file manager,
archiver, image viewer, document viewer etc (what is traditionally
considered a DE). If we had a unified logo for Plasma and Dolphin,
Okular, etc. this would be much more fitting.

Cheers,
Ivan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma logo as start menu icon and ksplash logo

[Thomas Pfeiffer]

On 03.02.2016 18:31, Marco Martin wrote:

On Wednesday 03 February 2016 09:10:06 Dirk Hohndel wrote:

http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/
s1600/plasma-5-banner.png

As someone with a more "outside" perspective... boy that one is ugly. And
really doesn't provide a lot of "recognizability". I'm running Plasma on


 "outside" perspective that makes it very, very valuable.


ArchLinux and I see the "K in the gear" logo in the bottom left corner of
my screen; replacing this with the three different sized, oddly spaced
dots and the '>' symbol? Doesn't sound like an improvement in branding to
me.


yep, if we replace the old "k with gear" it must be a really good one


The VDG is clearly of the opinion that we have to create a clear visual branding 
for Plasma which is distinct from the KDE brand, and a key element of that has 
to be Plasma's logo.


Therefore now the question is: Can the Plasma team identify itself with the 
current Plasma logo, or do you feel it still has to be improved?


What we certainly do not want is the Plasma team trying to hide away the logo 
because you don't really like it. So either you like it and make it a key 
element in Plasma (by using it e.g. for the launcher and the boot splash), or 
you tell us what you don't like about it so we can improve it.


Cheers,
Thomas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Ah, ok, I misunderstood that this will inherit by session since I thought 
> kwin start the script exit-with-session.
> 
> But then I still have one minor concern, for any window that actually inside 
> kwin (e.g. right click on title bar -> window specific settings), the input 
> method will be forced to qtvirtualkeyboard. Though I know input method is not 
> commonly being used there, but I don't think that's expected behavior for 
> input method user.

That dialog is a separate binary kwin_rules_dialog. Except for the virtual 
keyboard and wayland debug console I don't think there are any user-facing 
kwin-internal windows (that are real windows, not counting stuff like close 
buttons on present windows and so on)

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[xuetianweng (Xuetian Weng)]

xuetianweng added inline comments.

INLINE COMMENTS

> graesslin wrote in main_wayland.cpp:449
> I don't understand the concern. The QT_IM_MODULE env variable set here in the 
> code only affects KWin. It is not passed to any other process.
> 
> Setting QT_IM_MODULE env variables will still overwrite everything - except 
> in KWin where the variable is pointless. So nothing changes except by default 
> KWin can now offer a virtual keyboard.

Ah, ok, I misunderstood that this will inherit by session since I thought kwin 
start the script exit-with-session.

But then I still have one minor concern, for any window that actually inside 
kwin (e.g. right click on title bar -> window specific settings), the input 
method will be forced to qtvirtualkeyboard. Though I know input method is not 
commonly being used there, but I don't think that's expected behavior for input 
method user.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128038: [libtaskmanager] Stop highlighted window effect when close window in group item

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/#review96104
---



Ping, Eike, what you prefer?

- Anthony Fieroni


On Май 28, 2016, 10:19 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128038/
> ---
> 
> (Updated Май 28, 2016, 10:19 след обяд)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> 1. Enable highlighted window, tooltips and grouping
> 2. Open more then one in goup
> 3. Close one of grouped windows by click at tooltip button
> 
> 
> Diffs
> -
> 
>   applets/taskmanager/plugin/backend.cpp 
> afc6b91c0f492565b76a0a01e042ca7acbdbc0b4 
> 
> Diff: https://git.reviewboard.kde.org/r/128038/diff/
> 
> 
> Testing
> ---
> 
> Activate window "works" because kwin stops effect on activate, however it 
> better to be stopped.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[Martin Gräßlin]

graesslin added a comment.


  Totally stupid question: why import at all into plasma-workspace? We could 
also make it a standalone repository or does it depend on something else in 
plasma-workspace?

INLINE COMMENTS

> CMakeLists.txt:18-23
> +if (X11_FOUND)
> +set(taskmanager_LIB_SRCS
> +${taskmanager_LIB_SRCS}
> +xwindowtasksmodel.cpp
> +)
> +endif()

do we want to have X11 conditional? Other areas of Plasma use X11 
unconditionally.

> CMakeLists.txt:51
> +PRIVATE
> +${Qt5X11Extras_LIBRARIES}
> +KF5::IconThemes)

Qt5::X11Extras

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: graesslin, broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1726: Introduce a test server

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> bshah wrote in main.cpp:30-33
> It might be possible that one want to use executable with command line 
> option... lets not restrict it to 1? and have >= 1?

right, but then more needs to be changed. All positional arguments need to be 
passed to the application.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1698: A component shouldn't manage it's own geometry

[davidedmundson (David Edmundson)]

davidedmundson edited subscribers, added: plasma-devel; removed: Plasma.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1698

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1699: Limit BasicListItem width and elide text

[davidedmundson (David Edmundson)]

davidedmundson edited subscribers, added: plasma-devel; removed: Plasma.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1699

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1697: Don't set the implicitWidth the parent's actual width

[bshah (Bhushan Shah)]

bshah added a subscriber: plasma-devel.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D1697

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, Plasma
Cc: plasma-devel, Plasma
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Changed Subscribers] D1726: Introduce a test server

[bshah (Bhushan Shah)]

bshah added inline comments.

INLINE COMMENTS

> main.cpp:30-33
> +const auto arguments = parser.positionalArguments();
> +if (arguments.size() != 1) {
> +return 1;
> +}

It might be possible that one want to use executable with command line 
option... lets not restrict it to 1? and have >= 1?

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: bshah, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1726: Introduce a test server

[Martin Gräßlin]

graesslin added a dependent revision: D1727: Add a test case for KIdleTime.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1727: Add a test case for KIdleTime

[Martin Gräßlin]

graesslin added a dependency: D1726: Introduce a test server.

REPOSITORY
  rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1727

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 130 lines] D1727: Add a test case for KIdleTime

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The test uses the new Wayland test server to run the test app.

REPOSITORY
  rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland

BRANCH
  idle-test

REVISION DETAIL
  https://phabricator.kde.org/D1727

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/idletime/CMakeLists.txt
  autotests/idletime/idle_test.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 317 lines] D1726: Introduce a test server

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  The idea of shipping a test server is to have something like Xvfb for
  Wayland. To be able to run a test application with a fake Wayland server.
  
  To make this super easy the test server binary is installed into libexec
  directory and provides a cmake function to run a test application with
  the test server.
  
  The test server takes full control over the process. It's a guiless
  application and starts the passed test application once it is fully
  set up. The environment is setup to have the test application connect
  to the fake server (WAYLAND_SOCKET env variable and QT_QPA_PLATFORM).
  
  When the started application finishes the test server goes down and
  exits with the exit value of the test application. This allows a good
  integration with ctest.
  
  The test server is a virtual server which supports the following
  interfaces:
  
  - Shm
  - Compositor
  - Shell
  - Seat
  - DataDeviceManager
  - Idle
  - SubCompositor
  - Output (1280x1024 at 60 Hz with 96 dpi)
  - FakeInput
  
  This is sufficient to bring up a QtWayland based application and
  allows some basic interactions from a test application (e.g. fake
  input).
  
  So far the server fakes a repaint every 16 msec, but does not yet
  pass events to the test applications.
  
  To integrate this into an application for testing use:
  
find_package(KF5Wayland CONFIG)
add_executable(myTest myTest.cpp)
target_link_libraries(myTest Qt5::Gui Qt5::Test)
kwaylandtest(myTest)
  
  When now running ctest in the build directory the test server gets
  started and will start the myTest binary and report the passed/failed
  in the expected and normal way.
  
  This way a test case can easily be run against both X11 and Wayland.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  test-server

REVISION DETAIL
  https://phabricator.kde.org/D1726

AFFECTED FILES
  KF5WaylandConfig.cmake.in
  src/tools/CMakeLists.txt
  src/tools/testserver/CMakeLists.txt
  src/tools/testserver/main.cpp
  src/tools/testserver/testserver.cpp
  src/tools/testserver/testserver.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kscreen daemon race

[Sebastian Kügler]

Discussed with mgraesslin on IRC, preliminary conclusion below...

On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> reboot
> 
> This bugreport seems to be a common problem, and it's a good example for 
> what's wrong with the screen configuration on startup.
> 
> TL;DR: We have a race condition when the kscreen daemon starts. It looks up
> a  known config, then applies it and subsequently resaves the config. The
> same happens on config changes, it writes, then re-reads and then re-writes
> the config change.
> I've managed to prevent this from happening by adding a timer that avoids 
> saving the config as a direct reaction to our own config changes.

So what we want to try is the same mechanism that KWin uses. Kwin watches for 
configuration changes for 100ms, if any change takes longer than 100ms, it's 
considered unrelated. Basically, what we want to do in kscreen daemon is:

- start a timer in kscreen daemon for 100ms after SetConfigOperation::finished 
  and 
- restart it for every configChanged that arrives while the timer is still 
  running, 
- if the timer has timed out in the meantime, react to configChanged as usual

That should achieve the same effect as the "current" timer approach (which was 
just a proof of concept to prove my point, anyway.

Let's see how this goes.
-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

kscreen daemon race

[Sebastian Kügler]

Hey,

I've been looking into the bug 358011, that is:

https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after reboot

This bugreport seems to be a common problem, and it's a good example for 
what's wrong with the screen configuration on startup.

TL;DR: We have a race condition when the kscreen daemon starts. It looks up a 
known config, then applies it and subsequently resaves the config. The same 
happens on config changes, it writes, then re-reads and then re-writes the 
config change.
I've managed to prevent this from happening by adding a timer that avoids 
saving the config as a direct reaction to our own config changes.

So what happens on kded5 startup after loading the kscreen2 module:

- the kscreen config is requested and received
- the kscreen daemon (KD) looks into its config directory for a suitable config 
file
  (a config file is identified by a combined hash of all screen attached, so 
unique per connected set of outputs)
- KD usually finds a config
- KD ignores configChanged events before it starts ...
- a KScreen::SetConfigOperation to apply the "known config"
- SetConfigOperation returns after a while (say 100ms later)
- we re-enable the change monitor
- we receive a configChanged signal
- we save the new config (usually to the existing config file)

I don't think this behavior is desirable. I don't see a reason why the daemon 
should save its config right after applying it. I think this causes more 
problems than we want, since the startup may overwrite the user's config. This 
behavior seems to be desired by the code in KD, it's already blocking 
configChanged signals during the SetOperation (which, to be honest may result 
in nightmarish behavior in any way, so it might be a kludge which aims too 
short).

From libkscreen perspective, SetConfigOperation::finished cannot guarantee that 
all configChanged signals are already fired and that it's safe to watch for 
new, 
independent changes now. At least on X11, we simply don't know, and what we 
can do is wait a bit and cross fingers that we're not catching our own noise. 
The changed signal *may* come from a re-request of the edid information, but 
this is a bit hard to track down, and not too useful, anyway, since changed 
Edid may affect a large number of a screen's properties.
In the Wayland backend, that's a different story and we can prevent this 
behavior at an earlier stage, so this timer is "probably not needed" (I 
haven't tested that).

Approaching a fix, I've added a timer that waits a second before it enabled the 
changed signals. (I've also added timestamps to the daemon code to demonstrate 
the timing of events and get a ballpark figure.)

This effectively prevents KD from catching reactions to its own changes and 
does not trigger saving the config file on every login. It still reacts to 
changes from libkscreen, but will avoid re-saving the config a few times. The 
timer may not be the neatest of solutions for this, but it does help narrowing 
down the problem and may be a last resort action. Most importantly, it avoids 
the re-writing of the config on startup and plugging/unplugging a monitor 
effectively.

The 1000ms value is somewhat arbitrary: I can imagine even doing it a lot 
longer, because there's simply no reason to react to changes during the first 
seconds, but that's debatable. 1000ms means that I *hope* things have trickled 
through by then.

Another possible approach would be to delay the SetConfigOperation::finished 
signal only in the xrandr backend. This would be perhaps a bit cleaner, but I 
haven't tried it yet.

Maybe there's yet another solution?


So, gory details and logs I'm basing my theory on...

All this is, at least what I can make up from the following logs of kded5. 
(I've removed the lines irrelevant to my theory.)

This what happens during startup, on the user's machine, and also on my 
laptop.

KScreen::BackendManager::startBackend starting external backend launcher for 
""
KScreenDaemon::configReady "03:06:04.535" Config KScreen::Config(0x1bc2a80) is 
ready
KScreenDaemon::applyConfig Applying config
KScreenDaemon::applyKnownConfig "03:06:04.543" Applying known config 
"3f784869a2c8b2de9beaffcca16265bb"
KScreenDaemon::doApplyConfig "03:06:04.543" doApplyConfig()
KScreen::ConfigMonitor::Private::backendConfigChanged Requesting missing EDID 
for outputs (67)
KScreenDaemon::doApplyConfig(const ConfigPtr&)::http://vizZzion.org•http://www.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Flaky build behavior when using kded/kcm in tests (was, re: Jenkins-kde-ci: plasma-desktop master kf5-qt5 ..)

[Bhushan Shah]

Heya people,

On Tue, May 31, 2016 at 4:40 PM,   wrote:
>
> BUILD FAILURE
> Build URL: 
> https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
> Project: PLATFORM=Linux,compiler=gcc
> Date of build: Tue, 31 May 2016 11:07:31 +
> Build duration: 1 min 56 sec

Thought I'd share this now that I've fixed similar thing in 4
different places (akonadi, kcm_lookandfeel, kscreen, keyboard kcm)
Sometimes builds fail like that depending upon shade of moon, real fix
for this is not re-running build but,

Having something like : http://commits.kde.org/plasma-desktop/30ec050fd

If you are using kded module, or kcm module or something in your test
build, then you need to make a call to,

add_dependencies(your_test_target target_generating_json)

Thanks,
-- 
Bhushan Shah

http://bhush9.github.io
IRC Nick : bshah on Freenode
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:36:28 +
Build duration: 7 min 25 sec

CHANGE SET
Revision 30ec050fdbab82218dea9fe2ba4c05544505cf82 by Bhushan Shah: (add 
dependency to kded_keyboard)
  change: edit kcms/keyboard/tests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3368 
(69%)CONDITIONAL 1561/3758 (42%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1520 
(51%)CONDITIONAL 629/1703 (37%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:36:28 +
Build duration: 7 min 25 sec

CHANGE SET
Revision 30ec050fdbab82218dea9fe2ba4c05544505cf82 by Bhushan Shah: (add 
dependency to kded_keyboard)
  change: edit kcms/keyboard/tests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 37/39 (95%)CLASSES 37/39 (95%)LINE 2309/3368 
(69%)CONDITIONAL 1561/3758 (42%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 21/23 (91%)CLASSES 21/23 (91%)LINE 782/1520 
(51%)CONDITIONAL 629/1703 (37%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 251/342 (73%)CONDITIONAL 
82/187 (44%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 108 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:07:47 +
Build duration: 28 min

CHANGE SET
Revision f5546cb5e61f13b67b340de597a63af25f19cd7d by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit 
shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop
  change: edit plasma.desktop.cmake
  change: edit freespacenotifier/freespacenotifier.notifyrc
  change: edit menu/desktop/kf5-system-terminal.directory
  change: edit menu/desktop/kf5-utilities-desktop.directory
  change: edit applets/systemmonitor/cpu/metadata.desktop
  change: edit lookandfeel/contents/loginmanager/metadata.desktop
  change: edit wallpapers/color/metadata.desktop
  change: edit runners/powerdevil/plasma-runner-powerdevil.desktop
  change: edit runners/windowedwidgets/plasma-runner-windowedwidgets.desktop
  change: edit plasmawayland.desktop.cmake
  change: edit templates/ion-dataengine/src/ion-%{APPNAMELC}.desktop
  change: edit soliduiserver/soliduiserver.desktop
  change: edit runners/services/plasma-runner-services.desktop
  change: edit applets/systemtray/container/package/metadata.desktop
  change: edit kioslave/desktop/directory.trash
  change: edit dataengines/packagekit/plasma-dataengine-packagekit.desktop
  change: edit menu/desktop/hidden.directory
  change: edit menu/desktop/kf5-system.directory
  change: edit applets/systemmonitor/diskusage/metadata.desktop
  change: edit applets/systemmonitor/diskactivity/metadata.desktop
  change: edit applets/digital-clock/package/metadata.desktop
  change: edit menu/desktop/kf5-utilities-file.directory
  change: edit 
shell/packageplugins/qmlWallpaper/plasma-packagestructure-wallpaper.desktop
  change: edit 
shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop
  change: edit kioslave/desktop/Home.desktop
  change: edit applets/mediacontroller/metadata.desktop
  change: edit menu/desktop/kf5-internet-terminal.directory
  change: edit dataengines/mpris2/plasma-dataengine-mpris2.desktop
  change: edit themes/qtwindowsvista.themerc
  change: edit themes/qtwindows.themerc
  change: edit menu/desktop/kf5-utilities.directory
  change: edit 
shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop
  change: edit kioslave/remote/kdedmodule/remotedirnotify.desktop
  change: edit systemmonitor/ksysguard.desktop
  change: edit kioslave/desktop/desktopnotifier.desktop
  change: edit menu/desktop/kf5-utilities-xutils.directory
  change: edit runners/shell/plasma-runner-shell.desktop
  change: edit runners/activities/plasma-runner-activityrunner.desktop
  change: edit applets/clipboard/metadata.desktop
  change: edit menu/desktop/kf5-more.directory


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1683/2124 
(79%)CONDITIONAL 1209/2103 (57%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1672: Add support for touch events in fakeinput protocol and interface.

[bdhruve (Bhavisha Dhruve)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND7d460ed00254: Add support for touch events in 
fakeinput protocol and interface. (authored by bdhruve).

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1672?vs=4089=4093

REVISION DETAIL
  https://phabricator.kde.org/D1672

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, Plasma, bshah, graesslin
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.

[bdhruve (Bhavisha Dhruve)]

bdhruve added a comment.


  Thank you @graesslin and @bshah

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  fake-input-touch

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, Plasma, bshah, graesslin
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,190 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4092.
hein added a comment.


  Addressed:
  
  - Most of kbroulik's comments, including API comments

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4090=4092

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 83 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:07:31 +
Build duration: 1 min 56 sec

CHANGE SET
Revision 0f07e8bc237e77447d4767cb68414c73ac4ea0f0 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/runners/kcm_plasmasearch.desktop
  change: edit kcms/touchpad/src/kded/kded_touchpad.desktop
  change: edit kcms/style/kcmstyle.notifyrc
  change: edit kcms/colors/colors.desktop
  change: edit kcms/useraccount/kcm_useraccount.desktop
  change: edit kcms/ksplash/package/metadata.desktop
  change: edit applets/kicker/package/metadata.desktop
  change: edit kcms/ksmserver/kcmsmserver.desktop
  change: edit containments/panel/metadata.desktop
  change: edit toolboxes/desktoptoolbox/metadata.desktop
  change: edit kcms/knotify/kcmnotify.desktop
  change: edit kcms/ksplash/kcm_splashscreen.desktop
  change: edit toolboxes/paneltoolbox/metadata.desktop
  change: edit kcms/spellchecking/spellchecking.desktop
  change: edit kcms/kded/kcmkded.desktop
  change: edit kcms/workspaceoptions/workspaceoptions.desktop
  change: edit kcms/touchpad/src/kcm/kcm_touchpad.desktop
  change: edit applets/kimpanel/package/metadata.desktop
  change: edit runners/kwin/plasma-runner-kwin.desktop
  change: edit kcms/lookandfeel/kcm_lookandfeel.desktop
  change: edit 
kcms/solid_actions/device-actions/solid-device-OpticalDisc.desktop
  change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop
  change: edit containments/desktop/package/metadata.desktop
  change: edit kcms/lookandfeel/package/metadata.desktop
  change: edit kcms/touchpad/src/kded/kcm_touchpad.notifyrc
  change: edit applets/icontasks/metadata.desktop
  change: edit kcms/activities/kcm_activities.desktop
  change: edit kcms/style/style.desktop
  change: edit kcms/formats/formats.desktop
  change: edit 
kcms/solid_actions/device-actions/solid-device-StorageVolume.desktop
  change: edit kcms/translations/translations.desktop
  change: edit kcms/touchpad/src/applet/qml/metadata.desktop
  change: edit kcms/standard_actions/standard_actions.desktop
  change: edit applets/taskmanager/package/metadata.desktop
  change: edit applets/showActivityManager/package/metadata.desktop
  change: edit containments/folder/metadata.desktop
  change: edit kcms/solid_actions/solid-actions.desktop
  change: edit kcms/desktoppaths/desktoppath.desktop
  change: edit kcms/launch/kcmlaunch.desktop
  change: edit solid-device-automounter/kded/device_automounter.desktop
  change: edit kcms/input/mouse.desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1672: Add support for touch events in fakeinput protocol and interface.

[Martin Gräßlin]

graesslin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKWAYLAND KWayland

BRANCH
  fake-input-touch

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, Plasma, bshah, graesslin
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> broulik wrote in launchertasksmodel.h:86
> "will fail" sounds like it's dangerous, "will do nothing"?

It means it will return false, for failure.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> broulik wrote in taskmanagerplugin.h:32
> Indentation is off

No, it's not ...?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.

[bdhruve (Bhavisha Dhruve)]

bdhruve added a comment.


  In https://phabricator.kde.org/D1672#31870, @bshah wrote:
  
  > Looks good.
  
  
  Output of arc land fake-input-touch:
   TARGET  Landing onto "master", the default target under git.
   REMOTE  Using remote "origin", the default remote under git.
   FETCH  Fetching origin/master...
  This commit will be landed:
  
  - 2d5d5c2 Add support for touch events in fakeinput protocol and interface.
  
Revision 'https://phabricator.kde.org/D1672: Add support for touch events 
in fakeinput protocol and interface.' has not been accepted. Continue anyway? 
[y/N]
  
  Can i still submit it?

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, graesslin, Plasma, bshah
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in abstracttasksmodel.cpp:41-42
> traditionally these are called "display" and "decoration" 
> lowercase and without the word "Role"
> 
> Also you should be able to do
> 
> roles = QAbstractItemModel::roles()  to get them.

This was kept from the old lib, changing.

> broulik wrote in abstracttasksmodel.h:63
> I don't fully get that, can you clarify whether this means:
> 
> - A task that "can be grouped" (judging from the enum value name)
> - A task that "is currently grouped" (judging from the comment)

It means what the comment says: If it's true, the task is not subject to 
grouping. That means it will never be grouped. It's used by the applet's Don't 
allow/Allow This Program To Be Grouped action.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: broulik, davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1672: Add support for touch events in fakeinput protocol and interface.

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a comment.


  Looks good.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, graesslin, Plasma, bshah
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 5,133 lines] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein updated this revision to Diff 4091.
hein added a comment.


  Switch to changed data role names in update to 
https://phabricator.kde.org/D1722.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1724?vs=4085=4091

BRANCH
  importtmng

REVISION DETAIL
  https://phabricator.kde.org/D1724

AFFECTED FILES
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/Messages.sh
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/taskmanager/plugin/blur.cpp
  applets/taskmanager/plugin/draghelper.cpp
  applets/taskmanager/plugin/draghelper.h
  applets/taskmanager/plugin/qmldir
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp
  applets/taskmanager/plugin/taskmanagerplugin.h
  applets/taskmanager/plugin/textlabel.cpp
  applets/taskmanager/plugin/textlabel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 9,191 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein updated this revision to Diff 4090.
hein added a comment.


  Addressed:
  
  - Data role names
  - Nulling pointers
  - Removed Messages.sh
  - Saved lookup in startups model

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1722?vs=4083=4090

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/.kdev4/libtaskmanagerng.kdev4
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 107 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/107/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 09:59:36 +
Build duration: 9 min 18 sec

CHANGE SET
Revision fad800879265d3fe790ffeee11dbf54eecce1df2 by : (Fix available calendar 
plugins checkboxes being stacked on top of each)
  change: edit applets/digital-clock/package/contents/ui/configCalendar.qml


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1683/2124 
(79%)CONDITIONAL 1209/2103 (57%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated, 280 lines] D1672: Add support for touch events in fakeinput protocol and interface.

[bdhruve (Bhavisha Dhruve)]

bdhruve updated this revision to Diff 4089.
bdhruve added a comment.


  Fixed the coding style issue.

REPOSITORY
  rKWAYLAND KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1672?vs=4063=4089

BRANCH
  fake-input-touch

REVISION DETAIL
  https://phabricator.kde.org/D1672

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, Plasma, graesslin
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in activityinfo.cpp:69
> If I have 4 activities. 2 running, 2 not.
> 
> numberOfActivities returns 2
> 
> I set one to running:
> 
> the property changes
> this signal is not emitted.

Good catch. I think the old lib had this issue too ...

KActivities has no convenient API to listen to changes in the list of running 
activities, it seems - instead you have to keep a KActivities::Info around for 
all activtities, and listen to their stateChanged signals. Annoying ...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in concatenatetasksproxymodel.cpp:61
> we could add one?
> 
> sourceModelForIndex() would make sense for a few cases.

It's on my todo, the comments are partly so I don't forget :). It's not a vital 
issue at this moment, and also depends on me thinking through KF5-vs-Plasma 
schedules since it would raise the KF5 version dep.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 106 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/106/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 09:25:56 +
Build duration: 17 min

CHANGE SET
Revision e26f4ee4757cfcda06bb7ad57ba7e8aeb6f28061 by kde: ([PanelView] Check 
whether were X11 before calling)
  change: edit shell/panelview.cpp
Revision cc47d2bfca93481af3a0c149d5f424a30d3ebd7c by kde: ([System Tray] 
Dont iterate keys())
  change: edit applets/systemtray/systemtray.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 8 
test(s)Failed: TestSuite.org.kde.plasma.analogclock-testFailed: 
TestSuite.org.kde.plasma.kickoff-test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 43/49 (88%)CLASSES 43/49 (88%)LINE 1683/2124 
(79%)CONDITIONAL 1209/2103 (57%)

By packages
  
drkonqi.parser
FILES 6/10 (60%)CLASSES 6/10 (60%)LINE 303/423 (72%)CONDITIONAL 
478/616 (78%)
drkonqi.tests.backtraceparsertest
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 74/74 (100%)CONDITIONAL 
33/50 (66%)
kioslave.desktop
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 112/167 (67%)CONDITIONAL 
37/92 (40%)
kioslave.desktop.tests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 66/66 (100%)CONDITIONAL 
26/50 (52%)
klipper
FILES 12/13 (92%)CLASSES 12/13 (92%)LINE 256/384 
(67%)CONDITIONAL 109/210 (52%)
klipper.autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 630/693 (91%)CONDITIONAL 
377/820 (46%)
runners.bookmarks
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 89/159 (56%)CONDITIONAL 
34/96 (35%)
runners.bookmarks.browsers
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 88/93 (95%)CONDITIONAL 
84/107 (79%)
runners.bookmarks.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/65 (100%)CONDITIONAL 
31/62 (50%)___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Messages.sh:3
> The legacy version is also called this.
> 
> That will cause a breakage on the i18n side.
> 
> Either: 
>  two .pot files
> OR
>  one Messages.sh

I'll pick option 3: Remove Messages.sh :-)

The new lib doesn't contain any strings, that the Messages.sh is there is an 
oversight. Thanks for catching!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Reviewed up to "libtaskmanager/taskfilterproxymodel.h"
  Will submit this now, in case phabricator doesn't save it.

INLINE COMMENTS

> CMakeLists.txt:86
> +endif()
> +
> +write_basic_config_version_file(${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfigVersion.cmake
>  VERSION "${PROJECT_VERSION}" COMPATIBILITY AnyNewerVersion)

add_definitions(-DTRANSLATION_DOMAIN=...)

somewhere in this file

> Messages.sh:3
> +$EXTRACTRC *.ui  >> rc.cpp || exit 11
> +$XGETTEXT *.cpp */*.cpp *.h -o $podir/libtaskmanager.pot
> +rm -f rc.cpp

The legacy version is also called this.

That will cause a breakage on the i18n side.

Either: 
 two .pot files
OR
 one Messages.sh

> abstracttasksmodel.cpp:41-42
> +
> +roles.insert(Qt::DisplayRole, "DisplayRole");
> +roles.insert(Qt::DecorationRole, "DecorationRole");
> +

traditionally these are called "display" and "decoration" 
lowercase and without the word "Role"

Also you should be able to do

roles = QAbstractItemModel::roles()  to get them.

> activityinfo.cpp:55
> +if (!instanceCount) {
> +delete activityConsumer;
> +}

..and set pointer to null

Otherwise you have a crash if you delete them all and then then create a new 
one.

(or use QWeak and QShared pointer )

> activityinfo.cpp:69
> +connect(d->activityConsumer, ::Consumer::activitiesChanged,
> +this, ::numberOfActivitiesChanged);
> +}

If I have 4 activities. 2 running, 2 not.

numberOfActivities returns 2

I set one to running:

the property changes
this signal is not emitted.

> concatenatetasksproxymodel.cpp:61
> +if (m) {
> +// NOTE: KConcatenateRowsProxyModel offers no way to get a non-const 
> pointer
> +// to one of the source models, so we have to go through a mapped 
> index.

we could add one?

sourceModelForIndex() would make sense for a few cases.

> startuptasksmodel.cpp:146
> +launcherUrls.insert(id.id(), launcherUrl(data));
> +QModelIndex idx = q->index(startups.indexOf(id));
> +emit q->dataChanged(idx, idx);

q->index(row)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Requested Changes To] D1672: Add support for touch events in fakeinput protocol and interface.

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Looks good, but please fix the coding style.

INLINE COMMENTS

> fakeinput_interface.cpp:201-202
> +}
> +if(touchIds.contains(id))
> +{
> +return;

please watch coding style - same in all other areas you just adjusted.

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1672

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bdhruve, bshah, graesslin, Plasma
Cc: bshah, graesslin, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1705: [System Tray] Don't iterate keys()

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEcc47d2bfca93: [System Tray] Don't iterate 
keys() (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1705?vs=4038=4087

REVISION DETAIL
  https://phabricator.kde.org/D1705

AFFECTED FILES
  applets/systemtray/systemtray.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, Plasma, apol
Cc: apol, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127975/
---

(Updated May 31, 2016, 2:26 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Changes
---

Submitted with commit f3c05034d9e2ad3de984e833680b4b3def078430 by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

Like KIconloader, support a Selected state, in IconItem, as in all generic 
svgs/framesvg
it replaces the text color with HighlightedText and the background color with 
HighlightColor


Diffs
-

  src/declarativeimports/core/framesvgitem.h 335a9b4 
  src/declarativeimports/core/framesvgitem.cpp 1bde3d2 
  src/declarativeimports/core/iconitem.h 38a9c7a 
  src/declarativeimports/core/iconitem.cpp 12008f8 
  src/plasma/private/svg_p.h 6f1efc2 
  src/plasma/private/theme_p.h 945fcef 
  src/plasma/private/theme_p.cpp 99e865b 
  src/plasma/svg.h 3a4ca1d 
  src/plasma/svg.cpp 507ed75 
  src/plasma/theme.cpp 3b7b371 
  tests/selected_svg.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127975/diff/


Testing
---


File Attachments


showing a framesvg, a SvgItem and an IconItem
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/2434-baf4-45d2-9f26-71b4b857502d__dadel4.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Closed] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEe26f4ee4757c: [PanelView] Check whether we're 
X11 before calling QX11Info::connection() (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1718?vs=4076=4086

REVISION DETAIL
  https://phabricator.kde.org/D1718

AFFECTED FILES
  shell/panelview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127975/
---

(Updated May 31, 2016, 9:13 a.m.)


Review request for Plasma.


Repository: plasma-framework


Description
---

Like KIconloader, support a Selected state, in IconItem, as in all generic 
svgs/framesvg
it replaces the text color with HighlightedText and the background color with 
HighlightColor


Diffs (updated)
-

  src/declarativeimports/core/framesvgitem.h 335a9b4 
  src/declarativeimports/core/framesvgitem.cpp 1bde3d2 
  src/declarativeimports/core/iconitem.h 38a9c7a 
  src/declarativeimports/core/iconitem.cpp 12008f8 
  src/plasma/private/svg_p.h 6f1efc2 
  src/plasma/private/theme_p.h 945fcef 
  src/plasma/private/theme_p.cpp 99e865b 
  src/plasma/svg.h 3a4ca1d 
  src/plasma/svg.cpp 507ed75 
  src/plasma/theme.cpp 3b7b371 
  tests/selected_svg.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127975/diff/


Testing
---


File Attachments


showing a framesvg, a SvgItem and an IconItem
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/2434-baf4-45d2-9f26-71b4b857502d__dadel4.png


Thanks,

Marco Martin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 5,133 lines] D1724: Import Task Manager widgets ports to the new library.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added dependencies: D1723: Rename Task Manager applets out of the way of 
rewrites., D1721: Rename libtaskmanager to liblegacytaskmanager to make way for 
rewrite..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D1721, 
https://phabricator.kde.org/D1723.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  importtmng

REVISION DETAIL
  https://phabricator.kde.org/D1724

AFFECTED FILES
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/Messages.sh
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/taskmanager/plugin/blur.cpp
  applets/taskmanager/plugin/draghelper.cpp
  applets/taskmanager/plugin/draghelper.h
  applets/taskmanager/plugin/qmldir
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp
  applets/taskmanager/plugin/taskmanagerplugin.h
  applets/taskmanager/plugin/textlabel.cpp
  applets/taskmanager/plugin/textlabel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

[hein (Eike Hein)]

hein added a dependent revision: D1724: Import Task Manager widgets ports to 
the new library..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1721

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

[hein (Eike Hein)]

hein added a dependent revision: D1723: Rename Task Manager applets out of the 
way of rewrites..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1721

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 4,516 lines] D1723: Rename Task Manager applets out of the way of rewrites.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added a dependency: D1721: Rename libtaskmanager to liblegacytaskmanager 
to make way for rewrite..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Also ports Pager to renamed library.
  
  Depends on plasma-workspace changes to rename the library.
  
  Depends on https://phabricator.kde.org/D1721.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1723

AFFECTED FILES
  CMakeLists.txt
  applets/CMakeLists.txt
  applets/icontasks/CMakeLists.txt
  applets/icontasks/metadata.desktop
  applets/legacyicontasks/CMakeLists.txt
  applets/legacyicontasks/metadata.desktop
  applets/legacytaskmanager/CMakeLists.txt
  applets/legacytaskmanager/Messages.sh
  applets/legacytaskmanager/package/contents/code/layout.js
  applets/legacytaskmanager/package/contents/code/tools.js
  applets/legacytaskmanager/package/contents/config/config.qml
  applets/legacytaskmanager/package/contents/config/main.xml
  applets/legacytaskmanager/package/contents/ui/ConfigGeneral.qml
  applets/legacytaskmanager/package/contents/ui/GroupDialog.qml
  applets/legacytaskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/legacytaskmanager/package/contents/ui/MouseHandler.qml
  applets/legacytaskmanager/package/contents/ui/Task.qml
  applets/legacytaskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/legacytaskmanager/package/contents/ui/TaskList.qml
  applets/legacytaskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/legacytaskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/legacytaskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/legacytaskmanager/package/contents/ui/main.qml
  applets/legacytaskmanager/package/metadata.desktop
  applets/legacytaskmanager/plugin/backend.cpp
  applets/legacytaskmanager/plugin/backend.h
  applets/legacytaskmanager/plugin/blur.cpp
  applets/legacytaskmanager/plugin/draghelper.cpp
  applets/legacytaskmanager/plugin/draghelper.h
  applets/legacytaskmanager/plugin/legacytaskmanagerplugin.cpp
  applets/legacytaskmanager/plugin/legacytaskmanagerplugin.h
  applets/legacytaskmanager/plugin/qmldir
  applets/legacytaskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/legacytaskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/legacytaskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/legacytaskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/legacytaskmanager/plugin/textlabel.cpp
  applets/legacytaskmanager/plugin/textlabel.h
  applets/pager/CMakeLists.txt
  applets/pager/plugin/pager.cpp
  applets/taskmanager/CMakeLists.txt
  applets/taskmanager/Messages.sh
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/config/config.qml
  applets/taskmanager/package/contents/config/main.xml
  applets/taskmanager/package/contents/ui/ConfigGeneral.qml
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
  applets/taskmanager/package/contents/ui/TaskList.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
  applets/taskmanager/package/contents/ui/ToolTipWindowMouseArea.qml
  applets/taskmanager/package/contents/ui/main.qml
  applets/taskmanager/package/metadata.desktop
  applets/taskmanager/plugin/backend.cpp
  applets/taskmanager/plugin/backend.h
  applets/taskmanager/plugin/blur.cpp
  applets/taskmanager/plugin/draghelper.cpp
  applets/taskmanager/plugin/draghelper.h
  applets/taskmanager/plugin/qmldir
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.h
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.cpp
  applets/taskmanager/plugin/smartlaunchers/smartlauncheritem.h
  applets/taskmanager/plugin/taskmanagerplugin.cpp
  applets/taskmanager/plugin/taskmanagerplugin.h
  applets/taskmanager/plugin/textlabel.cpp
  applets/taskmanager/plugin/textlabel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1721

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma, mart
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 9,194 lines] D1722: Import next-gen libtaskmanager.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added a dependency: D1721: Rename libtaskmanager to liblegacytaskmanager 
to make way for rewrite..
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Depends on https://phabricator.kde.org/D1721.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  importlibtmng

REVISION DETAIL
  https://phabricator.kde.org/D1722

AFFECTED FILES
  CMakeLists.txt
  libtaskmanager/.kdev4/libtaskmanagerng.kdev4
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/Messages.sh
  libtaskmanager/TODO.txt
  libtaskmanager/abstracttasksmodel.cpp
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/abstracttasksmodeliface.h
  libtaskmanager/activityinfo.cpp
  libtaskmanager/activityinfo.h
  libtaskmanager/autotests/CMakeLists.txt
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/autotests/tasktoolstest.cpp
  libtaskmanager/concatenatetasksproxymodel.cpp
  libtaskmanager/concatenatetasksproxymodel.h
  libtaskmanager/declarative/CMakeLists.txt
  libtaskmanager/declarative/qmldir
  libtaskmanager/declarative/taskmanagerplugin.cpp
  libtaskmanager/declarative/taskmanagerplugin.h
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel.h
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/startuptasksmodel.h
  libtaskmanager/taskfilterproxymodel.cpp
  libtaskmanager/taskfilterproxymodel.h
  libtaskmanager/taskgroupingproxymodel.cpp
  libtaskmanager/taskgroupingproxymodel.h
  libtaskmanager/taskmanagerrulesrc
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h
  libtaskmanager/tasktools.cpp
  libtaskmanager/tasktools.h
  libtaskmanager/virtualdesktopinfo.cpp
  libtaskmanager/virtualdesktopinfo.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/waylandtasksmodel.h
  libtaskmanager/xwindowtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

[hein (Eike Hein)]

hein added a dependent revision: D1722: Import next-gen libtaskmanager..

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1721

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Request, 1,120 lines] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

[hein (Eike Hein)]

hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Also ports in-module users of the library.
  
  Translation domain and pot file name remain unchanged, as the new lib
  contains no strings.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1721

AFFECTED FILES
  CMakeLists.txt
  containmentactions/switchwindow/CMakeLists.txt
  containmentactions/switchwindow/switch.cpp
  containmentactions/switchwindow/switch.h
  dataengines/tasks/CMakeLists.txt
  dataengines/tasks/taskjob.cpp
  dataengines/tasks/taskjob.h
  dataengines/tasks/tasksengine.cpp
  dataengines/tasks/tasksengine.h
  dataengines/tasks/taskservice.cpp
  dataengines/tasks/taskservice.h
  liblegacytaskmanager/CMakeLists.txt
  liblegacytaskmanager/LibLegacyTaskManagerConfig.cmake.in
  liblegacytaskmanager/Mainpage.dox
  liblegacytaskmanager/Messages.sh
  liblegacytaskmanager/abstractgroupableitem.cpp
  liblegacytaskmanager/abstractgroupableitem.h
  liblegacytaskmanager/abstractgroupingstrategy.cpp
  liblegacytaskmanager/abstractgroupingstrategy.h
  liblegacytaskmanager/abstractsortingstrategy.cpp
  liblegacytaskmanager/abstractsortingstrategy.h
  liblegacytaskmanager/groupmanager.cpp
  liblegacytaskmanager/groupmanager.h
  liblegacytaskmanager/launcherconfig.cpp
  liblegacytaskmanager/launcherconfig.h
  liblegacytaskmanager/launcherconfig.ui
  liblegacytaskmanager/launcheritem.cpp
  liblegacytaskmanager/launcheritem.h
  liblegacytaskmanager/launcherproperties.cpp
  liblegacytaskmanager/launcherproperties.h
  liblegacytaskmanager/launcherproperties.ui
  liblegacytaskmanager/legacytaskmanager.cpp
  liblegacytaskmanager/legacytaskmanager.h
  liblegacytaskmanager/legacytaskmanagerrulesrc
  liblegacytaskmanager/startup.cpp
  liblegacytaskmanager/startup.h
  liblegacytaskmanager/strategies/activitysortingstrategy.cpp
  liblegacytaskmanager/strategies/activitysortingstrategy.h
  liblegacytaskmanager/strategies/alphasortingstrategy.cpp
  liblegacytaskmanager/strategies/alphasortingstrategy.h
  liblegacytaskmanager/strategies/desktopsortingstrategy.cpp
  liblegacytaskmanager/strategies/desktopsortingstrategy.h
  liblegacytaskmanager/strategies/manualgroupingstrategy.cpp
  liblegacytaskmanager/strategies/manualgroupingstrategy.h
  liblegacytaskmanager/strategies/manualsortingstrategy.cpp
  liblegacytaskmanager/strategies/manualsortingstrategy.h
  liblegacytaskmanager/strategies/programgroupingstrategy.cpp
  liblegacytaskmanager/strategies/programgroupingstrategy.h
  liblegacytaskmanager/task.cpp
  liblegacytaskmanager/task.h
  liblegacytaskmanager/task_p.h
  liblegacytaskmanager/task_win.cpp
  liblegacytaskmanager/task_x11.cpp
  liblegacytaskmanager/taskactions.cpp
  liblegacytaskmanager/taskactions.h
  liblegacytaskmanager/taskactions_p.h
  liblegacytaskmanager/taskgroup.cpp
  liblegacytaskmanager/taskgroup.h
  liblegacytaskmanager/taskitem.cpp
  liblegacytaskmanager/taskitem.h
  liblegacytaskmanager/tasksmodel.cpp
  liblegacytaskmanager/tasksmodel.h
  libtaskmanager/CMakeLists.txt
  libtaskmanager/LibTaskManagerConfig.cmake.in
  libtaskmanager/Mainpage.dox
  libtaskmanager/Messages.sh
  libtaskmanager/abstractgroupableitem.cpp
  libtaskmanager/abstractgroupableitem.h
  libtaskmanager/abstractgroupingstrategy.cpp
  libtaskmanager/abstractgroupingstrategy.h
  libtaskmanager/abstractsortingstrategy.cpp
  libtaskmanager/abstractsortingstrategy.h
  libtaskmanager/groupmanager.cpp
  libtaskmanager/groupmanager.h
  libtaskmanager/launcherconfig.cpp
  libtaskmanager/launcherconfig.h
  libtaskmanager/launcherconfig.ui
  libtaskmanager/launcheritem.cpp
  libtaskmanager/launcheritem.h
  libtaskmanager/launcherproperties.cpp
  libtaskmanager/launcherproperties.h
  libtaskmanager/launcherproperties.ui
  libtaskmanager/startup.cpp
  libtaskmanager/startup.h
  libtaskmanager/strategies/activitysortingstrategy.cpp
  libtaskmanager/strategies/activitysortingstrategy.h
  libtaskmanager/strategies/alphasortingstrategy.cpp
  libtaskmanager/strategies/alphasortingstrategy.h
  libtaskmanager/strategies/desktopsortingstrategy.cpp
  libtaskmanager/strategies/desktopsortingstrategy.h
  libtaskmanager/strategies/manualgroupingstrategy.cpp
  libtaskmanager/strategies/manualgroupingstrategy.h
  libtaskmanager/strategies/manualsortingstrategy.cpp
  libtaskmanager/strategies/manualsortingstrategy.h
  libtaskmanager/strategies/programgroupingstrategy.cpp
  libtaskmanager/strategies/programgroupingstrategy.h
  libtaskmanager/task.cpp
  libtaskmanager/task.h
  libtaskmanager/task_p.h
  libtaskmanager/task_win.cpp
  libtaskmanager/task_x11.cpp
  libtaskmanager/taskactions.cpp
  libtaskmanager/taskactions.h
  libtaskmanager/taskactions_p.h
  libtaskmanager/taskgroup.cpp
  libtaskmanager/taskgroup.h
  libtaskmanager/taskitem.cpp
  libtaskmanager/taskitem.h
  libtaskmanager/taskmanager.cpp
  

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[David Edmundson]

> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.
> 
> David Edmundson wrote:
> >so may the issue go away with the port to qscreen?
> 
> It should do.
> 
> It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 
> 
> there I list the events which cause the crash:
> 
> >Corona.cpp checks we are requesting a containment for a valid screen if 
> (screen >= 0 && screen < numScreens()) {
> 
> >This fails as numScreens() is Qt API based, whereas the signal we're 
> adding the output for is ShellCorona::addOutput
> 
> If Qt proceses the DBus event before we get the X event. You're out of 
> sync.
> (note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend 
> for kscreen was split into a separate process)
> 
> I fixed the case of them being out of sync at startup which was the main 
> time we got the crash, but it still apparently happens on unplugging/plugging 
> in a monitor.
> 
> As for this patch; sure you'll stop a crash, but you'll leave those 
> setups that would have crashed with a blank screen on the monitor they've 
> just plugged in.
> 
> Anthony Fieroni wrote:
> *but you'll leave those setups that would have crashed with a blank 
> screen*
> 
> Are you sure about that? So i'm not, still think KScreen has a false 
> positive signals, i.e. he will be done with screen recognazing

doesn't really matter: https://git.reviewboard.kde.org/r/125451/ is submitted 
and fixes the root cause.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 4:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 4:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.
> 
> David Edmundson wrote:
> >so may the issue go away with the port to qscreen?
> 
> It should do.
> 
> It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 
> 
> there I list the events which cause the crash:
> 
> >Corona.cpp checks we are requesting a containment for a valid screen if 
> (screen >= 0 && screen < numScreens()) {
> 
> >This fails as numScreens() is Qt API based, whereas the signal we're 
> adding the output for is ShellCorona::addOutput
> 
> If Qt proceses the DBus event before we get the X event. You're out of 
> sync.
> (note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend 
> for kscreen was split into a separate process)
> 
> I fixed the case of them being out of sync at startup which was the main 
> time we got the crash, but it still apparently happens on unplugging/plugging 
> in a monitor.
> 
> As for this patch; sure you'll stop a crash, but you'll leave those 
> setups that would have crashed with a blank screen on the monitor they've 
> just plugged in.

*but you'll leave those setups that would have crashed with a blank screen*

Are you sure about that? So i'm not, still think KScreen has a false positive 
signals, i.e. he will be done with screen recognazing


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On Май 30, 2016, 7:33 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Май 30, 2016, 7:33 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> xuetianweng wrote in main_wayland.cpp:449
> Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the 
> session I wonder if it will be inherit by the whole desktop session.

I don't understand the concern. The QT_IM_MODULE env variable set here in the 
code only affects KWin. It is not passed to any other process.

Setting QT_IM_MODULE env variables will still overwrite everything - except in 
KWin where the variable is pointless. So nothing changes except by default KWin 
can now offer a virtual keyboard.

REPOSITORY
  rKWIN KWin

BRANCH
  virtual-keyboard

REVISION DETAIL
  https://phabricator.kde.org/D1638

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: xuetianweng, sebas, mart, broulik, plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel