Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 252 - Still Unstable!

2016-07-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/252/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 17:02:41 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 36 - Still Failing!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 15:46:22 + Build duration: 5 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 249 - Still Unstable!

2016-07-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/249/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 15:46:42 + Build duration: 12 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 250 - Still Unstable!

2016-07-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 16:33:53 + Build duration: 12 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 39 - Still Failing!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 17:01:15 + Build duration: 41 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 38 - Still Failing!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/38/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 16:47:19 + Build duration: 44 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 251 - Still Unstable!

2016-07-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 16:49:39 + Build duration: 12 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 29 - Still Failing!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 16:43:09 + Build duration: 1 min 6 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 37 - Still Failing!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 16:33:23 + Build duration: 4 min 8 sec CHANGE SET Revision

[Differential] [Updated, 627 lines] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-13 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 5133. davidedmundson added a comment. Coding style changes REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2073?vs=4919=5133 BRANCH qgconf REVISION DETAIL

[Differential] [Updated, 626 lines] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-13 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 5134. davidedmundson added a comment. Addressed David's comments REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2073?vs=5133=5134 BRANCH qgconf REVISION DETAIL

[Differential] [Accepted] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-13 Thread drosca (David Rosca)
drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Please fix that last style issue and push, thanks! INLINE COMMENTS > modulemanager.h:42 > +public: > +ModuleManager(QObject *parent=nullptr); > +~ModuleManager(); This needs

[Differential] [Updated, 626 lines] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-13 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 5135. davidedmundson added a comment. spaces REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2073?vs=5134=5135 BRANCH qgconf REVISION DETAIL https://phabricator.kde.org/D2073

[Differential] [Requested Changes To] D2033: Clear idle timeouts when session becomes inactive

2016-07-13 Thread oliverhenshaw (Oliver Henshaw)
oliverhenshaw requested changes to this revision. oliverhenshaw added a reviewer: oliverhenshaw. oliverhenshaw added a comment. This revision now requires changes to proceed. I may not have much pull, but I'd rather these changes were revised again before being landed. Sorry! Note that

[Differential] [Requested Changes To] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-13 Thread drosca (David Rosca)
drosca requested changes to this revision. drosca added a reviewer: drosca. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > modulemanager.cpp:33 > +QObject(parent), > +m_combineSinksConfig(new GConfItem(PA_GCONF_PATH_MODULES"/combine", >

[Differential] [Abandoned] D2092: Fix icon loading in Widget Explorer

2016-07-13 Thread davidedmundson (David Edmundson)
davidedmundson abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2092 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson Cc: broulik, plasma-devel, jensreuterberg, abetts,

[Differential] [Closed] D2073: Add a KCM setting to control pulse audio module combine-sinks

2016-07-13 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA65b7db38: Add a KCM setting to control pulse audio module combine-sinks (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2073?vs=5135=5136#toc REPOSITORY

Re: The situation of KWallet, and what to do about it?

2016-07-13 Thread Albert Astals Cid
El dijous, 7 de juliol de 2016, a les 18:43:57 CEST, Elvis Angelaccio va escriure: > Hi, > thanks for raising this topic! > > 2016-07-07 12:36 GMT+02:00 Thomas Pfeiffer : > > Hi everyone, > > I'm addressing both the Plasma team and kde-devel because this issue > >

Re: The situation of KWallet, and what to do about it?

2016-07-13 Thread Albert Astals Cid
El dimecres, 13 de juliol de 2016, a les 11:41:14 CEST, Thomas Pfeiffer va escriure: > On Linux we could use GNOME Keyring, but if we don't want that, we'd of > course still have to implement our own backend. We could implement our own backend, and call it ... kwallet? :D SCNR Cheers,

[Differential] [Request, 16 lines] D2154: kscreen kcm: block changed signal after save

2016-07-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When changing position (and potentially other properties) of the screen setup, we receive delayed signals way

[Differential] [Request, 10 lines] D2155: kded: fix up invalid current mode before saving

2016-07-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When resizing a virtual machine, the current mode may become invalid. In this case, we set the current mode

[Differential] [Updated, 20 lines] D2154: kscreen kcm: block changed signal after save

2016-07-13 Thread Sebastian Kügler
sebas updated this revision to Diff 5139. sebas added a comment. - use compile-time connection REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2154?vs=5137=5139 BRANCH blockkcmchanges REVISION DETAIL https://phabricator.kde.org/D2154 AFFECTED

Re: The situation of KWallet, and what to do about it?

2016-07-13 Thread Albert Astals Cid
El dijous, 7 de juliol de 2016, a les 12:36:26 CEST, Thomas Pfeiffer va escriure: > Hi everyone, > I'm addressing both the Plasma team and kde-devel because this issue affects > Plasma as well as many applications, and Valentin as the current maintainer > of KWallet as well as KSecretService, a

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Andreas Kainz
> On Juli 13, 2016, 12:28 vorm., Sebastian Kügler wrote: > > Only the original string should be changed, not the translations. > > > > Have you run this by Thomas Pfeiffer, these strings are the result of > > careful restructuring we did before 5.0. Also, we shouldn't change these > > names

[Differential] [Commented On] D2149: [platforms/fbdev] Handle error conditions more gracefully

2016-07-13 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > bshah wrote in fb_backend.cpp:102 > Perhaps print warning here as well. The method initImageFormat already prints a warning. REPOSITORY rKWIN KWin BRANCH fbdev-init-failed-5.7 REVISION DETAIL https://phabricator.kde.org/D2149 EMAIL

Re: versioned dependencies on breeze

2016-07-13 Thread Martin Graesslin
On Tuesday, July 12, 2016 6:39:25 PM CEST Antonio Rojas wrote: > In Plasma 5.7 both kwin and plasma-integration added strict versioned > dependencies on Breeze: > > find_package(Breeze ${PROJECT_VERSION} CONFIG) > > Can this please be changed to depend on the actual minimum version required? >

[Differential] [Closed] D2134: [platforms/fbdev] Properly detect a BGR image format

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINaaf8ce16dfb2: [platforms/fbdev] Properly detect a BGR image format (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2134?vs=5098=5108

[Differential] [Closed] D2136: Call QCoreApplication::exit instead of stdlib exit to terminate if platform fails

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN56c2e158ee4e: Call QCoreApplication::exit instead of stdlib exit to terminate if platform… (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2135: [platforms/drm] Properly handle case that mapping the blank buffer fails

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINcd9a0afafa56: [platforms/drm] Properly handle case that mapping the blank buffer fails (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2078: Handle situation of no XDG_RUNTIME_DIR gracefully

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3c04d5295d5b: Handle situation of no XDG_RUNTIME_DIR gracefully (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2078?vs=4924=5112#toc REPOSITORY rKWIN KWin CHANGES

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/ --- (Updated Juli 13, 2016, 8:26 vorm.) Review request for Plasma. Changes

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Andreas Kainz
> On Juli 13, 2016, 12:28 vorm., Sebastian Kügler wrote: > > kcms/baloo/kcm_baloofile.desktop, line 22 > > > > > > The [$LANG] lines are all automatically added, they are generated > > by the translation system.

[Differential] [Closed] D2091: [server] Properly send a selection clear prior to keyboard focus enter

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDe65884f9eba6: [server] Properly send a selection clear prior to keyboard focus enter (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2077: [server] Handle no XDG_RUNTIME_DIR situation more gracefully

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND9033c364ba99: [server] Handle no XDG_RUNTIME_DIR situation more gracefully (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Request, 11 lines] D2149: [platforms/fbdev] Handle error conditions more gracefully

2016-07-13 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY So far if the framebuffer platform run into an error on

[Differential] [Accepted] D2149: [platforms/fbdev] Handle error conditions more gracefully

2016-07-13 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > fb_backend.cpp:102 > +if (m_imageFormat == QImage::Format_Invalid) { > +emit initFailed(); > +return; Perhaps print

[Breeze] [Bug 365318] KRDC is unreadable under breeze dark theme

2016-07-13 Thread Jens Reuterberg via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365318 Jens Reuterberg changed: What|Removed |Added CC||ohy...@gmail.com ---

[Differential] [Commented On] D2033: Clear idle timeouts when session becomes inactive

2016-07-13 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Don't worry, Oliver, I actually wasn't going to push this before I had further feedback from you. :) I'll address the clear all idle timeouts call (oh, how I wish I had already done the powerdevil-as-separate-binary thing) and then should be good to go, minus

Re: versioned dependencies on breeze

2016-07-13 Thread Antonio Rojas
Martin Graesslin wrote: > Well if KWin depends on Breeze you cannot parallel build KWin and Breeze. > That should be obvious. It could be theoretically possible to build Kwin and Breeze 5.7.1 in parallel against 5.7.0 packages if the dependencies were not versioned (actually parallel build was

[Differential] [Commented On] D2112: Add a shortcut for Meta+P

2016-07-13 Thread Sebastian Kügler
sebas added a comment. For the record, this change has been backported to Plasma 5.7, shipped with 5.7.1. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2112 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma,

[Differential] [Commented On] D2156: improve output identification

2016-07-13 Thread Sebastian Kügler
sebas added a comment. I'd like to get some feedback on the approach, however. I think this is actually a nice minimal fix, as we can't really change how the id is generated. I may be missing something here. This obviously needs some testing. It shouldn't break existing setups, but I

[Differential] [Request, 21 lines] D2156: improve output identification

2016-07-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When identical outputs (i.e. outputs with the same edid) are connected, the serializer can't match the outputs

[Differential] [Commented On] D2156: improve output identification

2016-07-13 Thread lbeltrame (Luca Beltrame)
lbeltrame added a comment. I have two identical screens set up as part of my 3 monitor set. I can test this. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas,

[Differential] [Closed] D2059: Merge signal connections for AbstractClient in Workspace

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN445335ba5f33: Merge signal connections for AbstractClient in Workspace (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2059?vs=4888=5115

[Differential] [Updated] D2085: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals

2016-07-13 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rKWIN KWin BRANCH sliding-popups-window-shown-hidden REVISION DETAIL https://phabricator.kde.org/D2085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, sebas

[Differential] [Closed] D2084: [libkwineffects] Add signals windowShown and windowHidden to EffectsHandler

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN5ee958ca7e4c: [libkwineffects] Add signals windowShown and windowHidden to EffectsHandler (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2085: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc6b25627105a: [effects] Adjust SlidingPopups to new windowShown and windowHidden signals (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2085?vs=4940=5118#toc

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

2016-07-13 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. I'll re-work a bunch of stuff, including image caching, and placement of credit text/logo based on where the panel is. Then I'll file a new revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES

[Differential] [Closed] D2083: Use hiddenInternal() for a ShellClient which got unmapped

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINa35ffa93d7d3: Use hiddenInternal() for a ShellClient which got unmapped (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2083?vs=4938=5116

Re: The situation of KWallet, and what to do about it?

2016-07-13 Thread Thomas Pfeiffer
On 11.07.2016 22:29, Mark Gaiser wrote: On Mon, Jul 11, 2016 at 9:58 PM, Thomas Pfeiffer > wrote: On 07.07.2016 19:50, Kevin Ottens wrote: There's two sides to that problem in fact, use from applications and the

Jenkins-kde-ci: plasma-workspace Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 35 - Still Failing!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 10:38:15 + Build duration: 46 sec CHANGE SET Revision

[Differential] [Closed] D2108: Add support for xdg-shell version 5 interface

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINc3af4c3f9cac: Add support for xdg-shell version 5 interface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2108?vs=5001=5121#toc REPOSITORY rKWIN KWin CHANGES

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128434/#review97343 --- See the inline comments. The things I've +1'd can be shipped

Porting C++ plasmoid and dataengine to plasma5

2016-07-13 Thread Simone Gaiarin
Hi all, time ago I've designed a Plasma 4 plasmoid together with a dataengine to configure and control a process (redshift). The structure is the following: - The plasmoid allow the user to start and stop the process, this is done by running a servicejob to commmunicate the dataengine to take an

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 248 - Still Unstable!

2016-07-13 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/248/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 10:39:15 + Build duration: 12 min CHANGE SET Revision

Re: Review Request 128431: Fix race condition when new applications open

2016-07-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/#review97342 --- Would it be possible to have a test there? It will be easier

[Differential] [Updated] D2102: Add support for xdg-shell

2016-07-13 Thread Martin Gräßlin
graesslin marked 9 inline comments as done. REPOSITORY rKWAYLAND KWayland BRANCH xdg-shell REVISION DETAIL https://phabricator.kde.org/D2102 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: sebas, plasma-devel,

[Differential] [Closed] D2102: Add support for xdg-shell

2016-07-13 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDb0acd7ad7539: Add support for xdg-shell (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2102?vs=5071=5120#toc REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Andreas Kainz
> On Juli 13, 2016, 12:04 nachm., Thomas Pfeiffer wrote: > > kcms/phonon/kcm_phonon.desktop, line 13 > > > > > > It does also contain settings for video recording devices, so it is not > > just audio. this kcm

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Andreas Kainz
> On Juli 13, 2016, 12:04 nachm., Thomas Pfeiffer wrote: > > kcms/baloo/kcm_baloofile.desktop, line 15 > > > > > > Hm, I'm not sure. From a user's perspective, it's relevant where the > > search can find things,

Re: Review Request 128431: Fix race condition when new applications open

2016-07-13 Thread Martin Tobias Holmedahl Sandsmark
> On July 13, 2016, 10:44 a.m., Aleix Pol Gonzalez wrote: > > Would it be possible to have a test there? It will be easier to review for > > us. what would the test test? nothing should call updateOrAddProcess(), ideally I'd just make it private, but I'm not sure how stable the libksysguard

Re: Review Request 128434: rename some kcm desktop files

2016-07-13 Thread Andreas Kainz
> On Juli 13, 2016, 12:04 nachm., Thomas Pfeiffer wrote: > > kcms/keys/keys.desktop, line 14 > > > > > > I thought we wanted to have both in the same KCM, just under different > > headings? > > We should

Re: Review Request 128423: fix rename file (or folder) in folder plugin (and desktop in folder mode)

2016-07-13 Thread Painless Roaster
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128423/ --- (Updated Čec. 13, 2016, 1:13 odp.) Review request for Plasma. Bugs:

Re: [RFC] WindowMetadata framework fundamentals

2016-07-13 Thread Thomas Pfeiffer
Hi sebas, On 13.07.2016 02:18, Sebastian Kügler wrote: During the Plasma sprint in March, we've been fleshing out plans to create a mechanisms for apps to be represented by the shell. The goals it to achieve a richer integration between apps and the workspace. The idea is that windows can

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-13 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D1989#39559, @bdhruve wrote: > I am not getting how to proceed further now, can you please help me on this? Also, current confusion i have is, should kwin_wayland nested window appear when i run qmlscene? Because currently it