Re: Implementing a panel in Plasma 5.8 needs a layout to accompany it?

2016-10-10 Thread Sebastian Kügler
On zaterdag 8 oktober 2016 21:43:59 CEST Michail Vourlakos wrote: > A small update for this for Plasma 5.8, > > removing "NoDisplay=true" from metadata.desktop is not an option for me... > The panel is appearing in the widgets list but there is the following not > acceptable behavior. > > If the

[Differential] [Accepted] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. INLINE COMMENTS > Background.qml:56 > +name: "colorBackground" > +when: sceneBackgroundType == "color" > +PropertyChanges { it might be

[Differential] [Closed] D3001: Avoid calling resize() with our current size

2016-10-10 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfbd11d8025ac: Avoid calling resize() with our current size (authored by l10n daemon script , committed by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99902 --- Fix it, then Ship it! tested several cases, normal load,

[Differential] [Changed Subscribers] D2981: Removes preferred definition so a new wallpaper is selected.

2016-10-10 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > image.cpp:245 > +// which has correct aspect ratio for the new screen size. > +m_wallpaperPackage.removeDefinition("preferred"); > +} shouldn't then "preferred" just not be defined anymore in the wallpaper package

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-10 Thread David Edmundson
> On Oct. 10, 2016, 11:23 a.m., Marco Martin wrote: > > src/plasma/pluginloader.cpp, line 561 > > > > > > this note isn't valid anymore? yes and no. It was, even in Plasma 5.8 the plasmoids runner used it.

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99906 --- src/plasma/pluginloader.cpp (line 539)

[Differential] [Request, 27 lines] D3003: Inherit from QQmlParserStatus and avoid busywork in Activity Pager case.

2016-10-10 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3003 AFFECTED FILES

Minutes Monday Plasma Meeting

2016-10-10 Thread Bhushan Shah
Attached the minutes for monday meetings Present on IRC: Sho_, notmart, mgraesslin, Riddell, d_ed, bshah, sebas Sho_ * Fixed regression to restore "wheel above group item only switches windows within group" mousewheel behavior in TM, on user request * Fixed regression causing FV contents to

[Differential] [Accepted] D3003: Inherit from QQmlParserStatus and avoid busywork in Activity Pager case.

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3003 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-10 Thread mart (Marco Martin)
mart added a comment. adding an event compression timer (that by the way, it's a perfectly fine, many times even desired thing) and solving the useless restore() calls at startup are two ortogonal pissues. an event compression there *may* be a good thing if during the normal use (like,

[Differential] [Request, 68 lines] D3004: [server] Use deleteLater when a ClientConnection gets destroyed

2016-10-10 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, bshah. Restricted Application added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In the situation that a wl_client gets destroyed while still wl_resources are around

[Differential] [Accepted] D3001: Avoid calling resize() with our current size

2016-10-10 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. yep.. no more positionPanel call.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3001 EMAIL PREFERENCES

[Differential] [Closed] D3003: Inherit from QQmlParserStatus and avoid busywork in Activity Pager case.

2016-10-10 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP942c3b356c03: Inherit from QQmlParserStatus and avoid busywork in Activity Pager case. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-10 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D2975#55706, @mart wrote: > adding an event compression timer (that by the way, it's a perfectly fine, many times even desired thing) and solving the useless restore() calls at startup are two ortogonal pissues. Double

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-10 Thread mart (Marco Martin)
mart added a comment. ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues, we reconsider this one again? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D2975: [shell] Event compress resizePanel

2016-10-10 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D2975#55709, @mart wrote: > ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup issues, we reconsider this one again? Okay looking onto it.

[Differential] [Request, 13 lines] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the check that was there, screen id not being more than screen count is not valid anymore with the screenpool

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. I can see how this is a bug that needs fixing for the a screen ID > screenCount but what about the case where the screenID isn't valid anymore? i.e a panel was on screen 2 you shutdown (assuming ID's are also 1 and 2 respectively) when you boot up you

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/ --- (Updated Oct. 10, 2016, 2:28 p.m.) Status -- This change has been

[Differential] [Updated] D3005: Library support for per-activity pinned tasks

2016-10-10 Thread hein (Eike Hein)
hein added a comment. Here's a few spontaneous thoughts ... not really meant as an in-depth review: - This is like a step 1, right? It appears the requestAdd/Remove APIs currently add/remove to all activities, so there's no way yet for users to make per-activity launchers? - I'm a

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3006#55743, @davidedmundson wrote: > I can see how this is a bug that needs fixing for the a screen ID > screenCount but what about the case where the screenID isn't valid anymore? > > i.e > a panel was on screen 2 you shutdown

[Differential] [Closed] D2985: Quicklaunch: Listen to external configuration changes

2016-10-10 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS0f4ec3e6da9c: Quicklaunch: Listen to external configuration changes (authored by drosca). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE

Re: [Differential] [Request, 396 lines] D3005: Library support for per-activity pinned tasks

2016-10-10 Thread Michail Vourlakos
I dont know if you would find this interesting.. In Now Dock Plasmoid (internally) I support per-activity pinned launchers. My use case is the following in case it will add information: - there are global launchers that can be shown in all activities (called Everywhere Launchers) - if the

[Differential] [Updated, 241 lines] D3005: Library support for per-activity pinned tasks

2016-10-10 Thread Ivan Čukić
ivan updated this revision to Diff 7276. ivan added a comment. - Library support for per-activity pinned tasks - Filtering now checks for the null activity - Exporting activities list through data member function - When a launcher is on all activities, the list is now empty - Relying

Re: Review Request 129100: Port some few remaining uses of pluginInfo to pluginMetaData

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129100/ --- (Updated Oct. 10, 2016, 6:42 p.m.) Status -- This change has been

Re: status of kde/plasma kiosk framework in kf5

2016-10-10 Thread Thomas Michael Weissel
hello plasma devs and community! i'm currently equipping 40 students with bootable flashdrives (kde neon 5.8 lts) and before deploying my fresh and shiny remastered system in all classrooms to (to annoy the teachers ;-) ) i did some tests with the kiosk framework. i stumbled over a small

[Differential] [Updated, 267 lines] D3005: Library support for per-activity pinned tasks

2016-10-10 Thread Ivan Čukić
ivan updated this revision to Diff 7277. ivan added a comment. - Validating the list of activities specified for a launcher - Nicer handling of duplicate urls REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3005?vs=7276=7277 BRANCH

[Differential] [Accepted] D2978: Implement support for the relative pointer protocol

2016-10-10 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWAYLAND KWayland BRANCH relative-pointer REVISION DETAIL https://phabricator.kde.org/D2978 EMAIL PREFERENCES

[Differential] [Closed] D2986: Systray: Move all icon resolution to dataengine

2016-10-10 Thread roberts (Lindsay Roberts)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE749f60b89f4a: Systray: Move all icon resolution to dataengine (authored by roberts). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99917 --- I confirm Kai's findings, to me it breaks loading of the

[Differential] [Accepted] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3011 EMAIL

[Differential] [Closed] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE4d0a0a453dbb: [SDDM Theme] Show caps lock warning (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Abandoned] D2956: [Lock Screen] When pressing Return just trigger button

2016-10-10 Thread broulik (Kai Uwe Broulik)
broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D2976 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2956 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread broulik (Kai Uwe Broulik)
broulik added a comment. I just made it consistent with what we have in the lock screen and with what we have had for years. We could surely change that (the bullet isn't translated anyway) but if we were to do this it must be consistently done in both places. REPOSITORY

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Kai Uwe Broulik
> On Okt. 10, 2016, 8:49 nachm., Kai Uwe Broulik wrote: > > This commit broke panel display/loading for me. > > > > When I have a system tray in a panel (eg. default panel) it won't show up > > on startup. Sorry, the REVIEW link in the commit was wrong. The offending commit is

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99914 --- Ship it! Ship It! - Marco Martin On Oct. 10, 2016,

[Differential] [Request, 18 lines] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We do the

[Differential] [Commented On] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 for the change! I think the string for failed unlock while capslock is on should be "Login failed (Caps lock is on)" though, as the "login failed" part is the more important one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/#review99915 --- This commit broke panel display/loading for me. When I have

[Differential] [Request, 2 lines] D3012: [DrKonqi] Update URL to Wiki page on how to create useful bug reports

2016-10-10 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The page has moved to

[Differential] [Accepted] D3004: [server] Use deleteLater when a ClientConnection gets destroyed

2016-10-10 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH fix-client-disconnecting REVISION DETAIL https://phabricator.kde.org/D3004 EMAIL PREFERENCES

[Differential] [Request, 4 lines] D3009: Fix logout translation message

2016-10-10 Thread guoyunhe (Yunhe Guo)
guoyunhe created this revision. guoyunhe added a reviewer: Plasma: Workspaces. guoyunhe set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The

[Differential] [Request, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

2016-10-10 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY PanelView::restore sets various properties including length, thickness, which would result in panel

[Differential] [Commented On] D3008: [shell] Don't resize or reposition panel if we are doing restore

2016-10-10 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > panelview.h:212 > int m_thickness; > +bool m_panelRestored; > Qt::Alignment m_alignment; code looks a bit weird but i see what it's trying to do.. i would give it another name, like m_initCompleted REPOSITORY rPLASMAWORKSPACE

[Differential] [Updated, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

2016-10-10 Thread bshah (Bhushan Shah)
bshah updated this revision to Diff 7270. bshah added a comment. rename var REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3008?vs=7269=7270 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3008 AFFECTED FILES

[Differential] [Accepted] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-10 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. a few docs improvements proposed, otherwise, it looks clean, clear and simple. INLINE COMMENTS > plasmashell.h:293 > +/** > + * Requests to hide a

[Differential] [Updated, 13 lines] D3008: [shell] Don't resize or reposition panel if we are doing restore

2016-10-10 Thread bshah (Bhushan Shah)
bshah updated this revision to Diff 7271. bshah added a comment. fix REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3008?vs=7270=7271 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3008 AFFECTED FILES

[Differential] [Accepted] D3008: [shell] Don't resize or reposition panel if we are doing restore

2016-10-10 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3008 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma,

[Differential] [Updated, 6 lines] D3009: Fix logout translation message

2016-10-10 Thread guoyunhe (Yunhe Guo)
guoyunhe removed rPLASMAWORKSPACE Plasma Workspace as the repository for this revision. guoyunhe updated this revision to Diff 7272. guoyunhe added a comment. Comparing commands should add context "log out command". This might be a copy-paste mistake. However, is it necessary to translate a

[Differential] [Closed] D3008: [shell] Don't resize or reposition panel if we are doing restore

2016-10-10 Thread bshah (Bhushan Shah)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc63baa3ae354: [shell] Don't resize or reposition panel if we are doing restore (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated] D2975: [shell] Event compress resizePanel

2016-10-10 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D2975#55717, @bshah wrote: > In https://phabricator.kde.org/D2975#55709, @mart wrote: > > > ok, so let's try to do the QQmlParserStatus thing (can you give a stab at it?) then when it's working and we know solves the startup

[Differential] [Accepted] D2979: Support for relative pointer motion events

2016-10-10 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWIN KWin BRANCH relative-pointer-events REVISION DETAIL https://phabricator.kde.org/D2979 EMAIL PREFERENCES

[Differential] [Accepted] D3009: Fix logout translation message

2016-10-10 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yes, it's fine that the command is translated REVISION DETAIL https://phabricator.kde.org/D3009 EMAIL PREFERENCES

[Differential] [Accepted] D2986: Systray: Move all icon resolution to dataengine

2016-10-10 Thread mart (Marco Martin)
mart accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: roberts, #plasma, davidedmundson, mart Cc: davidedmundson,

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-10 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 Harald Sitter changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO

[Differential] [Updated, 18 lines] D2985: Quicklaunch: Listen to external configuration changes

2016-10-10 Thread drosca (David Rosca)
drosca updated this revision to Diff 7241. drosca added a comment. Same logic also for popup launchers REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2985?vs=7226=7241 BRANCH Plasma/5.8 REVISION DETAIL

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-10 Thread Harald Sitter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 Harald Sitter changed: What|Removed |Added Version|unspecified |5.8.0

Re: Review Request 128956: Make KF5Baloo optional

2016-10-10 Thread Marco Martin
> On Oct. 10, 2016, 12:05 a.m., David Edmundson wrote: > > Ship It! still don't totally agree. actually, the proposal of disabling the runner when indexing is disabled makes sense. - Marco --- This is an automatically generated

[Differential] [Accepted] D2997: [server] Cancel previous selection from SeatInterface::setSelection

2016-10-10 Thread bshah (Bhushan Shah)
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-cancel-from-set-selection REVISION DETAIL https://phabricator.kde.org/D2997 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 42 lines] D2997: [server] Cancel previous selection from SeatInterface::setSelection

2016-10-10 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma on Wayland, bshah. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY When changing the selection the previous selection needs to be cancelled.

[Differential] [Closed] D2997: [server] Cancel previous selection from SeatInterface::setSelection

2016-10-10 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND5d6ab2c22396: [server] Cancel previous selection from SeatInterface::setSelection (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Request, 13 lines] D2996: [kwinrules] Hide all autogroup related widgets

2016-10-10 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Window tabs which are required for autogroup are currently not supported in KWin. Thus

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/ --- (Updated Oct. 10, 2016, 11:48 p.m.) Review request for KDE Frameworks

[Differential] [Accepted] D3012: [DrKonqi] Update URL to Wiki page on how to create useful bug reports

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3012 EMAIL PREFERENCES

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 10, 2016, 11:46 p.m.) Status -- This change has been

[Differential] [Closed] D2978: Implement support for the relative pointer protocol

2016-10-10 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND6dd6729f28b3: Implement support for the relative pointer protocol (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3004: [server] Use deleteLater when a ClientConnection gets destroyed

2016-10-10 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDc0aa3a4a2f13: [server] Use deleteLater when a ClientConnection gets destroyed (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Updated, 22 lines] D2991: Fix moving windows to a different activity.

2016-10-10 Thread hein (Eike Hein)
hein updated this revision to Diff 7246. hein added a comment. Use KWindowSystem instead of NetWinInfo. More sanity checking. Fix drop originating outside applet. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2991?vs=7245=7246

[Breeze] [Bug 370374] GRUB menu has huge lag due to theme

2016-10-10 Thread Roman via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370374 --- Comment #2 from Roman --- Thanks for the comprehensive guide. Will do the steps it in a few days when I'm back on my 4K monitor. -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Closed] D2991: Fix moving windows to a different activity.

2016-10-10 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf169fb653566: Fix moving windows to a different activity. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Plasma 5.9 Kickoff meeting delayed until next Monday

2016-10-10 Thread Aleix Pol
On Mon, Oct 10, 2016 at 12:33 PM, Jonathan Riddell wrote: > Plasma 5.9 Kickoff meeting is delayed until Monday 17th October, > 11:00UTC, 12:00BST, 13:00CEST in #plasma on Freenode. > > Jonathan Well then, I won't be able to be there. I'll try to send an e-mail with some

[Differential] [Accepted] D3000: If we manually invoke ::restore remove the pending timer to call restore

2016-10-10 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3000 EMAIL PREFERENCES

[Differential] [Updated, 7 lines] D2991: Fix moving windows to a different activity.

2016-10-10 Thread hein (Eike Hein)
hein updated this revision to Diff 7244. hein added a comment. Remove window from current activity, then add the target activity; keep any other activities. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2991?vs=7224=7244 BRANCH

[Differential] [Accepted] D2991: Fix moving windows to a different activity.

2016-10-10 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2991 EMAIL PREFERENCES

[Differential] [Closed] D2990: Fix circular logic causing Pager to remain hidden

2016-10-10 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPa109124d0ac6: Fix circular logic causing Pager to remain hidden (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 10 lines] D3000: If we manually invoke ::restore remove the pending timer to call restore

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also change positionPanelTimer to not call positionPanel() manually as restore already does

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

2016-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99900 --- +1 - David Edmundson On Oct. 7, 2016, 3:23 p.m., Aleix

[Differential] [Closed] D2995: No-op SeachRunner if indexing is disabled

2016-10-10 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6396bcd1243b: No-op SeachRunner if indexing is disabled (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3000: If we manually invoke ::restore remove the pending timer to call restore

2016-10-10 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6d9c6adae2e7: If we manually invoke ::restore remove the pending timer to call restore (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST

[Differential] [Request, 26 lines] D3001: Avoid calling resize() with our current size

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY resize(size()) does not no-op in QWindow, and actually processes the resizing. This performs

[Differential] [Requested A Review Of] D2991: Fix moving windows to a different activity.

2016-10-10 Thread hein (Eike Hein)
hein requested a review of this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2991 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, #plasma Cc: mart, plasma-devel, lesliezhai,

[Differential] [Accepted] D2980: Add event filter for key press/release events while KWin grabbed keyboard on root window

2016-10-10 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH mod-only-root-grabbed-keyboard REVISION DETAIL https://phabricator.kde.org/D2980 EMAIL PREFERENCES

Plasma 5.9 Kickoff meeting delayed until next Monday

2016-10-10 Thread Jonathan Riddell
Plasma 5.9 Kickoff meeting is delayed until Monday 17th October, 11:00UTC, 12:00BST, 13:00CEST in #plasma on Freenode. Jonathan

Re: Review Request 129050: kcm gnome

2016-10-10 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129050/ --- (Updated Okt. 10, 2016, 9:29 vorm.) Status -- This change has been

Re: Review Request 128726: klipper shortcut for open clipboard at mouse point

2016-10-10 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128726/ --- (Updated Okt. 10, 2016, 9:28 vorm.) Status -- This change has been

Re: Review Request 129048: Look and Feel -> Global Theme

2016-10-10 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129048/ --- (Updated Okt. 10, 2016, 9:29 vorm.) Status -- This change has been

Re: Review Request 129049: kcm window decoration

2016-10-10 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129049/ --- (Updated Okt. 10, 2016, 9:29 vorm.) Status -- This change has been

[Differential] [Updated, 7 lines] D2991: Fix moving windows to a different activity.

2016-10-10 Thread hein (Eike Hein)
hein updated this revision to Diff 7245. hein added a comment. Remove source activity id instead of current activity. Fixes drags originating from an activity delegate other than the one for the current activity. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 396 lines] D3005: Library support for per-activity pinned tasks

2016-10-10 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - The URL in the configuration file now contains also the list of activities it should be shown in - The

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 499 - Failure!

2016-10-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/499/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Oct 2016 14:31:01 + Build duration: 3 min 13 sec CHANGE SET Revision

[Differential] [Request, 220 lines] D3007: Add auto-hiding panel support to PlasmaShellSurface interface

2016-10-10 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This change adds support for auto-hiding panels. A PlasmaShellSurface with Role

[Differential] [Updated, 7 lines] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
mart updated this revision to Diff 7265. mart added a comment. - bring back old logic REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3006?vs=7263=7265 BRANCH phab/screenforcont REVISION DETAIL https://phabricator.kde.org/D3006

[Differential] [Closed] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEca1bf0e3e4c0: fix screenForContainment when screen ids > count (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3005: Library support for per-activity pinned tasks

2016-10-10 Thread Ivan Čukić
ivan added a comment. > This is like a step 1, right? It appears the requestAdd/Remove APIs > currently add/remove to all activities This is the first step that actually worked. Yes, the add/remove API will get a requestAdd/RemoveTo/FromCurrentActivity. > I'm a bit surprised

Re: Review Request 129101: Port to new plasma-framework API

2016-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129101/ --- (Updated Oct. 10, 2016, 2:30 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 500 - Fixed!

2016-10-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/500/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 10 Oct 2016 14:55:52 + Build duration: 19 min CHANGE SET Revision

[Differential] [Accepted] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/screenforcont REVISION DETAIL https://phabricator.kde.org/D3006 EMAIL PREFERENCES

[Differential] [Commented On] D3006: fix screenForContainment when screen ids > count

2016-10-10 Thread mart (Marco Martin)
mart added a comment. this version has the old logic again, it iterates trough all the screens but doesn't check for ids being < of the count, it just checks that thre is a qscreen for that screen id by using the association in screenpool REPOSITORY rPLASMAWORKSPACE Plasma Workspace

  1   2   >