[Differential] [Request, 27 lines] D3374: [effects] Introduce kcfg for FallApart effect

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REPOSITORY
  rKWIN KWin

BRANCH
  fall-apart-kcfgc

REVISION DETAIL
  https://phabricator.kde.org/D3374

AFFECTED FILES
  effects/CMakeLists.txt
  effects/fallapart/fallapart.cpp
  effects/fallapart/fallapart.kcfg
  effects/fallapart/fallapartconfig.kcfgc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3335: Move resolving glxSwapIntervalMesa into platform plugin

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-resolve-in-platform

REVISION DETAIL
  https://phabricator.kde.org/D3335

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision is now accepted and ready to land.


  sounds sane.

REPOSITORY
  rKWIN KWin

BRANCH
  glide-no-atom

REVISION DETAIL
  https://phabricator.kde.org/D3296

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3332: Move querying glx extensions into the platform plugin

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN730fd05f58f9: Move querying glx extensions into the 
platform plugin (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3332?vs=8076=8192

REVISION DETAIL
  https://phabricator.kde.org/D3332

AFFECTED FILES
  debug_console.cpp
  libkwineffects/kwinglutils.cpp
  libkwineffects/kwinglutils.h
  plugins/platforms/x11/standalone/glxbackend.cpp
  plugins/platforms/x11/standalone/glxbackend.h
  scene_opengl.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D3362: Port KillWindow to X11EventFilter

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN52cf47ff53bc: Port KillWindow to X11EventFilter (authored 
by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3362?vs=8149=8194

REVISION DETAIL
  https://phabricator.kde.org/D3362

AFFECTED FILES
  events.cpp
  killwindow.cpp
  killwindow.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3361: Support multiple event types in X11EventFilter

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN9f976a4b8dd7: Support multiple event types in 
X11EventFilter (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3361?vs=8148=8193

REVISION DETAIL
  https://phabricator.kde.org/D3361

AFFECTED FILES
  autotests/test_xrandr_screens.cpp
  events.cpp
  x11eventfilter.cpp
  x11eventfilter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

[Martin Gräßlin]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWIN3041b871ea2c: [libkwineffects] Delete 
EffectsHandler::deleteRootProperty (authored by graesslin).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3298?vs=7981=8190

REVISION DETAIL
  https://phabricator.kde.org/D3298

AFFECTED FILES
  autotests/mock_effectshandler.h
  effects.cpp
  effects.h
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3329: Move glx version check functionality to platform plugin

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3329#62981, @bshah wrote:
  
  > With @broulik 's comment addressed.. +1
  
  
  for the record: I'm not going to port the code to QVersionNumber. Internally 
KWin has the kVersionNumber which is used quite a lot in the code base.

REPOSITORY
  rKWIN KWin

BRANCH
  glx-version-check-platform

REVISION DETAIL
  https://phabricator.kde.org/D3329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3298#62976, @bshah wrote:
  
  > Assuming this doesn't break any other 3rd party effects(?)
  
  
  To my knowledge there are no 3rd party effects. And even if: we broke the ABI 
in 5.9 already, so at least a recompile is needed. Given that the method is not 
even documented I consider it unlikely that it was used

REPOSITORY
  rKWIN KWin

BRANCH
  effectshandler-drop-delete-root-property

REVISION DETAIL
  https://phabricator.kde.org/D3298

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3329: Move glx version check functionality to platform plugin

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision is now accepted and ready to land.


  With @broulik 's comment addressed.. +1

REPOSITORY
  rKWIN KWin

BRANCH
  glx-version-check-platform

REVISION DETAIL
  https://phabricator.kde.org/D3329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

[bshah (Bhushan Shah)]

bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision is now accepted and ready to land.


  Assuming this doesn't break any other 3rd party effects(?)

REPOSITORY
  rKWIN KWin

BRANCH
  effectshandler-drop-delete-root-property

REVISION DETAIL
  https://phabricator.kde.org/D3298

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma_on_wayland, #kwin, bshah
Cc: bshah, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3370: KillWindow support for Wayland windows

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3370#62908, @cfeck wrote:
  
  > 5 seconds seems long in the face of a user. But if the application does 
actually handle the termination signal, and needs more than 5 seconds for 
cleanup, does it mean the cleanup procedure will be interrupted/aborted, or is 
only the GUI connection disconnected?
  
  
  The GUI connection gets disconnected which will raise a Wayland error on 
client side. How the application handles this is toolkit specific. In case of 
QtWayland it will result in an ::exit(1)
  
  And it's also no guarantee that the window will be gone. In case of Qt it 
works as the Wayland connection is hold in another thread, so if the main 
thread is frozen and cannot react to the sigterm, the destroy of the Wayland 
connection will still work.
  
  So overall the 5 sec are a main-thread freeze protection and could be changed 
in whatever way we want.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3370

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: cfeck, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3365: Implement interactive window selection for Wayland platforms

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in input.cpp:488
> Can this happen? You check for buttons being NoButton and then for button 
> being RightButton?

Yes of course. QMouseEvent::buttons contains the buttons currently hold. So we 
test that no buttons are currently pressed. And QMouseEvent::button contains 
the button which generated the event.

So this tests that the right mouse button was released and no further button is 
hold.

> broulik wrote in input.cpp:1409
> Where is that being cleaned up?

like all InputEventFilters in InputRedirection::~InputRedirection

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3361: Support multiple event types in X11EventFilter

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> broulik wrote in x11eventfilter.cpp:58
> m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector 
> constructor?

no, it cannot be empty. just two lines above there is a check for m_eventTypes 
having exactly one element.

REPOSITORY
  rKWIN KWin

BRANCH
  x11-event-filter-multiple-types

REVISION DETAIL
  https://phabricator.kde.org/D3361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

[Martin Gräßlin]

graesslin added a dependent revision: D3297: [libkwineffects] Remove 
EffectsHandler::registerPropertyType.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3296

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType

[Martin Gräßlin]

graesslin added a dependency: D3296: [effects] Improve interaction between 
Glide and SlidingPopups effect.

REPOSITORY
  rKWIN KWin

BRANCH
  kwineffects-drop-register-property-type

REVISION DETAIL
  https://phabricator.kde.org/D3297

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[colomar (Thomas Pfeiffer)]

colomar added a comment.


  I haven't had the chance to play with it and I think we should still have a 
plan B if we get negative feedback on it during beta tests, but the concept as 
it is described in the latest comments makes sense to me.

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng added a subscriber: Plasma.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3372

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: #plasma, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Request, 114 lines] D3372: Remove Webkit usage in potd data engine.

[xuetianweng (Xuetian Weng)]

xuetianweng created this revision.
xuetianweng added reviewers: mart, hein, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  For natgeoprovider, since the page it can be accepted by QXmlStreamReader
  to get required content, we simple parse it as XML (HTML is NOT necessarily
  valid XML).
  
  For noaaprovider, QXmlStreamReader will hit an error in the middle of parsing
  so we use regular expression to extract the url.

TEST PLAN
  Manually test with plasmashell

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3372

AFFECTED FILES
  CMakeLists.txt
  dataengines/potd/CMakeLists.txt
  dataengines/potd/natgeoprovider.cpp
  dataengines/potd/natgeoprovider.h
  dataengines/potd/noaaprovider.cpp
  dataengines/potd/noaaprovider.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, mart, hein, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

[Albert Astals Cid]

El dimarts, 15 de novembre de 2016, a les 14:43:04 CET, Marco Martin va 
escriure:
> On Thu, Nov 3, 2016 at 4:12 PM, Jonathan Riddell  wrote:
> > Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in
> 
> Stuttgart.
> 
> > https://community.kde.org/Plasma/Affenfels
> > 
> > https://reimbursements.kde.org/events/25
> > 
> > Includes the option of a road trip from FOSDEM if you're going to both.
> 
> I'm booking the various stuff now, so as usual questions about the
> terrible reimbursements.kde.org ...

Ahh, the old let's complain but without any specifics to make sure we motivate 
people to work on it!

Cheers,
  Albert

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  I have to agree with Eike here and also apologies for chiming in at this late 
step.
  
  From what I can tell a full-blown web-engine isn't needed here at all.
  
  The NOAA one just looks for all script tags and extracts the URL from the 
_curPic call and the NatGeo one just looks for the meta og:image – both of 
which could be done by using plain Qt XML without any web engine involved.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: broulik, hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

[hein (Eike Hein)]

hein added a comment.


  Sorry to react to this late, but I'm not happy about adding a non-optional 
build dependency on QtWebkit at this stage ...

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: hein, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3370: KillWindow support for Wayland windows

[cfeck (Christoph Feck)]

cfeck added a comment.


  5 seconds seems long in the face of a user. But if the application does 
actually handle the termination signal, and needs more than 5 seconds for 
cleanup, does it mean the cleanup procedure will be interrupted/aborted, or is 
only the GUI connection disconnected?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3370

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: cfeck, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

[Lydia Pintscher]

On Nov 15, 2016 14:43, "Marco Martin"  wrote:
>
> On Thu, Nov 3, 2016 at 4:12 PM, Jonathan Riddell  wrote:
> > Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in
> Stuttgart.
> >
> > https://community.kde.org/Plasma/Affenfels
> >
> > https://reimbursements.kde.org/events/25
> >
> > Includes the option of a road trip from FOSDEM if you're going to both.
>
> I'm booking the various stuff now, so as usual questions about the
> terrible reimbursements.kde.org ...
>
> since will have to go a piece by train, and  the db site won't let me
> buy tickets for february yet (frankfurt-stuttgart), I still have to
> put a random price guess, is that ok?

Use the regular price it gives you now if possible.

> accomodation: do we have to put that in the reimbursment app as well?
> (if so i guess just half of us would need to if we take all doubles)

If you pay it individually then yes. If it is a group booking that the
board approved separately with the sprint organizer then no.

Cheers
Lydia

[Differential] [Closed] D3184: Bring potd wallpaper back to life.

[xuetianweng (Xuetian Weng)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKDEPLASMAADDONS8f1310dd1e9a: Bring potd wallpaper back to 
life. (authored by xuetianweng).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D3184?vs=7712=8180#toc

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3184?vs=7712=8180

REVISION DETAIL
  https://phabricator.kde.org/D3184

AFFECTED FILES
  wallpapers/potd/contents/config/main.xml
  wallpapers/potd/contents/ui/config.qml
  wallpapers/potd/contents/ui/main.qml
  wallpapers/potd/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3183: Port potd (picture of the day) dataengine to KF5.

[xuetianweng (Xuetian Weng)]

xuetianweng closed this revision.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3365: Implement interactive window selection for Wayland platforms

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> input.cpp:488
> +if (event->buttons() == Qt::NoButton) {
> +if (event->button() == Qt::RightButton) {
> +cancel();

Can this happen? You check for buttons being NoButton and then for button being 
RightButton?

> input.cpp:1409
>  installInputEventFilter(new LockScreenFilter);
> +m_windowSelector = new WindowSelectorFilter;
> +installInputEventFilter(m_windowSelector);

Where is that being cleaned up?

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3361: Support multiple event types in X11EventFilter

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> x11eventfilter.cpp:58
> +}
> +return m_eventTypes.first() == XCB_GE_GENERIC;
> +}

m_eventTypes could be empty here, maybe add a Q_ASSERT in the QVector 
constructor?

REPOSITORY
  rKWIN KWin

BRANCH
  x11-event-filter-multiple-types

REVISION DETAIL
  https://phabricator.kde.org/D3361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: broulik, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 131 lines] D3370: KillWindow support for Wayland windows

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  AbstractClient gains a new pure virtual killWindow method and this gets
  implemented in ShellClient.
  
  ShellClient performs the killing by sending a term signal to the
  process. This can only work if the client connected through the socket
  and didn't get a socketpair fd passed. In that case the pid is KWin's
  and KWin doesn't want to terminate. Thus this is special handled to
  destroy the connection instead.
  
  In case terminating the process has no effect, the connection gets
  destroyed after five seconds.
  
  The KillWindow is adjusted to operate on AbstractClient instead of
  Client.
  
  This implements https://phabricator.kde.org/T4463.

TEST PLAN
  Killed windows and auto test

REPOSITORY
  rKWIN KWin

BRANCH
  kill-window-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3370

AFFECTED FILES
  abstract_client.h
  autotests/integration/helper/CMakeLists.txt
  autotests/integration/helper/kill.cpp
  autotests/integration/shell_client_test.cpp
  client.h
  killwindow.cpp
  shell_client.cpp
  shell_client.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3370: KillWindow support for Wayland windows

[Martin Gräßlin]

graesslin added a dependency: D3365: Implement interactive window selection for 
Wayland platforms.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3370

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3365: Implement interactive window selection for Wayland platforms

[Martin Gräßlin]

graesslin added a dependent revision: D3370: KillWindow support for Wayland 
windows.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3355: add maskArea in panel view

[mvourlakos (Michail Vourlakos)]

mvourlakos added a comment.


  In https://phabricator.kde.org/D3355#62804, @mart wrote:
  
  > In https://phabricator.kde.org/D3355#62769, @mvourlakos wrote:
  >
  > > In https://phabricator.kde.org/D3355#62728, @mart wrote:
  > >
  > > > another thing, even if the input mask is correct, it would still not 
work correctly: both window maximizing and snapping would go to the real 
geometry of the window, making the "trick" obvious. window maximization could 
be fixed by setting different struts, but that would *not* work on wayland.
  > >
  > >
  > > Isnt possible for kwin to take into account the mask used in the panel in 
order to provide correct maximizing and snapping?
  >
  >
  > as far i know, no
  >
  > > One more point, the issue for the maximizing and snapping refers only to 
"Always Visible" panel state, the other three states "Windows can Cover, 
Autohide etc." do not have any issue... Most of my dock users do not use at all 
"Always Visible" state... Most of them use "Below Active" state which is not 
supported yet (I was hoping that I will make a patch for this in the future) 
and they live happilly with "Windows Can Cover".
  >
  > windows can cover have problem with snapping as well.
  
  
  this is true, I have just checked it...
  
  >>> - now it can animate and zoom where it wants, anywhere in the screen
  >>> - when the cursor goes away the icons area, the icons animate to small 
again, then gets reparented to the real panel again, the second window gets 
hidden again
  >> 
  >> I am not that sure about the above...
  >> 
  >> - how fast can all this be in order to catch up and not create glitches?
  > 
  > I don't know: only way would be trying it (preferably with a small test 
case before going full scale)
  >  on plasma mobile seems to work quite well. (worst case scenario this 
external window would be always visible?
  
  I dont think so but I cant even imagine...  so many corner cases that I can 
not think of... Taking the fact that plasmoids are animated and open other 
windows also e.g. the compact represation case...
  
  >> - how from my qml container will be able to disable blur and contrast 
effects for this window and how this window will know the x,y coordinates of 
the panel(dock) in the screen?
  > 
  > probably you would have to write your own c++ part that would register a 
c++ based qquickwindow subclass that would do all you need to make the thing 
seamless enough
  >  (if your c++ implementation has pointers to the object you need to 
reparent and its normal parent, then tracking the real panel geometry is easy)
  > 
  > the thing is: in itself kindof makes sense, but i think that following this 
approach is technically impossible to arrive to something that works well 
enough, since there is no way to make the window manager to play well enough 
with windows with a "fake" size.
  > 
  > I think a different way should be tried beforehand.
  
  I can understand the concerns but being honest... I think that this is a lot 
above my programming expertise and taking the fact how many things must be 
adjusted by the fact that this is going to be a fake panel above a real panel, 
it looks enormous and advance for me... Exhausted only to think it...
  
  I will probably leave it that way if anyone wants to try any future 
roadmaps...

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3341: add connector name to screen model

[mart (Marco Martin)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rKWINc304c0a69cc0: add connector name to screen model 
(authored by mart).

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3341?vs=8166=8167

REVISION DETAIL
  https://phabricator.kde.org/D3341

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 34 lines] D3341: add connector name to screen model

[mart (Marco Martin)]

mart updated this revision to Diff 8166.
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - shorter form of s_connectorNames.value()

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3341?vs=8157=8166

BRANCH
  arcpatch-D3341

REVISION DETAIL
  https://phabricator.kde.org/D3341

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D3341: add connector name to screen model

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  arcpatch-D3341

REVISION DETAIL
  https://phabricator.kde.org/D3341

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3355: add maskArea in panel view

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D3355#62769, @mvourlakos wrote:
  
  > In https://phabricator.kde.org/D3355#62728, @mart wrote:
  >
  > > another thing, even if the input mask is correct, it would still not work 
correctly: both window maximizing and snapping would go to the real geometry of 
the window, making the "trick" obvious. window maximization could be fixed by 
setting different struts, but that would *not* work on wayland.
  >
  >
  > Isnt possible for kwin to take into account the mask used in the panel in 
order to provide correct maximizing and snapping?
  
  
  as far i know, no
  
  > One more point, the issue for the maximizing and snapping refers only to 
"Always Visible" panel state, the other three states "Windows can Cover, 
Autohide etc." do not have any issue... Most of my dock users do not use at all 
"Always Visible" state... Most of them use "Below Active" state which is not 
supported yet (I was hoping that I will make a patch for this in the future) 
and they live happilly with "Windows Can Cover".
  
  windows can cover have problem with snapping as well.
  
  >> - now it can animate and zoom where it wants, anywhere in the screen
  >> - when the cursor goes away the icons area, the icons animate to small 
again, then gets reparented to the real panel again, the second window gets 
hidden again
  > 
  > I am not that sure about the above...
  > 
  > - how fast can all this be in order to catch up and not create glitches?
  
  I don't know: only way would be trying it (preferably with a small test case 
before going full scale)
  on plasma mobile seems to work quite well. (worst case scenario this external 
window would be always visible?
  
  > - how from my qml container will be able to disable blur and contrast 
effects for this window and how this window will know the x,y coordinates of 
the panel(dock) in the screen?
  
  probably you would have to write your own c++ part that would register a c++ 
based qquickwindow subclass that would do all you need to make the thing 
seamless enough
  (if your c++ implementation has pointers to the object you need to reparent 
and its normal parent, then tracking the real panel geometry is easy)
  
  > So, do you have concluded that this patch isnt going to be accepted in 
Plasma?
  
  the thing is: in itself kindof makes sense, but i think that following this 
approach is technically impossible to arrive to something that works well 
enough, since there is no way to make the window manager to play well enough 
with windows with a "fake" size.
  
  I think a different way should be tried beforehand.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 108 lines] D3367: [effects] Add interactive window selection mode to ScreenshotEffect

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  EffectsHandler gains a new method to startInteractiveWindowSelection
  which just delegates to the one in Platform. That way a window can be
  selected and returned to an Effect.
  
  The screenshot effect makes use of this new functionality and provides
  an interactive window screenshot mode which saves to a temporary file.
  Note that this is not yet the variant intended for use in spectacle.

TEST PLAN
  Took a screenshot on Wayland

REPOSITORY
  rKWIN KWin

BRANCH
  screenshot-interactive-selection

REVISION DETAIL
  https://phabricator.kde.org/D3367

AFFECTED FILES
  autotests/mock_effectshandler.h
  effects.cpp
  effects.h
  effects/screenshot/screenshot.cpp
  effects/screenshot/screenshot.h
  libkwineffects/kwineffects.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3341: add connector name to screen model

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> drm_output.cpp:196
>  
> +QString connectorName = 
> s_connectorNames.contains(connector->connector_type) ? 
> s_connectorNames.value(connector->connector_type) : 
> QByteArrayLiteral("Unknown");
> +QString modelName;

QString connectorName = s_connectorNames.value(connector->connector_type, 
QByteArrayLiteral("Unknown");

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3341

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3363: Support interactive window selection through the Platform

[Martin Gräßlin]

graesslin added a dependent revision: D3367: [effects] Add interactive window 
selection mode to ScreenshotEffect.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3363

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3367: [effects] Add interactive window selection mode to ScreenshotEffect

[Martin Gräßlin]

graesslin added a dependency: D3363: Support interactive window selection 
through the Platform.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3367

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType

[davidedmundson (David Edmundson)]

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  kwineffects-drop-register-property-type

REVISION DETAIL
  https://phabricator.kde.org/D3297

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, davidedmundson
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3355: add maskArea in panel view

[mvourlakos (Michail Vourlakos)]

mvourlakos added a comment.


  In https://phabricator.kde.org/D3355#62728, @mart wrote:
  
  > another thing, even if the input mask is correct, it would still not work 
correctly: both window maximizing and snapping would go to the real geometry of 
the window, making the "trick" obvious. window maximization could be fixed by 
setting different struts, but that would *not* work on wayland.
  
  
  Isnt possible for kwin to take into account the mask used in the panel in 
order to provide correct maximizing and snapping?
  
  One more point, the issue for the maximizing and snapping refers only to 
"Always Visible" panel state, the other three states "Windows can Cover, 
Autohide etc." do not have any issue... Most of my dock users do not use at all 
"Always Visible" state... Most of them use "Below Active" state which is not 
supported yet (I was hoping that I will make a patch for this in the future) 
and they live happilly with "Windows Can Cover".
  
  > An alternative approach for the parabolic zoom of your dock I tought 
instead is doing in a similar way of plasma mobile (for its top, pull-down 
slide panel):
  > 
  > - the panel would have the "real" geometry, always "small"
  > - when the mouse goes over it, another window that is not the panel appears 
(i think it would be either a dock window or a bypasswindowmanagerhit one) it 
may either be a fullscreen window or just the size of the maximum extent the 
icons would zoom
  > - the icon list gets reparented in the new window, tough positioned exactly 
over the panel actual geometry
  > - now it can animate and zoom where it wants, anywhere in the screen
  > - when the cursor goes away the icons area, the icons animate to small 
again, then gets reparented to the real panel again, the second window gets 
hidden again
  
  I am not that sure about the above...
  
  - how fast can all this be in order to catch up and not create glitches?
  - how from my qml container will be able to disable blur and contrast effects 
for this window and how this window will know the x,y coordinates of the 
panel(dock) in the screen?
  
  So, do you have concluded that this patch isnt going to be accepted in Plasma?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Minutes Monday Plasma Meeting

[Sebastian Kügler]

Minutes from Monday's weekly Plasma meeting
-- 
sebas

http://www.kde.org | http://vizZzion.orgPlasma Meeting minutes 14-11-2016

Present: notmart, kbroulik, d_ed, bshah, Sho, romangg, sebas

notmart:
* triaging
* wednesday passed in effort to iron out multiscreen problems
* Kirigami2
** side drawers not on overlay drawer when modal, but on the same layer to make 
easier to put stuff on top, as is expected by a normal sidebar
** bumped import version to 2.0, installs in org.kde.kirigami.2, to allow 
coinstallability with kirigami 1
* Desktop QQC2 style:
** SpinBox.qml
** Popup.qml
** Menu.qml
** MenuItem.qml
** quite a storm on qt devel mailinglist and channels :o somebody asked for it 
to be upstreamed (in a bit trolling way) I'm torn on this: iwould be nice but i 
don' tink it would be worth the big amount of time that would have be consumed 
by that, given thta is to be a temporary solution

kbroulik:
* Fixed Google Chrome webapps task manager mapping rules (chrome needlessly 
changed window id from google-chrome to Google-chrome)
HoloIRCUser2 is now known as llucas
* Worked on indicating applications playing audio in task manager: 
http://blog.broulik.de/2016/11/distraction-free-workspace/ - infrastructure is 
merged (X only so far, will look into Wayland impl); applet bits on review: 
https://phabricator.kde.org/D3302  Diff 3302 "[Task Manager] Indicate 
applications playing audio" [Needs Review] https://phabricator.kde.org/D3302
* Don't forget to add yourselves to https://community.kde.org/Plasma/Affenfels


d_ed:
* helped with some multiscreen things
* still working on the kwin scaling, now the openGL side
* still stuck on one thing there, but some progress

bshah:
- Investigating new device for plasma mobile
- Talking with some community members for more device ports
- slightly hard but want to increase coverage of devices for plasma mobile
I've some rough plans on how community can work on ports..

Sho:
* Code reviews and talk on kwin/kwayland stuff, libtm (pid data role by Kai, 
optimizations by Aleix), other stuff
* Some reddit discussion
* Yakuake work
** More talk with Marco about KPackage docs and a KPackage macro issue
** Theme loading and switching (based on KPackage)
** Window shadows from theme
** Lots of thinking and playing around with basic architecture of what and how 
components and context data get exposed to the QML inside the themes running 
the UI
* Will probably do some short vacationing at the end of Nov or in Dec (too many 
untaken v-days), still looking for dates

romangg:
* I worked on the touchpad kcm in wayland. lots of new stuff to learn for me 
again so progress is slow. but it's steady: I integrate it in the old kcm and 
it switches the backend and gui (wayland one is qml based) if in wayland 
session.

sebas:
- triaged a bunch of kscreen bugs
- finally able to reproduce the "plasma doesn't adapt to vm host window" problem
- working on fixing this bug, but waiting for neon to be rebuilt
- picking up the work on the OSD, though I started to have problems starting 
kwayland, will check with mgraesslin
- this week is mostly focused on OSD, new KCM and the dynamic modes stuff in 
kscreen


Full log:

12:00:47  Meeting!
12:00:52  Who's in?
12:00:57  here
12:01:00 -*- bshah
12:01:03 -*- kbroulik
12:01:09 -*- d_ed here
12:01:17  here
12:01:23  romangg: do you have a link to your client code?
12:02:00  d_ed: ok. i pushed my try by changing the cmake file also 
now.
12:02:15  notmart: wanna start?
12:02:43  ok
12:02:50  * triaging
12:02:51  * wednesday passed in effort to iron out multiscreen problems
12:02:53  * Kirigami2
12:02:54  ** side drawers not on overlay drawer when modal, but on the 
same layer to make easier to put stuff on top, as is expected by a normal 
sidebar
12:02:56  ** bumped import version to 2.0, installs in 
org.kde.kirigami.2, to allow coinstallability with kirigami 1
12:02:57  * Desktop QQC2 style:
12:02:59  ** SpinBox.qml
12:03:00  ** Popup.qml
12:03:02  ** Menu.qml
12:03:03  ** MenuItem.qml
12:03:05  ** quite a storm on qt devel mailinglist and channels :o 
somebody asked for it to be upstreamed (in a bit trolling way) I'm torn on 
this: iwould be nice but i don' tink it would be worth the big amount of time 
that would have be consumed by that, given thta is to be a temporary solution
12:03:31 -*- Sho_ had a somewhat heated follow-up exchange about this in 
#qt-labs as well
12:03:34  questions/next?
12:03:50 --> HoloIRCUser2 (~holo...@user-94-254-161-203.play-internet.pl) has 
joined #plasma
12:04:07  kbroulik: your turn
12:04:17  * Fixed Google Chrome webapps task manager mapping rules 
(chrome needlessly changed window id from google-chrome to Google-chrome)
12:04:21 <-> HoloIRCUser2 is now known as llucas
12:04:28  * Worked on indicating applications playing audio in task 
manager: http://blog.broulik.de/2016/11/distraction-free-workspace/ - 
infrastructure is merged (X only so far, will look into Wayland impl); applet 
bits on review: 

Re: Review Request 129400: Avoid potential access of .last() on empty list

[Marco Martin]

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote:
> > src/kpackagetool/kpackagetool.cpp, line 502
> > 
> >
> > Then just change to `QStandardPath::locate`?
> 
> David Edmundson wrote:
> Sounds sensible to me. Though I don't really know this code.
> Marco, should I do that?

err, comment in the review below was intended as answer for this thread (damn 
ui ;)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129400/#review100834
---


On Nov. 14, 2016, 1:35 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129400/
> ---
> 
> (Updated Nov. 14, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> locateAll can return nothing, therefore we can't always call .last() on
> it.
> 
> Existing code should be able to handle an empty package root as the user
> could also also have provided a broken package root as an argument.
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db 
> 
> Diff: https://git.reviewboard.kde.org/r/129400/diff/
> 
> 
> Testing
> ---
> 
> Ran kpackagetool --generate-index -g
> 
> Previously asserted. No longer asserted.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129400: Avoid potential access of .last() on empty list

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129400/#review100858
---


Fix it, then Ship it!




other than that, ship it


src/kpackagetool/kpackagetool.cpp (line 502)


no, locate would return the first most suitable it found, that is usually 
the local one under ~/.local

whuile this being with global option we need the system one instead. I 
don't see an option in qstandardpaths to ignore the local stuff, so using the 
last one of the things returned by locateAll is the better heuristic i found 
for having this behavior


- Marco Martin


On Nov. 14, 2016, 1:35 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129400/
> ---
> 
> (Updated Nov. 14, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> locateAll can return nothing, therefore we can't always call .last() on
> it.
> 
> Existing code should be able to handle an empty package root as the user
> could also also have provided a broken package root as an argument.
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db 
> 
> Diff: https://git.reviewboard.kde.org/r/129400/diff/
> 
> 
> Testing
> ---
> 
> Ran kpackagetool --generate-index -g
> 
> Previously asserted. No longer asserted.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

[Marco Martin]

On Thu, Nov 3, 2016 at 4:12 PM, Jonathan Riddell  wrote:
> Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in 
Stuttgart.
>
> https://community.kde.org/Plasma/Affenfels
>
> https://reimbursements.kde.org/events/25
>
> Includes the option of a road trip from FOSDEM if you're going to both.

I'm booking the various stuff now, so as usual questions about the
terrible reimbursements.kde.org ...

since will have to go a piece by train, and  the db site won't let me
buy tickets for february yet (frankfurt-stuttgart), I still have to
put a random price guess, is that ok?

accomodation: do we have to put that in the reimbursment app as well?
(if so i guess just half of us would need to if we take all doubles)

--
Marco Martin

[Differential] [Updated] D3363: Support interactive window selection through the Platform

[Martin Gräßlin]

graesslin added a dependent revision: D3365: Implement interactive window 
selection for Wayland platforms.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3363

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3365: Implement interactive window selection for Wayland platforms

[Martin Gräßlin]

graesslin added a dependency: D3363: Support interactive window selection 
through the Platform.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 248 lines] D3365: Implement interactive window selection for Wayland platforms

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.

REVISION SUMMARY
  The interactive window selection is implemented in InputRedirection
  through a dedicated InputEventFilter. The InputEventFilter so far takes
  care of pointer input and keyboard input. In addition it ensures that
  keyboard and pointer focus is reset on start and on end.
  
  With this change KillWindow now also works on Wayland, but only for X11
  windows, as the Wayland variant is not yet implemented.

TEST PLAN
  Tested in nested setup, auto-tests still needed

REPOSITORY
  rKWIN KWin

BRANCH
  interactive-window-selection-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3365

AFFECTED FILES
  input.cpp
  input.h
  keyboard_input.cpp
  platform.cpp
  platform.h
  pointer_input.cpp
  pointer_input.h
  wayland_cursor_theme.cpp
  wayland_cursor_theme.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

Re: Review Request 129400: Avoid potential access of .last() on empty list

[David Edmundson]

> On Nov. 14, 2016, 1:40 p.m., Aleix Pol Gonzalez wrote:
> > src/kpackagetool/kpackagetool.cpp, line 502
> > 
> >
> > Then just change to `QStandardPath::locate`?

Sounds sensible to me. Though I don't really know this code.
Marco, should I do that?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129400/#review100834
---


On Nov. 14, 2016, 1:35 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129400/
> ---
> 
> (Updated Nov. 14, 2016, 1:35 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> locateAll can return nothing, therefore we can't always call .last() on
> it.
> 
> Existing code should be able to handle an empty package root as the user
> could also also have provided a broken package root as an argument.
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 6135e14ba717d579553036f9ed7874813046a1db 
> 
> Diff: https://git.reviewboard.kde.org/r/129400/diff/
> 
> 
> Testing
> ---
> 
> Ran kpackagetool --generate-index -g
> 
> Previously asserted. No longer asserted.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

[Differential] [Commented On] D3341: add connector name to screen model

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> drm_output.cpp:196
>  
> +QString connectorName(s_connectorNames[connector->connector_type]);
> +QString modelName;

what if connector_type returns a number we don't know yet? Maybe a find would 
be better here with a fallback to unknown in case of not found.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3341

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3355: add maskArea in panel view

[mart (Marco Martin)]

mart added a comment.


  looking more into it, i see that qregions are not directly supported by qml, 
it should become a qvariantlist of rectangles, that's quite ugly, so scratch 
that.
  
  another thing, even if the input mask is correct, it would still not work 
correctly: both window maximizing and snapping would go to the real geometry of 
the window, making the "trick" obvious. window maximization could be fixed by 
setting different struts, but that would *not* work on wayland.
  
  An alternative approach for the parabolic zoom of your dock I tought instead 
is doing in a similar way of plasma mobile (for its top, pull-down slide panel):
  
  - the panel would have the "real" geometry, always "small"
  - when the mouse goes over it, another window that is not the panel appears 
(i think it would be either a dock window or a bypasswindowmanagerhit one) it 
may either be a fullscreen window or just the size of the maximum extent the 
icons would zoom
  - the icon list gets reparented in the new window, tough positioned exactly 
over the panel actual geometry
  - now it can animate and zoom where it wants, anywhere in the screen
  - when the cursor goes away the icons area, the icons animate to small again, 
then gets reparented to the real panel again, the second window gets hidden 
again

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  We could do the same hack we have with Kickoff, where the first task manager 
it finds with a global shortcut will be invoked. But that's not really 
discoverable how to change/why it broke when you created a new panel manually, 
etc etc.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: cfeck, colomar, ivan, graesslin, lbeltrame, mart, plasma-devel, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 34 lines] D3341: add connector name to screen model

[mart (Marco Martin)]

mart updated this revision to Diff 8154.
mart added a comment.
Restricted Application edited projects, added KWin; removed Plasma.


  - use a Qt QHash instead

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3341?vs=8153=8154

BRANCH
  arcpatch-D3341

REVISION DETAIL
  https://phabricator.kde.org/D3341

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3341: add connector name to screen model

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> drm_output.cpp:141-159
> +static const char * const s_connector_type_names[] = {
> +[DRM_MODE_CONNECTOR_Unknown] = "Unknown",
> +[DRM_MODE_CONNECTOR_VGA] = "VGA",
> +[DRM_MODE_CONNECTOR_DVII]= "DVI-I",
> +[DRM_MODE_CONNECTOR_DVID]= "DVI-D",
> +[DRM_MODE_CONNECTOR_DVIA]= "DVI-A",
> +[DRM_MODE_CONNECTOR_Composite]   = "Composite",

I was more thinking of something like:

  static QMap s_connectorNames = {
  {DRM_MODE_CONNECTOR_Unknown, QByteArrayLiteral("Unknown")},
  {DRM_MODE_CONNECTOR_VGA, QByteArrayLIteral("VGA")},
  // and so on...
  }

sorry for not having bean clear enough. Didn't mean that it should be a C 
variant.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3341

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3337: Remove KWin::display from kwinglobals

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  kwinglobals-drop-display

REVISION DETAIL
  https://phabricator.kde.org/D3337

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 34 lines] D3341: add connector name to screen model

[mart (Marco Martin)]

mart updated this revision to Diff 8153.
mart added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  - use a static map, like weston

REPOSITORY
  rKWIN KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3341?vs=8090=8153

BRANCH
  arcpatch-D3341

REVISION DETAIL
  https://phabricator.kde.org/D3341

AFFECTED FILES
  plugins/platforms/drm/drm_output.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3355: add maskArea in panel view

[mart (Marco Martin)]

mart added a comment.


  i kindof like it (snapping of windows will always be wrong but i don't think 
there is anything that can be done about) tough i would try passing qregions 
instead, in case an implementation wants something with a fancy shape

INLINE COMMENTS

> panelview.h:85
> + */
> +Q_PROPERTY(QRect maskArea READ maskArea WRITE setMaskArea NOTIFY 
> maskAreaChanged)
> +

while you're at you could use a qregion instead (iirc passing both a simple 
rectangle or an Array of rectangles works with qml

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mvourlakos, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3361: Support multiple event types in X11EventFilter

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  x11-event-filter-multiple-types

REVISION DETAIL
  https://phabricator.kde.org/D3361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3362: Port KillWindow to X11EventFilter

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rKWIN KWin

BRANCH
  kill-window-x11eventfilter

REVISION DETAIL
  https://phabricator.kde.org/D3362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 93 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 8152.
mart added a comment.


  - bigger hit area

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=8151=8152

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

[broulik (Kai Uwe Broulik)]

broulik added a comment.


  How would I tell the "primary monitor task manager" applet?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2680

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, hein
Cc: cfeck, colomar, ivan, graesslin, lbeltrame, mart, plasma-devel, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[hpereiradacosta (Hugo Pereira Da Costa)]

hpereiradacosta added a comment.


  In https://phabricator.kde.org/D3210#62696, @mart wrote:
  
  > this version always has a small scrollbar, show on hover enabled when 
animations are enabled
  
  
  +1 for me.
  
  Personally, I would leave the _scrollBar_Extend to 20, to have the same hit 
area as before, and increase the MinSliderHeight to 20 too, but at this stage, 
we need to push "something" and possibly adjust later.
  
  Also, assuming that Colomar is also ok with this change, if we stick to only 
one scrollbar size, then it can move back to Metrics (and not in Helper).

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D3341: add connector name to screen model

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> drm_output.cpp:177-228
> +switch (connector->connector_type) {
> +case DRM_MODE_CONNECTOR_VGA:
> +connectorName = QStringLiteral("VGA");
> +break;
> +case DRM_MODE_CONNECTOR_DVII:
> +connectorName = QStringLiteral("DVI-I");
> +break;

I would prefer a static hashmap instead of a long switch statement. Similar to 
how it is done in Weston.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3341

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas

[Differential] [Commented On] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart added a comment.


  this version always has a small scrollbar, show on hover enabled when 
animations are enabled

REPOSITORY
  rBREEZE Breeze

REVISION DETAIL
  https://phabricator.kde.org/D3210

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated, 93 lines] D3210: make scrollbar size configurable

[mart (Marco Martin)]

mart updated this revision to Diff 8151.
mart added a comment.


  - always small scrollbar

REPOSITORY
  rBREEZE Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3210?vs=8094=8151

BRANCH
  arcpatch-D3210

REVISION DETAIL
  https://phabricator.kde.org/D3210

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, #vdg, hpereiradacosta
Cc: colomar, alex-l, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3363: Support interactive window selection through the Platform

[Martin Gräßlin]

graesslin added a dependency: D3362: Port KillWindow to X11EventFilter.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3363

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Request, 367 lines] D3363: Support interactive window selection through the Platform

[Martin Gräßlin]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  A new virtual method is added to Platform:
  startInteractiveWindowSelection
  
  The interactive window selection enters a mode where the user can select
  a window through the pointer or keyboard device. The cursor is turned
  into a crosshair cursor, unless another cursor name is provided (e.g.
  pirate for kill window).
  
  Once a window is selected the provided callback method is invoked with
  the selected Toplevel as argument. In case the user cancelled the
  selection a nullptr argument is passed in.
  
  Currently it's only implemented by the X11 standalone platform using the
  logic from KillWindow. Just instead of killing the window the callback
  is invoked.
  
  KillWindow loses the X11 implementation and interacts with the new
  functionality in Platform by providing a lambda function for the
  killing.

TEST PLAN
  Killing of X11 windows is still possible

REPOSITORY
  rKWIN KWin

BRANCH
  interactive-window-selection

REVISION DETAIL
  https://phabricator.kde.org/D3363

AFFECTED FILES
  killwindow.cpp
  killwindow.h
  platform.cpp
  platform.h
  plugins/platforms/x11/standalone/CMakeLists.txt
  plugins/platforms/x11/standalone/windowselector.cpp
  plugins/platforms/x11/standalone/windowselector.h
  plugins/platforms/x11/standalone/x11_platform.cpp
  plugins/platforms/x11/standalone/x11_platform.h
  utils.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3362: Port KillWindow to X11EventFilter

[Martin Gräßlin]

graesslin added a dependent revision: D3363: Support interactive window 
selection through the Platform.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3183: Port potd (picture of the day) dataengine to KF5.

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKDEPLASMAADDONS Plasma Addons

BRANCH
  arcpatch-D3183

REVISION DETAIL
  https://phabricator.kde.org/D3183

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129404/
---

(Updated Nov. 15, 2016, 9:31 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Fabian Vogt.


Changes
---

Submitted with commit a195a6b0b3971f864b1b95ca93ac034bae9fa736 by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

When closing the launcher using Meta key, it pulls focus away and when clicking 
the button to expand the applet, it won't get focus.

BUG: 372476


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.cpp f24bc51 

Diff: https://git.reviewboard.kde.org/r/129404/diff/


Testing
---

started plasmashell:

click on kickoff -> it opened, typing searched
click on kickoff -> it closed
pressed meta -> it opened, typing searched
pressed meta -> it closed
click on kickoff -> it opened, typing searched (before it wouldnt search until 
I click the window)


Thanks,

Kai Uwe Broulik

[Differential] [Abandoned] D3242: Add an option to context menu to launch the application on a discrete graphics card

[jgrulich (Jan Grulich)]

jgrulich abandoned this revision.
jgrulich added a comment.


  Closing this review, there are new ones made into kio, kservice and kinit 
submitted to reviewboard.

REVISION DETAIL
  https://phabricator.kde.org/D3242

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: jgrulich, #plasma, hein
Cc: davidedmundson, graesslin, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D3362: Port KillWindow to X11EventFilter

[Martin Gräßlin]

graesslin updated the test plan for this revision.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3362: Port KillWindow to X11EventFilter

[Martin Gräßlin]

graesslin added a dependency: D3361: Support multiple event types in 
X11EventFilter.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D3361: Support multiple event types in X11EventFilter

[Martin Gräßlin]

graesslin added a dependent revision: D3362: Port KillWindow to X11EventFilter.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D3361

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas