Re: CI Requirements - Lessons Not Learnt?

On Fri, Jan 6, 2017 at 9:52 PM, Martin Gräßlin wrote: > Am 2017-01-06 05:57, schrieb Ben Cooksley: >> >> On Fri, Jan 6, 2017 at 12:38 AM, Martin Gräßlin >> wrote: >>> >>> Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at

[Differential] [Closed] D3738: [Task Manager] Tooltips redesign

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4f9198fc5f21: [Task Manager] Tooltips redesign (authored by subdiff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3738?vs=9787=9795 REVISION DETAIL

[Differential] [Request, 157 lines] D3991: kstart: Port away from K4AboutData

heikobecker created this revision. heikobecker added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kstart: Port away from K4AboutData kstart: Remove remaining bits of KDELibs4Support REPOSITORY

[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

davidedmundson added inline comments. INLINE COMMENTS > tasksmodel.cpp:388 > > +QObject::connect(filterProxyModel, ::rowsRemoved, q, > +[this](const QModelIndex , int first, int last) { I think it's a bit weird that we have a pair: groupingProxyModel::aboutToRemove

[Differential] [Accepted] D3991: kstart: Port away from K4AboutData

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D3991 EMAIL PREFERENCES

[Differential] [Commented On] D3923: Make AppstreamQt optional

mak added a comment. In https://phabricator.kde.org/D3923#73574, @anthonyfieroni wrote: > In https://phabricator.kde.org/D3923#73375, @mak wrote: > > > In any case, knowing the distro might be useful to check whether their packaging makes sense ;-) > > > KaOS don't have

[Differential] [Closed] D3991: kstart: Port away from K4AboutData

This revision was automatically updated to reflect the committed changes. Closed by commit R126:da328d6cada1: kstart: Port away from K4AboutData (authored by heikobecker). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3991?vs=9796=9805#toc REPOSITORY R126 KDE CLI Utilities CHANGES

[Differential] [Commented On] D3993: disable logging to kscreen.log by default

graesslin added a comment. +1 INLINE COMMENTS > testlog.cpp:93 > +delete log; > +qputenv(KSCREEN_LOGGING, QByteArray("truE")); > + typo REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D3993 EMAIL PREFERENCES

[Differential] [Accepted] D3085: Use DBusMenu if available

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

Re: CI Requirements - Lessons Not Learnt?

Hello all, First my apologies, yes the CI system is behind, I had done significant work on a new revamp and then life, work and those other incredibly annoying things got in the way. The CI team is rather small and we are trying our best to move things forward. We are now getting back on track,

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. The patch has been merged: http://code.qt.io/cgit/qt/qtbase.git/commit/?h=dev=34f82b8abcb279542b6350e70609c549e39caafb I'll get back to this review once Qt 5.9 is released... REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 Kai Stian Olstad changed: What|Removed |Added CC|

Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/ --- Review request for Plasma. Repository: kio-extras Description ---

[Differential] [Commented On] D3085: Use DBusMenu if available

davidedmundson added a comment. One teeny tiny catastrophe remains. In the spec calling AboutToShow returns whether the menu changed or not and if you need to refresh it. Our client code relies on this happening This QPT always returns false. The relevant code is in the QPT, but

Re: Review Request 129783: [kio-extras] Make activities kioslave optional, KF5Html not required

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129783/#review101846 --- CMakeLists.txt (line 166)

[Differential] [Updated, 312 lines] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

chinmoyr updated the summary for this revision. chinmoyr updated this revision to Diff 9811. chinmoyr added a comment. Added history functionality to the qml side for use use with back button. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

This revision was automatically updated to reflect the committed changes. Closed by commit R120:09ab6cdfb976: Fix "Pinned Chrome disappears when all Chrome windows are closed" (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

hein added a comment. For some reason Phab didn't update the summary even though I rewrote the commit message. Here's the new text: Fix "Pinned Chrome disappears when all Chrome windows are closed" Summary: It turns out that Chrome under certain conditions will change its

[Differential] [Accepted] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

davidedmundson accepted this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, davidedmundson Cc: plasma-devel, lesliezhai,

[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

hein added a comment. Thanks Roman! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, davidedmundson Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated, 42 lines] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

hein updated this revision to Diff 9797. hein added a comment. After the original bug became actually reproducible (thanks to Roman for a tip - I needed multiple Chrome tabs to slow down its teardown) I was able to pinpoint the actual cause, see the updated summary and the code comment.

[Differential] [Commented On] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

subdiff added a comment. Just tested it. Last revision fixes the problem indeed. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart,

[Differential] [Commented On] D3089: Restore global menu support

broulik added a comment. > to allow me to add the menu in the decoration, is this deliberately not available? No, I just haven't looked at the decorations KCM at all yet. I think we should also add the menu button to the default button order so that when you enable it you get it

Re: CI Requirements - Lessons Not Learnt?

Am 2017-01-06 05:57, schrieb Ben Cooksley: On Fri, Jan 6, 2017 at 12:38 AM, Martin Gräßlin wrote: Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: Am 2017-01-05 09:44, schrieb Ben Cooksley:

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 111 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 15:38:32 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

subdiff added a comment. Last try: It's the speaker symbol without the speaker. Should be easy to make by just cutting away the speaker. Plus vertically centered to the app icon. F1952405: Screenshot_20170105_111200.png REPOSITORY R119 Plasma

[Differential] [Request, 2 lines] D3992: Sync kicker tooltip icon to config setting

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 368912 TEST PLAN Set it to a non-square image. Checked it looked fine.

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 108 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/108/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 06 Jan 2017 15:42:39 + Build duration: 5 min 2 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D3992: Sync kicker tooltip icon to config setting

broulik added a comment. Patch looking fine but Eike had some reservations as the square icon stuff isn't in a version Plasma-desktop depends on, it might be running against the previous version where it will look crap. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

[Differential] [Accepted] D3992: Sync kicker tooltip icon to config setting

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3992 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 108 - Still Unstable!

​Fix here: https://git.reviewboard.kde.org/r/129779/

[Differential] [Commented On] D3992: Sync kicker tooltip icon to config setting

davidedmundson added a comment. In https://phabricator.kde.org/D3992#74676, @broulik wrote: > Patch looking fine but Eike had some reservations as the square icon stuff isn't in a version Plasma-desktop depends on, it might be running against the previous version where it will look

[Differential] [Request, 18 lines] D3993: disable logging to kscreen.log by default

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Most of the issues that this feature should uncover have been uncovered, it makes sense to disable the logging