[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added inline comments. INLINE COMMENTS > iconapplet.cpp:159 > > -return; > +if (name.isEmpty() && > url.scheme().startsWith(QLatin1String("http"))) { > +name = url.host(); Why only http? This would be useful for FTP, SMB and many other things, no?

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik added inline comments. INLINE COMMENTS > dfaure wrote in iconapplet.cpp:159 > Why only http? > > This would be useful for FTP, SMB and many other things, no? There you would usually have a filename that makes sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

marten added a comment. Agreed that a decision needs to be made, but I'm not an expert on the KPackage system and so wasn't sure whether the warning may be useful to package developers in some cases - in which case leaving it commented out would make it easier to reinstate than removing it

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik added a comment. Ok, I'll put it after if (name.isEmpty()) { name = url.path(); } and do a if (name.isEmpty() || url.scheme().startsWith(QLatin1String("http"))) { name = url.host(); } REPOSITORY R120 Plasma Workspace REVISION DETAIL

Re: plasma-integration/5.9 fails on build.kde.org

On 18/01/17 17:05, David Edmundson wrote: > I'm on it. > > David Master branch in kubuntu CI now fails with /<>/plasma-integration-5.8.5+p17.04+git20170119.0940/src/platformtheme/kdeplatformsystemtrayicon.cpp CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o:

[Differential] [Request, 19 lines] D4199: [Style KCM] Make sure to enable kappmenu kded module

broulik created this revision. broulik added reviewers: Plasma, ivan. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The old KCM enabled and disabled

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 19 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 10:14:43 + Build duration: 13 min CHANGE SET Revision

[Differential] [Accepted] D4198: Require Qt 5.7

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. +1 maybe to other repos as well, at least plasma-desktop? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4198 EMAIL

[Differential] [Changed Subscribers] D4198: Require Qt 5.7

ltoscano added a subscriber: Sysadmin. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4198 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: #sysadmin, graesslin, plasma-devel, lesliezhai,

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added inline comments. INLINE COMMENTS > broulik wrote in iconapplet.cpp:159 > There you would usually have a filename that makes sense. No, not necessarily. You can point to the root of a FTP server with ftp://ftp.kde.org/ and you can even point to your home dir on an FTP server with

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added a comment. But then every HTTP URL, even with a filename, will the host as filename? Useful if you have only one link to a given website, but what if you have 5 links to different pages on that website? Or maybe I didn't understand the order you wanted to use. REPOSITORY

[Differential] [Updated, 165 lines] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik updated the summary for this revision. broulik updated this revision to Diff 10348. broulik added a comment. - Improve default naming logic file:/// → "/" (would be neat to also ask kfileplaces at some point) ftp://www.somehost.com/ → "www.somehost.com"

[Differential] [Commented On] D4198: Require Qt 5.7

bshah added a comment. Yes we do have Qt 5.7 on CI - https://build.kde.org/view/QT/job/qt5%205.7%20kf5-qt5/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4198 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

https://bugs.kde.org/show_bug.cgi?id=362988 --- Comment #10 from Toralf Förster --- (In reply to Toralf Förster from comment #7) > (In reply to Toralf Förster from comment #4) > > https://git.reviewboard.kde.org/r/129134/diff/1#index_header > > had to apply this to

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 692 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/692/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 10:14:43 + Build duration: 24 min CHANGE SET Revision

[Differential] [Accepted] D4199: [Style KCM] Make sure to enable kappmenu kded module

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4199 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

https://bugs.kde.org/show_bug.cgi?id=375249 Elvis Angelaccio changed: What|Removed |Added CC|

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

broulik added inline comments. INLINE COMMENTS > dfaure wrote in iconapplet.cpp:159 > No, not necessarily. You can point to the root of a FTP server with > ftp://ftp.kde.org/ and you can even point to your home dir on an FTP server > with ftp://user@host (and no trailing slash). > >

[Differential] [Commented On] D4157: [Icon Applet] Use KIO::statJob to work with remote URLs

dfaure added a comment. What I used to do about all this is to turn every '/' into a unicode fraction slash (so that it still looks like a '/' to the user, but can be used in a filename), and name the link with the full URL like "ftp://www.somehost.com/foo/bar/;. See

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

mart added a comment. -1 on this.. wallpaper packagestructure is indeed very weird (it makes it so that a simple jpg is considered as a valid package.. is how the model for thumbnails works, which would be a good idea to change a little) , and that's why those warnings REPOSITORY R290

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129851/#review102095 --- Ship it! Ship It! - Christoph Feck On Jan. 18, 2017,

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129851/ --- (Updated Jan. 19, 2017, 1:06 p.m.) Status -- This change has been

[Differential] [Commented On] D4198: Require Qt 5.7

davidedmundson added a comment. Yeah, will do it to the all the main actively developed ones, just thought I'd put one up for review. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4198 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 13:17:20 + Build duration: 10 min CHANGE SET Revision

[Differential] [Closed] D4199: [Style KCM] Make sure to enable kappmenu kded module

This revision was automatically updated to reflect the committed changes. Closed by commit R119:af36a54e947f: [Style KCM] Make sure to enable kappmenu kded module (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4199?vs=10349=10352

[Differential] [Commented On] D4178: The welcome message is better written now

ivan added a comment. It is not grammatically correct now. The smallest change (that I can think of) that would make it correct is "Plasma, made by KDE" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4178 EMAIL PREFERENCES

[plasmashell] [Bug 363860] Slideshow does not cycle if only one image in set directory

https://bugs.kde.org/show_bug.cgi?id=363860 Christoph Feck changed: What|Removed |Added Target Milestone|--- |1.0

[Differential] [Closed] D4197: Delete KCModule before deleting QApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R126:8e7540a0e00b: Delete KCModule before deleting QApplication (authored by davidedmundson). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

[Differential] [Request, 4 lines] D4208: Deal with missing drawers

ervin created this revision. ervin added a reviewer: mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise the ActionButton is unusable if no drawer is attached to the ApplicationWindow. The rest of the code

[Differential] [Changed Policy] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

konstantinshtepa changed the visibility from "konstantinshtepa (Konstantin Shtepa)" to "Public (No Login Required)". konstantinshtepa changed the edit policy from "konstantinshtepa (Konstantin Shtepa)" to "All Users". REPOSITORY R119 Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D4202: use proper packagestructures

graesslin added a comment. I assume that should go into the 5.9 branch? what about window decoration themes (aka aurorae)? Does that also need adjustment? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4202 EMAIL PREFERENCES

[Differential] [Request, 320 lines] D4204: Added max size restrictions handlers for plasmoids

konstantinshtepa created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Signed-off-by: Konstantin Shtepa first step release commit. Bugs fixed, plasmoid behaves

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 694 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/694/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 19:52:38 + Build duration: 5 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 20 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 19:52:08 + Build duration: 15 min CHANGE SET Revision

[Differential] [Commented On] D4202: use proper packagestructures

mart added a comment. In https://phabricator.kde.org/D4202#78684, @graesslin wrote: > I assume that should go into the 5.9 branch? quite a big backport.. but yeah, may make sense as 5.9 release would be kinda broken otherwise > what about window decoration themes (aka

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

konstantinshtepa added a comment. In https://phabricator.kde.org/D4204#78701, @davidedmundson wrote: > That's quite a huge patch. > Can you give a much bigger explanation on exactly what it's doing and why. > "Fixes bug N" doesn't really explain what the original problem was.

Re: plasma-integration/5.9 fails on build.kde.org

Reported that issue as: https://bugs.kde.org/show_bug.cgi?id=375290 On 19/01/17 10:00, Rik Mills wrote: > On 18/01/17 17:05, David Edmundson wrote: >> I'm on it. >> >> David > > > Master branch in kubuntu CI now fails with > >

[Differential] [Request, 16 lines] D4214: Make sure we display enabled ListItem on hover

apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I just realized there was a weird workaround in plasma-nm where it gets checked so it's

[Differential] [Request, 42 lines] D4215: Make notifications execute the "default" action on click.

albertvaka created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This uses the feature introduced here [1] on KNotifications, so default actions don't appear as a regular action button. Instead, they

[Differential] [Updated] D4215: Make notifications execute the "default" action on click.

albertvaka added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

davidedmundson added a comment. Concept seems fine. New binding has some typos INLINE COMMENTS > ListItem.qml:97 > +prefix: (listItem.sectionDelegate ? "section" : > +(background.pressed || listItem.checked || > listItem.containsMouse) ? "pressed" : "normal") >

[Differential] [Request, 21 lines] D4218: Remove pointless QObject inheritance in model item

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We don't emit anything or use properties or anything else that requires MOC. We want to keep

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in ListItem.qml:97 > Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain... > > It's barely a behavioral change, in fact it's what it was supposed to happen > in the first place: give feedback on hover

[Differential] [Request, 61 lines] D4217: Remove unused feature "favorite" from PlasmaAppletItemModel

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There was no role exposed for isFavorite and it has no other impact. Removing it not only

[Differential] [Updated, 16 lines] D4214: Make sure we display enabled ListItem on hover

apol updated this revision to Diff 10379. apol marked an inline comment as done. apol added a comment. Address David's comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4214?vs=10372=10379 BRANCH master REVISION DETAIL

[Differential] [Updated] D4214: Make sure we display enabled ListItem on hover

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in ListItem.qml:97 > why are you now following containsMouse. That's a behavioural change > > How can background.pressed be true. I don't see where it exists? > do you mean

[Differential] [Accepted] D4202: use proper packagestructures

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH phab/packageplugins REVISION DETAIL https://phabricator.kde.org/D4202 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 695 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/695/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 05:23:03 + Build duration: 8 min 39 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 562 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/562/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 05:22:43 + Build duration: 9 min 52 sec CHANGE SET Revision

[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

davidedmundson added a comment. That's quite a huge patch. Can you give a much bigger explanation on exactly what it's doing and why. "Fixes bug N" doesn't really explain what the original problem was. INLINE COMMENTS > AppletAppearance.qml:61 > > -property int minimumHeight:

[Differential] [Request, 2 lines] D4205: Add missing descriptions on the trashcan and appmenubar plasmoids

apol created this revision. apol added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Was missing, error appstreamtest and appeared empty on the Widget explorer. REPOSITORY R119

[Differential] [Request, 123 lines] D4220: Add a basic SNI for keyboard layout

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On X11 the SNI for keyboard layout is provided by the keyboard

[Differential] [Commented On] D4220: Add a basic SNI for keyboard layout

graesslin added a comment. F2090291: keyboard-kded.png REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland

[Differential] [Request, 24 lines] D4203: Fix appstream name/summary ends with '.' warning

apol created this revision. apol added reviewers: Plasma, davidedmundson. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Drops the dot on these tags, possibly the right patch would be to fix the

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 693 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/693/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 16:01:38 + Build duration: 7 min 8 sec CHANGE SET Revision

[Differential] [Request, 261 lines] D4202: use proper packagestructures

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY as the plasmapkg2 utility is dead, scripts and tabboxes couldn't be installed anymore, as plasmapkg2

[kio-extras] [Bug 375305] SFTP file create date is wrong

https://bugs.kde.org/show_bug.cgi?id=375305 Elvis Angelaccio changed: What|Removed |Added Ever confirmed|0 |1

[Differential] [Closed] D4198: Require Qt 5.7

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb2803900fa5: Require Qt 5.7 (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4198?vs=10345=10355 REVISION DETAIL

[Differential] [Closed] D4196: Fix clang address sanitiser error in SNI memcpy.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:24a7f4e3ba72: Fix clang address sanitiser error in SNI memcpy. (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4198: Require Qt 5.7

graesslin added a comment. In https://phabricator.kde.org/D4198#78620, @davidedmundson wrote: > Yeah, will do it to the all the main actively developed ones, just thought I'd put one up for review. For KWin I'll take care of as it allows me to drop some code ;-) REPOSITORY

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 07:04:30 + Build duration: 8 min 59 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 20 Jan 2017 07:04:10 + Build duration: 10 min CHANGE SET Revision